GitLab

used a RawPtrWillBeMember instead because Oilpan can deal with
these ownership cycles


BUG=382542

Review URL: https://codereview.chromium.org/1290683003

git-svn-id: svn://svn.chromium.org/blink/trunk@200759 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The value attribute should not be set for non-native text fields, according to HTML to Platform A11y Spec.

E.g. <div contenteditable<Some text.</div>. The node with role=SECTION should not have the value="Some text.".
BUG=491027
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1289103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200758 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521200

Review URL: https://codereview.chromium.org/1300743002

git-svn-id: svn://svn.chromium.org/blink/trunk@200757 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200742

BUG=455939
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1288273004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200756 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520702

Review URL: https://codereview.chromium.org/1286423003

git-svn-id: svn://svn.chromium.org/blink/trunk@200755 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test cases initially ran in parallel, but the web-platform-tests'
promise_test() switched to running cases serially for predictability,
which made these tests with many cases and lots of setup time out.

* Split up the match() and matchAll() tests into separate files
* Do the pre-population of the caches (within each test) in parallel

BUG=508984

Review URL: https://codereview.chromium.org/1295573002

git-svn-id: svn://svn.chromium.org/blink/trunk@200754 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are frames that should be merged together, but they are not
because some of them contain callUID (those coming from CPU profiler)
and those that don't contain it (those coming from trace event stacks).

Do not use callUID in the frame id calculation.

BUG=521473

Review URL: https://codereview.chromium.org/1294183002

git-svn-id: svn://svn.chromium.org/blink/trunk@200751 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a reland of https://codereview.chromium.org/1290073003/

Reproduced crash locally, https://codereview.chromium.org/1302543002/ fixes it. So  after that lands land this again.

TBR=jsbell@chromium.org
BUG=502214

Review URL: https://codereview.chromium.org/1299903002

git-svn-id: svn://svn.chromium.org/blink/trunk@200749 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add Unicode Variation Selector support on Linux official builds (patchset #1 id:1 of https://codereview.chromium.org/1283923002/ )

Reason for revert:
This CL prevents building official Chrome images on Linux.

../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:176:13: error: use of undeclared identifier 'hb_ot_font_set_funcs'

The proposed workaround doesn't work, so reverting this CL.

Original issue's description:
> Add Unicode Variation Selector support on Linux official builds
> 
> Most of the work to support Unicode Variation Selector was done in a
> separate CL[1], but it was not enabled for Linux due to crbug.com/462689.
> 
> This patch enables the Unicode Variation Selector support on Linux
> official builds.
> 
> The CL to enable on all Linux[2] was reverted because chromeos=1 is still
> bound to the harfbuzz in the system and thus unable to use
> hb_ot_font_set_funcs() on Trusty.
> 
> [1] https://codereview.chromium.org/1149693002/
> [2] https://codereview.chromium.org/1209043010/
> 
> BUG=383580
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200427

TBR=eae@chromium.org,drott@chromium.org,kojii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=383580

Review URL: https://codereview.chromium.org/1292583006

git-svn-id: svn://svn.chromium.org/blink/trunk@200747 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200705

BUG=521801
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1290223006 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200746 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521457
TBR=dgozman
NOTRY=true

Review URL: https://codereview.chromium.org/1301603003

git-svn-id: svn://svn.chromium.org/blink/trunk@200745 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specifically, Vary headers should not prevent us from reusing an image that
already has been used in the current document.

BUG=518733,520376
TEST=ResourceFetcherTest.VaryImage
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1287073007

git-svn-id: svn://svn.chromium.org/blink/trunk@200744 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The call to layout() could invalidate some of the null-checks we did previously.
Instead layout first, then do all the null checks.

BUG=521479

Review URL: https://codereview.chromium.org/1291343008

git-svn-id: svn://svn.chromium.org/blink/trunk@200743 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=csharrison
BUG=455939

Review URL: https://codereview.chromium.org/1300853003

git-svn-id: svn://svn.chromium.org/blink/trunk@200742 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since CSSParserTokenRange represents a stream, calling something
like  size on it makes no sense. So change the logic in these
places to not call size by checking for end of the value list.

BUG=499780

Review URL: https://codereview.chromium.org/1225403010

git-svn-id: svn://svn.chromium.org/blink/trunk@200741 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, merge the data url path with the SubstitueData path, as
they do very similar work in emulating a cache hit.

BUG=521112

Review URL: https://codereview.chromium.org/1291883002

git-svn-id: svn://svn.chromium.org/blink/trunk@200738 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A constant series of compositor updates would force the serviceOnNextFrame
to be kept being put off. The wakeAfter was always called with a fixed
duration so it would just keep getting cancelled and rescheduled.

Since the serviceOnNextFrame ends up calling setNeedsLayout inside the
scheduleAnimation callback; the LayoutTree would get updated in that call.
The hit testing problem identified in the bug was related to the fact that
the LayoutTree's layer transforms weren't updated correctly until it was
told it needed to do a Layout.

The fix is to check the remaining duration vs the new scheduled duration
and avoid the schedule if the new duration is longer.


BUG=513833

Review URL: https://codereview.chromium.org/1287013003

git-svn-id: svn://svn.chromium.org/blink/trunk@200737 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously for the following case:
 current display items:
    A B C D
 new display items:
    C B A D

A and B in current display items will be skipped and indexed when adding
C, then the index will be used when adding B and A.

When adding D, currentIt points to A, and B and C will be iterated
again.

Add nextItemToIndexIt variable to memorize the place to index, to avoid
repeated iteration.

BTW
- Change DisplayItem::ignoreInDisplayList() to (!)DisplayItem::isValid()
- Let currentIt point to the next item of the item just being copied so
  that we can synchronize sooner in some cases.

Review URL: https://codereview.chromium.org/1287863003

git-svn-id: svn://svn.chromium.org/blink/trunk@200736 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Message ports were using the source frame's execution context
rather than the targets when ports were transferred from a frame
to another. This seems to be leaky and also creates difficulties
when implementing message port support for android webview
and OOPIF. Use the target instead.

This is patch 1 of 3. The next CL will move chromium code to
use newly introduced method and the third CL will delete
the old methods.

BUG=473258

Review URL: https://codereview.chromium.org/1289033003

git-svn-id: svn://svn.chromium.org/blink/trunk@200735 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Confirmed that it is possible to construct a page that will produce a
negative maxHeight, as seen in:

fast/block/line-layout/negative-max-height.html

which produces maxHeight of -5.

Review URL: https://codereview.chromium.org/1296383005

git-svn-id: svn://svn.chromium.org/blink/trunk@200734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=382542
NOTRY=true

Review URL: https://codereview.chromium.org/1290593004

git-svn-id: svn://svn.chromium.org/blink/trunk@200733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521202
NOTRY=true

Review URL: https://codereview.chromium.org/1299763002

git-svn-id: svn://svn.chromium.org/blink/trunk@200732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter. (patchset #2 id:20001 of https://codereview.chromium.org/1297803002/ )

Reason for revert:
Causes FOUC in iframes after the main frame has finished loading.

Original issue's description:
> Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter.
> 
> After r200515 we no longer start producing frames until the stylesheets
> have loaded which means we will never attempt to paint with pending
> sheets so we don't need the FOUC avoidance code that paints white. Lets
> remove it.
> 
> See: https://src.chromium.org/viewvc/blink?revision=200515&view=revision
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200587

TBR=bmcquade@chromium.org,chrishtr@chromium.org,pdr@chromium.org,ojan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1287113006

git-svn-id: svn://svn.chromium.org/blink/trunk@200731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Data from DocumentTiming must be pushed out of blink as it comes in,
to avoid losing data from fast shut downs. We propogate these
notifications to the WebFrameClient, for easy access outside of blink.

BUG=382542

Review URL: https://codereview.chromium.org/1288973002

git-svn-id: svn://svn.chromium.org/blink/trunk@200730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can use m_request instead.

BUG=519825

Review URL: https://codereview.chromium.org/1284383003

git-svn-id: svn://svn.chromium.org/blink/trunk@200729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Prepare for multiple !important author ranges. (patchset #11 id:200001 of https://codereview.chromium.org/1282243002/ )

Reason for revert:
This caused oilpan plugin errors on Windows.
From http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2535/steps/compile/logs/stdio:

..\..\third_party\WebKit\Source\core/css/resolver/MatchResult.h(115,1) :  error: [blink-gc] Class 'ImportantAuthorRangeIterator' contains invalid fields.
class ImportantAuthorRangeIterator {
^
..\..\third_party\WebKit\Source\core/css/resolver/MatchResult.h(140,5) :  note: [blink-gc] Stack-allocated field 'm_result' declared here:
    const MatchResult& m_result;
    ^
..\..\third_party\WebKit\Source\core/css/resolver/MatchResult.h(144,1) :  error: [blink-gc] Class 'ImportantAuthorRanges' contains invalid fields.
class ImportantAuthorRanges {
^
..\..\third_party\WebKit\Source\core/css/resolver/MatchResult.h(152,5) :  note: [blink-gc] Stack-allocated field 'm_result' declared here:
    const MatchResult& m_result;
    ^

Original issue's description:
> Prepare for multiple !important author ranges.
> 
> This CL is split out from [1] where we support multiple author origins in
> terms of shadow dom scopes. The vector of MatchedProperties contains
> matched declarations from all origins in the order in which they should
> be applied. For !important declarations, they are applied in the same
> order within the same origin, but the order of the origins are different
> as the cascading order is:
> 
>   - UA important
>   - Author important
>   - Author
>   - UA
> 
> We used to have two ranges, one for UA and one for author to accomplish
> this. However, with the normal/!important cascading order for
> declarations from different shadow doms, we need multiple author ranges:
> 
>   - UA important
>   - Author important scope n
>   ...
>   - Author important scope 1
>   - Author scope 1
>   ...
>   - Author scope n
>   - UA
> 
> We introduce an ImportantAuthorRangeIterator to iterate through the
> author ranges and add iterator-style iteration for each range through the
> MatchedPropertiesRange class.
> 
> As the applyMatchedProperties code is hot, I've run the blink_perf.css
> tests locally. Some improved by 2-4%, some became worse by similar
> percentages.
> 
> [1] https://codereview.chromium.org/1224673002/
> 
> BUG=487125
> TEST=fast/css
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200697

TBR=kochi@chromium.org,timloh@chromium.org,rune@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487125

Review URL: https://codereview.chromium.org/1303513002

git-svn-id: svn://svn.chromium.org/blink/trunk@200728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test had flaky whitespace error. This CL will fix it.

BUG=521854

Review URL: https://codereview.chromium.org/1298133002

git-svn-id: svn://svn.chromium.org/blink/trunk@200727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Optimized with SSE2 and obtained 4.37x speedup.
Standard:      	2.900553 seconds
SSE2 (fp32):   	0.662973 seconds
Speedup (fp32):	4.375067

Due to multiple multiplications with a small discreteTimeConstant, some divergences appear versus the serialized version. Test adjusted accordingly.

BUG=512376
TEST=Run webaudio/audioparam-setTargetAtTime.html

Review URL: https://codereview.chromium.org/1288773003

git-svn-id: svn://svn.chromium.org/blink/trunk@200726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously fetch() sent request's body data as a blob. That made the data
invisible from the devtools. Now it sends the body data as a form data to
fix the issue.

BUG=457484

Review URL: https://codereview.chromium.org/1301523002

git-svn-id: svn://svn.chromium.org/blink/trunk@200725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Ensure that scroll position is not restored if it has to be
clamped unless frame is done loading.

BUG=517912
TEST=fast/loader/scroll-position-restoration-without-premature-clamping.html

Review URL: https://codereview.chromium.org/1271143003

git-svn-id: svn://svn.chromium.org/blink/trunk@200724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch 2 of 4 to fix the overly long delay between
each scroll in smoothness.scrolling_tough_ad_cases caused by the render
thread being unresponsive.

Patch 1: https://codereview.chromium.org/1299643004/
Patch 3: https://codereview.chromium.org/1291513004/
Patch 4: https://codereview.chromium.org/1285133008/

BUG=510398

Review URL: https://codereview.chromium.org/1296993002

git-svn-id: svn://svn.chromium.org/blink/trunk@200723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1285413003

git-svn-id: svn://svn.chromium.org/blink/trunk@200722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |PositionAlgorithm<Strategy>::editingPositionOf()| as
replacement of |createLegacyEditingPosition()| since Blink doesn't use legacy
editing position since r200096, to remove a wrapper function for improving code
health.

BUG=513114
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1300823002

git-svn-id: svn://svn.chromium.org/blink/trunk@200721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently m_webMediaPlayer is cleared in resetMediaPlayerAndMediaSource
and clearMediaPlayerAndAudioSourceProviderClientWithoutLocking. So
reusing clearMediaPlayerAndAudioSourceProviderClientWithoutLocking
in resetMediaPlayerAndMediaSource.

Review URL: https://codereview.chromium.org/1287063006

git-svn-id: svn://svn.chromium.org/blink/trunk@200720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=515763

Review URL: https://codereview.chromium.org/1288623004

git-svn-id: svn://svn.chromium.org/blink/trunk@200719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When support for 4-value syntax for background-position was added,
only the non-repeating case was actually tested and render support for
the non-top-left anchor points were missing.

This patch adds render support and a simple test for the three anchor
positions that wasn't supported before for repeated/tiled
backgrounds.

BUG=488707,521481

Review URL: https://codereview.chromium.org/1287293002

git-svn-id: svn://svn.chromium.org/blink/trunk@200718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With  https://codereview.chromium.org/1287263004/ all spellcheck
work in blink moved to a separate subdirectory. Cleaning up
WATCHLISTS accordingly.

BUG=none

Review URL: https://codereview.chromium.org/1294283002

git-svn-id: svn://svn.chromium.org/blink/trunk@200717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1296233002

git-svn-id: svn://svn.chromium.org/blink/trunk@200716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521481

Review URL: https://codereview.chromium.org/1297913003

git-svn-id: svn://svn.chromium.org/blink/trunk@200715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have quirk code that |checked| returns new value even before the default
action of a click event is executed.  It adds some code complexity and produced
multiple bugs.

BUG=

Review URL: https://codereview.chromium.org/1295173004

git-svn-id: svn://svn.chromium.org/blink/trunk@200714 bbb929c8-8fbe-4397-9dbb-9b2b20218538