- 08 Aug, 2018 40 commits
-
-
Naoki Fukino authored
In FileSystem API level, the "Audio" media view has a directory structure like Audio/{Artist}/{Song}.aac. We can't limit the level of recursion up to 1 to find entries for "Audio". Actually, a file will not be shown in multiple folders in media view hierarchy, since no folders will be added in media documents provider. We don't need to limit the level of recursion. Bug: 870532 Test: Manually tested on arc-enabled kevin with voice recording app installed. Change-Id: I1087b9c6e11812025d8456eef8dbec9faeb29cd0 Reviewed-on: https://chromium-review.googlesource.com/1164865 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#581484}
-
Ramin Halavati authored
Preferences related to Variations are moved to the incognito persistent storage list. This CL does not change the current behavior. Bug: 861722 Change-Id: Iff56f55450639bf95848f3c1c97d7452f2c649a8 Reviewed-on: https://chromium-review.googlesource.com/1159369Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581483}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c857956fad09..20714bdf90f3 git log c857956fad09..20714bdf90f3 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-08 caryclark@skia.org add json dump to pathops unittest 2018-08-08 mtklein@google.com make sksg a component 2018-08-08 reed@google.com use VectorValue consistently 2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-08 herb@google.com Remove unused TextPathIter 2018-08-08 liyuqian@google.com Update ShouldUseAAA with our better complexity estimation 2018-08-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 1bd4bfb0c2d8..b983a4b28b83 (2 commits) Created with: gclient setdep -r src/third_party/skia@20714bdf90f3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I0afc1e7551f9b7be84ec7ae7e548f4501a636e9d Reviewed-on: https://chromium-review.googlesource.com/1166502Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581482}
-
Abhishek Arya authored
This reverts commit c85c6c91. Reason for revert: Broke AFL ASan builder https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Afl%20Upload%20Linux%20ASan Original change's description: > Stop using -std=gnu* > > BUG=427584 > R=thakis > TBR=sbc > > Change-Id: I4a6f67aa6ddaf8ab78719a3c925fcd732b8c28bf > Reviewed-on: https://chromium-review.googlesource.com/1149337 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581478} TBR=thakis@chromium.org,thomasanderson@chromium.org Change-Id: Ie673c185580662fad3d641000edfc4ee203acf9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 427584 Reviewed-on: https://chromium-review.googlesource.com/1166663Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#581481}
-
Naoki Fukino authored
The ext4 migration banner should be shown as a persistent warning message below the focused user's password field. LoginBubble is used to implement the message. Since only the ext4 migration warning uses UserBoardView::ShowBannerMessage(), I named the new mojo API as ShowWarningBanner() instead of ShowBannerMessage() and omitted |is_warning| parameter from the API. Bug: 831099 Test: ash_unittests, manual test using Kevin with profiles on old encryptions. Change-Id: I01838860bc9bd36fae69cdc869ad6837c7d2717c Reviewed-on: https://chromium-review.googlesource.com/1158672Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#581480}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/735f71d95bcb..dd5051fa529e git log 735f71d95bcb..dd5051fa529e --date=short --no-merges --format='%ad %ae %s' 2018-08-08 ehmaldonado@chromium.org metrics: Deal with permission denied when writing metrics.cfg. Created with: gclient setdep -r src/third_party/depot_tools@dd5051fa529e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870231 TBR=agable@chromium.org Change-Id: I9eeee439ba0df73c81c9b88145fd05cce2038f35 Reviewed-on: https://chromium-review.googlesource.com/1166622Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581479}
-
Tom Anderson authored
BUG=427584 R=thakis TBR=sbc Change-Id: I4a6f67aa6ddaf8ab78719a3c925fcd732b8c28bf Reviewed-on: https://chromium-review.googlesource.com/1149337 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581478}
-
Tom Anderson authored
This CL: * Uses the active frame color for deciding when to draw a stroke around the active tab * Prevents strokes from being draw on Aero glass themes * (Hopefully) Fixes a crash and flaky test BUG=853841,871739,871883,871910 R=pkasting Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c Reviewed-on: https://chromium-review.googlesource.com/1166546 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581477}
-
Rakina Zata Amni authored
TBR=futhark@chromium.org Bug: 869470,871105,872025,871416 Change-Id: Iab76b2330c889d36243f95f3c105f9bba7568819 Reviewed-on: https://chromium-review.googlesource.com/1166564 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#581476}
-
Justin Cohen authored
Moves compile to Xcode10b5, and adds iOS12 testers where necessary. Bug: 843244 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I94099d7fefef9b145b9c3b825422ba52046c45ed Reviewed-on: https://chromium-review.googlesource.com/1165318 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581475}
-
David Tseng authored
Bug: 867426 Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208 Reviewed-on: https://chromium-review.googlesource.com/1166231Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581474}
-
Rakina Zata Amni authored
TBR=estark@chromium.org Bug: 872029,872030 Change-Id: I64936a1236224d42b401aaea814387115536e0f2 Reviewed-on: https://chromium-review.googlesource.com/1166278Reviewed-by:
-
Hayato Ito authored
As part of http://crrev.com/581145. Bug: 581145 Change-Id: I60203e3705ee84260d17cbe1c7cfcd2ebaf94dca Reviewed-on: https://chromium-review.googlesource.com/1166281Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581472}
-
Rakina Zata Amni authored
TBR=dschuyler@chromium.org Bug: 87206,872027,872028,871692 Change-Id: I798194cdb7ee2059565940791b751856611ed34a Reviewed-on: https://chromium-review.googlesource.com/1166562Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e1c2f6d7fe7a..f90277e7f4bd git log e1c2f6d7fe7a..f90277e7f4bd --date=short --no-merges --format='%ad %ae %s' 2018-08-07 thestig@chromium.org Move CPDF_Font::LoadPDFEncoding() to CPDF_SimpleFont. 2018-08-07 thestig@chromium.org Change CPDF_Font::GetFace() to HasFace(). 2018-08-07 thestig@chromium.org Make CPDF_Font::GetFontBBox() return the bounding box. 2018-08-07 tsepez@chromium.org Remove unused codepage code from GetByteString(). 2018-08-07 vmiklos@collabora.co.uk Add FPDFTextObj_GetText() API Created with: gclient setdep -r src/third_party/pdfium@f90277e7f4bd The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icd680ac00831086638557608686438a6a6418716 Reviewed-on: https://chromium-review.googlesource.com/1166342Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581470}
-
Alexey Kozyatinskiy authored
We need additional check otherwise auto mapping may request content for dead UISourceCode. R=lushnikov@chromium.org Bug: none Change-Id: I098de1a6a157df3501cf969359168f6b92eeb2a0 Reviewed-on: https://chromium-review.googlesource.com/1166327Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581469}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e627814f2f22..1241c4e94ff3 git log e627814f2f22..1241c4e94ff3 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 dgarrett@google.com repository: Create PreLoad helper. Created with: gclient setdep -r src/third_party/chromite@1241c4e94ff3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idc43f65e8c6545b2a97d27f01a966d7eb26e6e2a Reviewed-on: https://chromium-review.googlesource.com/1166503Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581468}
-
Eric Willigers authored
AudioWorklet shipped to stable in M66 https://chromium-review.googlesource.com/938162 https://www.chromestatus.com/feature/4588498229133312 BUG=816549 Change-Id: Ie70d0303e381d8ededefa77e572d03724d7d731f Reviewed-on: https://chromium-review.googlesource.com/1163048Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
-
Trent Apted authored
Bug: None Change-Id: If02904a1c3e93b67ab467b556c73d05ea6672741 Reviewed-on: https://chromium-review.googlesource.com/1164723Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#581466}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ada05b3a7a57..5e7ddfe4f2b2 git log ada05b3a7a57..5e7ddfe4f2b2 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 benjhayden@chromium.org Configure gae_ts_mon in chromeperf dashboard. Created with: gclient setdep -r src/third_party/catapult@5e7ddfe4f2b2 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867060 TBR=sullivan@chromium.org Change-Id: I00b130d9dc5d751592fbe58d0d348c281811c672 Reviewed-on: https://chromium-review.googlesource.com/1166063Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581465}
-
Matthew Cary authored
Future changes to shared memory introduce an implicit dependency on mojo, which must be initialized in unittests. Reland of crrev.com/c/1156588 with proper includes. TBR: mcasas@chromium.org Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I06220d263deab02c82f97ca72a52cf9066b3df29 Reviewed-on: https://chromium-review.googlesource.com/1165984 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#581464}
-
Sadrul Habib Chowdhury authored
Add some metrics for why the display-scheduler aborts a draw operation. This metric should help explain why fewer frames are drawn when oop-d is turned on. BUG=865179, 778749 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I68e9a1e9c89b42042ac1611e9b6516bf7948657f Reviewed-on: https://chromium-review.googlesource.com/1165485 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#581463}
-
Noel Gordon authored
Remove the use of two windows for the paste tests: pre-populate system clipboard by copying 'hello.txt' there in the test preamble. Make the query for context menu display + command options more precise by prefixing the menu queries with a non-hidden content menu selector, this to avoid matching command attributes of hidden menus. The 'focus' remote command returns a boolean result: change all places in the test code to assert the 'focus' remote command result. Minor: fix comments where needed. Make tests that only need Drive only load Drive in their setupAndWaitUntilReady() call (for speed). Bug: 871771 Change-Id: I242344b60f405984aaa667f1f4d6c1def97880d0 Reviewed-on: https://chromium-review.googlesource.com/1165270Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581462}
-
Adam Rice authored
This reverts commit 530f6487. Reason for revert: Temporary revert to mitigate https://crbug.com/864351. This CL appears to have fixed https://crbug.com/788890, but that was a render process crash. 864351 is a browser process crash so preventing it is more important. Original change's description: > WS: Delete FileReaderLoader in BlobLoader > > Delete the FileReaderLoader member of WebSocketChannelImpl::BlobLoader > as soon as we are done with it. This moves the lifetime semantics closer > to what they were before Oilpan, and saves a bit of memory. > > Also remove some obsolete pre-Oilpan comments, since > WebSocketChannelImpl and BlobLoader are garbage collected rather than > explicitly deleted now. > > BUG=788890 > > Change-Id: I815e53a3271a91dbeb779b6f386004b454d1db92 > Reviewed-on: https://chromium-review.googlesource.com/1128837 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573647} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 788890 Change-Id: I71bdac66189d284637aabcb56998218a925aa01c Reviewed-on: https://chromium-review.googlesource.com/1166303Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#581461}
-
Parastoo Geranmayeh authored
When autofilling a select field, check if the user has previously changed the field. If so, don't overwrite. Note: If the user hovers over the fields, but doesn't choose any, we should overwrite. Bug: 868576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If4f9efa9bdc057e04295984a386b2083eb13a82d Reviewed-on: https://chromium-review.googlesource.com/1158712Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#581460}
-
Findit authored
This reverts commit 317cf670. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 581350 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMxN2NmNjcwMjA5N2M4ZGFkZWQyNDIyMDM3YTMzZjZjMWNmYmYxMjcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28539 Sample Failed Step: exo_unittests Original change's description: > Fix Autohide -> None frame transition > > This is reland of https://crrev.com/c/1164570 > > Change summary: A header view may outlive the target widget, > which can be differet widget. Reset the reference and check > before calling target widget. > > Bug: b/112240082 > Test: covered by unittests > Change-Id: Ia98d44a487b6cd2077b110e4a9799780cdbc4ebe > Reviewed-on: https://chromium-review.googlesource.com/1165697 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581350} Change-Id: Ic8de55e68e99a487e9783d5f61dd5fdba211352f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/112240082 Reviewed-on: https://chromium-review.googlesource.com/1166662 Cr-Commit-Position: refs/heads/master@{#581459}
-
Byoungkown authored
This CL makes XR API to be exposed on Window as following spec[1]. [1]: https://immersive-web.github.io/webxr/#xr Bug: None Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iddd4c7f4f899afe9145f6f9db77ae2cb3933222c Reviewed-on: https://chromium-review.googlesource.com/1165272 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581458}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I0be1be3485cb7c6f061af5883c121121bda49551 Reviewed-on: https://chromium-review.googlesource.com/1166431Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#581457}
-
Rakina Zata Amni authored
TBR=kenrb@chromium.org Bug: 871105 Change-Id: I1adc0dbcea30c6716238f309535cb46e91038891 Reviewed-on: https://chromium-review.googlesource.com/1166602Reviewed-by:
-
Yuki Yamada authored
Removed blink::V8WorkerOrWorkletEventListener and replaced it by blink::V8EventListener. The small differences between these were removed in previous CLs. Some codes for checking whether frame exists or not should have been removed in previous CL(https://chromium-review.googlesource.com/1160069), but it is done here. Bug: 869778 Change-Id: Ia6ceb8bb5481384db75265aca07e901f737873a4 Reviewed-on: https://chromium-review.googlesource.com/1160128 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#581455}
-
Yuki Yamada authored
Special error event handling in V8AbstractEventListener::ShouldPreventDefault() is needed in accord with HTML standard below, but was not implemented. https://html.spec.whatwg.org/multipage/webappapis.html#the-event-handler-processing-algorithm This CL add checking if the event is ErrorEvent and the event type is "error". Current target should also be checked as commented in TODO. Bug: 869778 Change-Id: Iaebec07ab4241713e1efd40ef4dd6a6fc3cf897e Reviewed-on: https://chromium-review.googlesource.com/1164966 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
-
Becca Hughes authored
Add new flags and pref state to chrome://media-engagement for debugging. We should also use the autoplay policy from WebPreferences. BUG=865548 Change-Id: I02bd462fbc58070f6bd2f4ab44bfd9311fad8aed Reviewed-on: https://chromium-review.googlesource.com/1157270 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#581453}
-
Wenzhao Zang authored
This fixes issues listed in: https://docs.google.com/spreadsheets/d/1y0pxAW1jz2mJJsloJLGleiOVvG3xNxB0vnjXxpYfGuM/edit?ts=5b638429#gid=0 The spreadsheet is the result from UI review. Bug: 800945 Change-Id: I25a87dffdd68a2a00ea574b1065c3cb490b348ef Reviewed-on: https://chromium-review.googlesource.com/1166335Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581452}
-
Mohsen Izadi authored
This is part of removing GpuClientImpl dependency on content so we can move it //components/viz/host/. A delegate interface is added with an implementation in content to provide access to GpuProcessHost for now. BUG=857218 Change-Id: I673860ada761e21eb77aa5b6a3272c96d02406ef Reviewed-on: https://chromium-review.googlesource.com/1137742 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#581451}
-
Joel Hockey authored
This is a reland of 64ab6403 Updates: * Fixed CrostiniInstallerView::SetupResult to not change kErrorOffline value. * VolumeManager::AddSshfsCrostiniVolume ignores if crostini is already mounted. * CrostiniInstallerViewBrowserTest is using a WaitingDiskMountManagerObserver to manage the run loop and ensure test runs all the way through new mounting code. * Added a custom mount point manager to FakeCrosDisksClient to fake the sshfs mounting in CrostiniInstallerViewBrowserTest. Original change's description: > CrOS crostini: sshfs mount immediately when container starts > > Perform sshfs mount to termina/penguin immediately when container > starts. Mounting code has moved from the chrome.fileManagerPrivate > extension functions into CrostiniManager. > > This change will make FilesApp more responsive to users who are > likely to use terminal or some other crostini app before using FilesApp. > > Bug: 846917 > Change-Id: I9fc246e45e54390e7a75f15a5571a24218cf2d5c > Reviewed-on: https://chromium-review.googlesource.com/1158317 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580094} Bug: 846917 Change-Id: I3677f88fc17031a2beaa6c82fc731a3c4545f4a8 Reviewed-on: https://chromium-review.googlesource.com/1161761 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#581450}
-
Nico Weber authored
This reverts commit a80e26da. Reason for revert: caused https://crbug.com/872089 via https://chromium-review.googlesource.com/c/chromium/src/+/1166170 Original change's description: > Add a dummy testing/buildbot entry for the new win-asan bot. > > TBR=dpranke > > Bug: 869973 > Change-Id: I768bbb4ae73c52d5fbd9d91960add069eefa5fac > Reviewed-on: https://chromium-review.googlesource.com/1164642 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581116} TBR=thakis@chromium.org,dpranke@chromium.org Change-Id: I70e245d67eb05a2f6312ce480a0a12118da31db5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869973 Reviewed-on: https://chromium-review.googlesource.com/1166642Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ebf9fdade33..735f71d95bcb git log 2ebf9fdade33..735f71d95bcb --date=short --no-merges --format='%ad %ae %s' 2018-08-08 hinoka@google.com [recipe_modules] Copy over windows_sdk from infra.git 2018-08-07 vadimsh@chromium.org [cipd] Bump versions of all CIPD packages + add mips(64)le platform support. Created with: gclient setdep -r src/third_party/depot_tools@735f71d95bcb The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:821194,chromium:867819,chromium:813782 TBR=agable@chromium.org Change-Id: I59662e6c61ccb156e85b00733e6c1e4668c703b1 Reviewed-on: https://chromium-review.googlesource.com/1166343Reviewed-by:
-
Xianzhu Wang authored
The rename is because the class just get PaintOffset from FragmentData without "adjusting" paint offset. It does adjust cull rect if there is PaintOffsetTranslation though. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b8a7c54454329700746215404c7dfbd582318ab Reviewed-on: https://chromium-review.googlesource.com/1121795Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581447}
-
Anand K. Mistry authored
Use it in tests instead of using a 23 argument constructor. BUG=None Change-Id: If5f6f2bf44363f99a02ac4f67774e1744c1ce53f Reviewed-on: https://chromium-review.googlesource.com/1159560 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#581446}
-
Jordy Greenblatt authored
As the multidevice Settings UI subpage fills up, it will need a few browsertests, so this CL is just to set that up so the infrastructure is there and to add a couple basic tests for the existing contents. Change-Id: Ie628de77d6242c521062a0c7a82ad5cb90a79c1a Reviewed-on: https://chromium-review.googlesource.com/1165855 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581445}
-
