- 26 Aug, 2014 40 commits
-
-
Michael Spang authored
We may want to watch a more targeted set of files, but the whole thing is too much. TBR=alexst Review URL: https://codereview.chromium.org/513463002 Cr-Commit-Position: refs/heads/master@{#292002}
-
thestig authored
Review URL: https://codereview.chromium.org/503853002 Cr-Commit-Position: refs/heads/master@{#292001}
-
pshenoy authored
BUG=None NOTRY=True Review URL: https://codereview.chromium.org/503973002 Cr-Commit-Position: refs/heads/master@{#292000}
-
dhnishi authored
This is part of the battery auditing feature, which will be surfaced in the Website Settings options page in the next patch. BUG=372598 Review URL: https://codereview.chromium.org/472383002 Cr-Commit-Position: refs/heads/master@{#291999}
-
piotaixr authored
BUG=401187 Review URL: https://codereview.chromium.org/447863003 Cr-Commit-Position: refs/heads/master@{#291998}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/511483002 Cr-Commit-Position: refs/heads/master@{#291997}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/503363003 Cr-Commit-Position: refs/heads/master@{#291996}
-
ernstm authored
Send idle notifications for V8 to do garbage collection after the commit. Behind a flag until V8 side of implementation is complete and tested. R=brianderson@chromium.org,skyostil@chromium.org,hpayer@chromium.org,danakj@chromium.org BUG= Review URL: https://codereview.chromium.org/429393003 Cr-Commit-Position: refs/heads/master@{#291995}
-
asvitkine authored
BUG=374763 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/502173002 Cr-Commit-Position: refs/heads/master@{#291994}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/505293002 Cr-Commit-Position: refs/heads/master@{#291993}
-
mfomitchev authored
Utilize the new gl_helper functionality to capture GestureNav screenshots in grayscale, which drastically improves screencapture performance, especially on hardware configurations with expensive RGBA readback. Part 1: https://codereview.chromium.org/388953002/ Original review: https://codereview.chromium.org/384453002/ BUG=379983, 380779 Review URL: https://codereview.chromium.org/389683002 Cr-Commit-Position: refs/heads/master@{#291992}
-
dbeam authored
R=estade@chromium.org BUG=393873 Review URL: https://codereview.chromium.org/501153005 Cr-Commit-Position: refs/heads/master@{#291991}
-
lazyboy authored
After we load a <webview>, setting its display to "none" removes the plugin <object> from the render tree. If we set the display back to "", we need to properly detect the case and allocate new instance id and call attach to make things work. The problem is briefly described here: https://docs.google.com/a/chromium.org/document/d/1ITPOxS97DsG1HkbTAlpH0YcaTXKZNYUs84p1MppaHg0/view BUG=399060 Test=Load a <webview> in a chrome app. See it render. Set <webview>.style.display = 'none', see it go away. Set <webview>.stlye.display = '', see it render properly. Review URL: https://codereview.chromium.org/440463002 Cr-Commit-Position: refs/heads/master@{#291990}
-
dtrainor authored
- Add a check for whether or not the favicon is valid before caching it - Still return an invalid favicon (will be default) - Updated caching logic a bit to be more robust BUG= Review URL: https://codereview.chromium.org/496733005 Cr-Commit-Position: refs/heads/master@{#291989}
-
noamsml authored
Change API to match protocol that may allow sticker authentication for devices. The PIN will not necessarily be available at provision time, and the client will need to send a user-typed PIN at code verification time. BUG= Review URL: https://codereview.chromium.org/468613003 Cr-Commit-Position: refs/heads/master@{#291988}
-
stgao authored
1. For DEPS file parsing, switching from svn to git. 2. For output of testcase https://cluster-fuzz.appspot.com/testcase?key=5097237064450048, now it is: Lines 1103-1112 of file ThreadState.cpp which potentially caused crash are changed in this cl (frame #2, function "blink::ThreadState::performPendingSweep()"). Lines 1120-1136, 1170-1174 of file Heap.cpp which potentially caused crash are changed in this cl (frame #0, function "blink::ThreadHeap<blink::FinalizedHeapObjectHeader>::sweepNormalPages(blink::HeapStats*)"; frame #1, function "blink::ThreadHeap<blink::FinalizedHeapObjectHeader>::sweep(blink::HeapStats*)"). Minimum distance from crashed line to changed line: 0. (File: ThreadState.cpp, Crashed on: 1100, Changed: 1100). NOTRY=true Review URL: https://codereview.chromium.org/504443004 Cr-Commit-Position: refs/heads/master@{#291987}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/504273002 Cr-Commit-Position: refs/heads/master@{#291986}
-
sky authored
SessionService::GetLastSession used a base::Unretained but there was no guarantee that the SessionService would be valid by the time the callback was processed. BUG=399655 TEST=covered by test now R=marja@chromium.org Review URL: https://codereview.chromium.org/500143002 Cr-Commit-Position: refs/heads/master@{#291985}
-
thestig authored
NOTRY=true Review URL: https://codereview.chromium.org/504503002 Cr-Commit-Position: refs/heads/master@{#291984}
-
jyasskin authored
Revert of Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages (patchset #2 of https://codereview.chromium.org/502233002/) Reason for revert: The fix (https://src.chromium.org/viewvc/blink?revision=180854) should be included by the Blink roll in http://crrev.com/ecb9875276ccd. Original issue's description: > Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages > > BUG=407396 > NOTRY=true > TBR=ager@chromium.org > NOTREECHECKS=true > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/8da39ba TBR=ager@chromium.org NOTREECHECKS=true NOTRY=true BUG=407396 Review URL: https://codereview.chromium.org/507833002 Cr-Commit-Position: refs/heads/master@{#291983}
-
dtrainor authored
Allow the ContentViewRenderView to request composites if UX components require it. BUG=387177 Review URL: https://codereview.chromium.org/504553002 Cr-Commit-Position: refs/heads/master@{#291982}
-
James Robinson authored
This is a new pure virtual on WebMimeRegistry. The implementations of WebMimeRegistry appear to bind only to net, so they could go somewhere and be shared by both content/ and mojo/ instead of duplicated. But this fixes a pending compile error so should probably happen first. R=darin@chromium.org Review URL: https://codereview.chromium.org/511583002 Cr-Commit-Position: refs/heads/master@{#291981}
-
dpranke authored
This fixes a crash when we skip a test only on ChromeOS; it turns out that telemetry uses two mechanisms for disabling tests, and only one of them was provoking this; that mechanism only seems to be used for this one ChromeOS test (everything else uses the other mechanism). R=dtu@chromium.org, nduca@chromium.org BUG=397279 Review URL: https://codereview.chromium.org/484333002 Cr-Commit-Position: refs/heads/master@{#291980}
-
jyasskin authored
BUG=339240 TBR=joaodasilva@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/474163004 Cr-Commit-Position: refs/heads/master@{#291979}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/509583002 Cr-Commit-Position: refs/heads/master@{#291978}
-
mlamouri authored
The ARB needs updating to use git commit numbers rather than SVN rev. BUG=None TBR=gavinp@chromium.org Review URL: https://codereview.chromium.org/505173002 Cr-Commit-Position: refs/heads/master@{#291977}
-
eroman authored
Review URL: https://codereview.chromium.org/508643003 Cr-Commit-Position: refs/heads/master@{#291976}
-
ajith.v authored
Currently not enought unit test case is available for Select Action Bar. This change adding useful UT for Select Action Bar with respect to input field. BUG= Review URL: https://codereview.chromium.org/501383002 Cr-Commit-Position: refs/heads/master@{#291975}
-
fmeawad authored
https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928 It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC). This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper. By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize. BUG=158234 Review URL: https://codereview.chromium.org/446203002 Cr-Commit-Position: refs/heads/master@{#291974}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/505283002 Cr-Commit-Position: refs/heads/master@{#291973}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/505233004 Cr-Commit-Position: refs/heads/master@{#291972}
-
gcasto authored
Viewing passwords locally requires reauth and users should not be able to go to a different location to circumvent this restriction. BUG=406579 Review URL: https://codereview.chromium.org/497233003 Cr-Commit-Position: refs/heads/master@{#291971}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/474973004 Cr-Commit-Position: refs/heads/master@{#291970}
-
rvargas authored
1. Automate the selection of the proper channel to enable the verifier. Now the code is enabled at runtime. 2. Switch to a hash_map to track handles. 3. Intercept CloseHandle to detect the code that is closing handles owned by ScopedHandles. The initial implementation only covers chrome.exe/dll, but the plan is to extend that in the future to all modules loaded in the process. BUG=362176 R=cpu@chromium.org R=sky@chromium.org See https://codereview.chromium.org/490043002/ for the actual review. TBR=cpu@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/506013004 Cr-Commit-Position: refs/heads/master@{#291969}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/498553004 Cr-Commit-Position: refs/heads/master@{#291968}
-
skyostil authored
BUG=391005 Review URL: https://codereview.chromium.org/507733002 Cr-Commit-Position: refs/heads/master@{#291967}
-
dhnishi authored
BUG=372607 Review URL: https://codereview.chromium.org/504773004 Cr-Commit-Position: refs/heads/master@{#291966}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/506903003 Cr-Commit-Position: refs/heads/master@{#291965}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/500383003 Cr-Commit-Position: refs/heads/master@{#291964}
-
tbarzic authored
The icon is changed so it's more distinguishable from the 'locked' icon BUG=405770 Review URL: https://codereview.chromium.org/508703002 Cr-Commit-Position: refs/heads/master@{#291963}
-