- 02 Nov, 2018 40 commits
-
-
James Hawkins authored
The app doesn't change state anymore so there is nothing to monitor. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I7daa43cb9137e37b3f38cece458d7aa921239f46 Reviewed-on: https://chromium-review.googlesource.com/c/1315351Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605019}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic0e717072a242ab397aad86a5ce651d4ea7de970 Reviewed-on: https://chromium-review.googlesource.com/c/1315488Reviewed-by:
-
Gabriel Charette authored
This is preferable because it avoids adding trace events while the thread is idle (for which there is no precedent). The delta between the instant events can be used to perform the same analysis which could be performed previously (and these will be in Slow Reports per being in an enabled category). R=fdoray@chromium.org Bug: 899897 Change-Id: I40d31df9f4db3ea8959f760323b7cd8f56299ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1312928Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#605017}
-
Ehsan Chiniforooshan authored
TBMv2 versions are added in https://chromium-review.googlesource.com/c/catapult/+/1308815 Bug: 890757 Change-Id: If9f56016acbcd7f218a4e5516dcd74d0ae1a5327 Reviewed-on: https://chromium-review.googlesource.com/c/1313548Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605016}
-
Evan Stade authored
Also, - Enable a couple locally passing tests that don't have bugs attached. - Disable EncryptedMediaTest suite on Chrome OS asan/lsan, to match Linux asan/lsan, due to flake (not unique to Mash). Bug: 793426 Change-Id: Ia01b402234e33e5fda0f587fc8d47fad7897cbb7 Reviewed-on: https://chromium-review.googlesource.com/c/1315809 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605015}
-
Peter Kotwicz authored
This CL changes the behaviour of H2OTransparentLauncherActivity#onHostBrowserSelected() in the edge case (not sure if the edge case is possible) that both H2OMainActivity and SplashActivity are enabled. When both H2OMainActivity and SplashActivity are enabled, this CL changes the behaviour of H2OTransparentLauncherActivity#onHostBrowserSelected() to do a normal launch instead of relaunching the WebAPK with the goal of changing the enabled component. This change also brings the code in line with the code comments. BUG=817263 Change-Id: Iedfdabce4245eaf0db689ac2d4968b967096eaab Reviewed-on: https://chromium-review.googlesource.com/c/1314615Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605014}
-
Tarun Bansal authored
At OnLoad event, the renderer notifies browser process of the anchor elements in the viewport. The browser uses this information to predict the navigation probability of each of these anchor elements. This CL changes the logic in the render side to skip reporting of elements that are part of ad frames since we expect these to be clicked less often. Bug: 899339 Change-Id: I171cce5d4b9f722039222865753f3b7cbe6d8a79 TBR: holte@chromium.org,ryansturm@chromium.org,kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1315529Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#605013}
-
Lucas Furukawa Gadani authored
This CL fixes the test flakyness and enables the test on Android. Bug: 892004 Change-Id: Ibc08897c300ce9704cebf861249b8c7f719cf474 Reviewed-on: https://chromium-review.googlesource.com/c/1313735 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605012}
-
Joshua Bell authored
Avoid integer overflow when computing a total buffer size from a base buffer and small partial sequence buffer. Bug: 901030 Change-Id: Ic82db2c6af770bd748fb1ec881999d0dfaac30f0 Reviewed-on: https://chromium-review.googlesource.com/c/1313833Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#605011}
-
Josh Karlin authored
At one point we identified sync registrations by an id instead of by the tag. But we've long since only used the tag. Remove the id. Bug: 901034 Change-Id: I94eb60fb51e9e036c98dff78c6fc8cd2f190232d Reviewed-on: https://chromium-review.googlesource.com/c/1313190Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605010}
-
Brian White authored
Until https://critique.corp.google.com/#review/206234268 is submitted, enumerations cannot be configured because their proportion values will change significantly with that chnage. Bug: 900230 Change-Id: I1670dabf72e4a2d6d00dd1c295961571b61fe9fa Reviewed-on: https://chromium-review.googlesource.com/c/1313189Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#605009}
-
Katie D authored
Does not yet start using windows in Arc. See go/a11y-arc++-window-mapping for more. Bug: 891483 Change-Id: Ibbd47b12b4440f3200edb9e57a14658f489e4cd5 Reviewed-on: https://chromium-review.googlesource.com/c/1308079 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605008}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d27da308ea5..5af3a96bfa9f git log 5d27da308ea5..5af3a96bfa9f --date=short --no-merges --format='%ad %ae %s' 2018-11-02 primiano@google.com UI: use distinct colors for distinct processes Created with: gclient setdep -r src/third_party/perfetto@5af3a96bfa9f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8fecaf1b67d819b39185c747886a749f290fba2f Reviewed-on: https://chromium-review.googlesource.com/c/1315332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605007}
-
Evan Stade authored
1. Better (more vertically centered) position for hosted app windows. 2. Correct sizing (29x29 instead of crunching to 24x24) for browser and hosted app windows. Packaged apps were already using 29x29. 3. Get rid of outline. GetAvatarImageFor{User,Context} already adds a white border. Bug: 901127 Change-Id: I5b0fcb1bcd3266c988e1a62c84b4f8455b53df35 Reviewed-on: https://chromium-review.googlesource.com/c/1313746 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605006}
-
Alex Clarke authored
There's no need to do the TLS lookup twice. Bug: 897751 Change-Id: I628297659ce38971bd16f204e29bace267679b71 Reviewed-on: https://chromium-review.googlesource.com/c/1314593 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605005}
-
Mason Freed authored
This CL enabled display compositor pixel dumps by default, which caused this group of tests to fail due to either a) minor antialiasing artifacts, or b) known differences in output due to being captured from the browser side. https://chromium-review.googlesource.com/c/chromium/src/+/1213864 These bugs should be resolved with this CL: - crbug.com/881040: Media controls now contain an overflow menu. - crbug.com/667551: A bunch of tests are listed under this bug, and just require rebaselining to fix non-material single-pixel antialiasing failures. - crbug.com/895556: These tests double their background size when the flag is enabled. These were already fixed by another CL, so they are NOT being rebaselined here, just removed from TestExpectations. Bug: 895912, 881040, 667551, 895556 Change-Id: I14a1065df604151ed06f2a6be4da7eaa53968705 Reviewed-on: https://chromium-review.googlesource.com/c/1303179 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#605004}
-
Shimi Zhang authored
The possible crash senario is like following: 1) Regular SuggestionMarker with suggestions get clicked, timeout triggered. 2) IME removes original SuggestionMarker, then added another SuggestionMarker with no suggestion. 3) SuggestionMenuTimeoutCallback() get called. 4) Crash happens because we are getting the first suggestion in suggestion_infos vector. This CL checks if suggestion_infos is empty to avoid the crash. Bug: 901135, 869261 Change-Id: I5949c370e3cbc2c760502f7357ba5463c7d909bb Reviewed-on: https://chromium-review.googlesource.com/c/1314130 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605003}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42e7d9c929ef..0367d1a1fb0a git log 42e7d9c929ef..0367d1a1fb0a --date=short --no-merges --format='%ad %ae %s' 2018-11-02 yinwa@webrtc.org Adds a field trial parameter to configure waiting time before sending Nack packets. 2018-11-02 eladalon@webrtc.org Change to RtcEvent::Copy 2018-11-02 kwiberg@webrtc.org Hide the AudioEncoderCng class behind a create function Created with: gclient setdep -r src/third_party/webrtc@0367d1a1fb0a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7505ba5732a32e3caaf450b55955575211cf2d85 Reviewed-on: https://chromium-review.googlesource.com/c/1315333Reviewed-by:
-
Ben Pastene authored
And remove cpu:x64 from the defaults. TBR=jbudorick Bug: 901205 Change-Id: I64be7685d85a2b5d895dafde6df0193b8db0c6bf Reviewed-on: https://chromium-review.googlesource.com/c/1315693Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#605001}
-
Peter Kotwicz authored
BUG=None Change-Id: Ibfccc7663c3d5091574af4cd50254e42dbb79190 Reviewed-on: https://chromium-review.googlesource.com/c/1313068 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b49154954d1d..48a5c18d49ce Created with: gclient setdep -r src-internal@48a5c18d49ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: Ifa643a4edbe8d08d71c2d71c826e2268945fbce6 Reviewed-on: https://chromium-review.googlesource.com/c/1315413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604999}
-
Ryan Hansberry authored
Most usages of PA_LOG(INFO) did not need to be in the default stdout, and were spammy. This CL downgrades most to VERBOSE, but leaves a choice few as INFO: * //chrome/browser/chromeos/tether/tether_service.cc:519 * //chromeos/components/proximity_auth/unlock_manager_impl.cc:219 * //chromeos/components/proximity_auth/unlock_manager_impl.cc:466 * //chromeos/components/tether/active_host_network_state_updater.cc (all) * //chromeos/services/multidevice_setup/host_backend_delegate_impl.cc:237 * //chromeos/services/secure_channel/ble_connection_manager_impl.cc:261 * //chromeos/services/secure_channel/ble_scanner_impl.cc (all) * //chromeos/services/secure_channel/secure_channel_impl.cc:132 * //chromeos/services/secure_channel/secure_channel_impl.cc:177 * //components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc (all) * //components/cryptauth/cryptauth_device_manager_impl.cc:659 * //components/cryptauth/secure_channel.cc:269 Some others which were actually error or unexpected cases have been moved to WARNING or ERROR. Bug: 899100 Change-Id: I58c8b734138fcb4c19be940fe79327adebe4d568 Reviewed-on: https://chromium-review.googlesource.com/c/1313762 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604998}
-
Leonard Grey authored
This is a speculative fix for https://crbug.com/876493 There's an implicit but unenforced assumption that a widget doesn't have mouse capture when a move loop runs. Indeed, all implementations of RunMoveLoop besides Mac appear to do this directly or indirectly, and we even do a DCHECK in BridgedNativeWidget to ensure this is the case. As it happens, in most cases on Mac, this ends up being true by accident: When detaching a tab into a new window, we attempt to acquire capture in TabDragController::Attach, but fail because the window of the newly created widget is not yet showing. However, evidence from the field in the linked bug shows that in reality, sometimes we *do* have capture while running a move loop. So at a minimum, let's get our RunMoveLoop semantics in line with other platforms and see what happens, though there's a lot of other stuff wrong with this situation IMO. Bug: 876493 Change-Id: If4e7a260d7be4e5f9272eca4b8eec73a8b52e156 Reviewed-on: https://chromium-review.googlesource.com/c/1315170Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604997}
-
John Rummell authored
Verify that we're not seeing double frees on DecoderBuffer. BUG=794740 TEST=media_unittests pass Change-Id: If280c93f065f7ea0254513af7f2d5efd1dc4ad0d Reviewed-on: https://chromium-review.googlesource.com/c/1313767 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604996}
-
Etienne Bergeron authored
This is moving the threshold to report a slow-reports with memory dump for a utility process. The chosen value is 250M, which is the 98th percentile based on UMA metrics. We are expecting to get about 3x more reports. The amount of reports is currently really low and harder to be actionnable. We believe this will help find new potential memory leaks in utility processes. R=erikchen@chromium.org Change-Id: I93f286d4603d612b4ad64f1573d5967a6ba87d0b Reviewed-on: https://chromium-review.googlesource.com/c/1315647Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604995}
-
Koji Ishii authored
This patch reorders members of NGConstraintSpace so that value (non-class/struct) members are placed at the end. Due to byte-align, it reduces the size from 96 bytes to 88 bytes on x64. Bug: 635619 Change-Id: I7d9471343f3c16d91f7534fd98e2b95f1d18f8c5 Reviewed-on: https://chromium-review.googlesource.com/c/1314070Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604994}
-
Jazz Xu authored
Bug: 896255 Change-Id: I12f394272b9bec2f11ccfaf850ef03fffa8e484c Reviewed-on: https://chromium-review.googlesource.com/c/1313560Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604993}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/86e5fbf71b88..d105d2e46b9a git log 86e5fbf71b88..d105d2e46b9a --date=short --no-merges --format='%ad %ae %s' 2018-11-02 tsepez@chromium.org Move CJS_PublicMethods::ParseString{String,Interger} to fx_date_helpers.cpp Created with: gclient setdep -r src/third_party/pdfium@d105d2e46b9a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I445bf670c166be40722388a3345108ebd73ad7b6 Reviewed-on: https://chromium-review.googlesource.com/c/1315329Reviewed-by:
-
Sean Topping authored
Bug: internal b/114464714 Test: CQ, verify Devtools is accessible on IPv4 and IPv6 Change-Id: I716643bb4c51cedaa0375ab51a9809246ecb64ab Reviewed-on: https://chromium-review.googlesource.com/c/1309101 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604991}
-
kylechar authored
It doesn't look like these metrics have been recorded since M54. Bug: none Change-Id: I57aadf19add26f8d0d8d3d85e25f6fd9d599cbeb Reviewed-on: https://chromium-review.googlesource.com/c/1313552Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
-
Eric Karl authored
This swaps the deprecated 'arraysize' macro for base::size in the GPU command buffer generator scripts and generated files. No change to logic. Bug: 837308 Change-Id: I229a7f9ad9a25f0a7e40690aae5ff167a75aa804 Reviewed-on: https://chromium-review.googlesource.com/c/1313835Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604989}
-
Eric Robinson authored
See: go/chromerulesetservicemerge This change removes references to ContentRulesetService in our codebase preferring RulesetService. It changes the direction of ownership of these classes, having the RulesetService own the ContentRulesetService. The publishing/distribution functionality is now called via the RulesetService itself, which makes calls to the virtual RulesetServiceDelegate implemented by the ContentRulesetService. Bug: 900292 Change-Id: I30420f0b36107e65d59d1911b506242c58886ecd Reviewed-on: https://chromium-review.googlesource.com/c/1294299Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604988}
-
Li Lin authored
Enable personal readout to support personal features after we changed to use libassistant device ID. Bug: b/118782806 Change-Id: I9b3d08eb700f6f352f88c59c11bfbf3813f15c4f Reviewed-on: https://chromium-review.googlesource.com/c/1312293Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604987}
-
Robert Sesek authored
This reverts commit dcb738f9. Reason for revert: Broke mac-dbg compile https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-dbg/1596 Original change's description: > Reimplement GetAppOutput and friends on Mac with posix_spawn. > > Mac no longer uses launch_posix.cc and all process creation goes through > posix_spawn now. > > Bug: 179923 > Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd > Reviewed-on: https://chromium-review.googlesource.com/c/1313334 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604982} TBR=rsesek@chromium.org,mark@chromium.org Change-Id: I9fd7e4c80f66de9acd35c7626cc65fdd5007d474 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 179923 Reviewed-on: https://chromium-review.googlesource.com/c/1315708Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604986}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a6ef719b69f4..a8f088180a1c git log a6ef719b69f4..a8f088180a1c --date=short --no-merges --format='%ad %ae %s' 2018-11-02 chiniforooshan@chromium.org Telemetry: migrate thread_*_cpu_time_per_frame 2018-11-02 erikchen@chromium.org [Reland 1] ADB commands should only retry errors, not exceptions. Created with: gclient setdep -r src/third_party/catapult@a8f088180a1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757,chromium:895027 TBR=sullivan@chromium.org Change-Id: I070af3f6172541300ce6dc4d5ac183f117dd1db6 Reviewed-on: https://chromium-review.googlesource.com/c/1315408Reviewed-by:
-
Ben Pastene authored
Its bots will be everything in: https://chromium-swarm-dev.appspot.com/botlist?c=id&c=os&c=task&c=status&f=os%3AChromeOS&l=100&q=os%3AChr&s=id%3Aasc Bug: 901205 Change-Id: I0266b1c75deacdd0b287bcd9cc7f8b247a4792af Reviewed-on: https://chromium-review.googlesource.com/c/1313836Reviewed-by:
-
Matthew Jones authored
This patch moves the responsibility of updating the scrim for the toolbar over to the ToolbarManager. This allows for the removal of a fair amount of plumbing for the scrim and some questionable casting. Change-Id: I3ee397c2444d96da9e9a32bb7652134989ffedad Reviewed-on: https://chromium-review.googlesource.com/c/1313115 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604983}
-
Robert Sesek authored
Mac no longer uses launch_posix.cc and all process creation goes through posix_spawn now. Bug: 179923 Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd Reviewed-on: https://chromium-review.googlesource.com/c/1313334Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604982}
-
Xing Liu authored
In normal profile, the small icon uses different default icons based on download state. Incognito mode should do the same since download state is not privacy information. Other systems try to use download notification currently don't plumb the small icon into DownloadNotificationFactory. Bug: 901141 Change-Id: I3f813adab15484b1e97e8d1592979f8f381ad8d0 Reviewed-on: https://chromium-review.googlesource.com/c/1313928Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604981}
-
Alex Clarke authored
It's important to cap delays at one day or bad things can happen on certain platforms. Also removes a redundant call to ScheduleDelayedWork. Bug: 863341, 850450 Change-Id: Idfb95a5e5d800255caff74d0718db600b9348335 Reviewed-on: https://chromium-review.googlesource.com/c/1314489Reviewed-by:
-
