GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175358 0039d316-1c4b-4281-b951-d872f2087c98

Replace it with explict Pause() and Resume() interfaces.

R=asanka@chromium.org
R=benjhayden@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11711003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175357 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r10534: (mseaborn) Mac: Fix an off-by-one corner case in handling single-stepping on x86-32
r10535: (mseaborn) Thread suspension: Fix querying registers for another Mac OS X corner case
r10536: (mcgrathr) toolchain_build: Update binutils and gcc revisions
r10537: (mseaborn) GDB tests: Improve error reporting when GDB's "reason" field is missing
r10538: (eliben) Fix pnacl driver tests to look for x64 host dir when x86-32 isn't built
r10539: (jfb) ARM: delete stale files and code.
r10540: (mcgrathr) Disable performance tests under qemu
r10541: (mcgrathr) Segregate trusted/untrusted values of MXCSR
r10542: (mcgrathr) Disable run_performance_test via tests_to_disable_qemu not is_broken

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11792004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163096

Review URL: https://codereview.chromium.org/11788012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175355 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-dual-core/intl1/times/t: http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl1/report.html?history=150&rev=175338

TBR=tonyg@chromium.org

BUG=

Review URL: https://codereview.chromium.org/11794030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175354 0039d316-1c4b-4281-b951-d872f2087c98

Without root the user must manually enable devtools debugging in settings. This
limitation is acceptable as we are able to detect it and instruct the user.

BUG=154415
TEST=Run a telemetry test on a production android image

Review URL: https://codereview.chromium.org/11784007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175353 0039d316-1c4b-4281-b951-d872f2087c98

We do this by wrapping the default ctor in a factory Create method, which handles the build-type logic.

Also, group static methods in variations_service.*.
Also, move the testing constructor to protected where it's better... protected.

BUG=162417
TEST=With an unofficial build: Ensure that running Chromium without a command line argument does not result in a request to the Variations server (https://clients4.google.com/chrome-variations/seed). Ensure that providing the --variations-server-url flag with a URL results in a request to that URL.

Review URL: https://chromiumcodereview.appspot.com/11753014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175352 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175350 0039d316-1c4b-4281-b951-d872f2087c98

Translate infobar delegate: name the "type_" and "error_" fields "infobar_type_" and "error_type_" for clarity and to match the underlying type names.

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11747014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175349 0039d316-1c4b-4281-b951-d872f2087c98

R=dalecurtis
TBR=darin,garykac

BUG=165264

Review URL: https://codereview.chromium.org/11791006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175348 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144491
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11535008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175347 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=The sample extension for activeTab should not fail to load unpacked.
Review URL: https://codereview.chromium.org/11777015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175345 0039d316-1c4b-4281-b951-d872f2087c98

ActiveAnimation has a bad name. It used to be the case that 'active' animations were a subset of all animations, but now every animation in cc/ is 'active' and I think that's confusing.

R=enne@chromium.org
BUG=None
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174267

Review URL: https://chromiumcodereview.appspot.com/11636051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175344 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erg@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11740023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175339 0039d316-1c4b-4281-b951-d872f2087c98

With this change, we will only tick animation controllers once one of their corresponding layers is active.

R=enne@chromium.org
NOTRY=true
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11633044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175338 0039d316-1c4b-4281-b951-d872f2087c98

Depends on: https://bugs.webkit.org/show_bug.cgi?id=106089

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11748031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175336 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/11759024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175335 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175334 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 175328
> 
> > Roll Skia DEPS to r7044 & add SK_IGNORE_TRANS_CLAMP_FIX and SK_IGNORE_FAST_SCALEMATRIX_INVERT
> > 
> > control: https://codereview.chromium.org/11791014/
> > Review URL: https://codereview.chromium.org/11779016
> 
> TBR=robertphillips@google.com
> Review URL: https://codereview.chromium.org/11784021

TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11779021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175333 0039d316-1c4b-4281-b951-d872f2087c98

This test hardcodes a date in Jan 2013, so it's broken now

BUG=168561
TBR=achuith@chromium.org

Review URL: https://codereview.chromium.org/11785020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175332 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175331 0039d316-1c4b-4281-b951-d872f2087c98

> Roll Skia DEPS to r7044 & add SK_IGNORE_TRANS_CLAMP_FIX and SK_IGNORE_FAST_SCALEMATRIX_INVERT
> 
> control: https://codereview.chromium.org/11791014/
> Review URL: https://codereview.chromium.org/11779016

TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11784021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175330 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175329 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11791014/
Review URL: https://codereview.chromium.org/11779016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166738

Review URL: https://codereview.chromium.org/11618019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175324 0039d316-1c4b-4281-b951-d872f2087c98

TBR=xians
BUG=166523
TEST=Misc set of WebRTC audio clients on Mac.

Review URL: https://codereview.chromium.org/11773017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175323 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167722
TEST=unit_tests --gtest_filter="DriveSystemServiceTest.InitialFeedFetch"

Review URL: https://codereview.chromium.org/11775014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175319 0039d316-1c4b-4281-b951-d872f2087c98

The condition file_watchers_.empty() does not hold if user signed out
with Files.app opened (onunload looks intentionally suppressed
http://crbug.com/123107 in this case). So DCHECK is not appropriate.

That said, the check can be useful to detect possible future regressions
to forget unregistering the file watch. So keeping it as DLOG should be useful.

BUG=126275

Review URL: https://codereview.chromium.org/11776018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175317 0039d316-1c4b-4281-b951-d872f2087c98

And switch to the existing AlternateNavInfoBar[Delegate] classes.

BUG=164772
R=pkasting@chromium.org
TBR=ben@chromium.org
NOTRY=True # ios_dbg_simulator seems to be broken in lkgm?

Review URL: https://codereview.chromium.org/11721003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124444
TBR=apatrick@chromium.org

Review URL: https://codereview.chromium.org/11779015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175312 0039d316-1c4b-4281-b951-d872f2087c98

In BookmarkTree.handleMoved(), moved tree item (bookmark folder) is unregistered by BookmarkTree.remove(), which overrides Tree.remove() and deletes child folder node from node id to node map, treeLookup[].

This causes subsequent move operation for moved tree item doesn't update BookmarkTree UI. Because moved tree item no longer in BookmarkTree look up table.

This patch removes override method BookmarkTreeItem.remove() for keeping removed node in treeLookup[].

BUG=123535

Review URL: https://codereview.chromium.org/11635038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175311 0039d316-1c4b-4281-b951-d872f2087c98

> Make RenderWidget responsible for the composited view's lifetime
> 
> Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071.
> content::RenderWidget constructs a WebLayerTreeView when WebKit
> asks it and then retains ownership. This has to be destroyed
> before the WebWidget is closed since the WLTVClient is (currently)
> a WebKit object.
> 
> BUG=156175
> TBR=piman@chromium.org for content/content_renderer.gypi
> 
> Review URL: https://codereview.chromium.org/11575049

TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/11794018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175304 0039d316-1c4b-4281-b951-d872f2087c98

Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071.
content::RenderWidget constructs a WebLayerTreeView when WebKit
asks it and then retains ownership. This has to be destroyed
before the WebWidget is closed since the WLTVClient is (currently)
a WebKit object.

BUG=156175
TBR=piman@chromium.org for content/content_renderer.gypi

Review URL: https://codereview.chromium.org/11575049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175303 0039d316-1c4b-4281-b951-d872f2087c98

Restructured this code quite a bit to use the new shortcut magic.

Added tests which turned out to expose edge cases that I think weren't covered by the previous implementation (i.e. would potentially update shortcuts when unecessary -- flashing the desktop in the process -- or not do it when necessary).

NOTRY=TRUE
(Actually dis use CQ at first, but iOS is messes up at LKGR looks like...)
BUG=142980
TEST=Pin Desktop shortcut to Start Screen or pin chrome.exe directly to the start screen via context menu.
Notice that there are now multiple shortcuts of Chrome (non-tiled; 1 for each "Pin to Start" action; upon launching Chrome those should all be merged down to one Chrome tile shortcut (not on the file system, but visually on the Start Screen itself).
Note: if you do try this; there is an intentional 15s delay before the migration kicks in to avoid delaying Chrome startup; so be patient, it will work ;)!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175230

Review URL: https://chromiumcodereview.appspot.com/11712003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175302 0039d316-1c4b-4281-b951-d872f2087c98

> Windows: Remove content's dependency on d3dx9_43.dll.
> 
> ANGLE doesn't need this loaded anymore.
> 
> Review URL: https://chromiumcodereview.appspot.com/11737027

TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/11791013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168128,168129
TEST=Added unittests; demo page works.

Review URL: https://codereview.chromium.org/11787012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168128,168129
TEST=Added unittests; demo page works.

Review URL: https://codereview.chromium.org/11745026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175299 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175298 0039d316-1c4b-4281-b951-d872f2087c98

I see these accidentally leak into codereview sometimes, and it'd be nice to
just have it automatically be prevented.

NOTRY=true
R=danakj@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11794017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175296 0039d316-1c4b-4281-b951-d872f2087c98