- 25 Jun, 2019 40 commits
-
-
Tibor Goldschwendt authored
Bug: 978509 Change-Id: I67b21a9d8e2276bfbf15bcd220be6cb82c949c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676668 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672157}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5767fb8cbd2a..04cffe3289f7 git log 5767fb8cbd2a..04cffe3289f7 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Switch example peerconnection server to ABSL_FLAG. 2019-06-25 nisse@webrtc.org Reland "Raise IllegalStateException for calls to retain() or release() on zero ref count" 2019-06-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6c5bbd86..42482d4f (671957:672061) Created with: gclient setdep -r src/third_party/webrtc@04cffe3289f7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b3257cd1e930c98eef35c48cb47f2517c729e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672156}
-
Yue Zhang authored
Bug: 978236 Change-Id: If2bd37ed4182597e7ee0175f367604b9ec2bca42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674669Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#672155}
-
danakj authored
The android startup tasks were run synchronously when a |ui_task| was present (ie in browser tests) because android browser tests were expecting synchronous initialization, however java initialization is asynchronous anyways. So we have a RunLoop in BrowserTestBase pumping tasks and waiting for java initialization to complete, which is done as a (possibly asynchronous) side effect of the |ui_task| running. Thus we can stop branching here for tests and just post the startup tasks in browser tests as we would do normally in production. And the RunLoop in BrowserTestBase::SetUp() will run them all, eventually running the |ui_task|. R=avi@chromium.org Bug: 961849 Change-Id: Ic4724895e7b3762c401f2e781907816e2048e1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671069 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672154}
-
Mohamed Heikal authored
Previously some JNI calls that used to pass Profile.java objects to native, were switched to use ProfileKey. However, since there was no implementation of ProfileKey.java, the JNI calls passed nothing from Java's side and native called ProfileKey's equivalent of ProfileManager::GetLastUsedProfile. Now that ProfileKey.java exists, JNI calls should pass in ProfileKey.java objects to native instead. Change-Id: I90f83e4c837a6d12613354c9bca5a8d52bf01d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657752 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672153}
-
Rouslan Solomakhin authored
Before this patch, PaymentRequest.show() on a page with invalid SSL certificate would be rejected with "NotSupportedError: Payment method not supported," which confused web developers, since it was not clear from the error message that Chrome refused to show any payment methods on this page. This patch returns the SSL state in the error message. After this patch, PaymentRequest.show() on a page with invalid SSL certificate will reject with a more detailed error message, for example: "NotSupportedError: SSL certificate is not valid. Security level: DANGEROUS." Bug: 908976 Change-Id: Ifa367b641e3e83e206332af85cd2ca6605da197d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666741Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#672152}
-
Robert Sesek authored
After c96c632d, MessagePumpKqueue is used instead to drive IO MessageLoops. The MessagePumpLibevent has gone unused, and the dependency can now be dropped. Bug: 973882 Change-Id: I698749a2dedea216bc8fa04578079f3e7b99294d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675913Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#672151}
-
Emil A Eklund authored
Bug: 591099 Tbr: mstensho@chromium.org Change-Id: If0565b11507e18b2856d64eaa8c17678e1457022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672537Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#672150}
-
Will Cassella authored
Rather than excluding the string resource from Android, don't use a string resource and inline the string. This is done for other process names. Bug: 968263 Change-Id: I08d5d7c771f439df70104cf8ffa952e4c5fe7210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670033Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#672149}
-
chrome://flagsJan Wilken Dörrie authored
This change adds the Touch To Fill flag to the list of UI flags and adds corresponding metadata. Bug: 957532 Change-Id: I4d366827140b6ba1f88903afec1755808c6ad1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675654Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#672148}
-
Doug Arnett authored
Change-Id: I736d616abcc99417452b42e869b3f290380ff78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676585Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#672147}
-
Justin Cohen authored
As a followup to http://crrev.com/c/1669577, move the trust check to LastCommitted so all WebState APIs can return a trusted URL rather than just VisibleItem. BUG: 971740 Change-Id: Ia912007c6bfc65efa0443a07b072d9ed8075cedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673566 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#672146}
-
Jun Mukai authored
This improves the animation smoothness for expanding to fullscreen from peeking, from ~20 to ~65 for oneshot, and ~80 to ~90 for reuse. Still sometimes (1 in 5 attempts) ~20 animation smoothness can be observed. This also improves drag-to-reveal performance; LauncherDragTest.Open is improved by ~10msecs (~80 to ~70). Bug: 978179, 961467 Test: interactive_ui_tests Change-Id: Ia0550cada6cedb8525dee8472e89de9c1d5e246f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673575Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#672145}
-
Mugdha Lakhani authored
Remove an extra BackgroundSyncManager object from BackgroundSyncManager unittests. Bug: 933849 Change-Id: I4f3e5d598c1778d20ae33f8921b0fd85da535a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675551 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#672144}
-
Mugdha Lakhani authored
if the options don't match. Bug: 925297 Change-Id: Ibb92dd0eb7ccedf9f6c235439fc82a903b613854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660553 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#672143}
-
Ian Vollick authored
Presently, we call .mutate() on a potentially null icon. In these cases, we should instead clear the icon. Bug: 966909 Change-Id: I6181c72d29ef15dfd543affcd7b8b38a664eef95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676724Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672142}
-
Evan Stade authored
Replace it with an observer interface on GlobalErrorService. Change-Id: Ief1d6c231684e886a17931be7355ca6a6cabda72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670054 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#672141}
-
Vladislav Kuzkokov authored
Refactor to |base::OnceCallback| where possible. Explicitly use |base::RepeatingCallback| where it isn't. Leave as is if depends on API that should be updated. Bug: 968109 Change-Id: I21262a79e87c182ed1a2d9287f67a748a95f6ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662549Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672140}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3792d868. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 845a980a "KV Storage: add timeout=long and reenable disabled test" 73b57b36 "Add sec-metadata test when updating a service worker" 58b8718f "KV Storage: update to match IDL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox drott@chromium.org: external/wpt/css/css-text-decor drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/css-rhythm external/wpt/css/css-text/line-break external/wpt/css/css-writing-modes kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 rego@igalia.com: external/wpt/css/css-contain external/wpt/css/css-grid external/wpt/css/css-ui NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I59c1e24113b5ee82be67b4bed81b870aef1c9ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675689Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672139}
-
jonross authored
Creates vulkan_swift_shader_blink_web_tests This adds a variant of blink_web_tests to the Chrome-GPU FYI bot: "Linux FYI SkiaRenderer Vulkan (NVIDIA)" This will allow us to get correctness coverage of SkiaRenderer+Vulkan until we have bots setup that can run the native Vulkan. This change adds a new FlagExpectations file to represent the failures occurring with Vulkan, which pass with GL. While also updating the skia_renderer_blink_web_tests to properly respect the SKIP expectation. Documentation on FlagExpectations has been updated to reflect how to mix expectations with test lists, while actually skipping tests. TEST=vulkan_swift_shader_blink_web_tests Bug: 969824 Change-Id: I8dec7f9e1c921868b2216efb0bd63ea952fc6dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652791 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672138}
-
Joshua Bell authored
On IDBObjectStore and IDBIndex instances, the keyPath property says is defined in the spec with: "if this attribute returns an object (specifically an Array), it returns the same object instance every time it is inspected". Web platform tests for this were missing. Since the property is 'any' in Web IDL (since it could be a string or Array) it can't use the [SameObject] extended attribute. And in the Blink IDL, it can't use the [SaveSameObject] hint since that requires [SameObject]. Instead, use the [CachedAttribute] hint and never dirty the cache. Bug: 977048 Change-Id: Ic4ede31a3a01e7a8a90c4f54eb8a989a673fcf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674495 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#672137}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I53712d04cad1fcc93e68125a0c76c9154c71c299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673537Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#672136}
-
Mason Freed authored
Change-Id: Ic629921bdc6280c19a9c2d0962bbfa37faba70fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670117 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#672135}
-
Jun Mukai authored
The current tests do not evaluate the case of opening as 'peeking' and then expanding to fullscreen to see all applications. This can have different performance characteristics, since the application data should be ready before the animation. Currently the performance would be identical to normal fullscreen, Open to be ~20 and Close to be ~90. Bug: 961467 Test: interactive_ui_tests on nocturne Change-Id: I002dc5ef3e4b2a57791b9da97c7fcf1e44ca323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674194Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#672134}
-
Rakesh Soma authored
MakeUserNameForAccount() doesn't fail creation of user on some of the windows instances. This fix explicitly returns a failure when we want to fail the login UI instead of depending on "create user" to fail for "empty username" instead. Note that currently the error_text is set as IDS_INTERNAL_ERROR_BASE. Explicit error handling with appropriate error messages would be done in a followup change (already filed a bug for it). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1659512/24 Bug: 976543 Change-Id: Ic4d92f5ef647d0f3cd5fd50c1f52b588c94a3afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672234 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#672133}
-
Antonio Gomes authored
This is part of the 4.3 phase on the design document [1]. It prepares ground for dependent mediastream classes to be Onion soup'ed. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/edit BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ib56eb8a4dc4c00f653d1a6b750eb526263b68976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672800 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#672132}
-
Mason Freed authored
This CL adds a specific, individual WPT test for each type of backdrop-filter effect. If you find yourself here, looking for the test for blur() or a multi-filter (combined) test, see crbug.com/978481. Bug: 831485 Change-Id: I065fd94dbfe5ef0813ffe90f07878247147d3261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674708 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#672131}
-
Robert Ogden authored
LoFi, both server and client, is now deprecated. Bug: 944286 Change-Id: I4095aea5e5136da44eef8f641e052f8782e92d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666306Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#672130}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3df9c76a4999..1e2dfd22680d git log 3df9c76a4999..1e2dfd22680d --date=short --no-merges --format='%ad %ae %s' 2019-06-25 ahassani@chromium.org build_lib: fix an exception catch problem Created with: gclient setdep -r src/third_party/chromite@1e2dfd22680d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I234108ab0ce7db94467844b8e4fc06c216a2bdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672129}
-
Michael Thiessen authored
This change gets rid of the small splash screen layout, which effectively shifts the text placement a little closer to the icon when the icon in small, and avoids having long text get cut off vertically. This also lowers the minimum icon size to 16dp for screens smaller than 600dp, where small icons don't look quite as bad. Bug: 977198 Change-Id: I58ebe7c76af6dc756709a21141c5cc45843cf135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670121 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#672128}
-
Mirko Bonadei authored
Some compare_videos.py flags will be removed by [1]. They were already deprecated and not used. [1] - https://webrtc-review.googlesource.com/c/src/+/143788 Bug: None Change-Id: Id37735b18ce5573468b8583e9f14392bc1b12128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675671Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#672127}
-
Allen Robinson authored
Change-Id: I2bfe4f20b0980dfa920586becfe9f2b9f9a97d87 Bug: 970240,934451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669231Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Allen Robinson <arobins@chromium.org> Cr-Commit-Position: refs/heads/master@{#672126}
-
Nektarios Paisios authored
1. Modified BrowserAccessibilityManager and its subclasses to return nullptr if the current tree is disconnected from the top document and the focus node is retrieved This is because from Blink, we get one focused element per renderer - one focused node per iframe. If the current accessibility tree is disconnected from its parent tree, we have no way of knowing where the document's global focus is and might erroneously get back the locally focused node, i.e. the focused node in the current iframe. This will cause the focus to appear to jump from the globally focused node to the locally focused one, until the trees containing each iframe are connected again on the browser side. The user-facing bug is that focus will seem to randomly jump around the page, mostly jumping back to the top, preventing the user from reading anything. 2. Ensured that the static variable in BrowserAccessibilityManager in which the previously focused node is stored is cleared when: A) The tree managed by the current BrowserAccessibilityManager is deleted. B) The tree managed by the current BrowserAccessibilityManager changes its tree ID. C) The subtree containing the previously focused node is deleted. 3. Audited all places in the code were certain focus related methods from BrowserAccessibilityManager are called, and accounted for the possibility of those methods returning nullptr. The list of methods is as follows: FireFocusEventsIfNeeded FireFocusEvent NativeViewHasFocus GetFocusFromThisOrDescendantFrame GetActiveDescendant GetFocus GetRootManager GetDelegateFromRootManager IsRootTree AccessibilityIsMainFrame CanFireEvents 4. Audited all the methods in BrowserAccessibilityManager and its subclasses that were using the BrowserAccessibilityManagerDelegate. Some of those methods were calling methods on the delegate without first checking if it was nullptr, which could be the case in unit tests. 5. Took the opportunity to add "const" to a bunch of focus related methods, since retrieving the focus should not be modifying any state on any class instance. 6. A followup patch should modify the deserializer in AXTree to ensure that the same node ID is used when the root of the tree has been updated after some of its children got added or removed. This will remove even more spurious focus events from being fired. Change-Id: I4a75312632bf0b66e346fc5cae683edd9e63933a Bug: 956748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660717 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#672125}
-
Morten Stenshorne authored
Follow-up to CL:1669916 Change-Id: Ie98e1cbf0ed3cb90b41bdc682367474992bd1970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676124 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#672124}
-
John Budorick authored
because b/a/pylib/symbols/stack_symbolizer.py uses it: http://bit.ly/2YkZKih Bug: 790202 Change-Id: Ie45a5de5947e5f296d42cbea0c49411be13f6702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675341 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#672123}
-
Doug Arnett authored
Adds new opt guide proto optimization type for DeferAllScript with whitelist checking for it from PreviewsDeciderImpl thru PreviewsHints. Bug: 965277 Change-Id: I7be59e6eda9b64d310027ac2c3ddfb7f91ac76eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673754Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#672122}
-
Sophie Chang authored
This UKM should only be recorded once per page load. Marking this event as singular makes it easier to query in logs. Change-Id: I72acf796d084d0fe97df8932067a30ce95dc7537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669573Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672121}
-
Peter Kasting authored
We did this by default and for flattenhtml=true, but not when setting preprocess=true. This seems like an oversight. Bug: 564112 Change-Id: Id3d6907e79be51ea2ce905e563f350fd0f882164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670353 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#672120}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e899321b0bf7..a25f5438fa27 git log e899321b0bf7..a25f5438fa27 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 chrisforbes@google.com Use correct alignment for input attachment loads Created with: gclient setdep -r src/third_party/swiftshader@a25f5438fa27 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/135954761 TBR=swiftshader-team+autoroll@google.com Change-Id: I5493b76f7d8f16aea2303001ea435282d10ffdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672119}
-
Lucas Furukawa Gadani authored
Bug: 973925 Change-Id: I7eae9ca730babc823341c766e49d242496d2c315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672204 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#672118}
-