- 03 Sep, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
This CL hides the "Move to your Google Account" option in the overflow menu for the entry in chrome://settings/passwords/device corresponding to the first signed-in GA. The reason is it makes no sense to move a password for an account into that same account. Screenshots are attached in the linked bug. Fixed: 1113739 Change-Id: I6a5cfed2a67ed9f0b6ede373f552a77029b291b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385336 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#804172}
-
Paula Vidas authored
Bug: 1102312 Change-Id: Ia1c4e4582bb6d4a36f7e21aa1300952b6d3361c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390200 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804171}
-
Ulan Degenbaev authored
With concurrent allocation GetHeapStatistics and GetHeapSpaceStatistics may return different results. This CL makes GetHeapSpaceStatistics the source of truth and relaxes some DCHECKs. Bug: v8:10315 Change-Id: I6e774ed3974b4dbe00d7fbb913c8ff77e3649e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388391Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804170}
-
Justin Cohen authored
This is a reland of 2f675c0b Original change's description: > Reland "ios: Disable RemoveCookie test on iOS14." > > This reverts commit c88fabeb. > > Reason for revert: Still failing in beta 6 on the bots: > https://chromium-swarm.appspot.com/task?id=4e4543820c675010 > > Original change's description: > > Revert "ios: Disable RemoveCookie test on iOS14." > > > > This reverts commit 163b6034. > > > > Reason for revert: Speculative revert for beta 6 > > > > Original change's description: > > > ios: Disable RemoveCookie test on iOS14. > > > > > > TBR=mrefaat > > > > > > Bug: 1121425 > > > Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705 > > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#801345} > > > > TBR=justincohen@chromium.org,mrefaat@chromium.org > > > > Change-Id: Ideb21ea26cee61249444139f7a0c59735f1e5754 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1121425 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376314 > > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801908} > > TBR=justincohen@chromium.org,mrefaat@chromium.org > > No-Try: true > Bug: 1121425 > Change-Id: I07719c7d73c83b5d288136ae4df9d57845b162d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378534 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801933} TBR=justincohen@chromium.org,mrefaat@chromium.org No-Try: true Bug: 1121425 Change-Id: I7cadaf0831995ff830ec38539c9651db814e4a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392281Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804169}
-
Dominik Röttsches authored
Instead of individual tests for tag sequences, use newer ICU methods to detect xpicto_sequences as in Unicode TR#29, compare https://www.unicode.org/reports/tr29/#Regex_Definitions by using ICU's UCHAR_EMOJI_COMPONENT and UCHAR_EMOJI_COMPONENT checks. Bug: 1121420 Change-Id: I37c9cab51ea88c6be85c2df637af03dcf68c568f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390341Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#804168}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4cac73d9..0463f138 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id030c6f1ac89d49e6f32cbd078e239f796366656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804167}
-
Alex Chau authored
Bug: 1109827 Change-Id: I39f378208da3d24b1c49738c8e30b111d3a3dd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390661Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#804166}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599025789-3a109ab6fe2db36da4d9ead01eda119b5774b91d.profdata to chrome-win64-master-1599089820-30c557886a4f99c250ad2970e2bac8f9c1182d9f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0203da053eb6a18d6a34008b98c1baa0b540e598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804165}
-
Makoto Shimazu authored
Disabled two tests: - WebContentsImplBrowserTest.DownloadImage_Deny_FileImage - WebContentsImplBrowserTest.DownloadImage_Allow_FileImage TBR=falken@chromium.org No-Try: true Bug: 1124349 Change-Id: I5412e0a932b22952e4243c7f075260bf2b434405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391889Reviewed-by:
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_PreviewIds to print.mojom to pass it to Mojo interfaces. This is a precursor CL to move PrintPreviewUI implementations to PrintPreviewMessageHandler and use WebContentsFrameReceiverSet instead of having its own pipe. Bug: 1122515, 1008939 Change-Id: I034e05f64f2de565dcf6a7d9724b78e822bf2114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379455 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#804163}
-
Palak Agarwal authored
stage of media::VideoCaptureBufferPoolImpl Change-Id: I993f1527729b11a12909bf07a3a1d929289fbf3a Bug: 781987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384035Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#804162}
-
Joel Hockey authored
This is a refactor only change to move functions from plugin_vm namespace to PluginVmFeatures object. TBR'ing owners as per https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR=stevenjb@chromium.org TBR=khorimoto@chroimum.org TBR=nancylingwang@chromium.org Change-Id: I3e0fe49adb32eb2f9cd830efec26b8adecfaff73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391031 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804161}
-
Alice Wang authored
This CL adds a field for spinner view in the AccountPickerBottomSheetView and rearranges some view setup methods. There is no behavior change in the CL. Bug: 1122942 Change-Id: I42bc643684be24f27e7234eea807672cde3fa14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385115Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804160}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6cebd4f5bf5..ca13f09d7848 2020-09-03 changhaohan@chromium.org Add UMA to track computed style grouping usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096230 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4d5c7e68619fa995a2ab82001efe73dd33f76b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391866Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7571f9e49024..a66a9c31a318 2020-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e1051cbaad46 to 75690ce7ef4a (4 revisions) 2020-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 33b01ad5 to 210fb6b5 (274 revisions) 2020-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6eeb3d8bf667 to 0c25fbe3e3ed (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1034840,chromium:1123524,chromium:1124379 Tbr: michaelludwig@google.com Change-Id: I0a395f20daaae9bab4aa28237b6215c3f527f6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391867Reviewed-by:
-
Hiroki Nakagawa authored
This is just a cleanup, and doesn't change functional behavior. Bug: n/a Change-Id: I42b6c5ca089302a9dcdffb85c01e3fc24e090d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391185Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#804157}
-
Michele Mancina authored
Bug: b/157457785 Change-Id: I405f33df3d48af3a83edfd58ebf6bb8fe29c08fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390644Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#804156}
-
Koji Ishii authored
This reverts commit 8ecd46b9. Reason for revert: Increases memory usage on 32 bits Original change's description: > Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing > > This patch changes |NGInlineNode::ShapeText()| not to reuse > |ShapeResult| for text with CSS property "letter-spacing" because we > modify |ShapeResult| directly to apply letter spacing. Thus, letter- > spacing is applied more than once on reused portion of |ShapeResult|. > > Bug: 1124446 > Change-Id: I8f0f45f613c872649e46fe96e031e9532a05bbe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390927 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804147} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: I2fbb377d000fa3944b5902043ae8796dedd9119c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390615Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f76c76d25df8..3649c2a8b0f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1116650,chromium:897470 Tbr: shimazu@google.com Change-Id: If890693c473d4bb641d6b96a59dd53af8491c72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804154}
-
Benoit Lize authored
glibc used to allocate memory using __libc_memalign(), and free it with free(). This imbalance means that our allocators are asked to free() data they didn't allocate. To make sure this doesn't happen, intercept the internal libc symbols. This was already done for tcmalloc, but not for PartitionAlloc. Extend it to PartitionAlloc, and add a test. Also document the issue more clearly in the files. This is required for PartitionAlloc Everywhere. Bug: 998048 Change-Id: I0852fc87f92f97de93aba130b2416926aa71d873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386717Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804153}
-
Camillo Bruni authored
Move the erroneously placed Microtask checkpoint from V8ScriptRunner::EvaluateModule to ModulatorImplBase::ExecuteModule. This CL affects the ordering around module script evaluation, especially between microtasks and Window/WorkerGlobalScope error events. This CL is a preparation to make the top-level await implementation simpler and more spec-conformant: https://crrev.com/c/2228881 Additionally we fix the evaluation-order-2-import-worker.mjs test expectations to be spec compliant. Bug: 1022182, 1096455c, 1114034, v8:9344 Change-Id: I0f6d510b62310d9342fea30ff8ed6cbe37349cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339658 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#804152}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599089820-64812fa7a88dc8607ac3baec5789a7fcb10cfda3.profdata to chrome-mac-master-1599112620-f359a51daebae2f754df062494b1fdebe13ff3bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I83e8fb9c57a0e3cb6054e08ffe8b66c74f1816b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391871Reviewed-by:
-
Alice Wang authored
This CL refactors AccountPickerBottomSheetTest by extracting the method clickContinueButtonAndWaitForErrorSheet() and add two more checks in checkCollapsedAccountList() method. Bug: 1121536 Change-Id: Id7a890ad66b244ea171c7a24d583c402600fca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383029Reviewed-by:
-
Irina Fedorova authored
This CL renames CompromisedCredentialsManager class to InsecureCredentialsManager and renames its methods. We need these changes as we want to repurpose this credentials manager to work with both weak and compromised credentials. Bug: 1119752 Change-Id: I533561b1212d8e55022e324dffa5c916b7e73d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387098 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
James Vecore authored
This change makes the Nearby Share keyed service only start for 'PrimaryProfiles' on chromeos and adds some additional profile oriented logging for debugging process manager profile issues. Change-Id: If239b038627c343bbf5848e9a4ab1f5aed498f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391905Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804148}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::ShapeText()| not to reuse |ShapeResult| for text with CSS property "letter-spacing" because we modify |ShapeResult| directly to apply letter spacing. Thus, letter- spacing is applied more than once on reused portion of |ShapeResult|. Bug: 1124446 Change-Id: I8f0f45f613c872649e46fe96e031e9532a05bbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390927 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804147}
-
Devlin Cronin authored
Composition is preferred over inheritance in general, and this also avoids multiple implementation inheritance (which is strongly discouraged by style) in two test suites. Also rename the Mixin to be "Helper". https://google.github.io/styleguide/cppguide.html#Inheritance Bug: None Change-Id: Ie4ab266baf55d7964ec2cbd06d372aa74ecadca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389415 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804146}
-
chrome://multidevice-internalsRegan Hsu authored
* Users can now set 2 tab model metadatas. * If any fields are empty, the url metadata will be treated as nullopt. * 3rd and 4th tabs will be added later. Screenshots https://screenshot.googleplex.com/AwV2evHm2c7QCMU https://screenshot.googleplex.com/6q7tXZFAH3K8pSL https://screenshot.googleplex.com/7rgRSDiU2EqKwXE https://screenshot.googleplex.com/7mJtxtdg3GrDF6q Bug: 1106937 Change-Id: I20872614efa1caa889267c1b01d4406255c60be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391647 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804145}
-
Paula Vidas authored
This CL adds a field to device info specifics for a list of data types for which the device wants to receive invalidations. The list will be used by the sync server to send invalidations for only those types. The data types are obtained from SyncInvalidationsService. Bug: 1102312 Change-Id: Ia85f2b523d1f9adeef84dc4562d1bd525615e368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387113Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
-
Sergey Abbakumov authored
This CL fixes media_unittests in a component build. The issue was a duplicate global feature object since media_switches.cc is inside a source set. Bug: 1123898 Change-Id: I97f18f166af4da4924ec191de6c183426e942aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387578Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Abbakumov <sabbakumov@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#804143}
-
Hiroshige Hayashizaki authored
This CL checks that worker.onerror event's `message` field contains the original exception's message, "TypeError", etc. This is a regression test for crbug/590219, where Chromium set the message to just "Uncaught ". This CL also refactors `exception-in-onerror.js` and renames it to `throw.js`, to share it from multiple test files. Bug: 590219 Change-Id: I7184eba7a9a6a7f08b1ef6eed95bc49adb91fcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368621 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804142}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46877765c47c..96dcbc6eb372 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4e00e7540aa0aca4d0f01deb432a1e948ed47ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392375Reviewed-by:
-
Klaus Weidner authored
The previous workaround for WebXR DOM Overlay mode from https://crrev.com/c/2378653 didn't work consistently due to a race condition. CompositorView's notifyWillUseSurfaceControl is asynchronous, so it's possible that initNativeCompositor will be using the OPAQUE surface even though a later call to canUseSurfaceControl() returns true and getSurfacePixelFormat() returns TRANSLUCENT. In this case, continue with the normal requestSurface path. Bug: 1123951 Change-Id: I612b24bcdeb8b45fb33c6d94481e6b2ab63c74c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386331 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804140}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ade98316c21..c60774bed06c 2020-09-03 danilchap@webrtc.org Delete RTPFragmentationHeader as no longer used 2020-09-02 deadbeef@webrtc.org Default streams: don't block media even if on different transceiver. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I39029e00fbf7956c52de83996896b8993d9920bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391053Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84bd9dade9cb..cba9bbbed68f 2020-09-03 syoussefi@chromium.org Vulkan: Fix resolve-with-subpass retaining resolve attachment 2020-09-03 syoussefi@chromium.org Vulkan: Remove accidental padding in push constants If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1124379 Tbr: cwallez@google.com Change-Id: I0fd8f8fefc572febcba757f6d6ed5f72859875a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391862Reviewed-by:
-
Gavin Williams authored
The histogram Printing.CUPS.UsbSetupSource expired in M85. This needs to be extended as this histogram still gives valuable data. Bug: 1089321 Change-Id: If56cf2004b53530b6d5e10ec043cc01ddd482dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391732Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#804137}
-
Makoto Shimazu authored
Tbr: mlamouri@chromium.org No-Try: true Bug: 1124352 Change-Id: Icd33fe6153b2659cf7ea0e4ded327ecdd0ceff84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390610Reviewed-by:
-
Chih-Yu Huang authored
Originally, we rely on ARC side to determine if the playback is secure or normal by passing a flag at initialization. But we could get the information from the input buffer directly. In this CL, we determine if the playback is secure by querying ProtectedBufferManager with the first input buffer. If we can get the corresponding protected buffer, then we consider the playback as secure. Otherwise, we consider it as normal playback. BUG=b:153608694 TEST=play sintel at Google Play Movie on rammus-arc-r Change-Id: I0e30ca169a36223b9d82854f3382303a68c1ba3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377040 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#804135}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/683beccf6776..7571f9e49024 2020-09-03 johnstiles@google.com Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I60377e2dc95e384ed03fda5958d1300c4f6d12af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391052Reviewed-by:
-
Kent Tamura authored
* Fold it into LayoutBox like other form control elements. * Introduce IsSliderContainer() to share identical code between LayoutBox and LayoutTheme. * Move kDefaultTrackLength from LayoutSliderContainer to SliderIntrinsicInlineSize() in layout_box.cc This CL has no behavior changes. Bug: 1040826 Change-Id: I70bb3c67a1fbdc40502e36ca68d890719fc02f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392280Reviewed-by:
-
