- 03 Mar, 2020 40 commits
-
-
Andrew Solovey authored
Fix a problem when the primary Unicorn account could be force logged out in case secondary account becomes unauthenticated. Force log out only when primary account has errors with its refresh token. R=droger@chromium.org, emaxx@chromium.org, sinhak@chromium.org Bug: b/146461662 Change-Id: I22f2da65e2b208f47d791cd1c6c3d9b0235a9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058958Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#746323}
-
Maksim Moskvitin authored
This CL is a part of ObjectId -> Topic API migration. It's a pure refactoring and there should be no behavioral changes. This CL replaces ObjectID with Topic for public interfaces of components/invalidation. It removes all the occurrences of ObjectID from chrome/browser/policy, chrome/browser/chromeos/policy, components/sync (except java counterpart) and components/drive. components/invalidation/public still exposes ObjectID in some places, because it has internal usages (will be addressed in follow-up patches), so build dependencies are not updated yet (cacheinvalidation should be only used internally in the future). Bug: 1029698 Change-Id: Ibd152e2185a9f63bb9f3667bbff7ab0b70720eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066917Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#746322}
-
Christopher Cameron authored
Specify RGBX_8888 when alpha is not needed, so that DXGI_ALPHA_MODE_IGNORE will be specified in DirectCompositionChildSurfaceWin. Bug: 1057163 Change-Id: Ief415035f268b0d56a03342d9adf1948eda6b774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082552 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#746321}
-
Eriko Kurimoto authored
This CL modifies the comment in dedicated-worker-parse-error.html. Change-Id: I671c28c08101dfb36d3a439897e64d7da12ae853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083982Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#746320}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ifba3512fa358617373c8da6f3353d3fe96ac7660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084334Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#746319}
-
Jérôme Lebel authored
This test has been disabled for a timeout raison. This cannot be reproduced. The test failed twice on ios13-beta-simulator in setup phase which is not related to the test. So the test can be re-enabled. Fixed: 1055457 Change-Id: Ib51ab730bb08171fe1c57896ea558bb9ba4a0375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083472 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#746318}
-
Mahmoud Gawad authored
Allow mojo_utils in wilco_dtc_supportd to use ScopedAllowBlocking's private ctor. GetStringPieceFromMojoHandle() runs in the browser process and has DCHECK errors. This is because GetStringPieceFromMojoHandle() uses base::file::Fstat() that is marked with ScopedBlockingCall. Background: Referring to the discussion in https://chromium-review.googlesource.com/c/chromium/src/+/2042611, the ideal solution to this problem is to upgrade mojo library in chromeos (mojo library in chromeos is 1-2 years older than chrome). Doing that, the new shmem builtin types can be used and we won't need to get the handle's length in the first place. The problem with that is upgrade will take time. So, as a temporary solution, allow mojo_utils in wilco_dtc_supportd to use ScopedAllowBlocking's private ctor by making the class friend with ScopedAllowBlocking. The justification as per alexilin@ is that: Fstat() shouldn't be blocking for shared memory descriptors (i.e. mojo handle). Fstat() will read tmpfs metadata that is always stored in RAM. That metadata is never swapped to disk since it's part of kernel-allocated memory that is never swapped out. Bug: 1055467,b:146119375 TEST=building and running unittests Change-Id: Iba688b7f311c07b051687a1f619b594475892178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070160 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746317}
-
Pâris MEULEMAN authored
This works around crashes that surfaced in Cross-origin-opener-policy WPT tests. Two possible crashes happened: 1 - The |RenderView| that created the |BlinkTestRunner| used as a delegate got deleted. Later a new |RenderView| is created, followed by its |RenderFrame|. The creation of the |RenderFrame|'s associated |WebFrameTestClient| crashes as |TestInterfaces::delegate_| is now uninitialized (DCHECK in |WebFrameTestClient| ctor). 2 - Two |RenderViews| are created, both create a |BlinkTestRunner|, the first one created is used for |TestInterfaces::delegate_|. Then |WebFrameTestClient|s are created, and take a pointer to this |delegate_|. Later the |RenderView| associated to the delegate is deleted, deleting the delegate. Leading to UAFs by |WebFrameTestClient|s under the other |RenderView|. This failures happen in COOP tests as multiple tests opening and closing popups are ran simultaneously from the same window. A bit more context: The creation of the |RenderView|, instrumentalized for tests through |CreateWebViewTestProxy| creates a new |BlinkTestRunner| and a child class of |RenderView|: |WebViewTestProxy|. The first execution of |CreateWebViewTestProxy| registers the |BlinkTestRunner| using |TestInterfaces::SetDelegate|. The |RenderView| destruction updates |TestInterfaces::delegate_| to nullptr. Likewise, the creation of |RenderFrame| through |CreateWebFrameTestProxy| creates a |WebFrameTestProxy| and closely related |WebFrameTestClient|. The latter saves a pointer to |TestInterfaces::delegate_|. To Prevent these crashes, this CL changes: - When a |RenderView| is created and no delegate exists, i.e. |TestInterfaces::delegate_| is nullptr, use the newly created |BlinkTestRunner| as the delegate_. This avoids 1-. - When a |RenderView| is deleted and another exists, switch to that one's |BlinkTestRunner| as the |TestInterfaces::delegate_|. - |WebFrameTestClient| to not hold a pointer to |TestInterfaces::delegate_| and instead access it through the |WebViewTestProxy| pointer it already had: |web_view_test_proxy_->test_interfaces()->GetDelegate()|. These two combined avoid 2-. Bug: 922191 Change-Id: I83e16a4064afca1c595b04c5ccbb46f1488188f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074482 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#746316}
-
Kent Tamura authored
This CL relands a part of http://crrev.com/c/2074840. In order to fix crbug.com/1056094, we'd like to add new pointer field to ChildrenChange. However, just adding the field regresses appendChild performance significantly on some perf bots (crbug.com/1057282). So, this CL also does the following changes to reduce memory cost and code size cost: - Make ChildrenChangeType and ChildrenChangeSource scoped enums, and they are based on uint8_t. - Move |by_parser| field next to |type| These two changes make it possible to pack |type| and |by_parser| - Introduce ChildrenChange:ByParser() to simplify the code This CL has no user-visible behavior changes. Bug: 1056094, 1057282 Change-Id: I1fd99c1779f26358e277dba521395e39b9751217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082428Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746315}
-
Maksim Moskvitin authored
UpdateCryptographerFromKeystoreNigori() and UpdateCryptographerFromNonKeystoreNigori() had already shared logic and we have plans to make their logic even more common: - accept different keys for decryption of keystore Nigori - validation of these keys (e.g. current default key is acceptable for any passphrase types, but it's better to avoid it after passphrase type change) - validation of remote keybag after encryption - differences related to going out of |pending_keys| state seem wrong There are still several redundant if's, which change behavior based on passphrase type, introduced in this CL. They will be removed in follow-up CLs and introduced to avoid behavioral changes. This CL is a pure refactoring and doesn't introduce any behavioral changes. Bug: 1020084, 1057655 Change-Id: I99ce31ac1c6ca3ca42e017c3a61ede731a48dc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944487 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746314}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03a5e99059af..f6edc90900fe git log 03a5e99059af..f6edc90900fe --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ting.shao@intel.com [Telemetry] Add logs for loading the server and request handler 2020-03-03 fancl@chromium.org sheriff-config add /warmup for config caching Created with: gclient setdep -r src/third_party/catapult@f6edc90900fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1019097 Tbr: skyostil@google.com Change-Id: Ie2d67bb98821dfda501cf50a49c0c54c2d706b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746313}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4d59d6d2f15a90c4dc1e207a06bd114e0133a23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084440Reviewed-by:
-
Mark Cogan authored
This CL refactors the BroswerState keyed service that handles enabling and disabling web states (WebStateListWebUsageEnabler) to be a Browser Agent. The API is unchanged, aside from accessing the agent via FromBrowser() instead of FromBrowserState(). The URLLoadingService unittest needed to be heavily updated for this change: - The unused TabModel mocks were removed. - The test was updated to do work in the constructor and destructor, rather than SetUp and TearDown. Thins includes moving most of the member init to an init list. - The test now uses no-parameter TestBrowser constructor which creates and owns its browser state and web state list. The accessory classes for WebStateListWebUsageEnabler (the factory and abstract base class) are also removed. Bug: 1032556 Change-Id: Ib973d31253c5c92586184089db31d780083a8fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062970 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746311}
-
Dominik Röttsches authored
https://codereview.chromium.org/1847173002 / crrev.com/e9b78323 removed the browser side DWrite font cache code after moving to DWriteFontProxy. Remove the corresponding deprecated histograms, which were contained in that code. Bug: 525142 Change-Id: I6886142702b4cdc1635a118ac815c4c7daffe7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082553 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#746310}
-
Omar Morsi authored
Bug: 980395 Test: browser_tests --gtest_filter=*EnterprisePlatformKeysTest* Change-Id: I3881ed76c7b498665c699b1c64c28ffc1713f4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967468Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#746309}
-
Taras Antoshchuk authored
Use software TPM implementation by default if tpm_fallback=true is in build arguments TEST=manual BUG=b:146479130 Change-Id: Ibc6e17c97554ee6c685cedff9ca0b11bea738f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062995 Commit-Queue: Taras Antoshchuk <tantoshchuk@google.com> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Auto-Submit: Taras Antoshchuk <tantoshchuk@google.com> Cr-Commit-Position: refs/heads/master@{#746308}
-
Dominik Röttsches authored
Addressing feedback to previous UMA lifespan extension CL in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2082375 Tbr: wfh, schenney Change-Id: I6cb28f47ec207ffcdac873b7f9ae212e4c6dfe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083330Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#746307}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89e8fe53505c..194c399f9673 Created with: gclient setdep -r src-internal@194c399f9673 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib4a324bcceddfad80c829d838b4814cb8ff1c8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084436Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746306}
-
Junyi Xiao authored
This change 1. hides the install pwa page action icon in the toolbar 2. grayed out "create shortcut" and "Install {pwaName}" menu items when page crashed. Bug: 1057526 Change-Id: I63d5e3607e9aff71ab2bd799d792f025b142ec42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078771 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#746305}
-
Mark Cogan authored
This reverts commit d5af0a22. Revert prior revert for re-land. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2078452 Bug: 1057621 Change-Id: Ib8875dedd510d078660c7cb37edb5823530e3fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082913Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746304}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f996a1c537a0..b6cad595a9df git log f996a1c537a0..b6cad595a9df --date=short --first-parent --format='%ad %ae %s' 2020-03-03 szuend@chromium.org Prepare SASSSourceMapping.js for asynchronous live locations 2020-03-03 szuend@chromium.org [utilities] Use Set instead of Array for TargetModel._observers 2020-03-03 szuend@chromium.org [utilities] Use Set instead of Array for tree outlines in SourcesPanel Created with: gclient setdep -r src/third_party/devtools-frontend/src@b6cad595a9df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61b1040459a16036bef6edd9827470cebf3b36e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084438Reviewed-by:
-
Mikel Astiz authored
Follow up to crrev.com/c/2062328 where an analogous DCHECK was adopted in BookmarkModel, the main caller to BookmarkNode's constructor, and the only one that does not always use base::GenerateGUID(). Change-Id: I1a7f60e0b778ac99950d99404cfd37fc17582a4a Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056464Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746302}
-
Sylvain Defresne authored
This is a reland of 95ba7404 Original change's description: > [ios] Remove dependency of Showcase on //ios/chrome/app:app_internal > > Showcase should not depend on //ios/chrome/app (except for the hooks). > The dependencies were unnecessary and can be safely removed (after the > removal of one stale #include). > > After this CL, there is no dependency on //ios/chrome/app:app_internal: > > $ gn path out/Debug-iphonesimulator --all \ > //ios/showcase:ios_showcase_egtests \ > //ios/chrome/app:app_internal > No non-data paths found between these two targets. > > Bug: 870935 > Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744923} Bug: 870935 Change-Id: I720f8e8dd8ed43ed2417d566454e8612cd518e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082914Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#746301}
-
Guido Urdaneta authored
This reverts commit 8b1fecff. Reason for revert: Causes bot failures. https://crbug.com/1057949 Original change's description: > [RTCInsertableStreams] Always sync JS ArrayBuffer with internal buffer. > > It is possible to modify the data field without replacing it, so syncing > always. > Will work on an optimization for a follow-up CL. > > Bug: 1052765 > Change-Id: Ibc5b143413163f12af3c6cacefb3a9ee028b7eb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083092 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746093} TBR=hta@chromium.org,guidou@chromium.org Change-Id: I69c89db2923f8279fdb40bd7415157dfbb48a189 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082921Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#746300}
-
Clemens Arbesser authored
This is a refactoring and should have no user-facing changes. There are three reasons for this change: (1) Basic interactions (i.e., interactions that are not platform-dependent) should be in a platform-agnostic location. (2) There is now a convenient build target to unit-test those interactions. (3) This is preparation for a follow-up CL where a new basic interaction will be added: SetChips. This will require calling Controller::SetUserActions, which would be impossible from within platform-dependent code without exposing way too much. (side note: chips should of course just be part of the model, which would make this change trivial. Unfortunately, they currently are not, and moving them is not easy / will be done in a separate CL). Bug: b/145043394 Change-Id: I8b26fbe15afdd8f5a1eec116c3790f67b2e63dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074500Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#746299}
-
Simon Que authored
This reverts commit eca48c52. Reason for revert: Build still fails: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886863551848667888/+/steps/compile/0/stdout Original change's description: > Reland "infra: Migrate builders to Goma RBE (iOS Week 1a)" > > This is a reland of 765c53e1 > > Original change's description: > > infra: Migrate builders to Goma RBE (iOS Week 1a) > > > > These are the two builders in webrtc.fyi: > > - WebRTC Chromium FYI ios-device > > - WebRTC Chromium FYI ios-simulator > > > > These builders are small. They are expected to have a peak traffic of > > 15 QPS: > > https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=1721756715 > > > > Schedule of migration: > > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > > > R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org > > > > Bug: 950413 > > Change-Id: Id47cc7887bbefaf4dfe9f72275b80c8f04c428a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043185 > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: smut <smut@google.com> > > Commit-Queue: Simon Que <sque@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739771} > > Bug: 950413 > Change-Id: Idf2146ed92e80075675c15b79f9d65633458258f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074178 > Reviewed-by: smut <smut@google.com> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Simon Que <sque@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746203} TBR=sque@chromium.org,agable@chromium.org,yyanagisawa@google.com,smut@google.com,tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I75499291c14e80bb6a90be0ef2126a7b6f98b9a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084217Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#746298}
-
arthursonzogni authored
According to the specification: https://mikewest.github.io/corpp/#initialize-embedder-policy-for-global The COEP of a DedicatedWorker is the COEP of its owner document. This patch fix WPT test introduced in the previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/2080355 TBR=mkwst@chromium.org Bug: 1031542 Change-Id: I5152096f543569696b57fd664942d0a9923d6ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080355Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
arthursonzogni authored
This is a follow-up to haraken@ comment on: https://chromium-review.googlesource.com/c/chromium/src/+/1533913/33/content/renderer/render_frame_impl.cc#1517 Bug: None Change-Id: I03a15efd4bca486c7400693ac3cdfe9da32b14fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083532Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746296}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc542822..7e2188de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I145f9b85eb5d904e58f58d02701761f4299e457a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746295}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<LayoutView> and DynamicTo<LayoutView> as new downcast helper 2. Use IsA<LayoutView>(element) in place of IsLayoutView(element) Bug: 891908 Change-Id: I62c0752345578f5c6299dbdefd3fd3de891f7ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018628 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: -
Eriko Kurimoto authored
This CL adds dedicated-worker-parse-error-failure.html which tests the failing cases with parse error. We already have dedicated-worker-import-failure.html and this tests the failing cases with fetch failure. Change-Id: I8ae51b5b857aeadbaad0c5df3c8580e674ad5da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079728Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/80f55e974204..b84969ad69c3 git log 80f55e974204..b84969ad69c3 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jmadill@chromium.org Vulkan: Use QueryHelper for internal GPU timing. 2020-03-03 jmadill@chromium.org Split up EGLContextCompatibilityTest. 2020-03-03 jmadill@chromium.org Vulkan: Clean up QueryHelper uses. Created with: gclient setdep -r src/third_party/angle@b84969ad69c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0cd144aa5b0dabfd71b4d002ebe2c797a6b84161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084108Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df7c402d99bc..29f04c8cdb9b git log df7c402d99bc..29f04c8cdb9b --date=short --first-parent --format='%ad %ae %s' 2020-03-03 treehugger-gerrit@google.com Merge "Revert "Revert "Cleanup startup: remove CPU ratio""" Created with: gclient setdep -r src/third_party/perfetto@29f04c8cdb9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id78f5990cadfcc5f048ea9246c9397ca437621c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084431Reviewed-by:
-
Jose Lopes authored
These callbacks are repeating because they are called (directly and indirectly) from an event handler. The callbacks are called in: * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=172faf690d9ee133cd1f9ec0f3e055323a1861a9&l=165 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=172faf690d9ee133cd1f9ec0f3e055323a1861a9&l=194 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=172faf690d9ee133cd1f9ec0f3e055323a1861a9&l=204 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=172faf690d9ee133cd1f9ec0f3e055323a1861a9&l=256 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=172faf690d9ee133cd1f9ec0f3e055323a1861a9&l=339 The event handler is triggered by: * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=4c6e8dd47f011e8b95095fdc8c05c453de9c0e3a&l=55 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=4c6e8dd47f011e8b95095fdc8c05c453de9c0e3a&l=220 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=4c6e8dd47f011e8b95095fdc8c05c453de9c0e3a&l=257 * https://cs.chromium.org/chromium/src/media/filters/pipeline_controller.cc?rcl=4c6e8dd47f011e8b95095fdc8c05c453de9c0e3a&l=319 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Id3acd465aa99e9d062e289575f140051fddb7377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080474Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#746290}
-
Eugene But authored
WebStateList supports batch operation (f.e. used in Close All Tabs and Undo Close All Tabs actions). These batch operations may call the same WebStateListObserver callback multiple times which creates a lot of noise in breadcrumb logs. This CL adds support for Insert and Close batch operations and only logs the number of inserted or closed WebState objects. Additional changes: - Remove WebStateDetachedAt because it's always coupled with WillCloseWebStateAt and does not add anything on its own - Remove _ from "Browser_<id>" to be consistent with logging "Tab<id>" Bug: 1046231 Change-Id: I11429a281bf8d7c343132c02e4b92f463aa8a7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082484 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746289}
-
Jose Lopes authored
This is a repeating callback because it's called by ProcessFrames which can be repeatedly called: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=c708c2ae1e32b8dfe18fa2636cecce1ff58ef979&l=379 For example, this method is called by an event handler: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=971142db40365137b9567f12af3ba2f03722aae4&l=949 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib2b48a9ed02e6670e0718c141bf60ad76a37902b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080419Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23ee1aad0a5d..f996a1c537a0 git log 23ee1aad0a5d..f996a1c537a0 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 szuend@chromium.org Revert "Typecheck Object.js" 2020-03-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-03-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-02 horo@chromium.org Remove sxg-with-network-service virtual tests from devtools-frontend 2020-03-02 tvanderlippe@chromium.org Update TypeScript to 3.8.3 2020-03-02 joselea@microsoft.com Typecheck Object.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@f996a1c537a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1057538 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4f307a72b83535ce5305a40268d803d2091a2848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084107Reviewed-by:
-
Mathias Bynens authored
Now that the corresponding DevTools front-end CL [1] has landed, we can re-enable the test with updated expectations. The CL that temporarily disabled the test was [2]. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2083147 Bug: chromium:1057042 Change-Id: I0fe4c97dd2640df23fae9a3c0db45a7c8118421f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083302Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#746286}
-
Colin Blundell authored
This CL creates //components/external_intents, initially populating it with the previously //chrome-level switch that is used to disable the launching of external intents. The ultimate goal is to have //chrome's ExternalNavigationHandler.java and friends live inside this component for sharing with WebLayer. Bug: 1031465 Change-Id: I738f5a9eff6d415aedc85364cb4b8e6c0bb1475b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082377Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#746285}
-
Xing Liu authored
This reverts commit 14bdb1d3. Reason for revert: Might break Clank x86 builders. Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=1056974 Original change's description: > Remove chromedriver/cipd. > > Change-Id: I5d81e5569a061d0e4609449c49835e61a810bae0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073120 > Auto-Submit: Andrew Luo <aluo@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744790} TBR=sky@chromium.org,changwan@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,aluo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7ea9fa3f9c0ee7951ae7a1d46770b2d1ebce9ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083751Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
