GitLab

In this case, arch="iPhone10,3" was not matched by \w+.

Also, fixed escaping . in several places inside regexes.


Bug: 881076
Change-Id: I2814eedce66b1b3c0a8fa8fff0eb6490dc4906cb
Reviewed-on: https://chromium-review.googlesource.com/c/1276889Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598808}

This is the unit test for https://crrev.com/595477, which fixes a crash
when ChromeDriver receives a large number of message packs from Chrome
(issue #877105). The test forces a large number of message packs by
using a very small buffer size.

Bug: 877105
Change-Id: I20895447ef33d75acd07135d8234e899ab1ed91d
Reviewed-on: https://chromium-review.googlesource.com/c/1272068
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598807}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/54ca2cd59219..6272edcb53d3

$ git log 54ca2cd59..6272edcb5 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 junyer Dial down the fanout limits slightly.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Bug: 894073
Change-Id: I4ec6ee50d405fb3b6d72fc27a328cb8b3e16bad2
Reviewed-on: https://chromium-review.googlesource.com/c/1276826Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598806}

When the user is picking a preferred ContentSize from the
"accessibility" bucket, the layout of the article should be different.

Bug: 893525
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8686c33ef80775d799e6fbb8752ee4c011798154
Reviewed-on: https://chromium-review.googlesource.com/c/1273147Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598805}

This reverts commit 7f08809a.

Reason for revert: broke compilation
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932945363042209344/+/steps/compile/0/stdout

../../gin/v8_foreground_task_runner.h:27:60: error: only virtual member functions can be marked 'override'
    void PostNonNestableTask(std::unique_ptr<v8::Task> task) override;
                                                             ^~~~~~~~
  ../../gin/v8_foreground_task_runner.h:34:40: error: only virtual member functions can be marked 'override'
    bool NonNestableTasksEnabled() const override;

Original change's description:
> [gin] Allow posting non-nestable tasks through V8
> 
> Will be used to allow V8 posting top-level tasks.
> 
> Bug: chromium:843903
> Change-Id: I97caa705b561fa8832ef8a11abfc3eefe47ec3f8
> Reviewed-on: https://chromium-review.googlesource.com/c/1273140
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598802}

TBR=mlippautz@chromium.org,jochen@chromium.org

Change-Id: I5d427abfe85e3b69a3d649ee190406a5d9583d9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:843903
Reviewed-on: https://chromium-review.googlesource.com/c/1277086Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598804}

This CL refactors image_decode_bench:
- Rewrites function ReadFile() to use base::FilePath etc.
- Configures the Logging and changes fprintf/stderr to LOG()
 statements, and exit()s into LOG_ASSERT().
- Names the constant kDefaultDecodeTimes.
- s/DecodeError/PrintErrorAndExit/ to clarify what it does.
- Changes uses of CurrentTimeTicks() with base::ElapsedTimer,
 and uses TimeDelta ISO double to count the elapsed time.
- Uses perf_test::PrintResult to add info about the image
 (size and #pixels), when a new parameter (-v / -verbose)
 is specified after the current two parameters, file and
 #iterations; output is e.g.:
*RESULT decode_time /usr/local/google/home/mcasas/Pictures/4.webp: 100 times 790528 pixels (1024x772)= 66.27827 ms/sample

Bug: 889898
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic0a66d2aa3d2f08b13c8af99aed31e61d7246dec
Reviewed-on: https://chromium-review.googlesource.com/c/1225653
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598803}

Will be used to allow V8 posting top-level tasks.

Bug: chromium:843903
Change-Id: I97caa705b561fa8832ef8a11abfc3eefe47ec3f8
Reviewed-on: https://chromium-review.googlesource.com/c/1273140Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598802}

This CL uses RasterDecoder for CPU rasterization (one-copy and
zero-copy) on worker background raster threads in two cases:

(1) in renderers whenever GPU raster is blacklisted or cannot create
    GrContext (similar to
    LayerTreeHostImpl::GetGpuRasterizationCapabilities)

(2) in browser whenever GPU raster is not requested

This CL copies some of the logic in LTHI::GetGpuRasterizationCapabilities
to RenderThreadImpl::SharedCompositorWorkerContextProvider.
I copied it so that if we fail GPU rasterization using GLES2Decoder, we
can fallback to CPU raster using a RasterDecoder.

This change should be safe because we have been fuzzing all
RasterDecoder entry points for about 1 quarter.

When testing this CL, I noticed that chrome://gpu was reporting
rasterization status incorrectly with --force-gpu-rasterization flag,
so I fixed that too.

Bug: 880911
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8d93b9d0bfe30e9ee0d5e522be0d9f8155a28726
Reviewed-on: https://chromium-review.googlesource.com/c/1258206
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598801}

Modernize the interface for JavaRef and its subclasses - make better use
of C++11 features, and mark existing confusing/easily misused APIs as
deprecated. Also. fully reformat the file while it's being changed this
much.

Notable changes:
 - JavaRef can now be converted to bool in bool contexts, so "if (obj)"
   works and "!obj.is_null()" is no longer necessary.
 - ScopedJavaLocalRef<T>::Adopt() now exists to make it more explicit
   that the caller is adopting an existing reference, not creating a new
   one. This should only be used when dealing with return values from
   JNIEnv methods.
 - Conversion constructors/assignments now exist, allowing for example
   JavaRef<jstring> to be assigned to ScopedJavaLocalRef<jobject>.
 - Local references can be constructed or assigned from global
   references and vice versa without needing to use Reset().
 - Confusing forms of Reset() that take different parameters, or behave
   differently from, construction/assignment have been deprecated.

The new API is intended to be somewhat similar to scoped_refptr, which
is the closest native equivalent.

Bug: 519562
Test: base_unittests
Change-Id: I8a989dd04b357e83bc2a28a6ec9b7e14495ccbd2
Reviewed-on: https://chromium-review.googlesource.com/c/1262115
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598800}

Bug: 888176
Change-Id: Ib823bc98d8aaadbd5deacf2ff7288e3661a73db2
Reviewed-on: https://chromium-review.googlesource.com/c/1274841Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598799}

Define a new helper class to register and unregister the test
factory to use in GCMProfileServiceFactory. It uses RAII to
ensure the factory is properly unregistered during the test
cleanup.

Bug: 809610
Change-Id: Iec5457b6372ea23d33f3a07de894c33100f7d9e0
Reviewed-on: https://chromium-review.googlesource.com/c/1261123
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598798}

We need to update the bottom margin on browser controls constraint
changes for VR.

Bug: 884803
Change-Id: I684eac23d8aefcaa8ad8c4cddcf12ebc4a6352cc
Reviewed-on: https://chromium-review.googlesource.com/c/1275145Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598797}

In Python tests in case Chrome fails to start with timeout,
it will be restarted, but no more than 3 times per suite.

Change-Id: Idafa7702d0fe63d4f430ba7a7311b4e62cbafbc7
Reviewed-on: https://chromium-review.googlesource.com/c/1272578Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598796}

WrapUnique(new ...) should be std::make_unique.

Bug: none
Change-Id: Ic2687b75ab5ef5884d2857d05defb37908a9e1ee
Reviewed-on: https://chromium-review.googlesource.com/c/1234961
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598795}

Fix launchApp command flakiness that has been observed in testing.

Bug: chromedriver:2607
Change-Id: I0db77d353079534238e857ffa090de0a37b52568
Reviewed-on: https://chromium-review.googlesource.com/c/1274589
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598794}

This changes adds an enterprise policy that disables NTLM authentication
protocol for enterprise-managed users and allows them to manually turn
it on.
For non-enterprise users, it will be enabled by default.

Bug: chromium:888096
Change-Id: If42e57b9242600ab9b51d61874bf810e2d32a804
Reviewed-on: https://chromium-review.googlesource.com/c/1256002Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598793}

The multiple meanings with the bottom controls are a root for multiple
issues:
 * the CCT bottom bar being overlaid (and leaving a white patch)
 * the PWA bar resizing the viewport deferred
 * the flakiness of fullscreen applications

This CL introduces a solution that provides the bottom bars and the
compositor view holder with the "keyboard extension" as new bottom
element that is independent from others.

Currently, this extension is set on the instance. Long-term, the
delegate would only provide a getter that its children inherit.

Bug: 885113, 704070, 875077, 891657, 881536
Change-Id: I59639204823296b7c4ac701d0243aaa751f8b57d
Reviewed-on: https://chromium-review.googlesource.com/c/1233716
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598792}

Until now CSSFlexibleBox use counter was counting
not only "display: flex|inline-flex" elements,
but also buttons or any other classes that inherit
from LayoutFlexbibleBox:
That's an implementation detail and we shouldn't be interested
in counting those cases as flexbox usage.

The patch moves the counter to LayoutObject::CreateObject()
so we actually check the display value.
The patch also moves the grid layout counter,
despite nobody is inheriting from LayoutGrid now,
a similar issue could happen in the future if someone does it.

New unit tests are added to verify that things are working
as expected now.

Change-Id: I716870a666a4167d19153667bc80f68a3ba0d7e3
Reviewed-on: https://chromium-review.googlesource.com/c/1273107
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598791}

A particular RenderProcessHost may be re-used for multiple renderer
processes. The bug is that GinJavaBridgeMessageFilter is not removed
when this happens, so it is not re-added as a filter to the new renderer
process in this case.

Fix by removing the filter when renderer process dies, so a new filter is
created and added when the new renderer process is created.

Bug: 892452
Change-Id: I0762019282f89d21c53136db58a99d8bbce3af1c
Reviewed-on: https://chromium-review.googlesource.com/c/1274590Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598790}

Previously, the DeviceSync service would retain references to its
dependencies until it was deleted when the browser process was killed.

When attempting to enable the MultiDevice flags by default, this
causes crashes in some tests due to the service not removing itself as
an observer. This CL adds an explicit shutdown step which removes these
references and causes the observer to be removed.

Sample failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933085811650027344/+/steps/sync_integration_tests__with_patch_/0/logs/USS__x2f_SingleClientWalletSyncTest.DownloadProfileStorage__x2f_0/0

Bug: 884066
Change-Id: I87bcc9ab27f0a1032bc6990a71f863786ddf97fc
Reviewed-on: https://chromium-review.googlesource.com/c/1274886
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598789}

- When using chromad kerberos, don't resolve the hostname into an ip
address since kerberos service tickets are keyed on the hostname
- Previously, we resolved any hostname we could (meaning the share was
found during discovery) into an ip address, which could prevent chromad
kerberos from working correctly.

Bug: chromium:853806
Change-Id: I48feec54defdb2821dee526f9f25cff0260363b6
Reviewed-on: https://chromium-review.googlesource.com/c/1274048
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598788}

Change the watchlist to cover ui code like:
chrome/browser/resources/settings/clear_browsing_data_dialog
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingData*

Change-Id: Ibe872c09e8ba9737faf474c1126524ca8c148531
Reviewed-on: https://chromium-review.googlesource.com/c/1276765Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598787}

Not sure yet why this isn't breaking M71, but it's breaking M70.

Bug: 894429
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7eadef0d8a6e990e37300ec0b391f05c1220ec0d
Reviewed-on: https://chromium-review.googlesource.com/c/1276566
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598786}

This is a prerequisite to:
https://chromium-review.googlesource.com/c/chromium/src/+/1122629

When a file chooser dialog is opened for an active iframe, but is closed
when the iframe is in pending deletion, it should not continue.

Bug: 609963
Change-Id: I897258f642e812de4b3abf117a2a83815568aba8
Reviewed-on: https://chromium-review.googlesource.com/c/1253783
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598785}

Currently to fix a layout issue in the save card infobar in iPhone X,
|-setFrame:| is overridden to call |-layoutIfNeeded| in order to update the
layout of subviews immediately. |-setFrame:| won't be required to be
overridden if the logic to adjust the layout constraints is moved from
|-sizeThatFits:| to |-layoutSubviews|. The existing logic is likely to be
wrong as the layout should not get updated in calls to |-sizeThatFits|.

This is likely the root cause for the crash in crbug.com/892144

Bug: 862688,892144
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iee81a30afa14581f304813512b84b86fc5c6feb5
Reviewed-on: https://chromium-review.googlesource.com/c/1262087
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598784}

Current resources that are cached are being reported as 0 byte
resources in Ads.ResourceUsage.Size.* histograms. This is skewing
the histograms low making it hard to see the real distribution of
resource sizes. Record cached resources in a separate histogram.

Change-Id: I379029ff70ad9f655a8e8887ff7cb5a5a3a08f5e
Bug: 859080, 892153
Reviewed-on: https://chromium-review.googlesource.com/c/1258284Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598783}

Currently, ProtoDatabase<T> only allows us to have a LevelDB that stores
a single proto type.

In preparation for a single unified proto DB, ProtoDatabase and
ProtoDatabaseImpl have been refactored. Much of ProtoDatabaseImpl's
logic has been moved into ProtoLevelDBWrapper, which contains template
functions instead of being a template class.

ProtoDatabase<T> provides the interface we have today, and we now
have a UniqueProtoDatabase<T> as a thin layer above ProtoDatabase so
that it can manage the unique_ptr to its own LevelDB.
ProtoDatabaseImpl<T> is kept around as an alias for UniqueProtoDatabase
for compatibility, and as a result no ProtoDatabase(Impl) users are
negatively impacted by this change.

The addition of the ProtoLevelDBWrapper provides a convenient place to
record metrics for the various database clients.

Bug: 870813
Change-Id: I6175a3cbea5dd312f09c1d88d5ad80f1f4b26006
Reviewed-on: https://chromium-review.googlesource.com/c/1170093
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598782}

https://webrtc.googlesource.com/src.git/+log/2b1562632a02..f81170b48fd4


git log 2b1562632a02..f81170b48fd4 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 perkj@webrtc.org Add error logs to RtpPacketHistory::GetBestFittingPacket when no packet is found.
2018-10-11 srte@webrtc.org Adds srte to WATCHLISTS.


Created with:
  gclient setdep -r src/third_party/webrtc@f81170b48fd4

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I817a9238ca176782360de7570a8cf747d5fa2098
Reviewed-on: https://chromium-review.googlesource.com/c/1276547Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598781}

It appears for the Chrome Sync users.

Bug: 890336
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0a443b3d29670c00c28a847d6d2253db3a620996
Reviewed-on: https://chromium-review.googlesource.com/c/1270922Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598780}

This is a cleanup CL to merge MainThreadWorkletGlobalScope and
ThreadedWorkletGlobalScope into WorkletGlobalScope for shallowing the class
hierarchy of WorkletGlobalScope and making it more extensible.

========== Details ==========

Before this CL, WorkletGlobalScope has the following class hierarchy.
MainThreadWorkletGlobalScope and ThreadedWorkletGlobalScope implement thread
specific things, for example, GetTaskRunner().

- WorkerOrWorkletGlobalScope
  - WorkletGlobalScope
    - MainThreadWorkletGlobalScope
      - PaintWorkletGlobalScope
      - LayoutWorkletGlobalScope
    - ThreadedWorkletGlobalScope
      - AudioWorkletGlobalScope
      - AnimationWorkletGlobalScope

This separation has been worked well until now because each subclass of
WorkletGlobalScope runs only on a specific thread (i.e., the main thread or a
worker thread). However, the situation has been changed. We started implementing
off-the-main-thread PaintWorklet (See https://crbug.com/829967) and noticed
this separation makes it so difficult to enable PaintWorklet to run on both the
main thread and a worker thread.

To mitigate the difficulty, this CL merges them into WorkletGlobalScope. After
this CL, the class hierarchy looks like this:

- WorkerOrWorkletGlobalScope
  - WorkletGlobalScope
    - PaintWorkletGlobalScope
    - LayoutWorkletGlobalScope
    - AudioWorkletGlobalScope
    - AnimationWorkletGlobalScope

In this new hierarchy, WorkletGlobalScope implements thread specific things, and
provides multiple constructors for its subclasses to specify thread affinity.

Bug: 893478
Change-Id: Iad817c7dd10ce5bd51a4c381fbd34aa1669454f7
Reviewed-on: https://chromium-review.googlesource.com/c/1272416Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598779}

FindIt is moving away from always using the --gtest* flags to a new set
of unified flags for all isolated script tests. This change adds the new
flags (as aliases to existing flags). The old --gtest* aliases will be
removed when FindIt no longer uses them.

Bug: 893235
Change-Id: I728c1377fb5f43a37b2cea7392c455af7b4a0e73
Reviewed-on: https://chromium-review.googlesource.com/c/1273886Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598778}

https://crrev.com/c/1272435 made it so that rebaseline-test-internal
would receive the step name from the parent rebaseline process, which
fixed rebaseline-cl.

However, there are still two users of BuildBot.results_url that do not
provide step_name: a log message in rebaseline_cl, and try_flag. This
change makes BuildBot.results_url get the step name if no step name is
provided, which will fix both the log message and try_flag.
https://crrev.com/c/1272435 is still good to have, because it saves lots
of network requests in the children rebaseline-test-internal processes.

Also include some drive-by cleanups.

Bug: 882946
Change-Id: I889885f42c001937123e733c6cf8124e2a9f2b3a
Reviewed-on: https://chromium-review.googlesource.com/c/1274665Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598777}

Bug: 101600
Change-Id: Ib2457bd9c714fe4d05b1eeb9dcaa1c311280c8fe
Reviewed-on: https://chromium-review.googlesource.com/c/1276685Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598776}

This CL adds a randomized encoder class. Instances of this class will
be used to encode autofill form and field metadata using differential
privacy, specifically randomized responses.

Bug: 850606
Change-Id: If0600595dafc6d3233674b92f40e3d092b2d5381
Reviewed-on: https://chromium-review.googlesource.com/c/1265832
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598775}

TBR=foolip

No-Try: True
Bug: 894457
Change-Id: I078420e54ad1b4626d5064b926da72048c6761c8
Reviewed-on: https://chromium-review.googlesource.com/c/1276828Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598774}

Ancient datatype-specific quirks are common in sync, and here's another
one: HISTORY_DELETE_DIRECTIVES datatype has special-handling in
GenericChangeProcessor() to handle directive deletion: instead of
tombstones uploaded to the server, the entries should be untracked
locally but nothing sent to the server.

The patch also fixes a DCHECK failure affecting pseudo-USS, because
such events (local "deletions") are signaled by the SyncableService as
remote changes / SyncDataRemote. Such is the implementation in
GenericChangeProcessor, so we follow the same approach in the
pseudo-USS bridge for compatibility.

Bug: 870624
Change-Id: Ic009b13c6e4aa7c3982d01b9ebd7511c6a0e3185
Reviewed-on: https://chromium-review.googlesource.com/c/1276607Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598773}

In order to get better understanding of Cacao hints applying to
slow page loads, this CL adds some HintCache match stats per
ECT. For original navigation it records whether the HintCache
has a known hint for the URL's host. At commit time it records
if there is a loaded hint for the committed URL and then whether
there is a matching PageHint (regardless of what the PageHint is
for) for the committed URL.

Bug: 892238
Change-Id: Ia66f899f1ee9299a1f780aa471e238ea073e06a2
Reviewed-on: https://chromium-review.googlesource.com/c/1270155Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598772}

This test was broken a while ago but now works.

Bug: 845503
Change-Id: I5275fe0166d3b82b26f616d0dcfe92e15d457b93
Reviewed-on: https://chromium-review.googlesource.com/c/1276786
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598771}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9ce2f8b70cf..2146d0609ce9


Created with:
  gclient setdep -r src-internal@2146d0609ce9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9f62c4437ff241c15b8e88de791b3c70b73daaab
Reviewed-on: https://chromium-review.googlesource.com/c/1275875Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598770}

This is only applicable when the application does not specify the
sdpSemantics and is relying on the default behavior which is about to
change from Plan B to Unified Plan. In "complex" use cases, Plan B SDP
would be rejected by Unified Plan clients. This CL adds a warning if:
- The SDP is "complex Plan B SDP".
- The RTCPeerConnection was constructed without specifying sdpSemantics.

Bug: 857003
Change-Id: I82b88fde2687edd68e0dc8e1126b16e49bf54c2b
Reviewed-on: https://chromium-review.googlesource.com/c/1275892
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598769}