GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/13f701a..5f6094a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/679973004

Cr-Commit-Position: refs/heads/master@{#301443}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=avi@chromium.org

Review URL: https://codereview.chromium.org/677413004

Cr-Commit-Position: refs/heads/master@{#301442}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/681753004

Cr-Commit-Position: refs/heads/master@{#301441}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/684483002

Cr-Commit-Position: refs/heads/master@{#301440}

Ensure that the main window does not render as deactivated when the link disambiguation bubble is displayed.

This uses the existing framework in the BubbleDelegate to disable inactive rendering in the active
widget when the bubble is displayed, etc. Inactive rendering is enabled when the bubble is dismissed.

Changes in this patch are to pass the active widget to the LinkDisambiguationPopup class when it is
created to display the bubble. This class then passes the contents view to the actual bubble.

BUG=421020

Review URL: https://codereview.chromium.org/680643002

Cr-Commit-Position: refs/heads/master@{#301439}

Selecting an app window from the overview mode maximizes the window only if it's maximizable.

A change proposal to fix the below 2 bugs: - crbug.com/424710 - crbug.com/424708

R=oshima@chromium.org
BUG=424710,424708
TEST=Manual & athena_unittests @ OnSelectWindow

Review URL: https://codereview.chromium.org/668513003

Cr-Commit-Position: refs/heads/master@{#301438}

- Bring back kiosk update url in device local account policy;
- Use the update url from policy to initialize kiosk cache;

BUG=345123
TEST=KioskEnterpriseTest.PrivateStore

Review URL: https://codereview.chromium.org/676913002

Cr-Commit-Position: refs/heads/master@{#301437}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/433f657..dbee270

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/682723002

Cr-Commit-Position: refs/heads/master@{#301436}

BUG=

Review URL: https://codereview.chromium.org/680903002

Cr-Commit-Position: refs/heads/master@{#301435}

This patch ensures that picture pile base is thread safe, since it is
not guaranteed that the ref is always adjusted on the same thread. In
particular, the worker thread (which refs picture pile on the cc thread)
might deref it (and delete it) on the worker thread.

R=reveman

Review URL: https://codereview.chromium.org/683543002

Cr-Commit-Position: refs/heads/master@{#301434}

Allocation of GpuMemoryBuffers requires a round-trip to the browser
process and by moving this to worker threads it is no longer on
the critical path on the compositor.

The LockForWrite mechanism in the ResourceProvider has been
adjusted to properly support worker thread allocation of
resources.

BUG=418553

Review URL: https://codereview.chromium.org/645943002

Cr-Commit-Position: refs/heads/master@{#301433}

We currently null the twin_layer_ pointer when pushing to the active
tree and then using hashmap lookups to find the recycled twin, and
reconnecting the pointers in DoPostCommitInitializationIfNeeded().

Instead, we can leave the pointers always valid and use Getter methods
that check what tree the twin is on to decide if we should consider it
a pending twin or a recycle twin.

This means that during commit the pending layer will be able to find
its active twin when it updates its picture pile, so that it can share
tiles that are not invalidated. (Previously it wouldn't know about its
twin until after commit, when we set it up and then did SyncTilings.)
This allows us to have a more straightforward flow of data, setting up
the pending tilings when we give it a pile from the main thread
instead of doing it at some hazy future time (usually inside
UpdateDrawProperties).

R=enne, vmpstr
BUG=407418,387116,427213

Committed: https://crrev.com/11f13546fd3ee3d53921c23861bf970bd2bb6428
Cr-Commit-Position: refs/heads/master@{#301155}

Review URL: https://codereview.chromium.org/676953003

Cr-Commit-Position: refs/heads/master@{#301432}

BUG=412383

Review URL: https://codereview.chromium.org/678553002

Cr-Commit-Position: refs/heads/master@{#301431}

Was reverted due to an in-flight conflict. Now includes update to Macy's test case.

TBR=isherman@chromium.org
BUG=426958

Review URL: https://codereview.chromium.org/686473002

Cr-Commit-Position: refs/heads/master@{#301430}

TBR=isherman@chromium.org
BUG=427603

Review URL: https://codereview.chromium.org/680633004

Cr-Commit-Position: refs/heads/master@{#301429}

This change introduces client_channel.mojom to define
internal messages for ChannelMojo. Hand-written HelloMessage
routines are no longer needed.

This is a preparation for coming fix which needs additional
internal messages.

TEST=ipc_mojo_unittest
R=viettrungluu@chromium.org
BUG=377980

Review URL: https://codereview.chromium.org/679453002

Cr-Commit-Position: refs/heads/master@{#301428}

If Unit tests are compiled with Ozone enabled by default, the
Ozone platform may be initialized twice leading to CHECK failures.

BUG=427299

Review URL: https://codereview.chromium.org/676043003

Cr-Commit-Position: refs/heads/master@{#301427}

BUG=364670

Review URL: https://codereview.chromium.org/643753002

Cr-Commit-Position: refs/heads/master@{#301426}

and also create an answer when setting the remote description has completed.

BUG=369796

Review URL: https://codereview.chromium.org/683433004

Cr-Commit-Position: refs/heads/master@{#301425}

Use --enable-power-overlay to view.

See http://crrev.com/673133002 for more details.

BUG=426761
TBR=stevenjb@chromium.org,asvitkine@chromium.org

Review URL: https://codereview.chromium.org/677983004

Cr-Commit-Position: refs/heads/master@{#301424}

TBR=jennb@chromium.org

Review URL: https://codereview.chromium.org/682713002

Cr-Commit-Position: refs/heads/master@{#301423}

BUG=none

Review URL: https://codereview.chromium.org/673313002

Cr-Commit-Position: refs/heads/master@{#301422}

Fix for URL text selection regression in
'chrome://settings/searchEngines'.

BUG=427385

Review URL: https://codereview.chromium.org/682663002

Cr-Commit-Position: refs/heads/master@{#301421}

Review URL: https://codereview.chromium.org/673363002

Cr-Commit-Position: refs/heads/master@{#301420}

BUG=

Review URL: https://codereview.chromium.org/683473003

Cr-Commit-Position: refs/heads/master@{#301419}

Currently, the second half of the test doesn't actually do anything. This
patch makes the second half of the test run. Fortunately, it already works :)

BUG=

Review URL: https://codereview.chromium.org/674203005

Cr-Commit-Position: refs/heads/master@{#301418}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/686463002

Cr-Commit-Position: refs/heads/master@{#301417}

BUG=159847

Review URL: https://codereview.chromium.org/678813002

Cr-Commit-Position: refs/heads/master@{#301416}

Seems the revert is a false alarm so reland the original patch.

refer to
https://codereview.chromium.org/682463002/

BUG=236640
TBR=scheib@chromium.org,cpu@chromium.org,jar@chromium.org,bshe@chromium.org

Review URL: https://codereview.chromium.org/676403002

Cr-Commit-Position: refs/heads/master@{#301415}

The profile cannot be determined by video codec type alone. Instead
the RtcVideoEncoder should wait until InitEncode time to determine
video codec profile based on the codec settings.

BUG=424828
TEST=trybot

Review URL: https://codereview.chromium.org/647613007

Cr-Commit-Position: refs/heads/master@{#301414}

to disable results caching.

TESTS=OmniboxFieldTrialTest + manual tests.

BUG=420903

Review URL: https://codereview.chromium.org/645303003

Cr-Commit-Position: refs/heads/master@{#301413}

Update PlatformFontMac to call the mac implementation of
FontRenderParams.

BUG=427319

Review URL: https://codereview.chromium.org/681773002

Cr-Commit-Position: refs/heads/master@{#301412}

r1994: Moves warning about invalid targets into 'invalid_targets' in result
r1993: Stop checking for duplicate basenames Chromium doesn't care about
r1992: Simplify and optimize FindCycles

BUG=426892
TEST=none
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/667423006

Cr-Commit-Position: refs/heads/master@{#301411}

BUG=230018
TEST=manual tests on falco

Review URL: https://codereview.chromium.org/657923003

Cr-Commit-Position: refs/heads/master@{#301410}

This is my initial attempt at the script suggested in http://crbug.com/415890.

BUG=415890

Review URL: https://codereview.chromium.org/652543005

Cr-Commit-Position: refs/heads/master@{#301409}

Currently there is insufficient coverage for text selection ActionBar
menu interaction. Add several basic tests covering such functionality.

Review URL: https://codereview.chromium.org/538103003

Cr-Commit-Position: refs/heads/master@{#301408}

R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/666443002

Cr-Commit-Position: refs/heads/master@{#301407}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/56de9f8..433f657

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/680103002

Cr-Commit-Position: refs/heads/master@{#301406}

BUG=399363

Review URL: https://codereview.chromium.org/643773002

Cr-Commit-Position: refs/heads/master@{#301405}

Context: https://codereview.chromium.org/660893002/

BUG=424345

Review URL: https://codereview.chromium.org/646033009

Cr-Commit-Position: refs/heads/master@{#301404}