- 06 Aug, 2020 40 commits
-
-
Brian Sheedy authored
This reverts commit 6ae1f421. Reason for revert: Incorrect test disabled. Original change's description: > Disable minidump tests on Linux > > Disables the Telemetry minidump symbolization tests on Linux, as they > are currently flaking pretty badly. > > TBR=johnchen@chromium.org > > Bug: 1108432 > Change-Id: I3fab14b82de7440eff534169cf028d324d6f37c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333667 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794208} TBR=bsheedy@chromium.org,johnchen@chromium.org Change-Id: I3cd4f00497602c008664e83413d6016e66e0b64d Bug: 1108432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335482Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795585}
-
Hyunjune authored
Remove |EnsureComputedStyle| on SVGPathElement::getPointAtLength. Although <path> is in an inactive document, <path> element can compute the total length of path. Because the equivalent path of a ‘path’ element is simply the path itself. Bug: 972979, 1108966 Change-Id: I5194352c1d4452dacc721f3ae223019998859d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339714 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#795584}
-
Tibor Goldschwendt authored
This CL: - Enforces a max height of 200px for image and unexpanded interactive doodles. - Anchors the doodle and logo 38px above the search box. This reflects the current behavior for 200px tall doodles and improves the layout for smaller ones. Before: https://screenshot.googleplex.com/7kaNU6rktGD After: https://screenshot.googleplex.com/QNbQg9F1bHi Fixed: 1113319 Change-Id: I56deedc2127c5421fcecd85fc862cba38993a763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340502 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795583}
-
ziyangch authored
We need to report the audio render position to the Android system, which is the amount of already played audio frames. Bug: Internal b/162079069 Test: On device. Change-Id: Idb86deccf2e24e7ab1b7864647596bc04a503a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334410Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#795582}
-
Guido Urdaneta authored
WebRtcGetUserMediaBrowserTest.ApplyConstraintsVideoTwoStreams flakes due to crbug.com/1113820 Bug: 1055012 Change-Id: I65017937e76c8547a374e2c588fb3350dcc111ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340918 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#795581}
-
Xinghui Lu authored
Per Android UI guidance, radio buttons should not be used in settings list. To follow the guidance, the "Security" section is renamed to "Safe Browsing" section. The "DNS over HTTPS" preference remains in the "Privacy and security" section. For more details, see: go/ep-clank. To avoid mixing refactoring with functional changes, further renaming will be done in a followup CL. * Changes on the "Privacy and security" section before: http://screen/SoETXTjFKe2 after: http://screen/vH6PVX423xN * Changes on the "Safe Browsing" section(previous "Security" section) before: http://screen/02ZdA6rFHK9 after: http://screen/gusmNtHYgnH Bug: 1097310 Change-Id: Id6de4a38fafad64e4daa39e42f4aa44a28e5ac50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337390Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795580}
-
David Tseng authored
A node can be both a combo box and editable. This is given by the textFieldWithComboBox role. R=anastasi@google.com Bug: 1110157Text Test: place focus over Gmail's compose dialog and the to text field. Verify an EditableTextNode wrapper is created and not a ComboBoxNode. Change-Id: Ia6726a5c3e687b225cd3b20d2e5f69300c1a585c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336957Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795579}
-
Sven Zheng authored
More tests are failing. List is based on union set of several jobs. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/666? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/656? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/642? Bug: 1111979 Change-Id: Id2749cfc298fe98eee90c65a7a15873b06dcaf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341169 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795578}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113700 Change-Id: I2f463115198f538b99dcfdc27df4c99ca01378fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341146Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795577}
-
Chris Lu authored
When attempting to get the source languages to switch to, a crash can occur if the self.newSourceLanguageIndex is -1. In this line of code, it should be self.newTargetLanguageIndex Bug: 1113818 Change-Id: I4260bc32ba620927a60a966ee8b67c4b1586bc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341388 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795576}
-
Dominic Mazzoni authored
Bug: 1111418 Change-Id: I64d56920ebe10412e311e5ca3b4b633b864e5160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340794 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795575}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113831 Change-Id: I8b0c5cf2d29cd5c1396e26f7e4c46ca0ea9bfea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341149 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795574}
-
Travis Skare authored
Bug: 1107466 Change-Id: If904c34d51be80412b3a1d077216f3dffeb1a406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309797 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#795573}
-
spdonghao authored
Bug: 1111388 Change-Id: I9170271535bc110c92994440dbc92cbe3ba0e084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329738Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795572}
-
Dominic Mazzoni authored
When a node's children have changed, accessibility code enqueues information about that in order to examine the accessibility tree after layout is clean. However, under some circumstances that led to enqueuing the same node over and over again. Fix that by adding a set to keep track of nodes already in the queue. This patch also adds tracing for AXObjectCacheImpl::ProcessDeferredAccessibilityEvents and adds a new perf test to track this optimization. I'm seeing a ~20x speedup. Bug: 1107988 Change-Id: I1263c5139991287a35b89c9c0e6e021f07628c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340384 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795571}
-
Etienne Bergeron authored
The rounding APIs on a Range are not used anymore. We fixed the use cases where the call to Round was incorrect. Typically, the code was looking for an "enclosing-range" or and "enclosed-range". It is preferable to remove the API since it's misleading the devs. R=rsesek@chromium.org Bug: 1111044 Change-Id: I7f11c9c28c2a5c93d3fe8cfcbd38a6b077e90105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339713Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795570}
-
Kevin Ellis authored
CompositorAnimations::ConvertTimingForCompositor does not take the play direction into account when adjusting the time offset for the start delay. Note that a similar trick might work for end delays; however, deferring to a separate CL given the comment: // FIXME: Compositor does not know anything about endDelay. which suggests that other CC changes may be required to accommodate end delays properly. Difference between composited and main thread animation can be observed in the following CodePen without the patch. https://codepen.io/kevers-google/pen/NWNPGRg Bug: 1095813 Change-Id: I3d5d09618f6e58795bc527c18bc6deabe9abed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339712Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795569}
-
Reilly Grant authored
This test appears to time out flakily. TBR=ftirelo@chromium.org Bug: 1113802 Change-Id: Id6280cac06c7deed2b8c2c7ae7c1a524e6246ded No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340277Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795568}
-
Amy Huang authored
The default upstream was recently set to ON, which broke the linux_upload_clang bot because its binutils is older than 2.26. Bug: 1113475 Change-Id: Ifcce2f9ab6181e45fe89182dca45dac3b5b10c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341369Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Amy Huang <akhuang@google.com> Cr-Commit-Position: refs/heads/master@{#795567}
-
Keren Zhu authored
Also make the constructor interface of MenuButton consistent with LabelButton. This CL is part of the effort to make Views default constructible, allowing UI to be built in a declarative fashion. Bug: 1108460 Change-Id: Ib46d0491d85bbd068c1a82a4d4dc3aaf47e63972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339586Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795566}
-
K. Moon authored
Creates a skeletal blink::WebPlugin counterpart to the Pepper-based OutOfProcessInstance. This will support migrating the PDF viewer from a Pepper plugin to a plain Blink plugin. Note that the ultimate intent is _not_ to run the PDF viewer as a plain Blink plugin, without other changes to isolate it. This is just a starting point for the final implementation. Bug: 1085334 Change-Id: I6bea3ddd7fc1b27879af5cd5614071cb02491d77 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328030Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795565}
-
Mansi Awasthi authored
This CL sets the ax::mojom::NameFrom property for static text nodes and inline text nodes in PdfAccessibilityTree. This property is used by AXNode::GetInnerText() to compute the inner text of the nodes. This CL also includes the relevant tests to validate the change. Bug: 1112890 Change-Id: I782ceb4d93a07146a81b1d23ff9696af3267d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337195 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795564}
-
Fabio Tirelo authored
This reverts commit 1f9a9579. Reason for revert: Can't generate build files on mac-arm64-rel Bug: 1113849 Original change's description: > Infra: Rename mac-arm64 builder to mac-arm64-rel > > Bug: 1106950 > Change-Id: Ie1c1fac0955afe6908335d2360a07954c718c25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337103 > Commit-Queue: Gary Tong <gatong@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795517} TBR=gbeaty@chromium.org,gatong@chromium.org Change-Id: I4c0fca2e541852704f57c843bfb14f874ddffcc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341810Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795563}
-
Xianzhu Wang authored
This is similar to what we do in local_frame_view.cc when traversing GraphicsLayers. The null paint state may be caused by throttling or display lock. Will follow up with a more complete solution. Bug: 1110232 Change-Id: Idce2c3e2ff80932dd6d0b68db52fa33e2fb8973c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341251 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795562}
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1113751 Change-Id: Ie7c04ab7b23b18ed6d980ed4b78fb6a756c59774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341402Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795561}
-
Tomasz Wiszkowski authored
The previous change was reverted because the newly introduced focus_resulted_in_navigation_ member caused MSAN failures as in some test scenarios the value would end up being uninitialized. The value is now default-initialized in constructor. This is a reland of 2ce4939f Original change's description: > Log abandoned omnibox interactions. > > Introduces new metric recording outcome of every Omnibox focus event. > Logged result will allow us to monitor for increase in abandoned > interactions as we introduce new suggestion types. > > Bug: 1105156 > Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878 > Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795155} Bug: 1105156 Change-Id: I67231a7c653617f3f197b66bf9c25a0183710fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340411Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#795560}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1362c1eac458..70df33d24eb1 2020-08-06 herb@google.com use a single point as DirectMaskSubRun's vertex data 2020-08-06 robertphillips@google.com Begin wrapping GrSmallPathRenderer atlas accesses 2020-08-06 jvanverth@google.com Reland "Switch GN defs on Mac and iOS to use frameworks, take 2." 2020-08-06 mtklein@google.com add SkGraphics::AllowJIT() 2020-08-06 adlai@google.com Migrate SkImage::MakeFromTexture to GrRecordingContext 2020-08-06 adlai@google.com Migrate MakeCrossContextFromPixmap to GrDirectContext 2020-08-06 mtklein@google.com iwyu fixes for VS 16.7's STL 2020-08-06 robertphillips@google.com Pull ShapeData into its own header file and rename to GrSmallPathShapeData 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c873cfde957 to bedac4f06b5c (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1104516 Tbr: herb@google.com Test: Test: Test: CQ Change-Id: If7f3b0c43f46a4f10331a2c490debe9d4f8749a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795559}
-
Yuta Hijikata authored
setproctitle sets argv[0] to space delimited string which causes program_invocation_short_name to include all the switches until NULL delimiter. This prevents such breakage by making program_invocation_short_name point to a copy of the program name. BUG=chromium:1110865 TEST=content_unittests Change-Id: Iece5fa626e027a0145e7321cdbbda915f73b6c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326511 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#795558}
-
Fabio Tirelo authored
TBR=tkent@chromium.org Bug: 1113791 Change-Id: I4adf0f4a0411cbba1ce414337b3c71340fd5039a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339231Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795557}
-
Yue Zhang authored
Similar to http://crrev.com/c/2328038, this CL moves more things that should happen after native is ready to appropriate places. This CL fixes the drag-and-drop misbehavior when instant start is on. Bug: 1111122 Change-Id: I84cfc6d7dc04d392f3af6d115e3b2a79fb6c3f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326858 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795556}
-
Etienne Bergeron authored
These traces events are causing issue with tracing. 1) The initial version of trace events were crashing chrome on Shutdown since tracing is using a TLS boolean to check re-entrancy. The TLS was not longer there and can't be re-created during shutdown. 2) The current version of trace events are causing a Locking issue and can deadlock. Let revert these events until we figure out what is happening. Bug: 1112636, 1111492 Change-Id: I5bd058f37203fdbb7fd4a8aa1e3424278397026d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341165 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#795555}
-
Xing Liu authored
The infobar currently show a time when download is scheduled on the same day. It needs another string since many languages need different translations between date and time. Bug: b/160265853 Change-Id: I1572c1be5065a983a5ba0534c1414d78d5e6ddde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327750Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795554}
-
Haiyang Pan authored
From the monitoring data, the pool is capable for higher traffic. Bug: 997376 Change-Id: I557a7de4b7eed461b31941661c56265004263cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340187 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#795553}
-
Ryan Hansberry authored
Partially implement a concrete location::nearby::api::BluetoothAdapter, using the shared bluetooth::mojom::Adapter reference in Chrome's Nearby Connections. Only implement the methods on BluetoothAdapter which are required to act as a 'Sender' device (discovery and connection initiation), and basic methods like GetName(). A subsequent CL will finish this implementation; more methods need to be made available on bluetooth::mojom::Adapter first. api::BluetoothAdapter is a synchronous interface, so this CL converts the bluetooth::mojom::Adapter::GetInfo() method it consumes to [Sync]. Please see design doc go/nearby-chrome-bt for more details. Bug: b:154849033, b:158848873 Change-Id: Ia787f2890c42629a78c5d6e5caac6a73f9784a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313998 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#795552}
-
Jeremy Roman authored
This is slightly more efficient (it doesn't require us to deduce at runtime that this always erases to the container end and thus no relocation after remove_if is necessary), but more to the point it's the standard idiom for using std::remove_if with a WTF::Vector seen elsewhere, so it's a little quicker to scan. Change-Id: Icb6957d32923f334a5fda5b6d7e017fa8e9ac5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340662 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795551}
-
Daniel Rubery authored
This CL removes credentials from the IncidentReportingService, and starts using the Browser-wide URLLoaderFactory, since we don't attach cookies. This allows for the SafeBrowsing URLLoader to become profile-keyed in the future. Bug: 1049833 Change-Id: I59d097d80aaf90c22b80928d7f9c8fce1209478b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337292Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#795550}
-
Connie Wan authored
Followup to crrev.com/c/2326632 and some comments there. For the Tab Groups Extensions API, it's useful to be able to query all browsers for the one containing a TabGroupId, without needing to know the profile up-front. There are separate checks for ensuring that a group doesn't move across profiles. This is still assuming it's unlikely for group IDs to clash across profiles. If there's a better way to approach this I'm happy to adjust! Bug: 1098439 Change-Id: I71bd07f5d00fad74ee5aa02d1a62feb4883e3819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339341 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#795549}
-
Anna Malova authored
Following the comments from crrev.com/c/2310800. Bug: 1085115 Change-Id: I2985b8a8f912009524edbcbb4286687ec6a5c0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339668Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#795548}
-
Roman Sorokin authored
Bug: 866790 Change-Id: I8f9f3c567717f36e91f8a8f12b42124f4114ed03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340913 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795547}
-
Darin Fisher authored
Bug: 1111856 Change-Id: I3b201ae3900980f52849d0dafc4632c5c16bce5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337513Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795546}
-