GitLab

<https://bugs.webkit.org/show_bug.cgi?id=25229>

Reviewed by Gavin Barraclough.

Implement Array.reduceRight


git-svn-id: svn://svn.chromium.org/blink/trunk@42570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.
        
        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
        a page with breakpoints set
        
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::clearJSFunctionInline):
        (WebCore::JSEventListener::markJSFunction):
        * bindings/js/JSEventListener.h: Actually clear our function and global
        object pointers when our client instructs us to. (Oops!) Also, mark
        our global object while we still intend to use it.

        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::mark):
        (WebCore::toJS):
        * bindings/scripts/CodeGeneratorJS.pm:
        * svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure
        that the corresponding element also has a wrapper, to keep its event
        listeners alive.



git-svn-id: svn://svn.chromium.org/blink/trunk@42569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25201
        Add ScriptFunctionCall/ScriptObject for V8.

        * bindings/v8/ScriptFunctionCall.cpp: Added.
        * bindings/v8/ScriptFunctionCall.h: Added.
        * bindings/v8/ScriptObject.cpp: Added.
        * bindings/v8/ScriptObject.h: Added.
        * bindings/v8/ScriptObjectQuarantine.cpp: Added.
        * bindings/v8/ScriptObjectQuarantine.h: Added.
        * bindings/v8/ScriptScope.cpp: Added.
        * bindings/v8/ScriptScope.h: Added.
        * bindings/v8/ScriptState.h:
        (WebCore::ScriptState::ScriptState): Added new constructors.
        (WebCore::ScriptState::frame): Added Frame ptr accessor.
        * bindings/v8/ScriptString.h:
        (WebCore::ScriptString::ScriptString): Added default constructor.
        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::isEqual): Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<https://bugs.webkit.org/show_bug.cgi?id=25227>

Reviewed by Gavin Barraclough.

We correct this simply by making the fast array path fall back on the slow path if
we ever discover the fast access is unsafe.


git-svn-id: svn://svn.chromium.org/blink/trunk@42567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@42566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (sharedCFURLCache):



git-svn-id: svn://svn.chromium.org/blink/trunk@42565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (sharedCFURLCache):
        (main):



git-svn-id: svn://svn.chromium.org/blink/trunk@42564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<https://bugs.webkit.org/show_bug.cgi?id=25159>

Reviewed by Gavin Barraclough

Implement Array.prototype.reduce


git-svn-id: svn://svn.chromium.org/blink/trunk@42563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Implement support for wxWebViewNewWindowEvent.
        
https://bugs.webkit.org/show_bug.cgi?id=19043


git-svn-id: svn://svn.chromium.org/blink/trunk@42562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
        https://bugs.webkit.org/show_bug.cgi?id=25221

        RenderSVGModelObject is the base rendering class for things which live
        in the SVG rendering tree.  Not all SVG renders are RenderSVGModelObjects yet.

        More patches coming.  This is just adding the class, future patches
        will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.

        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp: Added.
        (WebCore::RenderSVGModelObject::RenderSVGModelObject):
        * rendering/RenderSVGModelObject.h: Added.
        (WebCore::RenderSVGModelObject::requiresLayer):
        * rendering/RenderTreeAsText.cpp:
        * rendering/SVGRenderTreeAsText.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed an expected result and added a test to the Skipped list while I investigate why its expected results didn't change.



git-svn-id: svn://svn.chromium.org/blink/trunk@42560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        * platform/network/ResourceRequestBase.cpp:
        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::initializeMaximumHTTPConnectionCountPerHost):



git-svn-id: svn://svn.chromium.org/blink/trunk@42559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Changes needed for <rdar://problem/6785760>

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:



git-svn-id: svn://svn.chromium.org/blink/trunk@42558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe.

        Add special casing to bindings generator so that custom functions
        starting with xml or xslt conform to WebKit style guidelines.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::xmlHttpRequest):
        (WebCore::JSDOMWindow::xsltProcessor):
        * bindings/scripts/CodeGenerator.pm:



git-svn-id: svn://svn.chromium.org/blink/trunk@42557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
        not Mac)
        <https://bugs.webkit.org/show_bug.cgi?id=25160>

        * Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-2.js (who
        didn't see it coming?).

git-svn-id: svn://svn.chromium.org/blink/trunk@42556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Remove more dead code from RenderSVGHiddenContainer.

        lineHeight and baselinePosition used to be on RenderSVGContainer
        (of which this is a subclass) because RenderSVGContainer used
        to be a RenderBox and always the renderer for <svg>
        Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
        and RenderSVGViewportContainer (when inside SVG content)
        so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.

        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Remove unneeded (broken) code from SVG renderers
        https://bugs.webkit.org/show_bug.cgi?id=25214

        Mostly due to my historical confusions about the render tree
        and some methods not being removed after classes were split.

        RenderSVGRoot is an RenderBox and should just use all the
        standard RenderBox methods for inspector and repaint rects.

        RenderSVGContainer is *not* a RenderBox (any more) and thus
        doesn't need lineHeight or width/height or calcBounds.

        RenderSVGViewportContainer had some broken code which tried
        to see if the click was inside the container at all, but it
        was using width/height metrics based off of the containing
        block (from calcWidth) which is wrong (since its real
        width/height are from its containing viewport not containing block).

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGRoot.cpp:
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::layout):
        (WebCore::RenderSVGViewportContainer::nodeAtPoint):

git-svn-id: svn://svn.chromium.org/blink/trunk@42554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated expected result for a text dragging test that pastes text on Windows but not on Mac (which is expected).



git-svn-id: svn://svn.chromium.org/blink/trunk@42553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=25217
        Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
        Add ASSERT(element) to all these functions since they should never be passed a null element.

        * svg/SVGLocatable.cpp:
        (WebCore::isViewportElement):
        (WebCore::SVGLocatable::nearestViewportElement):
        (WebCore::SVGLocatable::farthestViewportElement):
        (WebCore::SVGLocatable::getBBox):
        (WebCore::SVGLocatable::getCTM):
        (WebCore::SVGLocatable::getScreenCTM):

git-svn-id: svn://svn.chromium.org/blink/trunk@42552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Anders Carlsson.

        Remove support for the ObjCIvar extended attribute from the Objective-C
        bindings generator.  It is not used anymore.

        * bindings/scripts/CodeGeneratorObjC.pm:



git-svn-id: svn://svn.chromium.org/blink/trunk@42551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Fix incorrect expected result.

        * http/tests/security/local-video-source-from-remote-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@42550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25204
        Create a fast path for ReplaceSelectionCommand that merges text nodes
        
        During simple pastes, where we're just pasting a text node into a run of text, we would split the current
        text and insert the new node in between.  This is slow and we hit this bug:

        https://bugs.webkit.org/show_bug.cgi?id=6148

        in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
        
        This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
        text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::performTrivialReplace):
        * editing/ReplaceSelectionCommand.h:
        * editing/TextIterator.cpp:

LayoutTests:

2009-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.
        
        https://bugs.webkit.org/show_bug.cgi?id=25204
        Create a fast path for ReplaceSelectionCommand that merges text nodes
        
        Simplified DOM/Render trees:
        * editing/pasteboard/4840662-expected.txt:
        * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
        * platform/mac/editing/pasteboard/paste-xml-expected.txt:

        Removed redundant styles that were generated during nesting prevention that is no longer needed:
        * platform/mac/editing/pasteboard/4076267-2-expected.txt:
        * platform/mac/editing/pasteboard/5156401-1-expected.txt:
        
        No longer incorrectly uncollapsing unrendered whitespace:
        * editing/pasteboard/paste-into-anchor-text-expected.txt:
        * platform/mac/editing/pasteboard/5387578-expected.txt:
        
        No longer invalidating the old selected DOM range during a paste:
        * editing/pasteboard/copy-in-password-field-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        Move VDMX parsing into the Chromium Linux port.

        https://bugs.webkit.org/show_bug.cgi?id=25116

        VDMX tables are optional tables in TrueType fonts which contain the
        exact pixel height of a given font at a given pel size. In order to
        match Windows font metrics we have to use these numbers.

        Previously, the parsing was performed in Skia. As part of the merge
        with upstream Skia, an interface for getting table data from a font
        has been added to Skia and we're moving the parsing into WebKit.

        This does not change any layout tests.

        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::uniqueID):
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        * platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
        * platform/graphics/chromium/FontTrueTypeLinux.h: Added.
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):



git-svn-id: svn://svn.chromium.org/blink/trunk@42548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25180

        Restore stroked outlines to PlatformContextSkia::drawRect().
        These were removed inadvertently in r41805, aka
        https://bugs.webkit.org/show_bug.cgi?id=24662.
        SkRect is { left, top, right, bottom }, not { left, top, width, height }.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::drawRect):



git-svn-id: svn://svn.chromium.org/blink/trunk@42547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6777374> Generated content with display: run-in
          causes a crash

        Test: fast/runin/generated.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is
        generated, and if so, make the RenderInline anonymous instead of passing
        a 0 node to the RenderInline constructor. If the run-in itself is
        generated, do move :before and :after children from the block into the
        inline, as they will not be regenerated. Changed nested ifs into early
        returns.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/6777374> Generated content with display:
          run-in causes a crash

        * fast/runin/generated.html: Added.
        * platform/mac/fast/runin/generated-expected.checksum: Added.
        * platform/mac/fast/runin/generated-expected.png: Added.
        * platform/mac/fast/runin/generated-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=25192

        Expose DOMWindow::removeInlineEventListenerForType and
        DOMWindow::inlineEventListenerForType as public.

        * page/DOMWindow.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25198

        Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
        in a USE(JSC), since it doesn't compile with V8 bindings.

        * dom/RegisteredEventListener.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        Use a media file inside of LayoutTests/http/ so a cgi isn't necessary to load 
        it. Fixes a test failure introduced in r42533.

        * http/tests/resources/silence.mpg: Added.
        * http/tests/security/local-video-source-from-remote-expected.txt:
        * http/tests/security/local-video-source-from-remote.html: change the
        remote url, update a comment.
        * http/tests/security/resources/load-media.cgi: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@42543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25194

        Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
        use the new name.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@42542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=25186
        There is no XSLT component in bugzilla

        * projects/xslt/index.html: Changed to search by bug title.



git-svn-id: svn://svn.chromium.org/blink/trunk@42541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ariya Hidayat.

        Rename extend() method in QWebElementSelection to append().

        * Api/qwebelement.cpp:
        (QWebElementSelection::append):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::appendSelection):

git-svn-id: svn://svn.chromium.org/blink/trunk@42540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Hausmann.

        Fixed nit/typo in QWebElement documentation.

git-svn-id: svn://svn.chromium.org/blink/trunk@42539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by NOBODY(Build fix)


git-svn-id: svn://svn.chromium.org/blink/trunk@42538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Cameron Zwarich

Add the concept of a CachedCall to native code for use in Array
prototype and similar functions where a single callback function
is called repeatedly with the same number of arguments.

Used Array.prototype.filter as the test function and got a 50% win
over a naive non-caching specialised version.  This makes the native
implementation of Array.prototype.filter faster than the JS one once
more.


git-svn-id: svn://svn.chromium.org/blink/trunk@42537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Don't keep platform objects for authentication challenge in ResourceHandleInternal.
        We already have a copy in AuthenticationChallenge object.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::clearAuthentication):
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):



git-svn-id: svn://svn.chromium.org/blink/trunk@42536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=25157

        Move the run loop observer cleanup from -close
        to -_close.

        * WebView/WebView.mm:
        (-[WebView _close]):
        (-[WebView close]):

git-svn-id: svn://svn.chromium.org/blink/trunk@42535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        Nixed some now-defunct autogeneration code.

        * bindings/scripts/CodeGeneratorJS.pm:



git-svn-id: svn://svn.chromium.org/blink/trunk@42534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by NOBODY (OOPS!).
        
        Fix <rdar://problem/6755724> <audio> and <video> elements can reference local 
        file:/// URLs from remote in Safari

        Tests: http/tests/security/local-video-poster-from-remote.html
               http/tests/security/local-video-source-from-remote.html
               http/tests/security/local-video-src-from-remote.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine if loader->canLoad()
        says it should not be loaded.

2009-04-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by NOBODY (OOPS!).

        Fix <rdar://problem/6755724> <audio> and <video> elements can reference local 
        file:/// URLs from remote in Safari

        Test cases to ensure that local 'src', 'poster', and <source> are not loaded.

        * http/tests/security/local-video-poster-from-remote-expected.txt: Added.
        * http/tests/security/local-video-poster-from-remote.html: Added.
        * http/tests/security/local-video-source-from-remote-expected.txt: Added.
        * http/tests/security/local-video-source-from-remote.html: Added.
        * http/tests/security/local-video-src-from-remote-expected.txt: Added.
        * http/tests/security/local-video-src-from-remote.html: Added.
        * http/tests/security/resources/load-media.cgi: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Part of <rdar://problem/6150868>
        Fix incorrect handling of content that needs to go into the head element
        once the head element has been removed.

        Test: fast/parser/head-content-after-head-removal.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head.
        (WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr.
        (WebCore::HTMLParser::createHead): Ditto.
        * html/HTMLParser.h: Make m_head a RefPtr.

LayoutTests:

2009-04-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Part of <rdar://problem/6150868>
        Test for incorrect handling of content that needs to go into the head element
        once the head element has been removed.

        * fast/parser/head-content-after-head-removal-expected.txt: Added.
        * fast/parser/head-content-after-head-removal.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Used svn merge -r42529:42528 to roll out my last patch because it broke
        the build.

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
        (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
        (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
        (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
        * bindings/js/JSDOMGlobalObject.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42531 bbb929c8-8fbe-4397-9dbb-9b2b20218538