- 10 Jan, 2020 40 commits
-
-
manukh authored
*The issue* When the input contains symbols not adjacent to alphanumeric characters, the HistoryQuick provider returns no suggestions. E.g., as the user types the input 'george washington - wikipedia', the corresponding HistoryQuick suggestion for 'en.wikipedia.org/wiki/George_Washington' will disappear once the user types the '-'. *Why the issue occurred* The history quick provider splits the user input into terms by whitespace and identifies word start offsets for each term. E.g., the input 'george washington - .wikipedia' is split into 4 terms: 1) 'george' with word start offset 0, 2) 'washington' with word start offset 0, 3) '-' with word start offset 1, and 4) '.wikipedia' with word start offset 1 When scoring, it ensures each term is present in either the suggestion title or URL beginning at a word break (with some exceptions) accounting for word start offsets. E.g, given the suggestion title: 'George Washington - wikipedia .someText' ^ ^ ^ ^ 0 7 20 31 Then the terms 'wiki', 'some', and '.some' will all match the title; but neither '.wiki' nor 'text' will match. The previous implementation accounts for word start offsets by checking if the sum of the match index and word start offset is a word start in the suggestion text. E.g., the input '.some' will match at index 30 and has word start offset 1, summing to 31 which is a word start. An unintended side affect of the previous implementation was that terms containing no words, (e.g. '-') would be incorrectly classified as matching at a non-word-start, and would therefore disqualify the suggestion. E.g, the input '-' will match at index 18 and has a word start offset of 1, summing to 19, which is not a word start. *The fix* We can't simply ignore such terms, since then inputs such as 'george ----' would match. This CL adds an explicit allowance for terms containing no words to match at non word starts. Bug: 1003010 Change-Id: Id8f755cf0fb4f5536ec21f23bcd79994b9011642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990449 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730172}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: I8ad4f0f0c0765a53f5ff618842c147da9284d70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993902Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#730171}
-
Colin Blundell authored
This CL integrates a check for whether to display the bad clock interstitial into WebLayer's SSLErrorHandler. The check is modeled on that in //chrome's SSLErrorHandler. However, we did not port the fetch of NetworkTimeTracker's time into //weblayer: this fetch introduces a fair degree of complexity into the flow by making it asynchronous, and it is not relevant on Android, where such fetches are not supported. This fetch will be incorporated when WebLayer shares //chrome's SSLErrorHandler implementation as part of crbug.com/1026547. Just like in Chrome, the bad clock interstitial is shown when there is an expired certificate and the network time is reported as being ahead or behind of the actual time. The network time is not always seeded, in which case the application defaults to showing the generic SSL interstitial. In particular, for Chrome on Android the network time is seeded either via sync or via the Variations Service. The latter will apply in WebLayer once variations is integrated. This CL adds a browsertest of the relevant functionality; the browsertest is adapted from one in //chrome and manually sets the network time in order to trigger the bad clock interstitial showing. (I did a similar exercise in the shell locally on Android and Linux to verify the showing of the interstitial). Note that opening the date/time from the interstitial is not yet supported; a followup CL will bring up that support by sharing the relevant implementation from //chrome. Change-Id: I176a342c5de328441d26a22f28742dba6793a1ed Bug: 1025059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983170 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#730170}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e6441b604f58..5fc2c82c11e0 git log e6441b604f58..5fc2c82c11e0 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 cwallez@chromium.org Add Instance and CreateInstance to webgpu.h Created with: gclient setdep -r src/third_party/dawn@5fc2c82c11e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I972527c3f14b2ac557bd50cba7f11f8c9670fd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730169}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e195519d..a19e6092 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id7345200bd931424f19ee808ed2fd79d6310ef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995207Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730168}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f9f51f7a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iacad3ed2778e2c8f9f6bad3f25f695f41f3ea3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993764Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730167}
-
Oleh Lamzin authored
Change wilco dtc supportd host origin extension id to the new one. BUG=b:147478977 TEST=none Change-Id: Id529c232f3ac86fb31231d36bafd73eb871a5a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993814Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#730166}
-
sandromaggi authored
Previously the source for contacts and shipping addresses was the same sorted list of profiles. There may be cases where we want to sort them differently, which is enabled by splitting the list in two. This CL also moves the transformation logic from CreditCard / Profile to their destination objects (AutofillContact, AutofillAddress, AutofillPaymentInstrument) from the DataBinder to native/model directly. Bug: b/144005336 Change-Id: I644d4b52f962582a87b8aabce5e55066e3356481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992082 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#730165}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 546640 Change-Id: I8ea59ea0816ab8f2cee1eb5a377d8b16ce41a220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991757 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730164}
-
Luke Zielinski authored
Stop setting flag --no-fail-on-unexpected, which causes wptrunner to always exit with code 0. Omitting this flag makes the exit code equal the number of failed tests. The CQ needs the exit code in order to determine which shards to retry. Bug: 937369 Change-Id: I150321a7783948724be0d622646108e5df6249eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992911Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730163}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/033f08c5a865..7ba39a0c2e40 git log 033f08c5a865..7ba39a0c2e40 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 eseckler@google.com Merge "gen_merged_protos: Fix return value calculation" Created with: gclient setdep -r src/third_party/perfetto@7ba39a0c2e40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib7df1b00628657297ce3f9a175a59039ecfc2917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730162}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/56452dd17bac..6ddbe2c5b003 git log 56452dd17bac..6ddbe2c5b003 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 phoglund@webrtc.org Extract results line plotting. Created with: gclient setdep -r src/third_party/webrtc@6ddbe2c5b003 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide84015bf4518132b302c5fbd61aaf9cd4e10207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730161}
-
Vasilii Sukhanov authored
This reverts commit 4a58461b. Reason for revert: broke compilation on iOS https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8891643701272051152/+/steps/compile/0/stdout Original change's description: > [iOS][multiball] Move AppURLLoadingServiceDelegate to Scene. > > Moves AppURLLoadingServiceDelegate from Main to Scene Controller. > * adds SceneControllerGuts temporary interface to expose scene-level > internals to MainController while the code is moved. > > Bug: None > Change-Id: I0c7dbe077a94ff5b9c598c401c9c7340cc8f969c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983226 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730151} TBR=marq@chromium.org,stkhapugin@chromium.org Change-Id: I65d0afac9c2296574c324784960b36ecb1802b43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995171Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#730160}
-
Yuki Shiino authored
The old bindings generator uses V8StringResource without NativeValueTraits, and existing NativeValueTraits<IDLString> is not as much performative as V8StringResource. This patch introduces NativeValueTraits<IDLStringV2> which uses the same technique as V8StringResource so that the new bindings generator can use NativeValueTraits for all the types without performance regression. Bug: 839389 Change-Id: Ibf7f40ba36d10affdef70d489f0f56a005bf73f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993360 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#730159}
-
Andreas Haas authored
I disabled the ArrayBufferContentsTest.AllocationFail test on ASAN, because ASAN causes a crash when allocation fails. Note that allocation is meant to fail in this test, and we want to check if the implementation can deal with a failed allocation. However, ASAN escalates the failed allocation to a crash. R=haraken@chromium.org, huangs@chromium.org Bug: chromium:1038741 Change-Id: I89c7138eb9b636cfd5ce6eae95bdfcf7dd7871cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985953 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730158}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8f4d89e1e6..ef05f96d6de1 git log 5a8f4d89e1e6..ef05f96d6de1 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 aerotwist@chromium.org Migrates bindings/ to ESM internally Created with: gclient setdep -r src/third_party/devtools-frontend/src@ef05f96d6de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I334cf37c9e63ce581899a0e73ec507fb1724ad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994085Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730157}
-
Anders Hartvoll Ruud authored
BUG=545324 Change-Id: I2ce865bf6c9bb07d258bdc568128341b1d08d9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986798 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#730156}
-
Vasiliy Telezhnikov authored
This CL moves BeginFrame related code to SynchronousCompositorHost from RenderWidgetHostViewAndroid as it was used only for WebView. This is part of ongoing refactoring for viz for WebView. Bug: 805739 Change-Id: I06c264db4fceb8ebee281660f1c771ac45a68b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992250 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#730155}
-
Vasiliy Telezhnikov authored
This CL moves code related to BeginFrames for browser-side fling to RenderWidgetHostViewAndroid. It also removes RenderWidgetHostView::SetNeedsBeginFrames as it's not used anywhere anymore (webview was last usage). This cleans up code after OOP-D launch and also part of viz for webview refactoring. Bug: 812322, 805739 Change-Id: I96d89e77fa9a31e51a87abb8ca203c6dc9265c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992506Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#730154}
-
Robbie Gibson authored
This adds a simple UI for text zoom (just the done button). The more important contribution is that now, BVC will check which feature is active, text zoom or find in page, and if something asks it to display the other, it first dismisses the shown one. Bug: 1028938 Change-Id: I576a096a635e0736f70e853f3c78e5459d7f4b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946481 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#730153}
-
Tim van der Lippe authored
It was broken in https://chromium-review.googlesource.com/c/chromium/src/+/1636716 TBR=jalyn@microsoft.com Bug: 963183 Change-Id: I759d3430fdcdf253c59d921902f0c61b6ca17dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993811Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#730152}
-
Stepan Khapugin authored
Moves AppURLLoadingServiceDelegate from Main to Scene Controller. * adds SceneControllerGuts temporary interface to expose scene-level internals to MainController while the code is moved. Bug: None Change-Id: I0c7dbe077a94ff5b9c598c401c9c7340cc8f969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983226 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#730151}
-
Vasilii Sukhanov authored
TBR=nzolghadr@chromium.org TBR=mustaq@chromium.org TBR=input-dev@chromium.org TBR=dom-dev@chromium.org Bug: 1034789 Change-Id: I80123c55571c5ebf98737101f9be2b1f2a84a75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993972Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#730150}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.18-1578307857-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307857-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib734989ad8dfc2fa33ca62a24cbd5b41bf889430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730149}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/079a14224dd1..3f1bd1b88a31 Created with: gclient setdep -r src-internal@3f1bd1b88a31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010717 Tbr: jbudorick@google.com Change-Id: I81b8a6846ce4dd210dd7102ab633c4eee9c8eed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995224Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730148}
-
Mikel Astiz authored
With this patch TrustedVaultClient.Backend has the ability to notify native code that the keys in the vault may have changed. This notification makes its way via TrustedVaultClientAndroid to ultimately SyncServiceCrypto, where refetching logic is triggered. This is expected to be an effective means for resolving encryption issues transparently without user action and without having to restart the browser. The very same method is also used upon relevant user action such as triggering the retrieval flow, in case the keys within the vault have changed since the last fetch (e.g. if the backend failed to or does not support broadcasting change notifications). Bug: 1012659 Change-Id: I985db773fe5b18f107a8c8731d31dbd80aaf599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978005Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730147}
-
Monica Basta authored
This CL adds tests for communicating the sWAA bit in sync setup settings. Bug: 1035421 Change-Id: I40f3c5304b04e433a2cac571a715299459a565c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991624 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#730146}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b6df1777cba..56452dd17bac git log 4b6df1777cba..56452dd17bac --date=short --first-parent --format='%ad %ae %s' 2020-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa827d65..54a7cb4b (729982:730109) Created with: gclient setdep -r src/third_party/webrtc@56452dd17bac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I24e8d14bb2fd1576508df7df884f1fe5b21d613d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730145}
-
Olivier Li authored
Set browser state builder dir to avoid file leaks in ios tests in /ios/chrome/browser/ui/location_bar This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=stkhapugin@chromium.org Bug: 546640 Change-Id: If47000191d0170327c9e74d270c7b6cb0506367a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991752Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730144}
-
Vasilii Sukhanov authored
TBR=foolip@chromium.org Bug: 1040912 Change-Id: Ie273a75c2f6f7efc1f0b17d9f8325eaaa6e8facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994296Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#730143}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/63dded1f4d55..033f08c5a865 git log 63dded1f4d55..033f08c5a865 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 primiano@google.com probes: workaround for missing NUL in /proc/pid/cmdline Created with: gclient setdep -r src/third_party/perfetto@033f08c5a865 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:147438623 Tbr: perfetto-bugs@google.com Change-Id: I8310f1a402b5a8bb0a3d09922a1b42f3301c6e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994083Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730142}
-
Gyuyoung Kim authored
This CL cleans up redundant Create() factory methods in //third_partyb/blink/renderer only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - CSSConicGradientValue::Create - PaymentManager::Create - RTCIceCandidatePlatform::Create Bug: 939691 Change-Id: I17f79f7478aa4491ee1995ac22593142731c0260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994541Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#730141}
-
Corentin Wallez authored
This reverts commit 7cb3f403. Reason for revert: Make TabCaptureApiPixelTest.EndToEndThroughWebRTC fail consistently on Win10 FYI x64 Release (Intel HD 630) Original change's description: > Fix issue where DXGI_FORMAT_R16G16B16A16_FLOAT gets used even when unsupported by hardware > > Issue backtrace: > - video_device_->CreateVideoProcessorOutputView(...) in > DXVAVideoDecodeAccelerator::CopyTextureOnDecoderThread() fails because > DXGI_FORMAT_R16G16B16A16_FLOAT is not supported by client's hardware. > - in DXVAVideoDecodeAccelerator::Initialize, use_fp16_ = true due to > "Issue 592074: Add support for different VP9 profiles". > - DXGI_FORMAT_R16G16B16A16_FLOAT is in fact not supported, and > CheckOutputFormatSupport(DXGI_FORMAT_R16G16B16A16_FLOAT) > DXVAVideoDecodeAccelerator::CreateDX11DevManager() reflects that, > and use_fp16_ = false. > > Proposed fix: > - Make use_fp16_ an enum to reflect the fact that its non-binary states. > - Because intent to use fp16 is expressed in DXVAVideoDecodeAccelerator::Initialize, > which can be called before or after support for fp16 is determined, let use_fp16_ be > set to kUsing for all states except kUnsupported. kUsing can be reversed later > when hardware support is queried. > > Bug: 1032438 > Change-Id: I113f26b126fdc1e0131a2362cbf19629f268f3eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974761 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Commit-Queue: Vi Nguyen <ving@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#730012} TBR=sandersd@chromium.org,liberato@chromium.org,tmathmeyer@chromium.org,ving@microsoft.com Change-Id: I5071f5b78391ba4479d04132402f728799821ffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995167Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#730140}
-
Anatoliy Potapchuk authored
app data Change-Id: I372946839db9523e76c3f1c6c6165087c2e8e4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993822Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#730139}
-
Markus Handell authored
This change fixes a problem where MediaStreamVideoTrack would would CHECK-fail when the source has been cleared or deallocated AND a call to either SetEnabled, AddEncodedSink or RemoveEncodedSink occurs. The change also includes a new unit test for this case which was previously uncovered. Change-Id: Iab02df69277b2d2a287e2505977ce94345afb848 Bug: 1013590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993291Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#730138}
-
Markus Handell authored
This change fixes a crash in RequestRefreshFrame and also a few other potential cases found during code inspection. Bug: 1040626 Change-Id: I1cdeaa76b530b833dbdad8ab239ae66ee08bac60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994287Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#730137}
-
Olya Kalitova authored
Adds failure details in case default Crostini configuration using Ansible has failed. TEST: deployed on DUT and checked that logs are present Bug: 1000287 Change-Id: I4215bb117ed82fe8829ea5375767000645326915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991561Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#730136}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a104a789f873..f6f813d450e5 git log a104a789f873..f6f813d450e5 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 khokhlov@google.com [py_trace_event] Support clock snapshots in proto trace format Created with: gclient setdep -r src/third_party/catapult@f6f813d450e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:990304 Tbr: crouleau@google.com Change-Id: Ie00fda30a7af9b9330a96400879c164e0d846f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730135}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72ee5754..e195519d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c29cdd5bb0f59a1f365f9983832fffda65ec8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993763Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730134}
-
Gauthier Ambard authored
This CL adds the UIAccessibilityTraitNotEnabled to the search engine cells when they are not interactable. Fixed: 1040497 Change-Id: Iec65f625d7bf3d7f738d82ab86b204c3c58a6099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994284 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#730133}
-