GitLab

Portals should not receive input, which includes any child frames of a
portal. This behaviour regresses with VizHitTestSurfaceLayer, so we
include a new test for this. Currently, it only runs for the
VizHitTestSurfaceLayer disabled case until this is fixed.

Bug: 1002228
Change-Id: I2cf81bc62bcddda2eb4fa42f0d24d2d5865ff1b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795494Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695780}

This code was written with the assumption that the key label of the
AuthorizationRequest sent to cryptohome while creating easy unlock keys
be empty, in order to act as a wild card. This CL always passes an empty
an empty key label to that AuthorizationRequest, instead of using the
copied label of the |user_context_|.

Bug: 1002336
Change-Id: Icfccf46ed479a1e7a29e8d09837e1223d62a4caa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797205Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695779}

This change adds logic to check for the device lid state by observing
the lid state switch when DSP is enabled, and stop DSP from recording
when the lid is closed. In this way, the Assistant cannot be waked up
by voice queries when the lid is closed.

Bug: b/139313417
Test: run unittest in this CL.
Change-Id: I1765db4f16e43ac7a5de71acde9dff253be8f363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758991
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695778}

Change UIA LocalizedControlType of <header> from "banner"/"group" to
"header" for all scopes per https://w3c.github.io/html-aam/#el-header
and https://w3c.github.io/html-aam/#el-header-ancestorbody

Change UIA LocalizedControlType of <footer> from "content info"/"group"
to "footer" for all scopes per https://w3c.github.io/html-aam/#el-footer
and https://w3c.github.io/html-aam/#el-footer-ancestorbody

To achieve this, introduce the new ax::mojom::Roles:
kHeader, kHeaderAsNonLandmark, and kFooterAsNonLandmark
(kFooter already exists).  The extra roles are necessary because
the mappings for <header> and <footer> change based on their position
in the document.

kHeader and kFooter are identical to kBanner and kContentInfo
respectively, except for their LocalizedControlTypes.
kHeaderAsNonLandmark and kFooterAsNonLandmark are identical to,
kGenericContainer, again with the exception of LocalizedControlType.

TBR=stevenjb@chromium.org

Bug: 996457
Change-Id: I3f061c8a47c9e04bc22af26b2cda865eef69fc01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763243
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695777}

Change-Id: I2d5ad7fcf8cf9ee45ead9ee4d2e3ba56e93ec387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796644
Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
Auto-Submit: Yue Ru Sun <yrsun@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695776}

Update ScrollElementRegionIntoViewHelper() to look for
kElementClickIntercepted instead of kUnknownError.
Reason was in https://crrev.com/634697 which changed
VerifyElementClickable() function to return
kElementClickIntercepted instead of kUnknownError.

Bug: chromedriver:2856
Change-Id: Ic2eee972663df9163e6fa6c56adcca1512e14efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797706Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695775}

A report may be separated into multiple requests when it's too big.

Bug: 956237
Change-Id: I3c888c8d01d064d247c146079f8d1cfcb7662bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795805Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695774}

DCHECKs crash the running XCTest without producing any useful log
output.  Instead, switch to XCTAssertTrue() so that an error message
will be displayed when bots are misconfigured.

BUG=1002739

Change-Id: If902ea15e2b89090fcd355ad7bfb04828e71561a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799082
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695773}

Also, this CL fixes settings and a typo.

Bug: 994939
Change-Id: Ied967e8a15f6c1a83ca5947d5a569d0c66a8191c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797325Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695772}

This CL fixes an issue with the print dialog scrollbars being unusable
due to hit test failure. In ScrollBegin, when the scroll_node is being
set up, IsInitialScrollHitTestReliable returns false. This leads to
the scroll_node remaining unset and hence scrolling fails.

Bug: 996540
Change-Id: I77c79ff079766b351f1a2068a19b774a98f80b43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764901
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695771}

https://skia.googlesource.com/skia.git/+log/ba36ee78262a..3c70f9acfc33

git log ba36ee78262a..3c70f9acfc33 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 nigeltao@google.com Add a GifTest for the Haeberli hack
2019-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-11 benjaminwagner@google.com Omit benches that time out on Pixel3a

Created with:
  gclient setdep -r src/third_party/skia@3c70f9acfc33

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I6cd515a838d00c7322c72f22548b59d26cf32715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797494Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695770}

https://chromium.googlesource.com/catapult.git/+log/fc09aa89b962..d195c8eb28db

git log fc09aa89b962..d195c8eb28db --date=short --no-merges --format='%ad %ae %s'
2019-09-11 dberris@chromium.org Pinpoint: Always send email on issue updates

Created with:
  gclient setdep -r src/third_party/catapult@d195c8eb28db

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: None
Change-Id: I50f8d440cfa30f62938f08a4dc811e6c294e4449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799027Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695769}

This reverts commit b6532ab4.

Reason for revert: likely caused CI test failures. crbug.com/1001970

Original change's description:
> Reland "Enable flag TabToGTSAnimation by default"
> 
> This is a reland of a90f0d96
> 
> Original change's description:
> > Enable flag TabToGTSAnimation by default
> >
> > Also update the default parameter of zooming-min-sdk-version to M.
> >
> > TBR=twellington@chromium.org
> >
> > Bug: 964406
> > Change-Id: I3a23e20511f9ecb48ed70fd6952f36b06191817c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743106
> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Reviewed-by: Matthew Jones <mdjones@chromium.org>
> > Reviewed-by: Mei Liang <meiliang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689627}
> 
> TBR=mdjones@chromium.org
> 
> Bug: 964406, 997065
> Change-Id: Iff003fda8274e0715b3e9ab492286218b649cdbf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767611
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694616}

TBR=mdjones@chromium.org,wychen@chromium.org,meiliang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 964406, 1001970
Change-Id: I962deeba786428a6bd0ec82d063f5163d1aa1e8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797094Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695768}

Move Fuchsia CDM codes (CDM and Decryptor) into //media:
1. Create new interface FuchsiaCdmProvider, which handles
fuchsia::media::drm::ContentDecryptionModule request. This is to remove
mojo dependency from media. MojoFuchsiaCdmProvider wraps the mojo
interface FuchsiaCdmProvider.
2. Move media/filters/fuchsia/stream_processor_helper*|sysmem_buffer_*
into media/fuchsia/common, so that they can be shared by
media/fuchsia/cdm and media/filters/fuchsia.
3. media/fuchsia/cdm becomes a submodule of media.
4. media/cdm is visible to media/fuchsia/cdm, for AesDecryptor.

Bug: 966191
Test: Component build.
Change-Id: I8ebbd5f33080a3ced4a91b85262af8f1e7df0ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790739Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695767}

* Implement handling of the
  chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner.
* Remove handling of the fuchsia.web.AdditionalHeadersProvider API in
  CastRunner as it is deprecated.
* Adapt the integration test to use the new API.

Bug: 976975
Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695766}

The reset occurred under the previous assumption that the toolbar
heights only change for navigation to/from the NTP, where the primary
toolbar height is 0.0.  This assumption is incorrect because the heights
can also be updated due to trait collection changes.  The navigation
case for NTP is already handled by FullscreenWebStateObserver::
DidFinishNavigation(), so removing the calls to ResetForNavigation()
does not break that case.

Bug: 896675
Change-Id: I2fd1b101f3057e6f3f3bb61802fc1683a1ab0862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1328234
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695765}

This change fixes an infinite loop in `OneShotAccessibilityTreeSearch`.
If the search starts at the root of a tree, goes backwards, and wraps
around to the last node, it will loop forever in `SearchByWalkingTree`.

The problem is that `stop_node` is set to NULL, so it is never matched.

The fix is to ensure that stop_node gets set to the root element (i.e.,
the start_node) so that we don't loop through the tree more than once.

Bug: 1001200
Change-Id: I67d8abd5e6044b2a125a633d39c7581e45cc7411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790255Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695764}

The shortcut handler is already executed when application becomes
active.
Executing it in performActionForShortcutItem will result in two
execution which can cause issues (e.g. if action is to trigger camera).

Bug: 1000940
Change-Id: Id89a1c1c88fc9594599772cb0170c7c6e08deded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789523Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695763}

This reordering allows us to issue SwapBuffers a little bit sooner
by moving DDL destructor after.

Bug: 974359
Change-Id: Iba9a81815cf1166d3d31bd9312adc8e0834bf512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797175Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695762}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/dom_distiller.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=bengr@chromium.org

Bug: 891670
Change-Id: Id769068426f8af6e23a32f62202883e3a2a8789e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787106
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695761}

We currently have no way of tracking usage of this tool. Tagging the
builds created by it should allow us to do some basic estimation of
usage numbers.

Change-Id: Ie73a2a8019a5eb79a9b7f4e0f004b81f05251f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797699Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695760}

This CL adds implementation to CreateSharedImage overload with
|pixel_data| to SharedImageBackingFactoryAHB.

Bug: 1002057
Change-Id: I246284c6df5f75c25bbedd69658d4fdfaac0f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792579
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695759}

This reverts commit 250c173e.

Reason for revert: <reverting did not fix crbug.com/999467>

Original change's description:
> Revert "Migrate pinned icons in ImplicitApp subdirs."
> 
> This reverts commit 4105186f.
> 
> Reason for revert: <crbug.com/999467>
> 
> Original change's description:
> > Migrate pinned icons in ImplicitApp subdirs.
> >
> > Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the
> > subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why
> > Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories,
> > but we should handle them.
> >
> > Bug: 980239
> > Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb
> > TBR:
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722
> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#681035}
> 
> TBR=msarda@chromium.org,grt@chromium.org,davidbienvenu@chromium.org
> 
> Bug: 980239
> Change-Id: I2b19e825ccd0f1bd2975678d9acb1ad7ff90cc6a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787560
> Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693898}

TBR=davidbienvenu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 980239
Change-Id: Ibe0af2947a119bdccea80067fe86f0d1d5bb7af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797692Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695758}

https://swiftshader.googlesource.com/SwiftShader.git/+log/5f1b4c0ba92e..5a5ffe52a944

git log 5f1b4c0ba92e..5a5ffe52a944 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 capn@google.com Update link to dEQP repository
2019-09-11 capn@google.com Fix OpenGL/EGL entry function calling convention

Created with:
  gclient setdep -r src/third_party/swiftshader@5a5ffe52a944

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/137875321,chromium:b/140700303
Change-Id: Idfa6f95ef7341f1b02c7ee017af3f904bf385df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695757}

Bug: 988538
Change-Id: I8f85d926afe39c75a8a34449a1fa8f57f52ff245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732895Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695756}

Writes of large blocks of memory can cause kernel address-space pressure
which can be fatal on 32-bit Windows. Yes, we still have some customers
using 32-bit Windows.

This change updates PEResource::WriteToDisk to write a maximum of 8 MiB
at a time. This should not affect performance and will avoid failures.

This change also updates the mini_installer copy of this file to use
nullptr for consistency.

Bug: 1001022
Change-Id: Icca3122a7decc7ce6ce89cc742c988d68737ff28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793531
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695755}

This CL wraps a inner class in NotificationSceduler class to track all
notification display flow, and invoke the TaskFinishCallback when
all display flows are finished.

Also, fixed an issue that InitHelper should be owned by
NotificationScheduler or we may use invalid pointer when the service
is destroyed.

Bug: 998980
Change-Id: I5d3dfa488eaeaf8b99649987c4982ddb279a4504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791274Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695754}

e3bf3a5fde91 Roll crashpad/third_party/mini_chromium/mini_chromium/
             588976752..660b43a77 (2 commits)
9a6234461201 [Log minidump] OutputStream interface and zlib
             implementation
9b314d5fa819 cros: Pass a dir for minidumps to crash_reporter
fc44a3747cf5 linux: Allow configuring unhandled signals
abeccef1efdb [fuchsia] fix
             crashpad_use_boringssl_for_http_transport_socket path
06fdbdecdc5d android, chromeos: fix build breakages

Change-Id: I16d519153599cbf960a0171957cdf58be1c37713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797705
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695753}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/spellcheck.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=groby@chromium.org

Bug: 891670
Change-Id: I49d8195a5ecb42ceacf78c3721550747cd501486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786946
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Rachel Blum <groby@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695752}

This adds support for reporting 3 new page load metrics
(largest contentful paint, first input delay, and
cumulative layout shift) to embedders on Android.

Change-Id: I3e49c4ca8cddbc6471d215cb8fc17a6a2ebcc5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785882Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695751}

Change-Id: I325e45c4a6131b09d04ec14836cf7290ad329fc5
Bug: 856777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793982
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695750}

This change adds the interface definition for a Touch To Fill View which
will is intended to be implemented on Android in a follow-up CL.

Bug: 957532
Change-Id: I819e8178db21c32d577560da82c64d79856a59cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798356
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695749}

Refactoring from composition to using CRTP to simple inheritance.

Drive-by: Rework TraceNodes to allow inlining and constant folding
ShouldTracePersistentNode in the case of regular Persistents (in
PersistentRegion).

Change-Id: I1306218f71ea0fea11783b6b8832be84cc3c8480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789588Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695748}

This was causing an msan failure (use of uninitialized var).

Bug: 1003006
Change-Id: Iad05067b34e8289ce0809d6bc2ce935b58f0397b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797060
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695747}

Mark conformance/rendering/blending.html as Failure

BUG=1002997
TEST=bot
TBR=kbr@chromium.org

Change-Id: I54598a0d4f8991d42420fd81e9e05d9433b7dcf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798871Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695746}

This is a reland of 62e19745 with the component
build fixed.

Original change's description:
> [fuchsia] Implement fuchsia.web.Frame/SetUrlRequestRewriteRules.
>
> * Implement the fuchsia.web.Frame/SetUrlRequestRewriteRules API.
> * Add a mojo interface to provide the renderers with new rules.
>   * This interface is implemented in the browser in
>     UrlRequestRewriteRulesManager, which also takes care of validating
>     and converting the rules from FIDL to Mojo, and providing them to
>     the WebEngineURLLoaderThrottles in the browser.
>   * In the renderer, there is one rules receiver per RenderFrame,
>     implemented in UrlRequestRulesReceiver. They cache the rules and
>     provide them to the WebEngineURLLoaderThrottles in the renderer.
> * Add unit tests and browser tests for the new API.
>
> Bug: 976975
> Change-Id: I446ea4838d50e65c568e7e2cbcd32c23d64af426
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659677
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695298}

Bug: 976975, 1002719
Change-Id: I8ea6fda911b6efb89eff8f33182525ed99a20cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797338
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695745}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chromecast.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=servolk@chromium.org

Bug: 891670
Change-Id: Iaa04676f2f42a2be1353c0ac67cfeba6086143b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786985
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695744}

This change converts LockManager mojom interface client in blink to use
BrowserInterfaceBroker. RenderProcessHost now has a CreateLockManager() method,
which is called by handlers for frames and workers.

Bug: 936482

Change-Id: I1f3b38549d352593eea27a9a3f12d14fe7681f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785621
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695743}

This would occur due to the pin button appearing after the item was
hovered. This change makes this no longer an issue since the pin button
will always be visible.

Bug: 1001617
Change-Id: If0c5886b2cd7cd33379bbe70ae58cb2c408acb9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798669Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695742}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/utility/image_writer.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=haven@chromium.org

Bug: 891670
Change-Id: Id42c705ac4a5dba6785b770aa62c377b029e1faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786968
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695741}