GitLab

BUG=232048

Review URL: https://codereview.chromium.org/14296002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194583 0039d316-1c4b-4281-b951-d872f2087c98

This data type should not be visible in the UI, as it will be configured automatically for managed users.

TBR=atwilson@chromium.org
BUG=229383

Review URL: https://codereview.chromium.org/14053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232048

Review URL: https://codereview.chromium.org/13963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194581 0039d316-1c4b-4281-b951-d872f2087c98

Don't create the virtual keyboard until it is first shown.  This helps
prevent some start-up races.

Also clean-up some of the object ownership between KeyboardController
and KeyboardLayoutManager.  Each pointer exists in only one or the
other object now.

BUG=none

Review URL: https://codereview.chromium.org/13932030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194580 0039d316-1c4b-4281-b951-d872f2087c98

This is just the old virtual keyboard that was removed a couple of years
ago, being used as a temporary stand-in.

BUG=222801

Review URL: https://codereview.chromium.org/13652010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194579 0039d316-1c4b-4281-b951-d872f2087c98

This CL refactors the ShellDelegate by adding a SessionStateDelegate to
which methods dealing with the session state can be moved. This cleans up
the huge ShellDelegate interface and paves the way for further Chrome OS
multiprofile work which will need to add several new methods related to
the session state.

This CL is only the first step. Several other methods should also move to
SessionStateDelegate but I do not want to overburden a single CL.

BUG=None
TEST=Manual and browser/unit tests

TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)

Review URL: https://codereview.chromium.org/14295008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194578 0039d316-1c4b-4281-b951-d872f2087c98

The leak is due to too much passing around of an IOBuffer via
a raw pointer.

BUG=232345
TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/14087008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194577 0039d316-1c4b-4281-b951-d872f2087c98

This is to avoid skipping "meta viewport" tag processing.

For controlling wide viewport-related behavior, a corresponding
WebSetting has been added into Blink.

Review URL: https://codereview.chromium.org/14234002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227043
TEST=content_unittests and mish audio tests in Chrome

Review URL: https://codereview.chromium.org/14244005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178009
TEST=this test

Review URL: https://codereview.chromium.org/13542003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194572 0039d316-1c4b-4281-b951-d872f2087c98

After the Blink roll 148494:148530 that happened in r194534 this test
started failing.

TEST=sanity compilation locally on Linux.
BUG=232340
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/14063013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173339

Review URL: https://codereview.chromium.org/14322009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194570 0039d316-1c4b-4281-b951-d872f2087c98

Just add new pattern. It will be used to implement DriveFileStreamReader.

BUG=127129
TEST=Ran unit_tests.

Review URL: https://codereview.chromium.org/14235017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194569 0039d316-1c4b-4281-b951-d872f2087c98

Disabling this test again as it has shown to keep being flaky even
after the fix in r193825.

BUG=232330,229700
TEST=sanity compile on Linux.
TBR=asargent@chromium.org

Review URL: https://codereview.chromium.org/13996011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194568 0039d316-1c4b-4281-b951-d872f2087c98

> Complete (but inefficient) implementation of the image retargetting method.
> 
> This CL contains:
> 1. Convolution of arbitrary channel with arbitrary kernel (convolver*).
> 2. Gaussian gradient magnitude implementation.
> 3. Image profile (X and Y projections) computations.
> 4. Otsu-like thresholding of profiles.
> 5. Image decimation.
> 6. The main routine which binds it all together.
> 
> Note: 1 and 2 do work, but remain main sources of suckiness due to performance
> problems. I actively work on this. Still, I'd love to get the current state in
> to establish a baseline and for viewing pleasure of those who are interested.
> 
> BUG=155269
> 
> Review URL: https://codereview.chromium.org/13947013

TBR=motek@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181502

Review URL: https://codereview.chromium.org/14322012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194566 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains:
1. Convolution of arbitrary channel with arbitrary kernel (convolver*).
2. Gaussian gradient magnitude implementation.
3. Image profile (X and Y projections) computations.
4. Otsu-like thresholding of profiles.
5. Image decimation.
6. The main routine which binds it all together.

Note: 1 and 2 do work, but remain main sources of suckiness due to performance
problems. I actively work on this. Still, I'd love to get the current state in
to establish a baseline and for viewing pleasure of those who are interested.

BUG=155269

Review URL: https://codereview.chromium.org/13947013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194565 0039d316-1c4b-4281-b951-d872f2087c98

Use SpdyBuffer for both SPDY reads and writes. A future
CL will add hooks to SpdyBuffer so that we keep track of
flow control windows properly.

Replace SpdyFrameProducer with SpdyBufferProducer.

Also introduce new SpdyReadQueue class for delegates
of SpdyStream to use.

BUG=176592

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194560

Review URL: https://codereview.chromium.org/13990005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231331
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/14208014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194563 0039d316-1c4b-4281-b951-d872f2087c98

> [SPDY] Replace SpdyIOBuffer with new SpdyBuffer class
> 
> Use SpdyBuffer for both SPDY reads and writes. A future
> CL will add hooks to SpdyBuffer so that we keep track of
> flow control windows properly.
> 
> Replace SpdyFrameProducer with SpdyBufferProducer.
> 
> Also introduce new SpdyReadQueue class for delegates
> of SpdyStream to use.
> 
> BUG=176592
> 
> Review URL: https://codereview.chromium.org/13990005

TBR=akalin@chromium.org

Review URL: https://codereview.chromium.org/13996009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194562 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194561 0039d316-1c4b-4281-b951-d872f2087c98

Use SpdyBuffer for both SPDY reads and writes. A future
CL will add hooks to SpdyBuffer so that we keep track of
flow control windows properly.

Replace SpdyFrameProducer with SpdyBufferProducer.

Also introduce new SpdyReadQueue class for delegates
of SpdyStream to use.

BUG=176592

Review URL: https://codereview.chromium.org/13990005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/13977013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232313
TEST=sanity compile and run on Linux and Windows.
TBR=akalin

Review URL: https://codereview.chromium.org/14167014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194558 0039d316-1c4b-4281-b951-d872f2087c98

 - remove quarantine_size, which is too greedy compared to the default value
 (this may result in less UAFs caught by ASan, but is very unlikely. ClusterFuzz uses the default setting)
 - temporarily set malloc_content_size=5 to avoid the enourmous growth of the stack trace repository
 (this will result in less memory footprint and shorter stacks for heap allocations printed in the reports.
 However we don't care much about the quality of ASan reports on the client side right now).

BUG=address-sanitizer:177

Review URL: https://codereview.chromium.org/13932014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230749
TEST=Open Files App, choose the sidebar item, verify the Drive related gear menus (e.g. "Show Google Docs files") are available.

Review URL: https://codereview.chromium.org/13871005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231795
TEST=unittests,trybots

Review URL: https://codereview.chromium.org/14118008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231273
TEST=pass all existing tests

Review URL: https://codereview.chromium.org/13929012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194552 0039d316-1c4b-4281-b951-d872f2087c98

This patch is just for setting up the interface. Actual code
to fire each event will come soon.

BUG=154243
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/14148006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194551 0039d316-1c4b-4281-b951-d872f2087c98

Broken data should be detected and cleared during initialization to avoid fatal bugs.

BUG=232054
TEST=unit_tests

Review URL: https://codereview.chromium.org/14167009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194550 0039d316-1c4b-4281-b951-d872f2087c98

This wires up the standard ConfigurationPolicyProviderTest suite with a
PolicyLoaderWin that is reading policy from GPO PReg files.

BUG=chromium:186445
TEST=unit tests

Review URL: https://codereview.chromium.org/13963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194549 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194547 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 194504 "Fix build break"
> 
> > Fix build break
> > R=shishir
> > 
> > Review URL: https://codereview.chromium.org/14307004
> 
> TBR=tburkard@chromium.org
> 
> Review URL: https://codereview.chromium.org/13933017

TBR=kjellander@google.com

Review URL: https://codereview.chromium.org/14235016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194542 0039d316-1c4b-4281-b951-d872f2087c98

> Fix build break
> R=shishir
> 
> Review URL: https://codereview.chromium.org/14307004

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/13933017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194541 0039d316-1c4b-4281-b951-d872f2087c98

Added Unit test to close the socket during spdy_session's
read and verifying that getting new URLs from the same
network session don't result in a failure.

Modified mock socket code to close the connection if
mock_read closes the connection (because of ERR_CONNECTION_CLOSED error).

Implement greedy approach to read all the data and process
it from the ClientSocket until we block.

Implemented the greedy approach to improves the network
stack performance on the mobile.

spdy_session_test_util.* files have the common code between
SpdySessionSpd2Test and SpdySessionSpd3Test.  Created this
file to reduce errors and to avoid duplicating of code.

Review URL: https://chromiumcodereview.appspot.com/11644088

The change adds a scoped_refptr to SpdySession in DoLoop
to clean up the state and to finish pending reads, in case
SpdyFramer receives GOAway and closes all streams.

DoReadComplete was holding the last reference before and
DoLoop was accessing the object after DoReadComplete deleted
the object at the end of the function.

Review URL: https://codereview.chromium.org/12212102

Added unit tests for use after free of SpdySession
and unit test to test yielding + async during Read.

A test that crashes when scoped_refptr to SpdySession
deleted from DoLoop.

Added the following test per rch@ to test interactions of
yielding + async during Read.

Do the following MockReads and verify all the data is
consumed and SpdySession has yielded during Read.

SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 2K
ASYNC 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 2K

Review URL: https://chromiumcodereview.appspot.com/12207122

Reverted URL: https://chromiumcodereview.appspot.com/13608003/

BUG=175574, 166958, 224701, 175069
R=rch@chromium.org, jar@chromium.org
TEST=network unit tests

Review URL: https://codereview.chromium.org/13834009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194540 0039d316-1c4b-4281-b951-d872f2087c98

The webNavigation API defines that the signals always arrive in that order.
However, the frame loader can finish loading the document before the parser
actually finished parsing. To work around this, we delay the finished load
signal until after parsing has finished.

BUG=230767
TEST=WebNavigationApiTest.SrcDoc doesn't fail flakily

Review URL: https://codereview.chromium.org/13929020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194539 0039d316-1c4b-4281-b951-d872f2087c98

I'm leaving in NaClProcessHost's enable_exception_handling_ field
because we will want to disable exception handling under PNaCl.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2401
TEST=inbrowser_test_runner in nacl_integration

Review URL: https://codereview.chromium.org/14122010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/13394004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194536 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/13926015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194534 0039d316-1c4b-4281-b951-d872f2087c98