GitLab

TBR=acolwell@chromium.org
BUG=122913
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10536072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129768
TEST=Verify app list bubble is at correct position with an auto-hide launcher bar.

Review URL: https://chromiumcodereview.appspot.com/10537061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141217 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10542063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127791.
TEST=Manually.


Review URL: https://chromiumcodereview.appspot.com/10532009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141215 0039d316-1c4b-4281-b951-d872f2087c98

Fix conversion between NSImage to ImageSkia for when this is the case.

Also changed unittest constants to be kWidth1x, kHeight1x etc

Test=ImageMacTest.NSImageWithResizedNSImageRepToImageSkia
Bug=None

Review URL: https://chromiumcodereview.appspot.com/10545069

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10535079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141214 0039d316-1c4b-4281-b951-d872f2087c98

Forcing string16 to 0 leads to iterator compatiblity check crash in MSVS2010 Debug builds.

This bug was diagnosed by tom.cassiotis@gmail.com

BUG=131589
TEST=Start MSVS2010 Debug build of chrome.exe

Review URL: https://chromiumcodereview.appspot.com/10545065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131744
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10538052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141212 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=88596

The basics work, but a lot of stuff is broken (e.g. switching
resolutions while chrome is running).

BUG=31960
TEST=Go HighDPI, launch chrome. No longer pixely.
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10537067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141211 0039d316-1c4b-4281-b951-d872f2087c98

Resetting the state of the outputs causes a black flash on the screen so avoid
doing this in the cases where the outputs were already configured such that they
were in a state we can recognize.

BUG=chromium:130943
TEST=Manually tested on lumpy with extra instrumentation to ensure that logging
in as guest does not change the CRTCs.


Review URL: https://chromiumcodereview.appspot.com/10532053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141209 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

R=asargent@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10539054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141208 0039d316-1c4b-4281-b951-d872f2087c98

The UUID will not be listed for some services advertised over SDP, so
this check is no longer reliable.  Adding the full check for SDP
services will be too resource intensive to be worthwhile.

BUG=none
TEST=none

R=keybuk@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10538044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141207 0039d316-1c4b-4281-b951-d872f2087c98

Fix conversion between NSImage to ImageSkia for when this is the case.

Also changed unittest constants to be kWidth1x, kHeight1x etc

Test=ImageMacTest.NSImageWithResizedNSImageRepToImageSkia
Bug=None

Review URL: https://chromiumcodereview.appspot.com/10545069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96477
TEST=This requires a special build of Google Update to test...
Review URL: https://chromiumcodereview.appspot.com/10537039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131647
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10537073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141204 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141203 0039d316-1c4b-4281-b951-d872f2087c98

control group: http://codereview.chromium.org/10541032/

Review URL: https://chromiumcodereview.appspot.com/10546027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141202 0039d316-1c4b-4281-b951-d872f2087c98

The collision due to the mosys serial_number key has been resolved, so
we can now re-prioritize the keys to try serial_number first and then
fall back to legacy keys. This is important for getting the correct
serial number on newer ZGBs, because they now have a valid serial number
in "serial_number", but a fake serial number in "sn".

BUG=chromium-os:31652
TEST=Enterprise enrollment still works for all devices.


Review URL: https://chromiumcodereview.appspot.com/10542072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141201 0039d316-1c4b-4281-b951-d872f2087c98

The test requires a data file which is now in the whitelist of files copied over to device.
Sample failure on the bot:
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Android/builds/10125/steps/Test%20suite%20content_unittests/logs/stdio

BUG=None
TEST=content_unittests should run successfully on the Android FYI builder.

Review URL: https://chromiumcodereview.appspot.com/10532064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141200 0039d316-1c4b-4281-b951-d872f2087c98

These will be used by browser_tests on chromeos.

BUG=
TEST=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10545071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131783

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141198 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130743
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141197 0039d316-1c4b-4281-b951-d872f2087c98

Candidate window is shown upper side of composition string if there is no space to be shown.
However it become too often.
According to CL, candidate window can be switched the side to be shown only one time.


BUG=129119
TEST=manually done on Alex

Review URL: https://chromiumcodereview.appspot.com/10542051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141196 0039d316-1c4b-4281-b951-d872f2087c98

Undo the wrong disable I did in my previous CL.
Details in bug.

TBR=kkania
BUG=131782
Review URL: https://chromiumcodereview.appspot.com/10537074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141195 0039d316-1c4b-4281-b951-d872f2087c98

The test fails on win. Details in bug.

TBR=kkania
BUG=131782
Review URL: https://chromiumcodereview.appspot.com/10543076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141194 0039d316-1c4b-4281-b951-d872f2087c98

This depends on WebKit patch at https://bugs.webkit.org/show_bug.cgi?id=88406.


BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10542025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141193 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan


Review URL: https://chromiumcodereview.appspot.com/10543075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141191 0039d316-1c4b-4281-b951-d872f2087c98

This was fixed upstream in webkit r119620 so we can remove the
suppression.  Since the bot only runs a subset of the layout tests
each run, it may be a while before I can verify on the bots.

BUG=131351
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10543060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141190 0039d316-1c4b-4281-b951-d872f2087c98

This changes the current overlay so that input is possible (selecting which keyboard shortcut to use). It also suspends current Chrome keyboard handling (Views only), while capturing the shortcut, so that you can press ie. Ctrl-F without Chrome eating your keyboard assignment and instead showing the Find box. 

NOTE: This does not persist the user's choice (future changelist).

BUG=121420
TEST=With a keybinding Extension installed, open chrome://extensions, click on Configure Commands, and notice that the shortcuts are listed in text boxes that are clickable and accept keyboard input.
Review URL: https://chromiumcodereview.appspot.com/10514003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141189 0039d316-1c4b-4281-b951-d872f2087c98

Previously it has been taking a file system name and relative file.
Now the API takes a FileEntry which is much nicer to use, and is
transformed into a file system name and relative file path for the
implementation via a custom binding.

BUG=130452
TEST=The existing automated test has been updated


Review URL: https://chromiumcodereview.appspot.com/10544069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141186 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=unit tests pass.
TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10539045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131505
TEST=unit_tests --gtest_filter="GData*"

Review URL: https://chromiumcodereview.appspot.com/10533042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131295
TEST=manual; successfully copied 3GB file in Chromeos filebrowser


Review URL: https://chromiumcodereview.appspot.com/10536062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141181 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10534055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141180 0039d316-1c4b-4281-b951-d872f2087c98

Instead of magic numbers for the correct total item count in menus, check
for the existence and absence of the items we do and don't want.

BUG=None
TEST=Covered by existing tests


Review URL: https://chromiumcodereview.appspot.com/10539060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141179 0039d316-1c4b-4281-b951-d872f2087c98

Convert path to UTF8 using the file_path routine AsUTF8Unsafe, instead of leaving as-is for all OS's except windows where conversion was UTF16ToUTF8. Using the file_path routine is safer, despite its name.

This will potentially still have some problems on weird POSIX systems, but should be more robust that the previous #if version.

BUG=None
TEST=Covered by existing tests


Review URL: https://chromiumcodereview.appspot.com/10543070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141178 0039d316-1c4b-4281-b951-d872f2087c98

Instead of an explicit "platform_app": true manifest keys, platform apps are now
defined by the presence of the "background" section inside "app" (since platform
apps require background pages). The top-level "background" section is not
supported for platform apps.

R=miket@chromium.org
BUG=131394


Review URL: https://chromiumcodereview.appspot.com/10544059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123160
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10533041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131313
TEST=apply patch from crbug.com/131315, run checkdeps.
TBR=tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10543071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141175 0039d316-1c4b-4281-b951-d872f2087c98