- 19 Sep, 2018 40 commits
-
-
dpapad authored
Enabling the following tests: CrSettingsChromeCleanupPageTest.All (Removed usage of /deep/) CrSettingsMultidevicePageContainerTest.All (already passing) Also fixing some overlapping inclusion and exclusion patterns (they should not exist). Bug: 875452,860069 Change-Id: Iba0546d24f032af0bfa4c3fb15b383e2ef938269 Reviewed-on: https://chromium-review.googlesource.com/1227479Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592466}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4c6d03d..0b5eefe8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia06993a4dead0ca406a6640e77dff9b72a8cc801 Reviewed-on: https://chromium-review.googlesource.com/1233188Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592465}
-
Doug Arnett authored
Also add check on feature being enabled to also gate instantiating the server blacklist plus a couple tests. Bug: 864640 Change-Id: I332fa10e1fa6711c38a43cef3d179e63b14a5a46 Reviewed-on: https://chromium-review.googlesource.com/1225860 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#592464}
-
Ned Nguyen authored
These benchmarks are handy for integration testing our pipeline & to dogfood new big features launch, so keeping them around. *This is part of the effort to add bug components for all perf benchmarks. Change-Id: Id8d8dee935ccc8b58186b2c6f3ec9ea6e5711397 BUG: 886965 Reviewed-on: https://chromium-review.googlesource.com/1234314 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#592463}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/274a6922da39..c57ca0ea3af6 git log 274a6922da39..c57ca0ea3af6 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 stevenjb@chromium.org cros_vm: Do not use sudo for creating VM dir 2018-09-19 manojgupta@google.com chrome_util: Make widevine cdm optional for ARM64. 2018-09-19 achuith@chromium.org cros_vm: Handle SSH port clash better. Created with: gclient setdep -r src/third_party/chromite@c57ca0ea3af6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibe8f58d3e1350b60e6cf71429942c04d150591dd Reviewed-on: https://chromium-review.googlesource.com/1233996Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592462}
-
Raphael Kubo da Costa authored
Shaderc was dropped altogether from the tree in commit 7f7dd90b ("Remove Shaderc"), but the code was still being checked out for no reason. Additionally, having third_party/shaderc/src with no accompanying README.chromium causes tools/licenses.py to fail: licenses.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in third_party/shaderc Bug: 39240, 852620 Change-Id: Ic5e98407149ebccf320a976f2810c93f71ee6658 Reviewed-on: https://chromium-review.googlesource.com/1228053Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#592461}
-
Sam Maier authored
These are being copied over before the originals are removed to accommodate downstream. TBR=agrieve@chromium.org Bug: 825947 Change-Id: I29a9db48c9d51d80cac8fd2c2d0287844ab8ff75 Reviewed-on: https://chromium-review.googlesource.com/1233718 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#592460}
-
Robbie McElrath authored
This migrates SyncSchedulerImpl from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883126 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3482c04e6943df0b928eaebd48d9b511c6cb913a Reviewed-on: https://chromium-review.googlesource.com/1222699Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592459}
-
Daniel Cheng authored
Bug: 742517 Change-Id: Id5ce54250468e9172f65f5dd79b522d08306e086 Reviewed-on: https://chromium-review.googlesource.com/1233121Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592458}
-
mrefaat authored
Create a field trail entry before experimenting with 50% Beta Bug: 847550 Change-Id: I427bb6d9d798dfe9bd7fa9df8040d790cfa23c44 Reviewed-on: https://chromium-review.googlesource.com/1224797Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592457}
-
Xiaohui Chen authored
This is a reland of 31a94c76 Original change's description: > assistant: turn on build for chromeos > > Bug: 114082902 > Test: locally build > Change-Id: Id29bb95768d2a6da75b649e4a32b4e37c74a6897 > Reviewed-on: https://chromium-review.googlesource.com/1226263 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591540} Bug: 114082902 Change-Id: If33405de3b7bb07d3cb048fbb7cd42401a83391a Reviewed-on: https://chromium-review.googlesource.com/1232194Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592456}
-
Sammie Quon authored
Do not allow app list or its childrens to process events during swipe to close. Cancel swipe to close non scroll/fling event on shelf is seen. Search box widget can still take events on app list, this does not seem to cause any problems, but may need investigating. Also added a test to check local variables get reset after swiping in HomeLauncherGestureHandler. Test: ash_unittest *HomeLauncher*GestureHandlerTest* Bug: 881131 Change-Id: Id0e49e8fc246837900dc1145af12608b5e507874 Reviewed-on: https://chromium-review.googlesource.com/1233193 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592455}
-
Xianzhu Wang authored
The result in BGPT mode is a progression. Bug: 879169 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ide0e2405c04d5b245294679e71a1dd3f4954e975 Reviewed-on: https://chromium-review.googlesource.com/1229179Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592454}
-
Yves Gerey authored
Mimic what was done for metrics (819be2e0). This CL doesn't change anything for Chromium build, but make it easier to pick Chromium's implementation of field_trial by external targets. Bug: webrtc:9631 Change-Id: I88ff9580200f711eabe13f597a3095ebc8d27c6f Reviewed-on: https://chromium-review.googlesource.com/1233838Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#592453}
-
Mike Dougherty authored
Calling supressNextClick is no longer necessary (as of at least iOS 10.0) to prevent navigation in the web view when presenting a context menu. |suppressNextClick| was incorreclty disabling the next touch after a context menu was canceled. TEST=No side effects after showing context menu Bug: 806737 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I40bd1e58a41a2fcab9985a436711da626800e718 Reviewed-on: https://chromium-review.googlesource.com/1228501Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#592452}
-
Michael Spang authored
Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on ozone as well to make sure we have build coverage. Bug: 861853 Test: compile Change-Id: I7c15e365b2a4cfc7160847457ce9bf46a3f12f1e Reviewed-on: https://chromium-review.googlesource.com/1229233 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#592451}
-
Zach Helfinstein authored
Bug: 826215 Change-Id: Ia7dc94085d74519e6ecaea09dd9f3b4dcb8104ec Reviewed-on: https://chromium-review.googlesource.com/1227594Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592450}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be50d76e46ea..eaac597484d5 Created with: gclient setdep -r src-internal@eaac597484d5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7aa9fea0103efe639ed0335be8b0a89f52396a1f Reviewed-on: https://chromium-review.googlesource.com/1233995Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592449}
-
Xi Cheng authored
Bug: 886957 Change-Id: I53e8736e548c96ff623b4543376bface5d6eb013 Reviewed-on: https://chromium-review.googlesource.com/1232526 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#592448}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4544f3711024..1bbc63df5b82 git log 4544f3711024..1bbc63df5b82 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 primiano@google.com Merge "Add bionic/ to buildtools gitignore" 2018-09-19 taylori@google.com Merge "trace_processor: Flatten CPU freq storage and remove cycles" Created with: gclient setdep -r src/third_party/perfetto@1bbc63df5b82 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia0714e522b5e8531c345360b7b43b1d483cfabe9 Reviewed-on: https://chromium-review.googlesource.com/1234313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592447}
-
Sky Malice authored
Also added DCHECKs to show our assumptions about callbacks and state when various methods are invoked. Bug: 885122 Change-Id: I4d9d96ffe300ddf7a650dc4421934b2639c3e6ac Reviewed-on: https://chromium-review.googlesource.com/1232481Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592446}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /device/bluetooth. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=ortuno@chromium.org Bug: 874080 Change-Id: Ib9d437546b43da34663eb96562becc94d6655989 Reviewed-on: https://chromium-review.googlesource.com/1191795Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#592445}
-
Aaron Colwell authored
Change-Id: I44dd0a6c1cf0168e7934378b0b3b4e900adf4f8d Reviewed-on: https://chromium-review.googlesource.com/1232213Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#592444}
-
Jun Cai authored
Bug: 843384 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib5d7677cbba9a715fbe295c530dea58135a79250 Reviewed-on: https://chromium-review.googlesource.com/1222291Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592443}
-
Varun Khaneja authored
Bug: 886952 Change-Id: Iffbd7918ba24f9e6447baa424a108b5736b6659d Reviewed-on: https://chromium-review.googlesource.com/1233123 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592442}
-
Kyle Horimoto authored
Previously SetHostDevice() accepted a public key as a parameter, but that parameter was changed to a device ID in https://chromium-review.googlesource.com/c/chromium/src/+/1149328. The actual implementations of the MultiDeviceSetup interface (e.g., MultiDeviceSetupImpl) were changed correctly, but the *.mojom file was not. Change-Id: I1687d98d09a1dfe69a01e9eb77e2d092375ef0b0 Reviewed-on: https://chromium-review.googlesource.com/1232527Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592441}
-
Adithya Srinivasan authored
As per discussion in the associated bug, we call EnsurePaintLocationDataValidForNode, which ensures that the document lifecycle is advanced to kCompositingInputsClean for sticky elements in order to correctly calculate its position. Bug: 850380 Change-Id: I27665028393cee6f330fda747b4a344e994fe8fe Reviewed-on: https://chromium-review.googlesource.com/1231378Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#592440}
-
edchin authored
This CL: 1) Notifies observers when the SnapshotCache removes a snapshot. This approach gives symmetry since observers are notified when a snapshot is added. 2) Adds a unittest for notifying observers on setting and removing a snapshot. 3) Adds TabGridMediator as an observer. Bug: 739840 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib6fa854670537a1d225f92adbc51a361a1714623 Reviewed-on: https://chromium-review.googlesource.com/1231897Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592439}
-
Sadrul Habib Chowdhury authored
Some of the discrepancy_ and mean_ metrics have been removed in crrev.com/c/1228794 and crrev.com/c/1229335. Update the tests accordingly. BUG=884950, 886913 Change-Id: If47fa9231e55fe52d6511b71cbcce1776cef4d60 Reviewed-on: https://chromium-review.googlesource.com/1234015Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592438}
-
Dan Zhang authored
Remove unnecessary forward declare of RandomBase in random_util_helper.h Merge quic part internal change: 210537018, 211551817 R=rch@chromium.org Change-Id: Idd96a1b6308dca93d68682490323d3ab7dee3f4f Reviewed-on: https://chromium-review.googlesource.com/1228838 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#592437}
-
Robert Ogden authored
See the UI mocks and specs in the bug for more detail. This CL also moves around some logic from the PreviewsInfoBarDelegate to the tab helper. Bug: 871839 Change-Id: Iba7f034fca449cf98c4c9054072365eef5bb339c Reviewed-on: https://chromium-review.googlesource.com/1222406 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#592436}
-
Ned Nguyen authored
Bug: 885913 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: If4d056738ff1ae84fa43f1d229ca89a39a71e81d Reviewed-on: https://chromium-review.googlesource.com/1234034Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592435}
-
Ahmed Fakhry authored
In this case, a web contents won't be the delegate of the render view host, and content::WebContents::FromRenderViewHost() will return nullptr. BUG=885207 TEST=Manual Change-Id: I76b722ebdd4ce2446dfb2087f3a2f4b3daae45a7 Reviewed-on: https://chromium-review.googlesource.com/1232681Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592434}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: I6e2b277d3083645c7967cc3a1a481c8bf645eebd Reviewed-on: https://chromium-review.googlesource.com/1233739Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592433}
-
Weiyong Yao authored
In another cl, the logic in capture() was modified according to the review comments, which causes the problem in crbug.com/883984. This cl is to restore the logic in capture() as before. Bug: 883984 Change-Id: I0c8684c7611fd75f37ce9d3b12c2dc8290668534 Reviewed-on: https://chromium-review.googlesource.com/1225974 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592432}
-
Antonio Gomes authored
Currently, there is currently ~9 identical implementations of this method spread across various tests / components. This CL is a first step that eliminates this redundancy, by adding a API to it in TestURLLoaderFactory and convert a couple of call sites. TBR=dewittj@chromium.org (straight forward switch in //components/offline_pages). BUG=773295 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie6b6867b046a72d0be7a7ec2bb6d964d2cfceb3e Reviewed-on: https://chromium-review.googlesource.com/1234133 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#592431}
-
Morten Stenshorne authored
The implementation is the same, but I threw in a DCHECK that inline size not being indefinite. This function can be used for other things than converting from border-box to content-box. It can e.g. also be used to convert from padding-box to content-box, or from border-box to padding-box. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic14550ec7019eedf03d3a16d31cd6ab51e507811 Reviewed-on: https://chromium-review.googlesource.com/1233698Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592430}
-
Scott Violet authored
EmbedRoot: needs to show the WindowTreeHost. I'm a surprised we actually see anything without this. WindowPortMus: removes an unnecessary local. WindowTree: Renames GetClientRootWindowFor() to FindClientRootContaining(). BUG=881574 TEST=covered by tests Change-Id: I869d59dd2a20c5a608ef1c7346bc906de73f84dc Reviewed-on: https://chromium-review.googlesource.com/1233173 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592429}
-
Asanka Herath authored
This reverts commit 888677bc. Reason for revert: Tests failing on chromium.memory/Linux CFI. See crbug.com/886576 Original change's description: > Switch UserScriptListener ResourceThrottle to NavigationThrottle > > ResourceThrottles do not work with network service enabled, a > NavigationThrottle will work both with NS enabled and disabled. > > Bug: 884006 > Change-Id: Ifea0e59bd67d70b593b46c2a2a2bd4be0e3f98f0 > Reviewed-on: https://chromium-review.googlesource.com/1227358 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592182} TBR=jam@chromium.org,rdevlin.cronin@chromium.org,cduvall@chromium.org Change-Id: I18519542954bf23e2e76ea83598382f4f00188e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884006 Reviewed-on: https://chromium-review.googlesource.com/1234214Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592428}
-
Boris Sazonov authored
This CL modifies OAuth2TokenService.hasOAuth2RefreshToken to check whether the account list cache has been populated and is ready to use. Native MutableProfileOAuth2TokenService::RefreshTokenIsAvailable also returns false if refresh tokens haven't been loaded yet. Bug: 837374 Change-Id: Ia7c2475566b05c93fd706ca2ce1e9f16bfbae608 Reviewed-on: https://chromium-review.googlesource.com/1231935Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592427}
-