GitLab

Cherry pick the HarfBuzz commit 8ac345e5c0ed0aad6547592ea0839aabfb4ba980
as it fixes a set of serious shaping regressions in the core text shaper
on Mac OS. Cherry picking as opposed to rolling to allow for a clean DI.

BUG=459043
TBR=behdad@chromium.org

Review URL: https://codereview.chromium.org/971153002

Cr-Commit-Position: refs/heads/master@{#318901}

This is going to help the PermissionService to have its
RequestPermission returing the expected value.

Internally, PermissionContextBase is using ContentSetting but the public
API is using PermissionStatus.

BUG=432978

Review URL: https://codereview.chromium.org/955383003

Cr-Commit-Position: refs/heads/master@{#318900}

It fixes the following clang format message:

In file included from ../../ui/ozone/platform/dri/gbm_buffer.cc:14:
../../ui/ozone/platform/dri/gbm_device.h:18:3: error: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
  ~GbmDevice() override;
  ^
../../ui/ozone/platform/dri/gbm_device.h:14:19: note: [chromium-style] 'GbmDevice' inherits from 'ui::DrmDevice' here
class GbmDevice : public DrmDevice {
                  ^
../../ui/ozone/platform/dri/drm_device.h:41:32: note: [chromium-style] 'DrmDevice' inherits from 'base::RefCountedThreadSafe<DrmDevice>' here
class OZONE_EXPORT DrmDevice : public base::RefCountedThreadSafe<DrmDevice> {

BUG=none

Review URL: https://codereview.chromium.org/975773002

Cr-Commit-Position: refs/heads/master@{#318899}

BUG=361761
TEST=no visible change

Review URL: https://codereview.chromium.org/975533002

Cr-Commit-Position: refs/heads/master@{#318898}

BUG=345874

Review URL: https://codereview.chromium.org/974903002

Cr-Commit-Position: refs/heads/master@{#318897}

The need to make the distinction between the two types of infobars has
disappeared with the new design of the infobars.

BUG=None

Review URL: https://codereview.chromium.org/975663002

Cr-Commit-Position: refs/heads/master@{#318896}

WebRTC 8548:8573
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1e5b7f7..c9dfd1c

Libjingle 8550:8571
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/bbfd399..3b22f07

TBR=

Review URL: https://codereview.chromium.org/969413002

Cr-Commit-Position: refs/heads/master@{#318895}

BUG=424075
TEST=manual

Review URL: https://codereview.chromium.org/957753002

Cr-Commit-Position: refs/heads/master@{#318894}

Also fix some mislabelled entries in the histogram enum.

Make the declaration site explicit to decrease the likelihood of such
omissions/mislabels happening again in the future.

BUG=None

Review URL: https://codereview.chromium.org/968253002

Cr-Commit-Position: refs/heads/master@{#318893}

We shouldn't hard code out/Release (since with GN the path could be different) or look for the checkout directory (since with swarming it doesn't exist).

This was needed with ui_tests or pyauto, but not with the current browser_tests binaries.

BUG=463180

Review URL: https://codereview.chromium.org/969313002

Cr-Commit-Position: refs/heads/master@{#318892}

Follows:
https://codereview.chromium.org/968943004/
https://chrome-internal-review.googlesource.com/#/c/203597/
BUG=428903
TBR=jbudorick

Review URL: https://codereview.chromium.org/964363003

Cr-Commit-Position: refs/heads/master@{#318891}

V8 caches all function templates internally for the lifetime of a web page in an
unbounded cache. Thus, creating a new function template for each call to a
method of injected object caused JS heap memory to grow linearly.

This is similar to a fix for Pepper Plugin objects (https://codereview.chromium.org/785213002/)

BUG=462664

Review URL: https://codereview.chromium.org/969353004

Cr-Commit-Position: refs/heads/master@{#318890}

Whether to actually cache the template depends on the use case, so only
adding a warning in a comment.

BUG=463487

Review URL: https://codereview.chromium.org/974863002

Cr-Commit-Position: refs/heads/master@{#318889}

It enables renderers without DumpRenderTree to trigger Blink GCs.

BUG=438074, 420515

Review URL: https://codereview.chromium.org/964283002

Cr-Commit-Position: refs/heads/master@{#318888}

See https://codereview.chromium.org/968663004/
BUG=377250

Review URL: https://codereview.chromium.org/965903003

Cr-Commit-Position: refs/heads/master@{#318887}

This API was missed in the CL to add missing APIs to histograms.
https://codereview.chromium.org/938283004/

This change also tweaks a comment that caused pretty_print.py to
complain.

BUG=

Review URL: https://codereview.chromium.org/970163002

Cr-Commit-Position: refs/heads/master@{#318886}

http://build.chromium.org/p/chromium.lkgr/builders/UBSan%20vptr%20Release/builds/1296

BUG=463464
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/974843002

Cr-Commit-Position: refs/heads/master@{#318885}

facilitates WebUI creation.

All parts of WUG are implemented:
* Base classes for view (View) and view-model (ViewModel)
* WebUIView -- specialization of View for use in WebUI.
* View's CC, HTML and JS code generator
* Templates for GYP and GN which help to generate code and
  produce components from generated code.

Tests to follow.

TEST=none
TBR=avi@chromium.org,mark@chromium.org
BUG=459230

Review URL: https://codereview.chromium.org/928163002

Cr-Commit-Position: refs/heads/master@{#318884}

Highlights:
 - mojo::ChannelInit has been replaced with
   content::ChannelInit.
 - ScopedIPCSupport has been added so Mojo consumers can
   ensure the EDK is initialized.
 - single process mode now uses some evil tricks to get
   child threads to create their mojo client channels on
   the browser I/O thread.
 - several Android bits adapted to new interfaces
 - a number of tests have been adapted to work properly
   in spite of unconventional process arrangements

BUG=None

Review URL: https://codereview.chromium.org/954643002

Cr-Commit-Position: refs/heads/master@{#318883}

BUG=463459

Review URL: https://codereview.chromium.org/973813002

Cr-Commit-Position: refs/heads/master@{#318882}

TBR=machenbach

BUG=463436

Review URL: https://codereview.chromium.org/973063002

Cr-Commit-Position: refs/heads/master@{#318881}

Revert of Update V8 to version 4.3.15. (patchset #1 id:1 of https://codereview.chromium.org/969053002/)

Reason for revert:
Speculative revert for issue 463436.

Original issue's description:
> Update V8 to version 4.3.15.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/32e6c72188d6b0b948d668afdc1cb209d44c2e70
> Cr-Commit-Position: refs/heads/master@{#318755}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/975713002

Cr-Commit-Position: refs/heads/master@{#318880}

Revert of Update V8 to version 4.3.16. (patchset #1 id:1 of https://codereview.chromium.org/974813002/)

Reason for revert:
Speculative revert for issue 463436.

Original issue's description:
> Update V8 to version 4.3.16.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/155278d6..ea02c333
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=machenbach@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/5d61006f40e3f14bbf8f2c60f698b051f8f84fd9
> Cr-Commit-Position: refs/heads/master@{#318874}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/978433002

Cr-Commit-Position: refs/heads/master@{#318879}

BUG=461604,435358
TEST=manual

Review URL: https://codereview.chromium.org/969403002

Cr-Commit-Position: refs/heads/master@{#318878}

BUG=None

Review URL: https://codereview.chromium.org/969353005

Cr-Commit-Position: refs/heads/master@{#318877}

We adjusted the leaderd dbus API to pass back an ObjectPath instead of
a string. Adjust the chromium bindings to match that.

BUG=453872

Review URL: https://codereview.chromium.org/972983003

Cr-Commit-Position: refs/heads/master@{#318876}

Component build was broken since 4a84927b, where
chromeos::device_event_log was moved  to components.

TBR=reillyg@chromium.org,derat@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/971363002

Cr-Commit-Position: refs/heads/master@{#318875}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/155278d6..ea02c333

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/974813002

Cr-Commit-Position: refs/heads/master@{#318874}

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu/+log/df1bf38..db16fd8

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/972953002

Cr-Commit-Position: refs/heads/master@{#318873}

This cl reverts back to the behaviour prior to https://codereview.chromium.org/795703003/. Ie, the security origin of the ancestors of a requesting iframe does not have to match in order to allow or deny a request.

BUG=448378, 456628

Review URL: https://codereview.chromium.org/969773002

Cr-Commit-Position: refs/heads/master@{#318872}

BUG=none

Review URL: https://codereview.chromium.org/968073004

Cr-Commit-Position: refs/heads/master@{#318871}

Revert of Fix crash in SimpleGeolocationProvider. (patchset #1 id:1 of https://codereview.chromium.org/973003002/)

Reason for revert:
This broke chromeos_unittests (see crbug.com/463499)

Original issue's description:
> Fix crash in SimpleGeolocationProvider.
>
> BUG=463150
> TEST=manual
>
> Committed: https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7
> Cr-Commit-Position: refs/heads/master@{#318866}

TBR=nkostylev@chromium.org,alemate@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463150

Review URL: https://codereview.chromium.org/974883002

Cr-Commit-Position: refs/heads/master@{#318870}

It is necessary because gles2_conform_supports depends on it and will
port it later.

Tested on Linux with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn gles2_implementation_no_check

BUG=None
TEST=see above
R=jbauman@chromium.org,dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/969603002

Cr-Commit-Position: refs/heads/master@{#318869}

BUG=463456
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/973793003

Cr-Commit-Position: refs/heads/master@{#318868}

Cr-Commit-Position: refs/heads/master@{#318867}

BUG=463150
TEST=manual

Review URL: https://codereview.chromium.org/973003002

Cr-Commit-Position: refs/heads/master@{#318866}

BUG=462483
NOTRY=true
TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/974833002

Cr-Commit-Position: refs/heads/master@{#318865}

This CL upstreams a small fork in ShouldShowAlwaysTranslateShortcut on
iOS, which is caused by a different UX on this platform.

Review URL: https://codereview.chromium.org/972123002

Cr-Commit-Position: refs/heads/master@{#318864}

This patch updates the dynamic lookup of NSS symbols to use
dlsym(RTLD_DEFAULT) instead of dlsym on the dlopen(NULL) handle.

The latter doesn't work if the binary that does the dynamic lookup was
loaded dynamically itself (as dlopen(NULL) gives access only to the
symbols loaded at the start of the program).

Note that RTLD_DEFAULT requires setting _GNU_SOURCE.

BUG=462203

Review URL: https://codereview.chromium.org/962593002

Cr-Commit-Position: refs/heads/master@{#318863}

Revert of Propagate audible state from player to the containing tab (patchset #16 id:310001 of https://codereview.chromium.org/896673003/)

Reason for revert:
This (Android only) change breaks the downstream Android test CastSwitchVideoTest#testNewVideoNewPageSameTab.

Reverting as Android Sheriff.

BUG=463445

Original issue's description:
> Propagate audible state from player to the containing tab.
>
> This is part 1 (chromium),
> part 2 (clank) is https://chrome-internal-review.googlesource.com/#/c/195455/
>
> This CL is only about propagation/plumbing.
> Neither the reporting of audible state my players nor the consumption
> (UI notification) are implemented.
>
> This patch creates a new object AudioMonitorAndroid and
> attaches it to MediaWebContentsObserver. The AudioMonitorAndroid
> maintains the audible state for the tab. It receives notifications
> from MediaPlayerAndroid objects and sends the resulting
> notification to the WebContents.
>
> BUG=414810
>
> Committed: https://crrev.com/6ad356d3e845ed9b67c5fb799b2ee8290f317268
> Cr-Commit-Position: refs/heads/master@{#318823}

TBR=qinmin@chromium.org,sievers@chromium.org,tedchoc@chromium.org,aurimas@chromium.org,timav@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=414810

Review URL: https://codereview.chromium.org/972973002

Cr-Commit-Position: refs/heads/master@{#318862}