- 17 Jun, 2014 40 commits
-
-
sigbjornf@opera.com authored
R=haraken@chromium.org BUG= Review URL: https://codereview.chromium.org/342463002 git-svn-id: svn://svn.chromium.org/blink/trunk@176320 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aandrey@chromium.org authored
BUG=381470 R=yurys@chromium.org, pfeldman@chromium.org, vsevik, yurys Review URL: https://codereview.chromium.org/321113005 git-svn-id: svn://svn.chromium.org/blink/trunk@176318 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
R=aandrey@chromium.org, yurys@chromium.org, aandrey Review URL: https://codereview.chromium.org/332173004 git-svn-id: svn://svn.chromium.org/blink/trunk@176317 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
Recently protocol was changed, but invocation remained unchanged. BUG=245436 TBR=vsevik@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/336393002 git-svn-id: svn://svn.chromium.org/blink/trunk@176316 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
The method allows to avoid direct access to implementation specific RecordType enum. BUG=361045 R=loislo@chromium.org Review URL: https://codereview.chromium.org/342473003 git-svn-id: svn://svn.chromium.org/blink/trunk@176314 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/341493002 git-svn-id: svn://svn.chromium.org/blink/trunk@176312 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
haraken@chromium.org authored
This CL broke browser_tests (WebSocket2): http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/8151 > [WebSocket] bufferedAmount should not decrease inside a task. > > The spec says that bufferedAmount must not decrease in the task that > send() is called. > Fixed both the new and the old implementation although the old implementaion > is at any rate broken (bufferedAmount in the old implementation includes > the protocol overhead). > > BUG=159563 > > Review URL: https://codereview.chromium.org/311993006 TBR=yhirano@chromium.org Review URL: https://codereview.chromium.org/338243006 git-svn-id: svn://svn.chromium.org/blink/trunk@176311 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
haraken@chromium.org authored
This broke browser_tests (WebSocket2): http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/8151 > ThreadableWebSocketChannelClientWrapper don't need suspend / resume code. > > As the WebSocket class handles suspend / resume, we can remove the suspend / > resume code from ThreadableWebSocketChannelClientWrapper. > > BUG=384238 > R=tyoshino > > Review URL: https://codereview.chromium.org/333223002 TBR=yhirano@chromium.org Review URL: https://codereview.chromium.org/338343002 git-svn-id: svn://svn.chromium.org/blink/trunk@176310 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
haraken@chromium.org authored
This broke webkit_unit_tests in Android bots: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14135 > Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled. > > The content should take total window width while overlay-scrollbar is enabled. > > BUG=382900 > > Review URL: https://codereview.chromium.org/333633003 TBR=sanjoy.pal@samsung.com Review URL: https://codereview.chromium.org/338993005 git-svn-id: svn://svn.chromium.org/blink/trunk@176309 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
R=lushnikov Review URL: https://codereview.chromium.org/339853003 git-svn-id: svn://svn.chromium.org/blink/trunk@176308 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
wibling@chromium.org authored
When doing tracing across threads I hit an assert due to tracing the SMILTimeContainer's hashmap from a different thread than the one it was allocated on. Basically in HashTable's trace method we call isEmptyOrDeletedBucket which ends up calling PairHashTraits::emptyValue which makes a pair<WeakMember<SVGElement>, QualifiedName> initialized with the individual empty values. This causes the nullQName to be copied to the new pair which causes a ref() in RefCountedBase hitting ASSERT(m_verifier.isSafeToUse()). With this change all global or static local QualifiedNames are ignoring ref counting. This is similar to the way StringImpl works. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG= Review URL: https://codereview.chromium.org/311803003 git-svn-id: svn://svn.chromium.org/blink/trunk@176307 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
This CL removes dependency on WebInspector.TimelineModel.RecordType as underlying implementation may use tracing events in which case coalescable types should be from WebInspector.TracingTimelineModel. BUG=361045 Review URL: https://codereview.chromium.org/336373002 git-svn-id: svn://svn.chromium.org/blink/trunk@176306 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
1) fix inlined DataGrid columns widths 2) fix left border 3) do not show corner column BUG= Review URL: https://codereview.chromium.org/334183003 git-svn-id: svn://svn.chromium.org/blink/trunk@176305 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kochi@chromium.org authored
No visible change, test expectation change is expected. Scope of styles in shadow tree used to be its shadow host for ease of checking the style against :host etc. This caused code complexity for checking against boundary breaking CSS selector rules (e.g. ::content, /deep/). Changing the scope to its shadow root will simplify some condition checks. This is a step towards fixing issue 355674. BUG=355674 TEST=pass all layout tests Review URL: https://codereview.chromium.org/313303002 git-svn-id: svn://svn.chromium.org/blink/trunk@176304 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yhirano@chromium.org authored
As the WebSocket class handles suspend / resume, we can remove the suspend / resume code from ThreadableWebSocketChannelClientWrapper. BUG=384238 R=tyoshino Review URL: https://codereview.chromium.org/333223002 git-svn-id: svn://svn.chromium.org/blink/trunk@176303 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
R=lushnikov Review URL: https://codereview.chromium.org/334313002 git-svn-id: svn://svn.chromium.org/blink/trunk@176302 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
The flakiness is caused by unpredictable order of stylesheets binding in InspectorCSSAgent. This patch replaces HashSet with Vector to make sure the order is maintained. R=lushnikov Review URL: https://codereview.chromium.org/339133002 git-svn-id: svn://svn.chromium.org/blink/trunk@176301 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
svillar@igalia.com authored
Specs state in section 5.2.2 that explicitly adding named lines of the form <foo-start>/<foo-end> should effectively create a named grid area (named foo in this case). We got this for free in r174021 as a nice side effect of implementing the resolution for named grid lines. We just lack proper test coverage to ensure that we don't regress. Review URL: https://codereview.chromium.org/313263003 git-svn-id: svn://svn.chromium.org/blink/trunk@176300 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
Revert of Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. (https://codereview.chromium.org/333403004/) Reason for revert: This patch leaks svg-font-face-leak-document test http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg/svg-font-face-leak-document.html Original issue's description: > Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. > > BUG=357163 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176270 BUG=357163 Review URL: https://codereview.chromium.org/337703004 git-svn-id: svn://svn.chromium.org/blink/trunk@176299 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yhirano@chromium.org authored
The spec says that bufferedAmount must not decrease in the task that send() is called. Fixed both the new and the old implementation although the old implementaion is at any rate broken (bufferedAmount in the old implementation includes the protocol overhead). BUG=159563 Review URL: https://codereview.chromium.org/311993006 git-svn-id: svn://svn.chromium.org/blink/trunk@176298 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
This was introduced in r176205. BUG=None TBR=caseq Review URL: https://codereview.chromium.org/339873002 git-svn-id: svn://svn.chromium.org/blink/trunk@176297 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
acolwell@chromium.org authored
This change removes the "invalid media attribute" case from this test so that it passes on release builds. This test was passing for the wrong reasons on the Chromium waterfall because an error was being generated for MP4 not being supported instead of the invalid attribute. The test URL was changed to an Ogg file so that a supported media type will be used on both the Chrome and Chromium builds. BUG=338197 TESTS=LayoutTests/media/video-source-error-no-candidate.html Review URL: https://codereview.chromium.org/334353003 git-svn-id: svn://svn.chromium.org/blink/trunk@176296 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rego@igalia.com authored
From the grid layout spec we can extract the following sentence: "If the grid item has an automatic position and a grid span for a named line in a given dimension, instead treat the grid span as one." The main reason is that as you don't know where the item is going to be placed (because of it's auto-positioned), spanning to a particular line makes no sense. Updated GridResolvedPosition code to include this restriction when resolving positions. Adapted auto-placement algorithm implementation in RenderGrid as now it's possible to pass row and column spans to GridIterator::nextEmptyGridArea() simplifying the code. Updated layout test to the new behavior. BUG=353789 TEST=fast/css-grid-layout/grid-item-auto-placement-automatic-span.html Review URL: https://codereview.chromium.org/320093002 git-svn-id: svn://svn.chromium.org/blink/trunk@176295 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nbarth@chromium.org authored
The core:core_generated target previously needed many include_dirs in its path, due to unqualified include statements. These have been resolved, and now we can remove them! R=haraken BUG=377364 Review URL: https://codereview.chromium.org/340473002 git-svn-id: svn://svn.chromium.org/blink/trunk@176294 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
keishi@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/275043002 git-svn-id: svn://svn.chromium.org/blink/trunk@176293 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
bonus: sort expectations file TBR=dmikurube@chromium.org NOTRY=true BUG=364390 Review URL: https://codereview.chromium.org/334403004 git-svn-id: svn://svn.chromium.org/blink/trunk@176292 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/341433003 git-svn-id: svn://svn.chromium.org/blink/trunk@176291 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
and make m_mediaElement Member<>. BUG=357163 Review URL: https://codereview.chromium.org/339843002 git-svn-id: svn://svn.chromium.org/blink/trunk@176290 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
- added "all" property to CSSProperties.in and so on. - added "unset" CSSValue. "unset" is defined in all spec. all spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand BUG=172051 TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html Review URL: https://codereview.chromium.org/338023002 git-svn-id: svn://svn.chromium.org/blink/trunk@176289 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ksakamoto@chromium.org authored
In the latest editor's draft spec [1], FontFaceSet#ready has been changed from a method to an attribute. We are likely to deprecate ready() in favor of ready attribute. To prepare for a deprecation process, this patch adds a UseCounter for FontFaceSet#ready(). [1] http://dev.w3.org/csswg/css-font-loading/#dom-fontfaceset-ready BUG=380990 Review URL: https://codereview.chromium.org/339563006 git-svn-id: svn://svn.chromium.org/blink/trunk@176288 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
l.gombos@samsung.com authored
Review URL: https://codereview.chromium.org/334373004 git-svn-id: svn://svn.chromium.org/blink/trunk@176287 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
gyuyoung.kim@samsung.com authored
NavigatorContentUtilsClientImpl has been placed in ChromeClientImpl.cpp. It would be good if NavigatorContentUtilsClientImpl has own file, because new functions have been added to the NavigatorContentUtilsClientImpl. Besides more functionality will be added in future. BUG=none Review URL: https://codereview.chromium.org/331223002 git-svn-id: svn://svn.chromium.org/blink/trunk@176286 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
gnanasekar.s@samsung.com authored
Don't try to mimic IE's special hit-testing behavior for touch-action - it probably only adds confusion and is unlikely to cause compat issues in practice. See http://crbug.com/380203 for details. Also reduces the hit tests done on touchstart from 2 to 1 for improved performance. BUG=380203 Review URL: https://codereview.chromium.org/329773002 git-svn-id: svn://svn.chromium.org/blink/trunk@176285 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
Before this patch, static SVGPropertyTearOff items inserted into a SVGListTearOff were not marked as a tear-off. For such items, |svgAttributeChanged| was not dispatched to its context element, and view was not updated when its value changed. This patch fixes the issue by converting a static tear-off inserted into a list to a dynamic tear-off. Also this patch fixes an issue that a tearoff returned from replaceItem/removeItem was still attached to the list. BUG=380546, 380176 Review URL: https://codereview.chromium.org/321403004 git-svn-id: svn://svn.chromium.org/blink/trunk@176284 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yhirano@chromium.org authored
WebSocket::resume starts a timer which does the actual resume work when fired. WebSocket::suspend must stop the timer in case it is called while the timer is active. BUG=NONE R=tyoshino Review URL: https://codereview.chromium.org/330253002 git-svn-id: svn://svn.chromium.org/blink/trunk@176283 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
falken@chromium.org authored
If the document gets detached before Service Worker registration completes, the CallbackPromiseAdapter promise gets cleared. Then when registration completes, ServiceWorker::from is passed the resolver with the empty promise. Before this patch, an assert would then occur because ScriptPromise::then bails before adopting its fulfilled/rejected arguments. This patch fixes an overly aggressive assert in V8GarbageCollected and also makes ServiceWorker creation skip waiting on an empty promise. BUG=384498 Review URL: https://codereview.chromium.org/337053004 git-svn-id: svn://svn.chromium.org/blink/trunk@176282 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
Revert of Forbid creating new wrapper from SetWrapperReferenceTo (https://codereview.chromium.org/332643003/) Reason for revert: There seems to be an existing bug which hits this callpath. Reverting the change until the bug is fixed. Original issue's description: > Forbid creating new wrapper from SetWrapperReferenceTo > > SetWrapperReferenceTo IDL attribute is a hack to use V8 wrapper reference > to avoid reference cycles in Blink. The |visitDOMWrapper| callback is > used to create a temporary strong reference between the wrappers in GC > prologue. > > Before this patch, |visitDOMWrapper| was allowed to create a new wrapper > if the wrapper for target object didn't exist. However this is dangerous, > as the target object may be already destructed. The target wrapper must > already exist for this reference hack to work correctly. > > This patch forbids creating a new wrapper from |visitDOMWrapper| callback, > and adds an ASSERT that checks that the target object wrapper already > exists. > > BUG=None > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175998 TBR=nbarth@chromium.org,haraken@chromium.org BUG=384459 Review URL: https://codereview.chromium.org/332183008 git-svn-id: svn://svn.chromium.org/blink/trunk@176281 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
m_fontElement is a parent element. It's ok to use a strong reference. BUG=357163 Review URL: https://codereview.chromium.org/338213004 git-svn-id: svn://svn.chromium.org/blink/trunk@176280 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tyoshino@chromium.org authored
R=haraken,sof BUG=none Review URL: https://codereview.chromium.org/338833002 git-svn-id: svn://svn.chromium.org/blink/trunk@176279 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ksakamoto@chromium.org authored
When the font name passed to check() does not match any font face in the FontFaceSet, current implementation always returns true. As per the latest spec draft [1], it should return true if it matches platform font name, otherwise false. [1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-check BUG=378989 TEST=fast/css/fontfaceset-check-platform-fonts.html Review URL: https://codereview.chromium.org/324293003 git-svn-id: svn://svn.chromium.org/blink/trunk@176278 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-