GitLab

It seems the roll broke Android tests, see crbug.com/463436.

Also, fix common.gypi to add a dependency on the Clang version when
host_clang is set. We think this might be the reason the breakage
didn't show on trybots when the roll landed: the host binaries
weren't recompiled with the new Clang version.

BUG=444089, 463436
NOTRY=true
NOPRESUBMIT=true
TBR=jln, jbauman

Review URL: https://codereview.chromium.org/976833002

Cr-Commit-Position: refs/heads/master@{#318940}

BUG=417532

Review URL: https://codereview.chromium.org/957183002

Cr-Commit-Position: refs/heads/master@{#318939}

The extensions::Dispatcher::is_extension_process flag is set for both the
standalone extensions renderer and single process mode. This caused
ChromeContentRendererClient to act differently in single process mode, like
returning true from ShouldFork for any navigation started by blink, which
would cause a new WebView to be created for each navigation.

BUG=462210

Review URL: https://codereview.chromium.org/956313002

Cr-Commit-Position: refs/heads/master@{#318938}

BUG=428842

Review URL: https://codereview.chromium.org/976493003

Cr-Commit-Position: refs/heads/master@{#318937}

BUG=458541

Review URL: https://codereview.chromium.org/974633002

Cr-Commit-Position: refs/heads/master@{#318936}

BUG=463552

Review URL: https://codereview.chromium.org/977583003

Cr-Commit-Position: refs/heads/master@{#318935}

Update LED state in kernel in InputControllerEvdev::SetCapsLockEnabled.
This is currently the only way to toggle caps lock.

BUG=463242
TEST=plug in external keyboard on link_freon & press caps lock. Light on
  keyboard should turn on.

Review URL: https://codereview.chromium.org/971753006

Cr-Commit-Position: refs/heads/master@{#318934}

CL https://codereview.chromium.org/950223002 did not move all the densities
of ic_warning.png to components/

BUG=458328
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/970113003

Cr-Commit-Position: refs/heads/master@{#318933}

This file is not supposed to be part of libgtest but in its
own library called libgtest_main.a.  Its also fairly
useless right now in the context of PPAPI (all our gtest
examples currently use ppapi_simple and define their own
entry point).  In the long run we could re-enable this
if it becomes useful, but really we should probably just
remove the gtest libraries from the SDK completely since
shipping gtest in library form is not recommended practice.

Review URL: https://codereview.chromium.org/958233004

Cr-Commit-Position: refs/heads/master@{#318932}

This patch is just a small refactor with a few more comments explaining
what this function is meant to do. I've been confused in the past when
trying to remember what this function does, so hopefully this helps...

R=danakj, enne

Review URL: https://codereview.chromium.org/973713002

Cr-Commit-Position: refs/heads/master@{#318931}

BUG=450050

Review URL: https://codereview.chromium.org/975453003

Cr-Commit-Position: refs/heads/master@{#318930}

BUG=internal b/19212285
R=lcwu@chromium.org

Review URL: https://codereview.chromium.org/961993006

Cr-Commit-Position: refs/heads/master@{#318929}

This CL reduces unnecessary work in StatusBubbleMac and replaces it with some
DCHECKs to verify invariants.  (The invariant here is that we set
kWindowSizeDeterminedLater once, when state is set to kBubbleHidden, and the
size stays that way until the bubble transitions to a different state.  If that
invariant holds, then we don't need to constantly re-set the size for a hidden
bubble.)

BUG=None
TEST=No visible impact.  Status bubble should continue to show, expand, and hide properly.

Review URL: https://codereview.chromium.org/968263005

Cr-Commit-Position: refs/heads/master@{#318928}

The code in [DownloadItemController showDangerousWarning:] calls
[GTMUILocalizerAndLayoutTweaker sizeToFitFixedHeightTextField:minWidth:]
to wrap the warning string within the DownloadItemController's
dangerousDownloadLabel_ textField. Within the nib this textField is 22
points tall and holds two lines of text. Under Yosemite, however, the
font metrics have changed and the two lines are now 24 points tall.

This cl insets the dangerousDownloadLabel_'s frame height by -2 points
when running on Yosemite. dangerousDownloadLabel_ is not as tall as its
superview, so the new frame still fits comfortably within the superview's
frame.

BUG=454782
TEST=Follow instructions in bug 454782 and confirm that text is wrapping
properly on Yosemite.

Review URL: https://codereview.chromium.org/911303002

Cr-Commit-Position: refs/heads/master@{#318927}

A telemetry test that checks for "q=low" in the Chrome-Proxy
request header and verifies that the image received was less than 100 bytes.

BUG=449665

Review URL: https://codereview.chromium.org/942863004

Cr-Commit-Position: refs/heads/master@{#318926}

Have BluetoothAdapterProfileChromeOS remove itself from adapters when it
is deleted via it's deconstructor, to avoid references being left behind
after deletion.

BUG=457978

Review URL: https://codereview.chromium.org/935383003

Cr-Commit-Position: refs/heads/master@{#318925}

This is necessary because GN's exec_script only runs Python scripts.

This was requested by Nico in https://codereview.chromium.org/971593003/.

BUG=462972
TEST=run ./tools/clang/scripts/plugin_flags.py and compare the output
with the bash version. They should be exactly the same.
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/966723003

Cr-Commit-Position: refs/heads/master@{#318924}

The flag for specifying the URL for the Data Saver secure proxy check
was changed in https://codereview.chromium.org/961983002/. This change
makes the relevant integration test use the new flag value, and also
makes the test restart after each page.

BUG=463210

Review URL: https://codereview.chromium.org/971073002

Cr-Commit-Position: refs/heads/master@{#318923}

Since DefaultRendererFactory uses GPU factories, code that instantiates
the default factory need to include GPU factories headers and need to be
able to instantiate them as well, so moving the GPU factories (both the
mock and the real one) to media/renderers/ to make deps easier.

BUG=457959

Review URL: https://codereview.chromium.org/970023002

Cr-Commit-Position: refs/heads/master@{#318922}

BUG=462072

Review URL: https://codereview.chromium.org/964723003

Cr-Commit-Position: refs/heads/master@{#318921}

BUG=463150
TEST=manual

Committed: https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7
Cr-Commit-Position: refs/heads/master@{#318866}

Review URL: https://codereview.chromium.org/973003002

Cr-Commit-Position: refs/heads/master@{#318920}

BUG=462299

Review URL: https://codereview.chromium.org/972143002

Cr-Commit-Position: refs/heads/master@{#318919}

BUG=444697

Review URL: https://codereview.chromium.org/965953002

Cr-Commit-Position: refs/heads/master@{#318918}

The current mechanism is to create an instance of DataReductionProxyParams
inside of page_load_histogram, and to then check the proxy server inside of
DocumentState against DataReductionProxyParams. However, the plan is to make
the configuration dynamic, so we can no longer use DataReductionProxyParams.

BUG=452773

Review URL: https://codereview.chromium.org/966443002

Cr-Commit-Position: refs/heads/master@{#318917}

BUG=

Review URL: https://codereview.chromium.org/976673002

Cr-Commit-Position: refs/heads/master@{#318916}

ES6 makes the function name property configurable, which
means that __defineGetter__ will add a getter and not
silently fail like before.

This change is in preparation of landing this feature in
V8.

BUG=463526
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/971343003

Cr-Commit-Position: refs/heads/master@{#318915}

BUG=358315

Review URL: https://codereview.chromium.org/926703002

Cr-Commit-Position: refs/heads/master@{#318914}

BlinkPlatformImpl currently creates an instance of WebThreadImpl when blink
creates a thread using 'createThread()'. When some code runs in the newly
created thread and tries to get hold of the WebThread that represents the
current thread using 'currentThread()', BlinkPlatformImpl creates a new
instance of a WebThreadImplForMessageLoop and returns that. For subsequent
calls to 'currentThread()', this same WebThreadImplForMessageLoop is
returned. So BlinkPlatformImpl ends up creating two WebThread instances
for each thread created in blink.

This patch changes this to only create a single instance of WebThread for
each thread created in blink. WebThreadImplForMessageLoop is no longer
necessary, so it is removed.

BUG=462067

Review URL: https://codereview.chromium.org/959803003

Cr-Commit-Position: refs/heads/master@{#318913}

BUG=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/973073002

Cr-Commit-Position: refs/heads/master@{#318912}

The NSFont object could be nil, which would have a NULL font name, which when
converted to a std::string would cause a crash. The font name is already in the
FontDescriptor, so it's entirely unnecessary.

BUG=452651
R=avi@chromium.org

Review URL: https://codereview.chromium.org/969683003

Cr-Commit-Position: refs/heads/master@{#318911}

Before this change a malformed value of RemoteAccessHostUdpPortRange policy
(i.e. "123456-blah") was ignored and a default value was used.  Similarily for
the 3 third-party-auth-config policies (RemoteAccessHostTokenUrl,
...TokenValidationUrl and ...TokenValidationCertificateIssuer) we were falling
back to a secure default, but not reporting a policy error.  After this change
such malformed values will trigger an OnPolicyError callback.

Notes:
- Guaranteeing that PolicyWatcher always returns valid policy values, removes
  the need for a "rejecting" Me2MeHostAuthenticatorFactory.
- Moving PortRange and ThirdPartyAuthConfig to separate compilation units
  helps readability elsewhere + encourages better unit tests coverage.
- Initially I tried to wrap all policies in a new ChromotingPolicies class,
  but eventually went back to prevalidating and passing base::DictionaryValue.
  - Arguments for using ChromotingPolicies:
    - Helps avoid overtesting in policy_watcher_unittests.cc (i.e. helps focus
      the tests on a single policy value).
  - Arguments for using base::DictionaryValue:
    - Minimizes changes.
    - Keeps things simple (as opposed to having to introduce a custom
      equivalent of optional<T> [nothing similar present in Chromium AFAICT]).
  - Neutral:
    - Strong-typing of ChromotingPolicies didn't help readability as much as I
      expected and hoped for.

BUG=427513
TEST=remoting_unittests

Review URL: https://codereview.chromium.org/966433002

Cr-Commit-Position: refs/heads/master@{#318910}

MemoryPressureListener.

BUG=447208
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/971413002

Cr-Commit-Position: refs/heads/master@{#318909}

This cl reverts a change made in

https://codereview.chromium.org/952823004

Since this code is controlling the display of the zoom icon (not
the bubble) we should not hide when not at default zoom level.

BUG=462482

Review URL: https://codereview.chromium.org/968213003

Cr-Commit-Position: refs/heads/master@{#318908}

EnhancedBookmarksModel(int) is never used and should be removed.

BUG=458632

Review URL: https://codereview.chromium.org/968383002

Cr-Commit-Position: refs/heads/master@{#318907}

Speculative fix for unit tests failure -- sometimes calling -removeVisits will
call back into history.js with -deleteComplete before |deleteCompleteCallback_|
has been set.

BUG=452893

Review URL: https://codereview.chromium.org/970213002

Cr-Commit-Position: refs/heads/master@{#318906}

BUG=462153

Review URL: https://codereview.chromium.org/969383004

Cr-Commit-Position: refs/heads/master@{#318905}

TEST=./tools/valgrind/chrome_tests.sh -t cmdline -- echo "hello"

Review URL: https://codereview.chromium.org/966363003

Cr-Commit-Position: refs/heads/master@{#318904}

Also adds a simple service to allow layout tests to test all this.

This is part of a series of changes:
[1/5] Blink side changes in https://codereview.chromium.org/924983002/ that expose a needed v8 context
[2/5] https://codereview.chromium.org/921013002/ allow MessagePort to send messages as values
[3/5] https://codereview.chromium.org/944443003/ which causes the send_messages_as_values flag to be propagated
[4/5] This CL
[5/5] https://codereview.chromium.org/940423004/ adds layout tests to blink to test these new features

BUG=426458

Review URL: https://codereview.chromium.org/938403005

Cr-Commit-Position: refs/heads/master@{#318903}

Also remove nduca@ as he's moved on to bigger and better things.

TBR=nduca@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/961003003

Cr-Commit-Position: refs/heads/master@{#318902}

Cherry pick the HarfBuzz commit 8ac345e5c0ed0aad6547592ea0839aabfb4ba980
as it fixes a set of serious shaping regressions in the core text shaper
on Mac OS. Cherry picking as opposed to rolling to allow for a clean DI.

BUG=459043
TBR=behdad@chromium.org

Review URL: https://codereview.chromium.org/971153002

Cr-Commit-Position: refs/heads/master@{#318901}