GitLab

While preparing a refactoring of AccountTracker, I noticed that this
unittest is not doing what its name says it's doing; rather, it's just
a copy of the unittest above it. This CL changes the test to match
the name (as best as I could infer the intent of the test from the
name).

Change-Id: I46d809c1fa9d786688ddca82641f3df4d96c5821
Reviewed-on: https://chromium-review.googlesource.com/1142776
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577157}

A small tweak to the spring damping ratio for the new tab animation, which ensures that the spring effect doesn't show a black hairline on an iPhone X.

Bug: 851872
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b6769f9d4b124e332efddf2f9602b4665d7aca8
Reviewed-on: https://chromium-review.googlesource.com/1146640Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577156}

Replace an error with a prompt warning to gracefully handle false
positives when the patch touches existing code.

R=haraken@chromium.org
CC=​hajimehoshi@chromium.org,farahcharab@chromium.org

Change-Id: I979f1b72dd515b30df5aac97e47e6cad8b3400f6
Reviewed-on: https://chromium-review.googlesource.com/1146720Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577155}

The overall goal is to prevent storing the result of calls to
context#getApplicationContext. We previously removed them all, but more have
snuck in since.

Bug: 846456
Change-Id: I6ff008b75a3980cc2db770ea42a18b9ee3669cae
Reviewed-on: https://chromium-review.googlesource.com/1082666Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577154}

This reverts commit 574add02.

Reason for revert: network_service_browser_tests / DevToolsFrontendInWebRequestApiTest.HiddenRequests times out most of the time

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=DevToolsFrontendInWebRequestApiTest.HiddenRequests

Original change's description:
> Reset URLLoaderFactory bindings for web request proxy
> 
> Previously, if a request was made before any web request listeners or
> rules were added, the URLLoaderFactory would not be proxied through the
> browser process to run the WebRequest code. Now, if it is detected that
> WebRequest listeners/rules are added, we reset the bindings so they will
> be recreated and proxied through the browser process.
> 
> Observers were added for a few classes so WebRequestAPI can listen to
> rule changes.
> 
> Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371.
> 
> Bug: 857577
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I7805be86512545b496e30b9693374981fdc2633e
> Reviewed-on: https://chromium-review.googlesource.com/1139048
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577036}

TBR=kinuko@chromium.org,rockot@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 857577
Change-Id: I1c70daaa63107ac1527755b3d94e0fe61cb49ae8
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1146541Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577153}

Change-Id: Ide25550f5db4b0d64edd767059cfd89fb2833d85
Reviewed-on: https://chromium-review.googlesource.com/1145233Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577152}

Thanks to recent works that make network APIs (fetch, importScripts, WebSocket,
etc) off-the-main-thread, the shadow page is now used only for fetching the
top-level classic script. Therefore the shadow page no longer needs CSP and
referrer policy for subresource fetch.

This change is useful for deprecating the shadow page.

Bug: 538751
Change-Id: Id192a17068de0e3a20f08cbe9ba2463bc56ffb1f
Reviewed-on: https://chromium-review.googlesource.com/1098427
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577151}

Add an api for clearing the GeneratedCodeCache.

Bug: chromium:812168
Change-Id: Iba8fb3c81e8bed04573ed0cd4dabf4af31ea0c21
Reviewed-on: https://chromium-review.googlesource.com/1114974
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577150}

https://webrtc.googlesource.com/src.git/+log/0c3ad73948e4..94ef424b3160


git log 0c3ad73948e4..94ef424b3160 --date=short --no-merges --format='%ad %ae %s'
2018-07-23 mbonadei@webrtc.org Enable clang::find_bad_constructs for examples/androidnativeapi.


Created with:
  gclient setdep -r src/third_party/webrtc@94ef424b3160

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I813a82c05560d3fcc05bf9d0b5c989573f3faf84
Reviewed-on: https://chromium-review.googlesource.com/1146600Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577149}

Background Fetch introduced a new way to select icons (Bug: 813564)

However, now that we have udpated our spec and code to use ImageResource
instead of IconDefinition to represent icons, we should reuse the Web Manifest's
icon selection code here.

This is the second step towards that.

Bug: 860507
Change-Id: I1e8795f8768610e22002a9a87b0c7bf8c33f9d0b
Reviewed-on: https://chromium-review.googlesource.com/1128086
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577148}

This change was dropped from
https://chromium-review.googlesource.com/c/chromium/src/+/1102505 due to
a bad merge. Add it back.

R=eseckler@chromium.org
BUG=806271

Change-Id: I6dc5f83cfe61ccbad3069e7d194c1dc494909ff9
Reviewed-on: https://chromium-review.googlesource.com/1145437Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577147}

WebSockets on workers now run off the main thread. This CL removes unused
on-the-main-thread code for cleanup.

Bug: 825740
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5cf5b846e6099067d2da9b8b90de157e09020d7c
Reviewed-on: https://chromium-review.googlesource.com/1146134Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577146}

This change cleans up the password list sorting logic by removing the
PasswordEntryType enum. This two state enum added no value, as the same
information was already stored on the PasswordForm itself in the form of
`blacklisted_by_user`. This change cleans up the interface of
CreateSortKey() and SortEntriesAndHideDuplicates().

Bug: 778146
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I883a5945168b569cdf1d6312f5e5d2eab4fb2ba5
Reviewed-on: https://chromium-review.googlesource.com/1143384Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577145}

When sync is paused, i.e. the user is in an auth error, the
syncSetup page now has a button to sign in again to resolve
the error.

Mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr664Bt8FBOxWEyjSSOyFCbW0

Bug: 856210
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iab413fb69fcabff076f3c48d3b828dea05df6229
Reviewed-on: https://chromium-review.googlesource.com/1138619
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577144}

This CL does not solve the bug, but it adds instrumentation that could help us
understand if Chromium sends the Desktop Identity Consistency headers for
requests that are sent to Gaia.

Bug: 865941
Change-Id: I868394f7b23390b87494b26c49e2f8ac13a21795
Reviewed-on: https://chromium-review.googlesource.com/1145263
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577143}

CLEAR_DATA is what's typically used in practice, and KEEP_DATA is a
weird concept anyway.

Bug: 860482
Change-Id: Ia3d15463a03f947db19d08ebfd035299ee566eaf
Reviewed-on: https://chromium-review.googlesource.com/1146572Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577142}

This CL turns off Safe Browsing Extended Reporting when the user clears
the primary account.

Bug: 865526
Change-Id: I92f42f1ae1e24e0948db00848e17cd6b61c2c4e3
Reviewed-on: https://chromium-review.googlesource.com/1146573Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577141}

Bug: 812553
NOPRESUBMIT=true

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8522ebbc147afd0d39b85cda1545ef526d037e44
Reviewed-on: https://chromium-review.googlesource.com/1128890
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577140}

Bug: 865408
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I43ace7047750f8754cf6882d35fd598c3fffda3a
Reviewed-on: https://chromium-review.googlesource.com/1146209Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577139}

Originally the webview content was always set to clickable but after
http://crrev.com/551479 it wasn't. This CL restores original behaviour.

Also adds a test to ensure this remains true in the future.

Bug: 857427
Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e
Reviewed-on: https://chromium-review.googlesource.com/1127951Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577138}

Random failures encountered so far can be reproduced by compiling
third_party/blink/renderer/bindings/core/v8:testing target on clean repo.

Change-Id: If92737cdfdc6f12533776b6ded935ac1a2689137
Reviewed-on: https://chromium-review.googlesource.com/1127040
Commit-Queue: Marek Haranczyk <mharanczyk@opera.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577137}

This CL fixes what caused the revert in commit bed2f341.

(No TBRs because the original is quite old)

Original change's description:
> Revert "Clear password search on X and close it with back button"
> 
> This reverts commit dcb5b1f4.
> 
> Reason for revert:
> Regressed on some devices. Failure reason is not obvious enough for confident immediate fix.
> 
> Bug: 834676
> 
> Original change's description:
> > Clear password search on X and close it with back button
> > 
> > Right now, clicking the X button in the search will close it.
> > To start a new search, you have to open a new search.
> > That experience isn't very discoverable, so UX developed an improved
> > workflow - details in the bug.
> > 
> > The new flow needs these changes:
> > - the X button _only_ clears the query text field now
> > - the X button is _only_ available when a query was entered
> > - closing the search happens only via the "navigate up" button
> >   in the action bar.
> > - the three-dots overflow menu is hidden while a search is active
> >   (already the case on small screens - now large screens do the same)
> > 
> > Tests cover all of these cases.
> > 
> > Bug: 821755
> > Change-Id: Ieb2e16c096750d66874aa4c4999759629332491b
> > Reviewed-on: https://chromium-review.googlesource.com/966070
> > Reviewed-by: Theresa <twellington@chromium.org>
> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#550955}
> 
> TBR=twellington@chromium.org,fhorschig@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 821755
> Change-Id: I9035e5aed91dca19bcff94e195cf060ef61f2b29
> Reviewed-on: https://chromium-review.googlesource.com/1019150
> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552101}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 834676, 821755, 864607
Change-Id: I7afbcd0022a84a10c13b89f7538f63105ab04e52
Reviewed-on: https://chromium-review.googlesource.com/1143204Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577136}

This patch is fixing change made with the
https://chromium-review.googlesource.com/c/chromium/src/+/1097408.

Before patch: ContentSettingException permissions are not displayed.

After patch: ContentSettingException are visible.

Affected path: Settings->Site Settings->(setting)->(exception site)

BUG=865032

Change-Id: I35dffa8c071fae4f4e76c69850b542b747dc493e
Reviewed-on: https://chromium-review.googlesource.com/1145434Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#577135}

This is one of the tricky parts of service worker code, and its role has
changed after various changes over the years.

There is no longer such thing as a "new registration" associating
with a provider host. Association happens only during:
1) main resource requests in ServiceWorkerControlleeRequestHandler
2) claim() in ServiceWorkerRegistration.

There is no need for ServiceWorkerControlleeRequestHandler to defend
against itself. So claim() is the only thing to defend against.

So the whole point of it is to stop claim() from claiming provider
hosts that are still undergoing their main resource request. This
should be the same thing as |is_execution_ready_|. But
unfortunately there is still edge cases/trickiness around
shared workers and about:blank iframes. Add some comments and
revisit after NetS13nServiceWorker.

Change-Id: I508f13c52fc30aa40776e17d4966ff05c0c57e14
Bug: 866353
Reviewed-on: https://chromium-review.googlesource.com/1146414
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577134}

This reverts commit 81626592.

Reason for revert: MetricsOnlyFromUILoops test appears to be flaky (see https://crbug.com/866299).

Original change's description:
> [MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread
>
> Addresses crbug.com/860801 in time for the M69 branch while keeping the
> diagnosis signals which will be used to assess future improvements
> (MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is).
>
> Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've
> learnt everything we needed from this one, that is :
> We now know that while 99% of tasks are posted with a delay under 30s,
> 95% of users post at least one task in every portion of the 0ms-3hours
> range at least once per day:
> https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
>
> Removed MessageLoop.ScheduledSleep.* metrics as we've also
> learnt what we wanted from it, that is :
> The maximum sleep a MessageLoop ever completes is 1 hour (and
> even then 99% of completed sleeps are under 1 second), all
> longer delays are reliably always interrupted.
> Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
>
> Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle
> but it appears to be broken on MacOSX (prior to this CL). Added a note
> to investigate on the metric but it shouldn't block this CL which
> doesn't make it worse.
>
> R=​kylechar@chromium.org, rkaplow@chromium.org
>
> Bug: 860801, 850450, 786597
> Change-Id: I7a693886ab4e1b9c8e9fbe8a64d906a95019a609
> Reviewed-on: https://chromium-review.googlesource.com/1142589
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576686}

TBR=gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org

Bug: 860801, 850450, 786597, 866299
Change-Id: I848621acf9ddbec69d72649d16a459910ffa937e
Reviewed-on: https://chromium-review.googlesource.com/1146300
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577133}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6018c94b02d241c416d14fb7431aea912524d8f5
Reviewed-on: https://chromium-review.googlesource.com/1137826Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577132}

EXPECT_CALL(...).WillRepeatedly(...) doesn't actually set up any
expectation, only a default return value. That's what ON_CALL is for.

Bug: none
Change-Id: I26ff25929f191e29651f0c1eb69e1785f2e40441
Reviewed-on: https://chromium-review.googlesource.com/1145062
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577131}

This patch introduces weak member callback in |DocumentMarkerController| to
detect empty weak hash map |markers_| to avoid unregistering mutation observer
during mutation callback.

This patch is follow-up of the patch[1].

[1] http://crrev.com/c/1137988 Blink Editing: Workaround unsafe iteration in
DocumentMarkerController.

TBR=jbroman@chromium.org

Bug: 862960
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Icd6acfed2ca00dabc4ed79959df2fdf0bd6fce4b
Reviewed-on: https://chromium-review.googlesource.com/1143113Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577130}

Public Session startup UI should be updated according to attached mocks (see
linked bug) in order to highlight possible MITM certs that might be installed
by device admin.

Bug: 862078
Change-Id: I50a1bed05bdc4966932c5649eb62e5dc5a6f861a
Reviewed-on: https://chromium-review.googlesource.com/1142145
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577129}

Adding shik@ and hywu@ as owners of Chrome OS Video Capture.

R=wuchengli

Bug: None
Change-Id: I3ea88421720ea252ea1d74fb3bf0e63d0fec5327
Reviewed-on: https://chromium-review.googlesource.com/1146124Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577128}

When deleting with an EmptyBlacklist filter, we shouldn't create a
Network deletion filter to properly use optimized "delete all" code paths.

Bug: 843995
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ifc84f403dc2f2b50471e7fab273d20ebcba3f4f4
Reviewed-on: https://chromium-review.googlesource.com/1068736Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577127}

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_browser_tests&tests=ResourceLoadingHintsBrowserTest.ResourceLoadingHints

TBR=tbansal

Bug: 866212
Change-Id: Ie4e1ff6848b2b28d7daf98a74057296a6de2a5df
Reviewed-on: https://chromium-review.googlesource.com/1146532Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577126}

Wait for IPC propagation to ensure the tests do not try to navigate
before the beforeunload handler registration has informed the browser.
Also, use a navigation instead of a reload to avoid ending up back at
the page with a beforeunload handler during shutdown, causing shutdown
to be blocked by a beforeunload dialog.

TBR=rdevlin.cronin@chromium.org

Bug: 866209
Change-Id: Id7c34e7a371f10f05297ea6cd3e3addeef75a49b
Reviewed-on: https://chromium-review.googlesource.com/1146528Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577125}

The frame's initialization code focuses the content from browser
process via an IPC (browser->renderer), but its handling in the
renderer can be delayed until after the test code script execution
is started.

This caused the test to have a race condition, that a focus event
is delivered where it is not expected, and resulted the flakiness.
The test can fail on the initial use of content_shell process.

Delay the execution of test function so that it will not be
affected by the frame initial focus event.

Bug: 863067
Change-Id: I475d912b0e9baffa3917212b2fc0735189381cb8
Reviewed-on: https://chromium-review.googlesource.com/1146523
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577124}

When DecoderStream<DemuxerStream::AUDIO> encounters a config change it needs to
do two things, among others: flush the decoder and reset the audio timestamp
validator. It's important that it does the latter only after processing any
decoder output produced during the flushing.

This CL moves the responsibility of resetting the validator from
DecoderStream to DecoderStreamTraits<DemuxerStream::AUDIO>. It also adds
a test where the decoder's behavior of releasing internally buffered
samples upon flushing is mocked.

Bug: 865926
Test: New test AudioBufferStreamTest.FlushOnConfigChange doesn't fail assertions. No regressions in media_unittests.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8cbb01df3792ca9de5db8ab637285d1e64188b39
Reviewed-on: https://chromium-review.googlesource.com/1145188Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#577123}

RenderProcessHostTest.KillProcessZerosAudioStreams flakes with an
indeterminate result. This CL hopes to make the test fail explicitly
instead as a way of debugging the test.

Sheriffs: This test was flaky before this CL. Instead of reverting
the CL, disable the test on Android and post a log in the bug.

Bug: 864476
Change-Id: I372bfa8f82245b9306554641fc56d651fd84dad9
Reviewed-on: https://chromium-review.googlesource.com/1145265Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577122}

When building using jumbo, files get merged and variables,
functions and defines could end up in the same scope and
conflict. This commit solves issues with includes and defines
for the mac specific part of chrome/browser/ui.

Bug: 803406
Change-Id: I55d1f6110a6144bc7ee3037a374d3e33c36a9879
Reviewed-on: https://chromium-review.googlesource.com/1144928Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#577121}

With this CL, CORSURLLoader only allows "http", "https" and "data"
schemes for CORS enabled requests. This CL adds a new error code,
kCORSDisabledScheme, for the error. As noted in the design doc[1],
no one updates the scheme list in Chromium, so it's safe to
assume url::GetCORSEnabledSchemes is equivalent to the
counterpart in blink::SchemeRegistry. We are planning to remove
blink::SchemeRegistry::RegisterURLSchemeAsSecure.

The existing xmlhttprequest/resources/cross-origin-unsupported-url.js
output relies heavily on the error output timing. This CL fixes the
test.

Because the error is reported asynchronously, console messages change
a bit (i.e., the line number doesn't show up). We accept that change.

1: https://docs.google.com/document/d/1JNmUcvbw2UcjfdI2uyUpveHXCbae-DQ1n8d_sVs5fLg/edit#heading=h.r9hjqrw3gn9e

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id49ad02e1413353e96c9fed1d0a84d34f0262fab
Reviewed-on: https://chromium-review.googlesource.com/1144903Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577120}

IsEngineInitialized can now be implemented in terms of GetState (as an
intermediate step before fully removing it). Moving the implementation
into the base class makes sure tests can't expose inconsistent state.

TBR=marq for ios/
who did say LGTM, but forgot to press "+1" :)

Bug: 839834
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I67b5174d4a0bdb0b286526a6deecfed58d01267f
Reviewed-on: https://chromium-review.googlesource.com/1141844
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577119}

This function was computing the right transform, and then applying it
to a temporary variable instead of the input.

TBR=fsamuel

Bug: 860344
Change-Id: I917b1ea2610b6edaaa43eb2d7abc6febbb44f0fc
Reviewed-on: https://chromium-review.googlesource.com/1146480Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577118}