- 01 Aug, 2018 40 commits
-
-
Kyle Milka authored
Missed the reference in local_ntp.js Bug: 869230 Change-Id: I50d9a991df8660592263abb79115bea5c484d756 Reviewed-on: https://chromium-review.googlesource.com/1157538Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579689}
-
Charlie Ma authored
long-press-back-new-design. Bug: 800033 Change-Id: Iaddb0816ea911669d2cc8c7ef6eb49d5c49d8d13 Reviewed-on: https://chromium-review.googlesource.com/1155976 Commit-Queue: Charlie Ma <charliema@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#579688}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1de8bd2ba3b..f4bf7fc35d83 git log c1de8bd2ba3b..f4bf7fc35d83 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2eb65034db71..ad63728be30d (6 commits) Created with: gclient setdep -r src/third_party/skia@f4bf7fc35d83 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Iecc506e52a0dc5e3aa0cfb88f9c0f6dd107e0dc6 Reviewed-on: https://chromium-review.googlesource.com/1157824Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579687}
-
Yao Xiao authored
A patch to CL 1140204 that's areadly merged in Bug: 863889 Change-Id: If16395f2becabbc49c372d88c98d3021f2c36868 Reviewed-on: https://chromium-review.googlesource.com/1157608Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#579686}
-
Fady Samuel authored
We would like to understand what happens to CompositorFrames in the wild. This UMA tracks whether Viz accepts the surface, or drops it due to some violation. This UMA records what violation has occurred if any. Bug: 865179 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I23cb97f64ac9905d35921fbded90de9577f32357 Reviewed-on: https://chromium-review.googlesource.com/1155471 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579685}
-
Bence Béky authored
Bug: 807724 Change-Id: I2c8ec3cabdd0f3b502d9dfccd8f72a0973330fa4 Reviewed-on: https://chromium-review.googlesource.com/1156852Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579684}
-
James Cook authored
We no longer have mash vs. classic configs in ash, and there's only one implementation of ShellPort. As a step towards eliminating ShellPort, remove the object factory methods from it. Keep CreatePointerWatcherAdapter for now because that will require more general PointerWatcher cleanup. Bug: 866523 Test: ash_unittests Change-Id: Iff2c3898932389ebc7eeb253ca4eb046da35e641 Reviewed-on: https://chromium-review.googlesource.com/1157688 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#579683}
-
Emil A Eklund authored
Further optimize ShapeResult::ComputeGlyphBounds by moving population of source glyphs vector to ComputeGlyphPositions thereby avoiding the extra iteration over all glyphs in ComputeGlyphBounds. Furthermore by changing SimpleFontData::BoundsForGlyphs to take a SkRect vector avoids one extra copy and one extra iteration. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib155ce1e069d5329c5fbc6a8850fc40736ee520b Reviewed-on: https://chromium-review.googlesource.com/1157271Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579682}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3895ea2a..c5287309 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I362b28a682974fda6ec2c7cb64e49e0ccb5f5984 Reviewed-on: https://chromium-review.googlesource.com/1157689Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579681}
-
Takuto Ikuta authored
Currently, compilation of simple chrome build is done like below. gomacc -> chromeos's compiler wrapper -> actual compiler binary But chromeos's compiler wrapper modifies some flags inside it before invoking actual compiler binary. This prevents goma from knowing some information for build cache sharing. To know all the flags passed to compiler binary, this change supports the way not using gomacc prefix. If we set has_gomacc_path = true, we don't prepend gomacc and lets compiler wrapper find gomacc from GOMACC_PATH env and invoke gomacc inside wrapper. By doing this, gomacc can know all the flags passed to compiler binary. This is a part of effort to share build cache between goma users for simple chrome build. chromite side change is https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1140099 BUG=chromium:846610 Change-Id: I84174b12a7f286d1b911f4d0a4e167883a4891c7 Reviewed-on: https://chromium-review.googlesource.com/1151040Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#579680}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/44d40fafd233..5c2d9e757a6f git log 44d40fafd233..5c2d9e757a6f --date=short --no-merges --format='%ad %ae %s' 2018-08-01 sadrul@chromium.org renderer: Add breakdown metrics for compositor pipeline. Created with: gclient setdep -r src/third_party/catapult@5c2d9e757a6f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855328 TBR=sullivan@chromium.org Change-Id: Ida622416b7b558f8dc6c5da778f6236a058259a3 Reviewed-on: https://chromium-review.googlesource.com/1157626Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579679}
-
Devlin Cronin authored
Update the logic used to partition permissions between granted and withheld with click-to-script. This patch addresses a few issues: - Previously, permissions granted with runtime host permissions were added to the active permissions entry in the ExtensionPrefs. This meant there was a chance that extensions would continue to be affected after the feature was disabled. - Previously, we would try to grant an entire origin to an extension, even if only a certain path was requested. This could result in a crash, since we later CHECK'd that all granted permissions were strictly contained within the withheld permissions of an extension. - The user should not need to specify an exact URLPattern at the chrome://extensions page in order to grant permission to an extension. That is, the user should be able to allow the extension on "google.com", rather than "google.com/some-specific-path-the-extension-specified". (This is dependent on the changes here, but will be fully resolved in a followup.) To fix this, we change runtime granted host permissions to only affect the runtime granted permissions preference (and not change active permissions in the preferences). When calculating permissions, we determine the set of permissions requested by the extension and intersect it with the permissions in the runtime granted permissions. This patch also allows extensions to be granted more permissions than they explicitly request. This means that if an extension requests only https://google.com/maps, it can be granted https://google.com/*. This is necessary for runtime host permissions, where permissions granted may be broader than explicitly requested. For security purposes, even though the granted permissions may exceed the requested permissions, the permissions active on the extension object (and in the extension process) will always be strictly bound by the requested permissions. To achieve this, we leverage the new intersection logic in URLPatterns introduced in https://crbug.com/867549. These two changes are interdependent (and cannot be submitted as two CLs) because by no longer adding runtime-granted permissions to the active permissions set, we introduce a need to find the semantic intersection of the runtime-granted permissions and the requested permissions. Otherwise, because of the way we partitioned permissions, we would not grant any permissions if an extension requested *://*/* and the user granted https://google.com/*. Bug: 867547 Change-Id: I161cc699c95989f86be5b1743aee422ac5b41221 Reviewed-on: https://chromium-review.googlesource.com/1153986 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579678}
-
Yoshifumi Inoue authored
This patch changes |SetSelectionToDragCaret()| to utilize early-return style to reduce indentation for improving readability. This is 3/3 of series of patches: 1. http://crrev.com/c/This patch 2. http://crrev.com/c/1153070 3. This patch Change-Id: Ib8c95fc4d027ce7633c9d69ef7bef0554503744c Reviewed-on: https://chromium-review.googlesource.com/1153071 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#579677}
-
Noel Gordon authored
Bug: 869240 Change-Id: Ie5350b73b21bf94912fea292261b4dea7382c511 Reviewed-on: https://chromium-review.googlesource.com/1157728 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#579676}
-
Hayato Ito authored
Fix links to *.{h,cc} files. TBR=rakina Bug: 742715 Change-Id: I13df9ba392405dfdba37d12279b98dccc35be1a2 Reviewed-on: https://chromium-review.googlesource.com/1157736Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#579675}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1aefad2a5982..6f812e132d25 git log 1aefad2a5982..6f812e132d25 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 ehmaldonado@chromium.org metrics: Separate metrics collection and print notice logic. Created with: gclient setdep -r src/third_party/depot_tools@6f812e132d25 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868280 TBR=agable@chromium.org Change-Id: I2372686119cd531c28d4aa1c947f20242b5493ba Reviewed-on: https://chromium-review.googlesource.com/1157485Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579674}
-
Matt Falkenhagen authored
This reverts commit 2dbd1cd1. Reason for revert: The crash still exists with or without the workaround on M70. Re-adding the workaround brings M69 and M70 to the same code, so that the future fix in M70 will be easy to merge to M69. Original change's description: > service worker: Remove workaround for ServiceWorkerObjectHost crash. > > Since issue 864731 was fixed in r576288, this workaround is no longer > needed. > > Bug: 854993 > Change-Id: I789dfb18cdb82ec51aa0ce5185586163c92269ec > Reviewed-on: https://chromium-review.googlesource.com/1147889 > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577435} TBR=falken@chromium.org,bashi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 854993 Change-Id: Idb68e5d11c8b14da4dfee6d2fb484cc13be72501 Reviewed-on: https://chromium-review.googlesource.com/1157665Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#579673}
-
Takuto Ikuta authored
This is for more than 30 mins compile steps like below builds. 3098s https://ci.chromium.org/b/8939533321978115792 2795s https://ci.chromium.org/b/8939589875030577488 2665s https://ci.chromium.org/b/8939589087341023936 2577s https://ci.chromium.org/b/8939542011766010016 Bug: 804251 Change-Id: I54121207009b07e65686c9415c0bc7f31e929e6c Reviewed-on: https://chromium-review.googlesource.com/1155277Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#579672}
-
Hayato Ito authored
Add "Slots and node assignments" section. TBR=rakina Bug: 742715 Change-Id: I4e5ad0da310c186643ce42695459a17d1a853654 Reviewed-on: https://chromium-review.googlesource.com/1157732Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#579671}
-
Kinuko Yasuda authored
This reverts commit 1edc413f. Reason for revert: the test added by this (CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget) has been super flaky on linux-chromeos-rel right after this was added. Some builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11360 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11361 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11363 Original change's description: > OopAsh: port/enable some more browser tests. > > Bug: 854704 > Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d > Reviewed-on: https://chromium-review.googlesource.com/1153777 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579476} TBR=sky@chromium.org,estade@chromium.org Change-Id: I33d224561923905ceaabe67a57cec6c78c0b104c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854704 Reviewed-on: https://chromium-review.googlesource.com/1157844Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579670}
-
Kinuko Yasuda authored
Looks like they're flaky (in viz_content_browsertests). TBR=niklase Bug: 869723 Change-Id: I8c2ea517fddfddb3f664107d0dc237fc3579c704 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1157733 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579669}
-
Takuto Ikuta authored
This is to generate reproducible binary between commits for Linux by giving use_dummy_lastchange=true in args.gn. This CL makes binaries independent from commit hash at least for below (time consuming) targets on Linux. * content_unittests * interactive_ui_tests * content_shell (for webkit_layout_tests) * content_browsertests * browser_tests If we can generate deterministic binary, test execution on build bot can be cached. And it will improve CQ cycle time. But we don't know how often we make changes not introducing functional change in binaries. So this CL is mainly for getting some stats from test on Linux buildbot and evaluate whether it is better to go forward or not for other platforms. See more backgrounds here. https://docs.google.com/document/d/16dalG0ssugZlwc7BBzUoBQUmuqM0S_gwtG2uxL0htdw/edit# TBR: pfeldman@chromium.org Bug: 869348 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b351b2135fd5e749ed575484b2182e847a420c9 Reviewed-on: https://chromium-review.googlesource.com/1151169 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579668}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/68be5dab98f6..1a9c02850686 git log 68be5dab98f6..1a9c02850686 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 buildbot@webrtc.org Roll chromium_revision 19a9e3bb..bf3721ae (579465:579581) Created with: gclient setdep -r src/third_party/webrtc@1a9c02850686 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ba5b0467dea560766a281ba38510f19055a8c64 Reviewed-on: https://chromium-review.googlesource.com/1157624Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579667}
-
Yoichi Osato authored
LayoutSelection::ClearSelection() is called while LayoutObject::RemoveChildNode() to clear LayoutObject references in LayoutSelection and selection painting. However, my preceding patch(crrev.com/c/1125709) changed the selection algorithm where LayoutSelection didn't keep the references and the function now do nothing. This patch simply removes relevant function calls. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I74b15b6139959b26f2a00ab5402c53f19f22be3a Reviewed-on: https://chromium-review.googlesource.com/1154777 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579666}
-
Stephen Martinis authored
The builders have been renamed, so we can remove all the references to the old names. Bug: 867725 Change-Id: I30e93d563348d297e4916d1268adeb1c7cdae307 Reviewed-on: https://chromium-review.googlesource.com/1157344Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#579665}
-
Gabriel Marin authored
Account for file changes in tcmalloc 2.7. BUG=724399,b:70905156 Change-Id: I7a831684d5ddbd26f9906876e8df2a412a482454 Reviewed-on: https://chromium-review.googlesource.com/1130775Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#579664}
-
dpapad authored
In this CL updating: - chrome://history - chrome://print - chrome://settings This adds some additional size to the binary, since both Polymer 1 and 2 HTML bundles are included. This is temporary and the Polymer 1 version will be removed once the migration is completed Bug: 862472 Change-Id: Ia77a01b730630ab04a34483c7f0a53358501ceed Reviewed-on: https://chromium-review.googlesource.com/1155834 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579663}
-
Chris Harrelson authored
The containing block of a float is the containing *block*, meaning that it is an actual block and therefore does not include inlines. This means that floats and positioned elements can have mutually inconsistent containing block chains. Example: <div id=root> <span style='position: relative'> <div style='float: left'> <span style='position: absolute'></span> </div> </span> </div> In this example, the containing block of the abs-pos span is the rel-pos span. However, the containing block of the float is the root element. Therefore the containing block chains mutually cross each other. Other than floats, containing blocks do not have this behavior. IOW if there are no floats, and ContainingBlock(A) = B, then for any element C between A and B in the DOM parent chain, B is in its containing block chain. Bug: 823748 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4038aa6db33af53b04721760d6ee32904ac7a727 Reviewed-on: https://chromium-review.googlesource.com/1156136Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579662}
-
dpapad authored
In this CL updating: - chrome://bookmarks - chrome://downloads - chrome://extensions This adds some additional size to the binary, since both Polymer 1 and 2 HTML bundles are included. This is temporary and the Polymer 1 version will be removed once the migration is completed Bug: 862472 Change-Id: I55e0edbd4e9269432e2494aadb3d0abae146b43b Reviewed-on: https://chromium-review.googlesource.com/1155827 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579661}
-
Raymond Toy authored
To support deprecating the AudioParam value setter in favor of setValueAtTime, some methods were added. The deprecation has happened and these are no longer needed. Bug: 764396 Test: Change-Id: I6e296e17582a078cacc01f91fb56af812079db38 Reviewed-on: https://chromium-review.googlesource.com/1157213Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579660}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f107a2fd014c..c1de8bd2ba3b git log f107a2fd014c..c1de8bd2ba3b --date=short --no-merges --format='%ad %ae %s' 2018-07-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-31 reed@google.com remove conditional flags for sksg -- not needed for a module 2018-07-31 ccameron@google.com Revert "Disable GPU clip masks" 2018-07-31 bungeman@google.com Remove SK_IGNORE_SUBPIXEL_EMOJI_FIX. 2018-07-31 bbaren@google.com Set `-Wno-implicit-fallthrough` when building for iOS 2018-07-31 herb@google.com Move path leaf loop to drawer 2018-07-31 jcgregorio@google.com Use a larger machine for our cloud build. Created with: gclient setdep -r src/third_party/skia@c1de8bd2ba3b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4837df136528e38677251f555a51eaaeedc6a663 Reviewed-on: https://chromium-review.googlesource.com/1157625Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579659}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c1508bc0b4f..ac43aaa2c2e1 git log 8c1508bc0b4f..ac43aaa2c2e1 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 jmadill@chromium.org Refactor client check from ValidateDrawAttribs. Created with: gclient setdep -r src/third_party/angle@ac43aaa2c2e1 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ib8a9f08bd794a1b3b01de79e2e8f484cee7d2305 Reviewed-on: https://chromium-review.googlesource.com/1157487Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579658}
-
Eric Karl authored
This patch may have been leading to regressions in memory on Windows. Temporarily disabling mip map generation to test whether this is the culprit. R=khushalsagar Bug: 867468 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74467e2f620ecb15af86a6a82c6b772d03c739d1 Reviewed-on: https://chromium-review.googlesource.com/1157273Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579657}
-
Michael Spang authored
Framebuffers are a DRM-master specific object, so move them out out of GbmBuffer. This makes GbmBuffer independent enough of the DRM modesetting code that we can merge it with GbmBoWrapper. Bug: 869206 Change-Id: I4ae6e1191ef115a4aa58b1c7ccb9f19e06de28aa Reviewed-on: https://chromium-review.googlesource.com/1155918 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579656}
-
Kevin Strohbehn authored
Bug: 868117 Change-Id: I15aae661ae200ec858e6886be718eaa55ff3266a Reviewed-on: https://chromium-review.googlesource.com/1152231 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579655}
-
Yuri Wiitala authored
Introduces the mojo IDL and implementation "glue" to be able to create overlays to be rendered on top of each video frame captured by a FrameSinkVideoCapturer. This allows for use cases like mouse cursor rendering and debug status displays. Also, the new overlay APIs have been added to ClientFrameSinkVideoCapturer (a client-side wrapper that handles the auto-reconnecting-to-VIZ after a VIZ process crash). Bug: 810133 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I963b6a1d736e1510618a723694f3b22ac0bf1589 Reviewed-on: https://chromium-review.googlesource.com/1150929 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579654}
-
tzik authored
extensions::ContentVerifyJob is ref counted, and its first reference may be implicitly created in ContentVerifyJob::Start through base::BindOnce. However, after an upcoming change to base::Bind, it starts rejecting to make the implicit first reference to a ref-counted object, as this is an error prone pattern. This CL updates callers of ContentVerifyJob::Start to hold to hold the first reference, before Start() is called. Bug: 866456 Change-Id: Ib3a70973ac789f60a75e636db03f4e4d66e12603 Reviewed-on: https://chromium-review.googlesource.com/1156704Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#579653}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4d53fb3. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22183 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I1a710e023cc5268ad365820e61d5a1f5cf453a2b Reviewed-on: https://chromium-review.googlesource.com/1157346 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#579652}
-
Jia authored
These optional values should have been filled when PopulatePreviousEventData is called. We now add the checks before using them. Also add metrics to record any unexpected events. Bug: 869127 Change-Id: I645c3c2242961fe055f6043b7541e36c01caa892 Reviewed-on: https://chromium-review.googlesource.com/1156105Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#579651}
-
Takuto Ikuta authored
This is a reland of b166ec24 I dropped the change for build flags from this. Original change's description: > Reland "Fix to remove /wd4018 (-Wno-sign-compare) for /build/config" > > This is a reland of 1f75f99f > > Original change's description: > > Fix to remove /wd4018 (-Wno-sign-compare) for /build/config > > > > This is a part of effort to remove /wd4018 warning suppression. > > > > Master CL is > > https://chromium-review.googlesource.com/c/chromium/src/+/1152755 > > > > This CL was uploaded by git cl split. > > > > R=dpranke@chromium.org > > > > Bug: 868248, 588506 > > Change-Id: I3c31dc8f72266eda85904c4a860e156fadb2a76e > > Reviewed-on: https://chromium-review.googlesource.com/1152840 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#579311} > > Bug: 868248, 588506 > Change-Id: Ic673677dfc0800b361d97f6516ee61887635d9d4 > Reviewed-on: https://chromium-review.googlesource.com/1156164 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579401} Bug: 868248, 588506 Change-Id: I41148bf02e6f5d1998b88f38e26022888a3b8623 Reviewed-on: https://chromium-review.googlesource.com/1157664 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579650}
-