- 29 Jun, 2018 40 commits
-
-
Tetsui Ohkubo authored
This CL moves remaining mojom::SystemTray implementation in SystemTrayController to SystemTrayModel, and changes SystemTrayModel to bind mojom::SystemTray interface directly. TEST=trybot pass BUG=none Change-Id: Ie73cd257e19a5230387058f45c57a771a32310cf Reviewed-on: https://chromium-review.googlesource.com/1107582 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571419}
-
Oscar Johansson authored
The macro ENDPOINT is defined inside namespaces in: net/third_party/quic/core/quic_connection.cc net/third_party/quic/core/quic_crypto_handshaker.cc net/third_party/quic/core/quic_crypto_stream.cc net/third_party/quic/core/quic_data_reader.cc net/third_party/quic/core/quic_framer.cc net/third_party/quic/core/quic_packet_creator.cc net/third_party/quic/core/quic_sent_packet_manager.cc net/third_party/quic/core/quic_session.cc net/third_party/quic/core/quic_spdy_stream.cc When building using jumbo these end up in the same namspace and conflict. This commit solves the issue by undefining the macro inside the namespace. Bug: 772146 Change-Id: Ie85920ac632dd90402afc2276ed30fff8609d9be Reviewed-on: https://chromium-review.googlesource.com/1118220Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571418}
-
Han Leon authored
This CL adds a function OnDestroyed() into EmbeddedWorkerInstance::Listener interface, so that ServiceWorkerRegisterJob can stop observing EmbeddedWorkerInstance once it's gone away. BUG=856969,856330 Change-Id: I3acc9143f9ea2f8f24ab0aac465f29f97fdf9906 Reviewed-on: https://chromium-review.googlesource.com/1118006 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#571417}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0601d68ac85e..82d171c82469 git log 0601d68ac85e..82d171c82469 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 mbonadei@webrtc.org Skip PeerConnectionEndToEndTest.CallWithCustomCodec on Win ASan builds. 2018-06-28 peah@webrtc.org AEC3: Allow filter adaptation even though the estimated echo is saturated 2018-06-28 terelius@webrtc.org Port RtcEventLog encoder unittests to the new parser API. Created with: gclient setdep -r src/third_party/webrtc@82d171c82469 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:857426 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2dc160e12af018a946993c8cbb0055e44cd8e9b7 Reviewed-on: https://chromium-review.googlesource.com/1119707Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571416}
-
Matt Falkenhagen authored
This adds UMA for start worker breakdown recorded from the renderer. The plan is to replace the UMA that's recorded on the browser based on IPCs from the renderer. Some motivations include: * Avoid skewing the metrics when the IPCs get delayed due to busy browser IO thread. * Avoid delaying end-to-end start time. Each IPC is a chance to get delayed, which delays end-to-end start time. * Simplify the code. The timing milestones are: * start * browser sent start worker IPC * renderer received start worker IPC * JavaScript evaluation on the worker thread started * JavaScript evaluation on the worker thread ended * end The current implementation does more things, e.g., after JS evaluation end it posts another task to itself and then sends the worker started IPC, but this is expected to be removed so it's not added as a milestone here. The UMA added includes: * Total startup time: ServiceWorker.StartTiming.Duration * Start to milestone: ServiceWorker.StartTiming.StartToReceivedStartWorker ServiceWorker.StartTiming.StartToScriptEvaluationEnd ServiceWorker.StartTiming.StartToScriptEvaluationStart ServiceWorker.StartTiming.StartToSentStartWorker * Each milestone: ServiceWorker.StartTiming.SentStartWorkerToReceivedStartWorker ServiceWorker.StartTiming.ReceivedStartWorkerToScriptEvaluationStart ServiceWorker.StartTiming.ScriptEvaluationStartToScriptEvaluationEnd ServiceWorker.StartTiming.ScriptEvaluationEndToEnd See also: https://docs.google.com/document/d/18LzAAO7YFTMc2v6Nrr1EPypXd9CDzSTQTUyMGUPZieQ/edit?usp=sharing Change-Id: Ic6d0de634ca160518bcd6600ec3b22aa067ab086 Bug: 855952 Reviewed-on: https://chromium-review.googlesource.com/1114565 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571415}
-
Fady Samuel authored
Don't use the CompositorLock if surface synchronization is enabled. This was causing issues on telemetry bots where the CompositorLock was preventing the UI from submitting CompositorFrames for a long period of time and so input latency was very high. Before: https://pinpoint-dot-chromeperf.appspot.com/job/11675b9b240000 After: https://pinpoint-dot-chromeperf.appspot.com/job/152a7367240000 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I95407531216b543fb4c192387bd67fe690bee0b4 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1119191 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571414}
-
Ramin Halavati authored
This reverts commit fb40db12. Reason for revert: crrev.com/c/1117264 got reverted, and this CL is based on that. Original change's description: > Roll traffic_annotation_auditor for Linux > > The new binary for traffic_annotation_auditor after the change in > crrev.com/c/1117264 is rolled. > > Bug: 856884 > Change-Id: Ief41cd698f8190b3642582a2ddabf15724f91a2f > TBR: georgesak@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1117682 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571041} TBR=georgesak@chromium.org,rhalavati@chromium.org Change-Id: Idac821023b403db1d9182b54616bcc50904a8401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856884 Reviewed-on: https://chromium-review.googlesource.com/1119785 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#571413}
-
Ramin Halavati authored
This reverts commit 081bb19a. Reason for revert: crrev.com/c/1117264 got reverted, and this CL is based on that. Original change's description: > Roll traffic_annotation_auditor binary for Windows. > > The new binary for traffic_annotation_auditor after the change in > crrev.com/c/1117264 is rolled. > > Bug: 856884 > Change-Id: I76523df5e58ace767ac19c619c9bb32da5a25674 > TBR: georgesak@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1117686 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571048} TBR=georgesak@chromium.org,rhalavati@chromium.org Change-Id: I2706aa14d74d1c858d6e53c2703baf55c041f340 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856884 Reviewed-on: https://chromium-review.googlesource.com/1119805Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae1f03388f7a..406de133efaf git log ae1f03388f7a..406de133efaf --date=short --no-merges --format='%ad %ae %s' 2018-06-29 yyanagisawa@chromium.org Add gclient_utils to InputAPI export. Created with: gclient setdep -r src/third_party/depot_tools@406de133efaf The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4ebdc7e46587f7903d11d5a904aabd144869f54b Reviewed-on: https://chromium-review.googlesource.com/1119706Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571411}
-
Joel Hockey authored
Fixes Error: webkitResolveLocalFileSystemURL not found: [filesystem:drive/team_drives] Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6979d279f6986dba4ff5cb0ee6ac63b8f4594bfd Reviewed-on: https://chromium-review.googlesource.com/1119733 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#571410}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia4a739ea250766e1d1747d2b39d0d2f529e41fba Reviewed-on: https://chromium-review.googlesource.com/1119765Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571409}
-
Colin Blundell authored
The GCMAccountTracker unittest currently plays fast-and-loose with the notion of an "account ID", which can be either the Gaia ID or the email address for a given account depending on the platform. This is a blocker to porting GCMAccountTracker to use IdentityManager, as the IdentityManager test infrastructure deliberately makes a much more explicit and enforced separation between email address, Gaia ID, and account ID. This CL paves the way for that porting by changing the GCMAccountTracker unittest to be explicit about its usage of the email address, Gaia ID, and account ID of a given account. Interestingly, this change exposed an actual production bug (https://crbug.com/856170). Bug: 809923 Change-Id: I46e2f632bacd89ba55132255a95bcb089d4fb3c8 Reviewed-on: https://chromium-review.googlesource.com/1113548 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571408}
-
Muyuan Li authored
TBR=dcheng@chromium.org,jamescook@chromium.org,msw@chromium.org,xiaohuic@chromium.org Original change's description: > assistant: filter out incognito windows in assistant screenshot. > > Per privacy requirement, incognito windows should not be included > in screenshot sent to assistant server. > > Bug: b/78193324 > Test: > ash_unittests --gtest_filter=AssistantControllerTest.Screenshot > browser_tests --gtest_filter=BrowserNonClientFrameViewAshTest.IncognitoMarkedAsAssistantBlocked* > > Change-Id: Idf55135959721d69414a1ec6fae396f9763ebe49 > Reviewed-on: https://chromium-review.googlesource.com/1114293 > Commit-Queue: Muyuan Li <muyuanli@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571385} Change-Id: Ieecafffe5f1e14971b3c07dc799323a29885de16 Reviewed-on: https://chromium-review.googlesource.com/1119766Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571407}
-
Patti authored
Currently, All Sites shows all origins in their raw format, which looks crowded and can be confusing to users. Use the host instead in most situations, displaying non-HTTPS schemes off to the side to easily differentiate from other hosts that may be the same. Note non-default ports will also be shown as part of the host. See a screenshot - https://bugs.chromium.org/p/chromium/issues/detail?id=835712#c12 Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id34ef01e3fe41cd428e5a97bbc4fc207dbe07d05 Reviewed-on: https://chromium-review.googlesource.com/1107579 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#571406}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie62c720fcdce018d12a54d5b69ddf0f34d8c76a3 Reviewed-on: https://chromium-review.googlesource.com/1119767Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571405}
-
Kent Tamura authored
security_context.h is used in 3,100+ compilation units, and this CL reduces its pre-processed size from 3.10MB to 1.74MB. Bug: 242216 Change-Id: I0fe6dd82eea775853cfe23377f2803bd0f90b069 Reviewed-on: https://chromium-review.googlesource.com/1119613Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#571404}
-
Reza.Zakerinasab authored
This change does the plumbing for ImageDecoder::HighBitDepthDecodingOption, which is required to differentiate the expected behavior from PNGImageDecoder. This is a partial CL toward supporting 16 bit PNG decode to half float backed bitmap. This CL does not change the behavior and does not contain any tests. Testing is covered in the main CL: chromium-review.googlesource.com/c/chromium/src/+/1079788. Bug: 839034 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie6f34b866b1fbe09bd425bdbecd7fb9726cf9621 Reviewed-on: https://chromium-review.googlesource.com/1113506 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571403}
-
John Abd-El-Malek authored
There was a race condition when the policy fetch request that's initiated in CloudPolicyTest::SetUpOnMainThread is cancelled becauase the test bodies start their own request (through RefreshPolicies). The first request seems to get the python test server in a bad state and it stops responding to requests afterwards. The fix is to skip issuing the first request by temporarily unregistering CloudPolicyRefreshScheduler. TBR=pmarko Bug: 858883 Change-Id: I8c158ab3dffc2f38a7712a6806f9b8d28efbcfdb Reviewed-on: https://chromium-review.googlesource.com/1119628 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#571402}
-
Kouhei Ueno authored
This CL follows signed exchange spec change: https://github.com/WICG/webpackage/commit/3903da6e Bug: 803774 Change-Id: If93b419488c166b1d8ec8a35b7a752a439d1cd7a Reviewed-on: https://chromium-review.googlesource.com/1114407Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Changing the paper-button bg-color to white was too big of a change and would require reviewing all usages of paper-button to ensure that style bugs similar to the one found in cr-toast do not occur. The default paper-button bg-color will not be set. The bg-color of paper-button in the user-manager will be set to white. And for cr-toast, the bg-color will be set to transparent (including the hover state). Bug: 845576 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b7a513012c43e2da0163555c1a5d25e69cf8328 Reviewed-on: https://chromium-review.googlesource.com/1115354 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571400}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6d97dd7fb70f..898687843450 git log 6d97dd7fb70f..898687843450 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 vapier@chromium.org gerrit: update old googlecode URLs Created with: gclient setdep -r src/third_party/chromite@898687843450 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: Ia948fd9c24c9d0a0c4b259ffc3f612467b7dc1ad Reviewed-on: https://chromium-review.googlesource.com/1119705Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571399}
-
Sadrul Habib Chowdhury authored
crrev.com/570859 removed a trace-event that was used to find the frames, but failed to update the trace-name correctly. This fixes the script so that frames can correctly be determined again. BUG=855328 Change-Id: I22980d8473272a256e348b1d3f54e041be51dda1 Reviewed-on: https://chromium-review.googlesource.com/1119625 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571398}
-
Charles Zhao authored
(1) MRUFeatures are calculated and saved when WillCloseAllTabs() is invoked but returned when the WebContentsDestroyed is called. (2) MRUFeatures is calculated in WebContentsDestroyed if not in closing_all mode. (3) Change tab_strip_model to respond to WillCloseAllTabs, CloseAllTabsCanceled and CloseAllTabsFinished. Bug: 817174 Change-Id: Idea15b5c48666fbc0163ccba62ee37b23bb192f0 Reviewed-on: https://chromium-review.googlesource.com/1086552Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571397}
-
Wez authored
Bug: 858194 Change-Id: I051084347da2f395e25b090ba54439c866b0c044 Reviewed-on: https://chromium-review.googlesource.com/1119357 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571396}
-
Tetsui Ohkubo authored
This CL restores IME mode icon to UnifiedSystemTray. The icon was removed as a part of UnifiedSystemTray & Shelf spec, but it turned out the icon is important especially for CJK users with laptop mode. We still hide the icon for tablet mode. TEST=manual BUG=854948 Change-Id: I55bdd88627f91c9e285242b725c4a55451d0c60a Reviewed-on: https://chromium-review.googlesource.com/1116412 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#571395}
-
Findit authored
This reverts commit 9f6cd533. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 571385 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmNmNkNTMzZGIxNGJmZjY3OWJkOGNkNjcxNGI3MzI0NTVlNDRjMTYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6550 Sample Failed Step: compile Original change's description: > assistant: filter out incognito windows in assistant screenshot. > > Per privacy requirement, incognito windows should not be included > in screenshot sent to assistant server. > > ash_unittests --gtest_filter=AssistantControllerTest.Screenshot > browser_tests --gtest_filter=BrowserNonClientFrameViewAshTest.IncognitoMarkedAsAssistantBlocked* > > Bug: b/78193324 > Test: > Change-Id: Idf55135959721d69414a1ec6fae396f9763ebe49 > Reviewed-on: https://chromium-review.googlesource.com/1114293 > Commit-Queue: Muyuan Li <muyuanli@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571385} Change-Id: Ieb8299a17fca3e3033e2c5a67933ed5ef642335b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/78193324 Reviewed-on: https://chromium-review.googlesource.com/1119745 Cr-Commit-Position: refs/heads/master@{#571394}
-
Penny MacNeil authored
This is a reland of ea1974d4 Original change's description: > [chrome_elf, third-party block support] Pass file path in registry. > > Due to rare case of install_static::GetUserDataDir() path expansion, > this API cannot be used inside DllMain(). The full, expanded path to > the packed blacklist file will be dropped into install_static::GetRegistryPath(), > in the kThirdPartyRegKeyName subkey, in the kBlFilePathRegValue REG_SZ value. > This has no other impact on existing functionality. > > - This change includes comments, constants, and tests. > > - LogLoadAttempt() will now include the section path for any 'blocked' logs > as well. Friendly reminder that log.AddEntry() will still not add duplicate > 'blocked' logs, to protect against spammy logging. > > - Removed old bit of uninstaller touching old blacklist. > > Test: chrome_elf_unittests.exe, ThirdParty* > Bug: 769590 > Change-Id: Id9ada49215aa110db9fb72a4712da9d3fb7ccf31 > Reviewed-on: https://chromium-review.googlesource.com/1109600 > Reviewed-by: Robert Shield <robertshield@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570849} Bug: 769590 Change-Id: I80fd3a322a9d578a9d4b716f81f5a8d110e9eab4 Reviewed-on: https://chromium-review.googlesource.com/1117498 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#571393}
-
Adam Rice authored
blink::ReadableStreamOperations::GetReader() should throw an exception when the operation failed. Take an ExceptionState& parameter and rethrow the exception on failure. BodyStreamBuffer::CloseAndLockAndDisturb used the exception from GetReader() to detect when the stream was already locked. Since it there's no straightforward way to distinguish between the expected exception and some other exception, instead check IsLocked() beforehand to eliminate the possibility of an expected exception from GetReader(). Bug: 853189 Change-Id: Ib7bdf1cda9d392e4434ceff352c8f10ddf8ff951 Reviewed-on: https://chromium-review.googlesource.com/1118205Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#571392}
-
Tetsui Ohkubo authored
This CL fixes label and icon color of notifier settings view and IME list view in UnifiedSystemTray. TEST=manual BUG=850396 Change-Id: I11bc88e3420b45641773ac7b1185db477a294455 Reviewed-on: https://chromium-review.googlesource.com/1117728Reviewed-by:
-
Tetsui Ohkubo authored
This CL changes feature pod toggle behavior as follows: Current behavior: The feature was enabled. -> The feature is disabled. The feature was disabled. -> The feature is enabled. Expected behavior (This CL): The feature was enabled. -> The feature is disabled. The feature was disabled. -> The feature is enabled & transition to the detailed view. As currently we only have three feature pod buttons which are togglable & having a detailed view, so it changes behavior of these buttons: * Network * Bluetooth * Quiet Mode TEST=manual BUG=856028 Change-Id: I860bd9501bc651d74d982130d22b5006e0fba6e0 Reviewed-on: https://chromium-review.googlesource.com/1116503Reviewed-by: -
Kenneth Russell authored
Suppressing the following flaky test on Linux NVIDIA: deqp/functional/gles3/texturespecification/ random_teximage2d_cube.html Tbr: ynovikov@chromium.org Bug: 618447 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia22432c9cfd71fc4d26e21eea26576ecedfe8593 Reviewed-on: https://chromium-review.googlesource.com/1119542Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571389}
-
Tetsui Ohkubo authored
Currently, network feature pod button may show Ethernet, mobile data & tether in addition to WiFi. However, clicking on the button always toggled WiFi enabled / disabled. TEST=manual BUG=856030 Change-Id: If39e3360a045e0b0ba64cb89c43999dd11151549 Reviewed-on: https://chromium-review.googlesource.com/1116510Reviewed-by:
-
Ryan Cui authored
Adds new Event.Touch.GestureTarget histogram for browser UI elements, and stops including browser events in Ash.GestureTarget. Removes header and runtime dependency between browser and ash for gesture metric handling. BUG: 826476 Change-Id: I87e8de2c4cae6f5e30939726917f5f811cb61ba8 Reviewed-on: https://chromium-review.googlesource.com/1116250Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Patti authored
This is a reland of e2cac39f Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} TBR=stevenjb@chromium.org Bug: 835712, 717468 Change-Id: I88522c41a536e86e27b831358c61842d69f42d34 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1116318 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#571386}
-
Muyuan Li authored
Per privacy requirement, incognito windows should not be included in screenshot sent to assistant server. ash_unittests --gtest_filter=AssistantControllerTest.Screenshot browser_tests --gtest_filter=BrowserNonClientFrameViewAshTest.IncognitoMarkedAsAssistantBlocked* Bug: b/78193324 Test: Change-Id: Idf55135959721d69414a1ec6fae396f9763ebe49 Reviewed-on: https://chromium-review.googlesource.com/1114293 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#571385}
-
Sadrul Habib Chowdhury authored
Add async trace-events for selected commands to see how long they spend in the queue. This can then be used to measure the impact of the gpu-scheduler. This can be done by adding 'trace_queueing_time' attribute to the commands. This CL adds this only to SwapBuffers. BUG=858895 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I75146dd806f54357d0d669e92c1d461dc04d912c Reviewed-on: https://chromium-review.googlesource.com/1114057 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571384}
-
Esmael El-Moslimany authored
Bug: 850243 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7f028f7541a60f0aa15495823969fdd243609845 Reviewed-on: https://chromium-review.googlesource.com/1115589 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571383}
-
Tetsui Ohkubo authored
This CL * Fixes the behavior when date is clicked while system does not allow manual time change (we still allow users to change time zone & 12/24 clock). * Closes system tray bubble when managed button is clicked. * Adds material design ripple to date button and managed button. TEST=manual BUG=none Change-Id: I43df968100952940d21e87132bbb1007a7bacdca Reviewed-on: https://chromium-review.googlesource.com/1118091Reviewed-by:
-
Joel Hockey authored
Bug: 825010 Change-Id: I384e1fc1e24572a2fc185d2ceac1bd9fa0b8a5bc Reviewed-on: https://chromium-review.googlesource.com/1119611 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#571381}
-
Peter Kasting authored
Bug: 856896 Change-Id: I5897da89ffbf38a5ca7fbce3205aefb770d81ecc TBR: kylixrd Reviewed-on: https://chromium-review.googlesource.com/1119646Reviewed-by:
-
