- 03 Dec, 2020 40 commits
-
-
Reilly Grant authored
This adds support for an uncommon configuration in which a composite USB device has the WinUSB driver loaded for the whole device rather than using Microsoft's composite driver to create device nodes for each device function. A manual test which confirms that all calls to claimInterface() succeed or fail in a reasonable time has been added. Bug: 1150758 Change-Id: If86d2e21dbc575cadea943a9c319029a10c78b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568546Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833505}
-
Ben Kelly authored
It contains a traceable v8 object, yet was previously always owned via a std::unique_ptr<>. Current best practice recommends a GarbageCollected<> type here instead. Bug: 1141510 Change-Id: Ia823ccc8388ed43c1ca3a90d2ecc841c07ddfe55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571810 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833504}
-
Robert Sesek authored
AX-Relnotes: n/a. Bug: 1153883 Change-Id: Iff9f2d2dd72314f04c11b0b87ff2438655a16335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572177Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833503}
-
Lan Wei authored
Use testdriver Action API to simulate mouse click actions in css/selectors/focus-visible-003.html. Bug: 1145677 Change-Id: I18d3862d524c0a917c056891e7012c589b8252e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548197Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833502}
-
Darwin Huang authored
Ensure that a format is valid before creating a placeholder Blob, so that clipboard.read() no longer returns nullptr blobs. In particular, filter out custom/pickled formats not supported by the Clipboard API Previously, custom/pickled formats not supported by the Clipboard API, but exposed via blink::SystemClipboard, would create nullptr Blobs when read via clipboard.read(), and return them in the output ClipboardItems. This output ClipboardItem could then be written via clipboard.write(), and cause a crash. Bug: 1153361 Change-Id: Ib57ccca0e79adb09ee51e64c324c32283c788cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568818 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833501}
-
Bailey Berro authored
Calls the correct method when RoutineType is kBatteryCharge. Bug: 1128204 Change-Id: Ib53ee77c54bca7dd324d6bbac69ccde7d7b98f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573125 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#833500}
-
edchin authored
Removes unnecessary subclass in test file. Bug: 1147967 Change-Id: I72d5d219dd5488a1b42a1512a7de0e34d153cc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572041Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833499}
-
rbpotter authored
Migrate file manager from preprocess_grit (being removed) to preprocess_if_expr. Both tools copy files/generate manifests for bundling and generating grd files, and both process <if expr>, but preprocess_if_expr no longer supports the deprecated // <include in JS. file_manager uses <include> in JS, but not in any files being processed by preprocess_grit, so it can be migrated to preprocess_if_expr. Also correcting a comment about inlining images, as neither the old preprocess_grit nor the new preprocess_if_expr inline images. Change-Id: Ie2d1f669346183263250abf0613450c573d28943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570455Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833498}
-
Clark DuVall authored
After http://crrev.com/c/2547404, native libs can now be loaded from DFMs, so we no longer need to move libs into the base module. Bug: 1150459 Change-Id: I8e33dba16932e64c3ee5b97c84a01f1adc72fee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571956 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833497}
-
Avi Drissman authored
macOS 10.11 simplifies the NSTextAttachment API, so now that Chromium requires 10.11, clean up the New badge code. Bug: 1153883 Change-Id: I12f17b0c8da7f75346fac9ad9e6d4da12b04d8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572937 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833496}
-
Josh Simmons authored
This is a reland of cd15c4b9 Original change's description: > Update Files.app iconography to new style > > Replaced the existing icons with new icons that have a different style. > > Test: Looked at Files.app icon in launcher, shelf and switcher > Bug: 1128673 > Change-Id: I55e3a586dd6ea9ab7f03134d4992eb6e7e2ae92d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430564 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Josh Simmons <simmonsjosh@google.com> > Cr-Commit-Position: refs/heads/master@{#810521} Bug: 1128673 Change-Id: I78cf917d7d567def61a3d8e59a07bfe3535a0f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573256Reviewed-by:
Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#833495}
-
Jimmy Gong authored
The ProfileType enum helps distinguish whether the current phone profile is a work profile or the default profile. Bug: 1155244 Change-Id: I21a5f957c31ec1a8ceb4a39080a45ee62daf3ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572703 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833494}
-
Roger Tawa authored
This is a followup of CL 2535685 that continues the changes at the //content and //chrome layers. Bug: 1150852 Change-Id: Ia30bd4074d38dea66131592c2d655b300b72f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561025 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833493}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I01ae7a5565df32b6ab555a9edbf7fcebdc298c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572000Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833492}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30bf3b85f1d9..38f2fff09dac 2020-12-03 brcui@microsoft.com Fix bad XML in accessibility_strings.grdp 2020-12-03 vidorteg@microsoft.com [Loc] Migrate media panel to Localization V2 2020-12-03 patrick.brosset@microsoft.com Flex: Remove temporary support for non-baseline flex overlay backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1139949 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4ad2f9ba77cfe2607a8280899f58f80e6083aafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572126 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833491}
-
Karandeep Bhatia authored
This CL implements evaluation of session scoped rules. Follow-ups: - Shared rule limits with dynamic rules. - Raise error on regex rules which exceed memory limit. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1043200 No-Presubmit: True Change-Id: I8ac39f3fba702896a2ff291e476285b49a37cce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548270 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833490}
-
Michael Bai authored
The query starts from AutofillHandler, there is no functionality change since WV/WL doesn't instantiate DownloadManager. Bug: 1151542 Change-Id: Ifccce22515ae2faef48fed6445a61bd415d51e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570307 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#833489}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I973977578df209d21fab6983dbc3e09d02056453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573128 Commit-Queue: Norman Rosas <normando@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46092e95a4ec..ba66a670730d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbergquist@google.com,sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tbergquist@google.com,sebsg@google.com Change-Id: Ifc61c20c9714f6152751f944b30ea034bacc891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572360Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833487}
-
Nick Diego Yamane authored
R=sky@chromium.org Bug: None Change-Id: If56f5d55e63a1456c2c66ee476f1b14a4ee03e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571808 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#833486}
-
yilkal authored
This cl ensures that that the auth headers are sent only to the families.google.com servers for the EduCoexistence flow. Bug: 1155252 Change-Id: Ia07b16d32c865052d7c30f23401cbfafdd6f4e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572596Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833485}
-
Peng Huang authored
Also set PresentationFeedback from CompleteNotifyEvent properly. Bug: 2561401 Change-Id: I0b77dcb6664860aac78e1187ae4faf599720e320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572043 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#833484}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9901ec70fa0e3ca748d50191af57e7a7e343b788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833483}
-
Joon Ahn authored
Bug: 1125150 Change-Id: Ic34f9545bceb90c6a2a0f8a63c0914a49870ca88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572678Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833482}
-
Victor Vasiliev authored
Change-Id: I3cfb0db37a10d5e0d80c0b1103a4b2100f1878de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572198 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833481}
-
Victor Hugo Vianna Silva authored
This is a reland of d2746236 Original change's description: > Remove unused */render_tests/*.sha1 > > The associated render tests now use an online platform to check for the > expected image (https://chrome-gold.skia.org/). All these hashed images > are doing in the repository is confusing developers who are new to > render tests, so let's remove them. > > Bug: 1103836 > Change-Id: Iaa541f22e6ba9002fadaae99b99d9003e4b7f5c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566796 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833249} Bug: 1103836 Change-Id: Ic2a98dca027d5acfdb9b624045aefb5d24b8f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569518 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833480}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I400faeb7b7c1684dfe7a64812ae446f7beaaf74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571800Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833479}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606996231-faa54c695225bf8f6afffc1841d10967281c359d.profdata to chrome-win64-master-1607007593-3407e023275e887982890e083190cec03a46fa25.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9eeb00a730f3bd94dc54b9005d4a19c3adca5ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833478}
-
Robert Sesek authored
Bug: 1153883 Change-Id: If50e63050b90f4a35b9c286180c6e1a91c10ca6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571639 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833477}
-
Lin XInan authored
BUG=chromium:1153349 TEST=./main.star Change-Id: I83fc4424e3a111511f949cd68ba285b34e96d128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571809 Auto-Submit: Xinan Lin <linxinan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#833476}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I854f878aad5ee258c4dbfb851059d3bc3bfa58ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571811Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833475}
-
Gavin Williams authored
Show the dialog when a scan job fails. The app returns to READY state once the dialog is closed. http://screen/6CS5wL2BB7v429a Bug: 1059779 Change-Id: I937209ca0caf13bb00d0731248fe0d5bd991687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570411 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#833474}
-
Fabian Henneke authored
Android's Autofill framework interacts with Chrome via an Accessibility- based compatibility bridge. In order to allow it to see (and thus offer to save) unmasked passwords, these need to be exposed to Accessibility services. However, since Android O the policy for password fields is to preserve their current masking state in all matters related to Accessibility. With this change, passwords will be exposed to Accessibility unmasked if the only consumer of Accessibility information is the Autofill framework's CompatibilityBridge. As the bridge hooks directly into the AccessibilityManager via an AccessibilityPolicy, this situation can be detected easily by checking that the ENABLED_ACCESSIBILITY_SERVICES setting is empty. As a result, third-party Autofill services can save passwords in Chrome if the user does not have any Accessibility services enabled. These services can reliably check for this situation in the same way as done in this change and thus selectively offer save flows when they now the password will be unmasked. Bug: 1151614 Change-Id: I4644c977f65bf31fa4e1daa76a1e5d55cd0adada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552791Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Fabian Henneke <fabian.henneke@gmail.com> Cr-Commit-Position: refs/heads/master@{#833473}
-
Piotr Bialecki authored
ArCoreDeviceProviderFactory & related classes are no longer needed & have been removed in this CL. This also simplifies provider installation logic. Change-Id: I6a8ea6004408ef55eddadcefe753d8fe8d869367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567502Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#833472}
-
minch authored
Add a "force-in-tablet-physical-state" switch to force tablet physical state so that auto rotation is on regardless of the actual physical state. Bug: 1122138, b/169636434 Change-Id: I7ab6f57bc670f5ba17f6fb2f08aea16e072f0fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524120Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#833471}
-
John Lee authored
- Add more gridcell elements to show that the grid has two columns: one for the bookmark metadata and one for the more actions button. - Move role="row" to the item so that when focus moves to it, the screen reader can read out its aria-selected attribute. - Add aria-multiselectable to the whole list to allow screen readers to read that the user can select multiple items in the list. These aria attributes seem to be very buggy on multiple screen readers, but this follows the accessibility spec's guidelines and has no regressions from the previous setup. Bug: 1142080 Change-Id: Iddb7eaa68dd357e2b8f48e5d33d9fdf9a93223c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566595 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833470}
-
Illia Klimov authored
This CL reduces call sites for ContentSettingsType::PLUGINS. Bug: 1149393 Change-Id: If59590e43aa54066fde60603c30b0cfec9c66658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569737 Commit-Queue: Illia Klimov <elklm@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833469}
-
Titouan Rigoudy authored
This does not seem to have a bearing on the test results, but it does simplify my mental model of what requests are getting UseCounted. Bug: chromium:1142865 Change-Id: Ie3ff28dabb1e521df384f99ad12399c46a8d9273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517731 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833468}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3dba3ee4654f..5f9ba6953f8d 2020-12-03 reed@google.com fix debugger bindings 2020-12-03 mtklein@google.com add to_fp16/from_fp16 2020-12-03 mtklein@google.com add load64 2020-12-03 reed@google.com deprecate getTotalMatrix 2020-12-03 tdenniston@google.com [svg] Remove kInherit from several SVG types 2020-12-03 fmalita@google.com Revert "[skottie] Add image sampling and transform options" 2020-12-03 johnstiles@google.com Simplify InterfaceBlock by removing multi-dimensional array support. 2020-12-03 csmartdalton@google.com Plumb mixed samples through GrXPFactory::GetAnalysisProperties 2020-12-03 johnstiles@google.com Simplify VarDeclaration by removing multi-dimensional array support. 2020-12-03 johnstiles@google.com Disallow multi-dimensional arrays in SkSL. 2020-12-03 johnstiles@google.com Disallow returning array types in SkSL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ib5f73226788ee9d9c50fb6e85c9514adc35391c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833467}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/877fbcb69179..8ddf5ae4b8a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ied6a0b0bb01499de329d0f1d2a14f07ec8e5895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833466}
-