- 17 Jul, 2018 40 commits
-
-
Fernando Serboncini authored
Makes XPositionForOffset and CharacterIndexForPosition support return results inside a ligature glyph (while still not breaking ZWJs) by using a character-based TextBreakIterator inside glyphs. Reland of 1e3235b3 Bug: 473476 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I80348a10044edc89f0e85789c71dc17a56f6393d Reviewed-on: https://chromium-review.googlesource.com/1140275 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575822}
-
Farah Charab authored
Provide support for experimenting with using resource fetch priorities for resource loading tasks in blink. Bug: 860545 Change-Id: I064f287ea2c96d67f532ba7dc03abb45875947c3 Reviewed-on: https://chromium-review.googlesource.com/1128857 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575821}
-
Wei-Yin Chen (陳威尹) authored
Many JNI methods in HistoryReportJniBridge are too costly to run on the UI thread. Add assertOnBackgroundThread() to avoid possible misuse in the future. Bug: None Change-Id: If76e16aa417984d7eb27be31ca241e7e2051275d Reviewed-on: https://chromium-review.googlesource.com/1139893Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575820}
-
Chris Hamilton authored
This is non-sensical and is a way for a user to crash the browser. BUG= Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I913e0197f3b8d8bda60fa28729d4e5e0bfafbf4b Reviewed-on: https://chromium-review.googlesource.com/1140790Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#575819}
-
Minh X. Nguyen authored
This is to correct the way the (old) extension updater determines updates from the update manifest (|ExtensionDownloader::DetermineUpdates|). It currently treats extension update errors (e.g. extension not in the update manifest, invalid update version in the update manifest, ...) as no updates, which would cause a disparity with the new extension updater running in the Finch experiment. Bug: 722942 Change-Id: I4d958fb0d313f2a9cd2456eef3035d2ef5f091fe Reviewed-on: https://chromium-review.googlesource.com/1123710 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575818}
-
David Black authored
The parameter is used in Ash to show the appropriate UI for the given interaction type. Bug: b:80186902 Change-Id: Id5cd3d52df4d5132dc87a5cfb25edb9c8cf01e2d Reviewed-on: https://chromium-review.googlesource.com/1137334 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575817}
-
Roberto Carrillo authored
This builder is meant to be used with a cron job on luci scheduler to update the bot_db as a json file in google storage readable by Findit. (Instead of having Findit attempt to parse the python files where these configs are defined, under the chromium_tests recipe module). R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv Bug: 787918 Change-Id: I668eaef3511ff82795ff80a2650ecadd741cd861 Reviewed-on: https://chromium-review.googlesource.com/1141092Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575816}
-
James West authored
Bug: 110481245 Bug: 110967761 Test: manual Change-Id: Id86ba187069699dc3d2f6ac9f1bc8864a6e41484 Reviewed-on: https://chromium-review.googlesource.com/1111680 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#575815}
-
Yue Cen authored
Bug: 835029 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icbe94f99997fe13758400e26ae29eeeb8bb234b6 Reviewed-on: https://chromium-review.googlesource.com/1103778Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#575814}
-
Shakti Sahu authored
UX: https://docs.google.com/presentation/d/14pBMf4Qrhd_a4qF6KdXJJfAZYLdmv_JN0gL8GC4SWAU/edit?ts=5b2c34ff#slide=id.g3d18eff084_2_13 Bug: 863717 Change-Id: I682470f7e0eb66d874fbc82b9ccfae19bb1a7090 Reviewed-on: https://chromium-review.googlesource.com/1139022Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575813}
-
Tien-Ren Chen authored
This reverts commit 3c0ef7a5. Reason for revert: It didn't fix the target crash. Original change's description: > [Blink] Invalidate clip path cache if mask layer is mutated > > This is a speculative fix for https://crbug.com/856818 . > > It is speculated that the clip path of an element become valid without > invalidating its cache, resulting in the associated clip nodes not > being created, and the newly created mask layer having bad layer state. > > BUG=856818 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iab7acc4eb8007d03b259e6dab4f036e2b11bd900 > Reviewed-on: https://chromium-review.googlesource.com/1130596 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574425} TBR=trchen@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 856818 Change-Id: Ib4f9d6920caa36ac31b4e1825adc926fa9c9064f Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1140456Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575812}
-
Hongchan Choi authored
Under the high pressure in WebAudio rendering using AudioWorkletThread, the |contextTime| value can be negative and the current code does not address it correctly. This CL clamps |contextTime| so it cannot past |currentTime|. Spec: https://webaudio.github.io/web-audio-api/#dom-audiocontext-getoutputtimestamp "After the context’s rendering graph has started processing of blocks of audio, its currentTime attribute value always exceeds the contextTime value obtained from getOutputTimestamp method call." Bug: 859870 Test: The time difference in the repro case does not go negative. Change-Id: I2460de263045762659319a18722ace27c2b0bd47 Reviewed-on: https://chromium-review.googlesource.com/1140505Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#575811}
-
Becca Hughes authored
Move DisplayCutoutHostImpl out of WebContentsImpl into its own file. BUG=825890 Change-Id: Id759fa7c9fd880648ec35baac853a046d90959ab Reviewed-on: https://chromium-review.googlesource.com/1131847 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#575810}
-
Shakti Sahu authored
Currently SelectableItemView contains the logic for selection as well as highlighting the UI. Separated the selection functionality into a base class since in the new download home, different types of views will implement different UI for selection. Also added the ability to insert a RecyclerView into the SelectableListLayout since in the download home the main view is created separately in DateOrderedListView. The actual wiring will be in a follow up CL. Bug: 850601 Change-Id: I33b1e68b27d6103d57c82322e5231dddfb6fd112 Reviewed-on: https://chromium-review.googlesource.com/1137332 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575809}
-
Esmael El-Moslimany authored
Bug: 863845 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5da18cebf49709c6499bba94ea82bfabbef5a773 Reviewed-on: https://chromium-review.googlesource.com/1140510 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575808}
-
wutao authored
This cl implements a new feature to read the latest opened foreign tab on Chrome OS. Bug: 843839 Test: manual. Change-Id: Iab5e9e5eb092d8103497492c9f88bc79e323e9b5 Reviewed-on: https://chromium-review.googlesource.com/1134485 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575807}
-
Zhongyi Shi authored
QUIC Connection Migration: do not check non-migratable streams when starting to probe an alternative network. Instead, check and reset non-migratable streams when probe is successful and session is about to migrate to the probed path. Bug: 791886 Change-Id: Icdff9b77d340fedbf64ab8e8eb05d1d99aaf0b65 Reviewed-on: https://chromium-review.googlesource.com/1139314 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#575806}
-
Sandra Sun authored
This reverts commit dab53435. Reason for revert: Couldn't reproduce the test failure on a local Win7 and the failure seems unrelated to my change. Try to submit it once more and will investigate it further if it fails again. Original change's description: > Revert "Snaps after scrollbar clicking." > > This reverts commit e98df9c6. > > Reason for revert: suspect for webkit_layout_tests consistently > failing, e.g. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/81791 > > Original change's description: > > Snaps after scrollbar clicking. > > > > After user clicking on the scrollbar's track or arrows, we should snap > > to the closest snap position of the container. This is done by simply > > moving SnapAfterScrollbarDragging() from > > ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp(). > > > > This patch also rewrites the previous > > snaps-after-scrollbar-dragging.html test using the gesture-util.js, and > > adds the new clicking tests to it as well. > > > > Bug: 860768 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824 > > Reviewed-on: https://chromium-review.googlesource.com/1127153 > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575191} > > TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > Change-Id: Iab3c3c489bda0fc6b150ba0e0a5bde8de9721798 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 860768 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1138013 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575202} TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,mastiz@chromium.org Change-Id: Iaef646348cc6e1c0a6e8b0bca3deb9296f79a7e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860768 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1138473 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#575805}
-
Mohsen Izadi authored
ServerGpuMemoryBufferManager is updated to support changing the GPU service it is using, in case GPU process is crashed and restarted. If this happens, it will retry pending allocation requests as soon as the new GPU service is available. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I56fa97c7b74ec71d7e7a18e0e3036ffd7350e296 Reviewed-on: https://chromium-review.googlesource.com/1132679 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#575804}
-
Danyao Wang authored
-webViewSecurityFeaturesDidChange is meant to update the SSL status of the last committed item. With WKBasedNavigationManager, on a back/forard navigation, there exists a small window between web view starts loading and -webView:didStartProvisionalNavigation is triggered that WKBasedNavigationManager::GetLastCommittedItem() returns the pending item instead of the last committed item. -updateSSLStatusForCurrentNavigationItem must not be called in this window, otherwise the wrong navigation item will be used. Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57eb96f74c3a6a133b1fdad6559de093f5d125c5 Reviewed-on: https://chromium-review.googlesource.com/1141054 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#575803}
-
Francois Doray authored
Bug: 775644 Change-Id: I2e1558710c665322c1cbba93ed20176f6be83667 Reviewed-on: https://chromium-review.googlesource.com/1136984 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#575802}
-
Annie Sullivan authored
Change-Id: I29978aa75fe2a71490cdcb1fcc78e47ac672f185 Reviewed-on: https://chromium-review.googlesource.com/1141094Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575801}
-
Katie D authored
The SelectToSpeak class is messy and should be refactored to separate the input handling, state logic, and output handling. This is the first part of that refactor. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If53dc7f85b223641e82533c82ab89aa50719d198 Reviewed-on: https://chromium-review.googlesource.com/1136842 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575800}
-
Scott Violet authored
And changes ws2 to ensure client is notified when scale-factor changes. The conversion from ScreenProviderObserver to associated interface is to ensure the ScreenProviderObserver is notified *before* the bounds change because of scale-factor. To do otherwise means the client might use the wrong scale-factor. BUG=862409 TEST=none Change-Id: I78333dcabe3e4adb1e2091cba784d53d9c27be1a Reviewed-on: https://chromium-review.googlesource.com/1138866Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#575799}
-
Lei Zhang authored
Point various OWNERS files for Cloud Print code to //cloud_print/OWNERS. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0ba92831f62904415c5d5f4ddf8fcf0335e301b8 Reviewed-on: https://chromium-review.googlesource.com/1141072Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575798}
-
Lily Houghton authored
NetworkChangeNotifier::IPAddressObserver is being deprecated. This CL migrates CloudPolicyRefreshScheduler to use NetworkChangeObserver instead. Bug: 754695 Change-Id: I4a3c1dd2320151ae78e504d732e6b67cec9bc78b Reviewed-on: https://chromium-review.googlesource.com/1133333Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#575797}
-
Matt Falkenhagen authored
ServiceWorkerProviderHost destructor destroys ServiceWorkerVersion, which destroys ServiceWorkerEventDispatcher which some Mojo interfaces are associated with. Namely, it causes ServiceWorkerObjectHost and maybe ServiceWorkerRegistrationObjectHost's Mojo connection error handlers to be invoked during ServiceWorkerProviderHost's destructor. The error handlers attempt to use the halfway destroyed ServiceWorkerProviderHost. Fix things by explictly destroying the hosts in the destructor. No test because I don't see a good way to test this. Bug: 854993, 838410 Change-Id: I62f057c641738fa3ed9b780550fd3d4b730ef98a Reviewed-on: https://chromium-review.googlesource.com/1139850Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575796}
-
Bret Sepulveda authored
This patch changes the size at which close buttons disappear from being approximately 48 dips of content area to being a fixed constant. As a first pass I've set the constant to 68 dips, which feels good to me. This patch also ties the logic for when to show extra left padding to the close button visibility, which addresses cases where the favicon would "twitch" due to the alert indicator appearing. Bug: 853788, 863027 Change-Id: I681f8b7d530b192f2fd5943436ae16bd93f33fba Reviewed-on: https://chromium-review.googlesource.com/1125315Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#575795}
-
Christopher Thompson authored
This changes the default HTTPS security indicator to drop the "Secure" verbose chip and only show the lock icon (for non-EV HTTPS). This also updates the flag groups from crbug.com/803138 to account for the new default, and add a "holdback" condition. The SecurityIndicatorTest tests are updated to match. Bug: 864606 Change-Id: I08acd2dc9431f8b70d6f932c977a831111d08e75 Reviewed-on: https://chromium-review.googlesource.com/1140674Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#575794}
-
chaopeng authored
There are 3 changes make in overflow-scrollability.html: 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the overflow-scrollability.html flaky on virtual/threaded test suites. Bug: 841567 Change-Id: Ic098832a3ce685774d204d245f61809edee4a60b Reviewed-on: https://chromium-review.googlesource.com/1131834Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575793}
-
Stephen McGruer authored
This is a reland of 73716e90 Original change's description: > Add histogram to measure usage of '#' in WebView loadData APIs > > The goal is to compare how often this histogram is logged with the > existing kDataUriHasOctothorpe UseCounter for WebView, in order to > determine what API path we might want to modify when doing a compat > fix. The belief is that the histogram and UseCounter should be > roughly comparable because the histogram will only be recorded at most > once per site load (because the loadData APIs cause a site load). > > Bug: 823666 > Change-Id: I0ce63b8c86bc3bcd02d3b10ab7a38112fb520439 > Reviewed-on: https://chromium-review.googlesource.com/1112045 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575268} Bug: 823666, 864152 Change-Id: I7cbd818a9a427ab9497aa51bc1df8e91b38dc295 Reviewed-on: https://chromium-review.googlesource.com/1138893Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575792}
-
Tibor Goldschwendt authored
Change-Id: Ia24af4265badb67284c4151af813559ed7fbf7c1 Reviewed-on: https://chromium-review.googlesource.com/1140779 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575791}
-
Daniel Rubery authored
In order to prevent Referrer chains from looping, add a timestamp argument to both FindNavigationEvent and FindRetargetingNavigationEvent. Then only allow the next event if it precedes the previous event chronologically. Bug: 864234 Change-Id: Ie5752096eb2571ecf24bdf22057ebc5c4d87adbd Reviewed-on: https://chromium-review.googlesource.com/1141058Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#575790}
-
Charlie Harrison authored
The code for initializing the memory mapping from a ruleset file was not properly checking for IO errors from lower level mmap utilities. This CL accounts for that by adding a factory method to MemoryMappedRuleset which returns nullptr if initializing the memory mapped file fails. This is tested via a global boolean which simulates mmap failures by always returning nullptr from the factory method. Bug: 734102 Change-Id: Id9372d09c0c1abdd4eb26a6486a84e11cd7cc245 Reviewed-on: https://chromium-review.googlesource.com/1138336 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#575789}
-
Muyuan Li authored
Bug: None Test: None Change-Id: I18651c7a5aae4535cf0c7b652e68735126b3fe6c Reviewed-on: https://chromium-review.googlesource.com/1139111Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#575788}
-
Sergey Ulanov authored
Renamed targets under //webrunner as follows: service_unittests -> webrunner_unittests runner_pkg -> webrunner_pkg runner_exe -> webrunner_exe runner -> webrunner Bug: 852145 Change-Id: Id92d021d29e7fada81153d70440b6376052e3abd Reviewed-on: https://chromium-review.googlesource.com/1138992Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575787}
-
Quan Nguyen authored
Bug: 837501 Change-Id: I2c3473b7198a3f8a172552dfda07b91fec19f5da Reviewed-on: https://chromium-review.googlesource.com/1136020Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575786}
-
Hidy Han authored
InspectorDOMSnapshotAgent: expose and book layout nodes owned by pseudo elements under their owners. Currently, only support before, after and first letter pseudo types. Change-Id: Ifb10fecad1dbfb6b987eaa0bd0e7ccb4a222d13f Reviewed-on: https://chromium-review.googlesource.com/1125511 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575785}
-
Kenneth Russell authored
The new names for the affected bots are: mac10.13_retina-blink-rel mac10.13_retina-blink-rel-dummy WebKit Mac10.13 (retina) Bug: 863070 Change-Id: I0a9cfb1e0378f6fe2f900c84e0d73c16f1094d8d Reviewed-on: https://chromium-review.googlesource.com/1136883Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575784}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b609e6dc6a02..3229e65886a0 git log b609e6dc6a02..3229e65886a0 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jvanverth@google.com Revert "Add some optimizations to PolyUtils" 2018-07-17 ziadb@google.com SkAR Java: drawing planes as paths 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-17 jvanverth@google.com Add some optimizations to PolyUtils 2018-07-17 kjlubick@google.com Add SkFloat2Bits and Region stub 2018-07-17 caryclark@google.com build for gdb on linux 2018-07-17 caryclark@skia.org fix bookmaker build bot 2018-07-17 robertphillips@google.com Restore SkLightingShader and associated classes 2018-07-17 allanmac@google.com Bug fixes and improvements to SKC and HotSort. Vulkan is WIP. 2018-07-17 caryclark@skia.org remove unused untested parts of text blob 2018-07-17 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 6fb8ba4e8660..d691aeeb956f (1 commits) Created with: gclient setdep -r src/third_party/skia@3229e65886a0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I8680e0eeffa0615b25d1b0e5c8767c4ba199f02f Reviewed-on: https://chromium-review.googlesource.com/1140417Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575783}
-