- 13 Dec, 2016 40 commits
-
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/941e7e2c9567..18b4f981aeda $ git log 941e7e2c9..18b4f981a --date=short --no-merges --format='%ad %ae %s' 2016-12-13 jvanverth Fix doc typo 2016-12-10 bsalomon Remove antialias axis from GrPathRendererChain::DrawType 2016-12-13 fmalita Avoid int64 overflow in SkClampRange Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2567243004 Cr-Commit-Position: refs/heads/master@{#438209}
-
manzagop authored
Details: - Collection was added in https://codereview.chromium.org/2544853003/ - log messages are added to the stability report's top level and not to the process level. We may want to revisit that if/when reports start containing multiple processes BUG=620813 Review-Url: https://codereview.chromium.org/2554423002 Cr-Commit-Position: refs/heads/master@{#438208}
-
bshe authored
BUG=673644 Review-Url: https://codereview.chromium.org/2572483004 Cr-Commit-Position: refs/heads/master@{#438207}
-
deadbeef authored
This CL prepares for later renaming updateIce to setConfiguration in Blink, once it has an Intent to Ship. updateIce was never functional in the first place (in the native webrtc library), always throwing the same exception. SetConfiguration is functional, and will allow an application to change the set of ICE servers and ICE candidate policy. Soon, also the ICE candidate pool size. updateIce will no longer be tracked after this CL, which should be ok since it has always been nonfunctional and stats show zero use. BUG=chromium:587453 Review-Url: https://codereview.chromium.org/2511633002 Cr-Commit-Position: refs/heads/master@{#438206}
-
chrome://ntp-tiles-internals/sfiera authored
Implement it for Android, Desktop, and iOS. This largely supersedes chrome://popular-sites-internals/. Relative to that, it lacks a way to see the cached JSON and the status of a manual fetch. BUG=655622 Review-Url: https://codereview.chromium.org/2557103004 Cr-Commit-Position: refs/heads/master@{#438205}
-
tommycli authored
Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2562153002 Cr-Commit-Position: refs/heads/master@{#438204}
-
thomasanderson authored
BUG=672763 Review-Url: https://codereview.chromium.org/2568233003 Cr-Commit-Position: refs/heads/master@{#438203}
-
fdoray authored
This CL initializes TaskScheduler in renderers using default arguments. ContentRenderClient may provide different arguments. Initially, no threads will be created by TaskScheduler in renderers because no tasks are posted to it and pools are initialized with StandbyThreadPolicy::LAZY. In a separate, we will start running v8 tasks in TaskScheduler rather than WorkerPool (https://cs.chromium.org/chromium/src/gin/v8_platform.cc?sq=package:chromium&l=70&dr=C). BUG=664996 Review-Url: https://codereview.chromium.org/2491823005 Cr-Commit-Position: refs/heads/master@{#438202}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d822ae6..0948a26d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2570063002 Cr-Commit-Position: refs/heads/master@{#438201}
-
jwd authored
BUG=672950 Review-Url: https://codereview.chromium.org/2563103002 Cr-Commit-Position: refs/heads/master@{#438200}
-
mlippautz authored
The expectations don't differ anymore. TBR=haraken@chromium.org NOTRY=true BUG=chromium:468240 Review-Url: https://codereview.chromium.org/2574583003 Cr-Commit-Position: refs/heads/master@{#438199}
-
skyostil authored
This patch splits the Network.getCookies command into Network.getCookies, which returns the cookies for the current URL and Network.getAllCookies, which returns all the cookies in the cookie jar. BUG=668932,166637 Review-Url: https://codereview.chromium.org/2568503002 Cr-Commit-Position: refs/heads/master@{#438198}
-
csharrison authored
This patch optimizes KURL::protocol and KURL::protocolIs by keeping an AtomicString m_protocol on KURL. This reduces string allocations throughout the code using KURL::protocol(). This also fixes an inconsistency with KURL::protocolIs that will return true for invalid URLs. BUG=348655 Review-Url: https://codereview.chromium.org/2463703002 Cr-Commit-Position: refs/heads/master@{#438197}
-
estade authored
* affects system menu, message center, palette bubble, ime bubble, etc. * WM shadow aperture calculation is adjusted to work better for small windows (like the message center when it's empty). There's a TODO here which will have to wait for Sebastien to get back so he can give feedback on what to do in this case. * fix alignment of NO_ASSETS bubble --- don't account for non-existent stroke. * existing BubbleBorder tests applied to more different kinds of bubble BUG=608852 Review-Url: https://codereview.chromium.org/2555373004 Cr-Commit-Position: refs/heads/master@{#438196}
-
reed authored
purely a renaming from Foo_SkClipOp to SkClipOp::Foo plus one static_cast to treat the enum as an index into array. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR= Review-Url: https://codereview.chromium.org/2575533002 Cr-Commit-Position: refs/heads/master@{#438195}
-
zmin authored
BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2561243002 Cr-Commit-Position: refs/heads/master@{#438194}
-
dcastagna authored
crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. Review-Url: https://codereview.chromium.org/2568243004 Cr-Commit-Position: refs/heads/master@{#438193}
-
avi authored
GlobalErrorService ownership was crazy; sometimes the error objects contained were owned, and sometimes they weren't. This separates the two cases into clear statements of ownership, and deprecates the case where the error objects are unowned. BUG=555865,673578 Review-Url: https://codereview.chromium.org/2409443002 Cr-Commit-Position: refs/heads/master@{#438192}
-
boliu authored
Revert of Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky (patchset #1 id:1 of https://codereview.chromium.org/2568413003/ ) Reason for revert: Infra problem, not test problem. And the problematic bot has been taken off of cq. Original issue's description: > Mark org.chromium.android_webview.test.ClientOnPageFinishedTest#testPassesCorrectUrl flaky > > BUG=672885 > TBR=boliu@chromium.org > > Committed: https://crrev.com/7d0a2e6fd2a182eb8fa8888cd9539c6072bbf136 > Cr-Commit-Position: refs/heads/master@{#438190} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672885 Review-Url: https://codereview.chromium.org/2573833002 Cr-Commit-Position: refs/heads/master@{#438191}
-
nednguyen authored
BUG=672885 TBR=boliu@chromium.org Review-Url: https://codereview.chromium.org/2568413003 Cr-Commit-Position: refs/heads/master@{#438190}
-
lpromero authored
These are third party libraries used by Chrome for iOS. BUG=none Review-Url: https://codereview.chromium.org/2551963004 Cr-Commit-Position: refs/heads/master@{#438189}
-
olivierrobin authored
Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2569713003/ ) Reason for revert: Breaks compilation of autofill_controller_unittest.mm Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a > Cr-Commit-Position: refs/heads/master@{#438167} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Review-Url: https://codereview.chromium.org/2577443002 Cr-Commit-Position: refs/heads/master@{#438188}
-
hcarmona authored
Using a dialog is a much cleaner solution because it handles all focus trapping without attempting to capture TAB or require updating all tabindex properties. We removed the ability to swipe the drawer open in order to keep the code simple. BUG=633858 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2465433002 Cr-Commit-Position: refs/heads/master@{#438187}
-
gambard authored
BUG=651041 Review-Url: https://codereview.chromium.org/2569223002 Cr-Commit-Position: refs/heads/master@{#438186}
-
lgrey authored
BUG=673362 Review-Url: https://codereview.chromium.org/2555033003 Cr-Commit-Position: refs/heads/master@{#438185}
-
clamy authored
This CL triages the currently failing layout tests. Marking this as NOTRY since this is only affecting the FYI bot LinuxBrowserSideNavigation. BUG=576261 NOTRY=TRUE TBR=nasko@chromium.org Review-Url: https://codereview.chromium.org/2572783003 Cr-Commit-Position: refs/heads/master@{#438184}
-
stkhapugin authored
Semi-automatically generated ARCMigrate commit Notable issues:Had to fix includes and subclasses. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2574463002 Cr-Commit-Position: refs/heads/master@{#438183}
-
mathp authored
Since crrev.com/2561373002 was submitted, cancelling out of the editor will now go back to the "ready to pay" state with an item still selected (given there was one selected prior to entering the editor). This made a bunch of tests flaky, so this change - marks known flaky tests as FlakyTest - Attempts to fix some tests with mReadyToPay, although this is just speculative at this point; a more comprehensive fix is in order. BUG=673371 TEST=PaymentRequest* (java) Review-Url: https://codereview.chromium.org/2571493002 Cr-Commit-Position: refs/heads/master@{#438182}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/3b3bdafa8e3a..941e7e2c9567 $ git log 3b3bdafa8..941e7e2c9 --date=short --no-merges --format='%ad %ae %s' 2016-12-12 ethannicholas re-land of added sk_FragCoord support to skslc 2016-12-13 borenet Add PDFium_SkiaPaths bot 2016-12-13 reed don't use deprecated api 2016-12-12 scroggo SkGifCodec: intersect frameRect with image size 2016-12-12 msarett Fix Android overdraw detection 2016-12-12 borenet Roll recipe DEPS 2016-12-13 reed remove old clipping flags Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2569843003 Cr-Commit-Position: refs/heads/master@{#438181}
-
nednguyen authored
BUG=673681 TBR=donnd@chromium.org,twellington@chromium.org Review-Url: https://codereview.chromium.org/2571783002 Cr-Commit-Position: refs/heads/master@{#438180}
-
tbansal authored
If Chromium is using a HTTP2 proxy server, then the preconnect jobs are skipped if a preconnect request is already pending. This prevents Chromium from unnecessarily establishing multiple preconnections to an HTTP2 proxy. The new behavior is guarded behind a field trial so that the performance benefits can be evaluated. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=667471 Review-Url: https://codereview.chromium.org/2522703002 Cr-Commit-Position: refs/heads/master@{#438179}
-
sahel authored
BUG=669668 TEST=WebFrameTest.TestNonCompositedOverlayScrollbarsFade Review-Url: https://codereview.chromium.org/2569053002 Cr-Commit-Position: refs/heads/master@{#438178}
-
skyostil authored
Revert of Implement a runtime headless mode for Linux (patchset #20 id:380001 of https://codereview.chromium.org/1991953002/ ) Reason for revert: Unexpectedly added a couple of new static initializers: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/29946 Original issue's description: > Implement a runtime headless mode for Linux > > This patch implements a runtime headless mode (i.e., a > --headless command line switch) that makes it possible to > use a regular Chrome binary as a headless. When the binary > is launched with this switch, the main entrypoint calls > into the Headless Shell entrypoint, effectively starting > that shell instead of Chrome. > > To make this possible we must remove the dependency from > Headless to Ozone, because Ozone is a build-time feature > which is generally not enabled for regular Chrome builds. > In practice this means implementing a new headless-specific > WindowTreeHost and modifying various graphics and input > entrypoints to do something appropriate in headless mode. > > Since many of the modifications are in platform-specific > code, this initial patch only adds headless support in Linux. > Other platforms will be added later. > > Design doc: https://docs.google.com/document/d/1aIJUzQr3eougZQp90bp4mqGr5gY6hdUice8UPa-Ys90/edit# > > BUG=612904 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/eb0f3b0218478f30858dfa2078cb350ea259701f > Cr-Commit-Position: refs/heads/master@{#438152} TBR=jochen@chromium.org,eseckler@chromium.org,sky@chromium.org,zmo@chromium.org,vmiura@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612904 Review-Url: https://codereview.chromium.org/2570873002 Cr-Commit-Position: refs/heads/master@{#438177}
-
krb authored
BUG=643804 Review-Url: https://codereview.chromium.org/2544793003 Cr-Commit-Position: refs/heads/master@{#438176}
-
msramek authored
Define BrowsingDataRemoverDelegate, a class to which BrowsingDataRemover will delegate all embedder-specific deletions. This class is in 1:1 relationship to BrowsingDataRemover and is owned by it. Create a Chrome-specific subclass ChromeBrowsingDataRemoverDelegate by extracting all Chrome datatypes from BrowsingDataRemover::RemoveImpl(). This is the first step of the implementation plan. See the design doc for more background and explanation of the next steps: https://docs.google.com/document/d/1I6m4QwbTNhG6wdtazamhTnArJN-UMUGqpvwH6InBEaM/edit#heading=h.m5pzu7ah79n9 This change is covered by BrowsingDataRemoverTest and BrowsingDataRemoverBrowserTest. NOTES FOR REVIEWERS: 1. This CL tries to keep the diffs at minimum for easier review, even if the method ordering could be improved. That will be improved in a follow-up CL. 2. However, the diffs widely differ in BrowsingDataRemover::RemoveImpl and ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData. Fortunately, one can convince themself that they are still equivalent by trusting the test coverage (58 unittests and 6 browsertests). 3. One can convince themself that no datatype was left out by checking the list of asynchronous tasks, such as "waiting_for_clear_cache_", "waiting_for_clear_cookies_" etc. present in both .h files and in the AllDone() method of both classes. 4. The distribution of datatypes might not be final. For example, downloads are known to content but have a chrome/ dependency. Similarly, the DNS cache lives in net/ but is retrieved via a class in chrome/. Future CLs might correct their placement based on how strong the chrome/ dependencies are. Patchset 3: Simplify the "bool waiting_for_clear_<type>" paradigm by encapsulating it to a SubTask class. BUG=668114 Review-Url: https://codereview.chromium.org/2554413002 Cr-Commit-Position: refs/heads/master@{#438175}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d654057e..8d822ae6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2568213003 Cr-Commit-Position: refs/heads/master@{#438174}
-
alexclarke authored
Note this patch, while useful in it's own right, needs base messageloop cancellation support for full effect. Until that patch lands there may be some pointless wakeups for canceled DoWorks. This is of particular concern for using the scheduler on the compositor thread. BUG=578176 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2546423002 Cr-Commit-Position: refs/heads/master@{#438173}
-
junov authored
This change block user code from accessing cross-origin image data from a placeholder canvas. The placeholder code was modified to use StaticBitmapImage instead of Image to gain access to the originClean() method without downcasting. BUG=673348 Review-Url: https://codereview.chromium.org/2566313002 Cr-Commit-Position: refs/heads/master@{#438172}
-
olivierrobin authored
The setting is not used anymore. Remove it. Review-Url: https://codereview.chromium.org/2576473002 Cr-Commit-Position: refs/heads/master@{#438171}
-
sigbjornf authored
Internal types, no good reason to expose these to the outside. R= BUG=673645 Review-Url: https://codereview.chromium.org/2573783002 Cr-Commit-Position: refs/heads/master@{#438170}
-