- 01 Oct, 2020 40 commits
-
-
Zain Afzal authored
Previously the media app was unable to perform a save as operation on a file obtained from a drag and drop or from a paste event. This was because the logic surrounding the operation was encapsulated in ReceivedFile which is a class the media app does not have access to. This cl updates the requestSaveFile IPC to return a ReceivedFile instead of returning a file token, allowing the media app to obtain a native file, overwrite it and copy over it's functions so future saves can happen in place. The google3 side of this change is @ cl/334717684. Bug: b/165769056, b/169630668 Change-Id: Ied8dd540f9f319b18b427e6566851bc628ed3204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439969Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#812607}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fae3f2841bd0..95949e4c8ae8 2020-10-01 changhaohan@chromium.org Refactor away ad hoc treeElementSymbol field in DOMNode 2020-10-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55e17cac84d6ed76252d28c5ec1ac75dbd18f399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812606}
-
Hitoshi Yoshida authored
- Updates the list of generated files - Includes v8_foo.h instead of foo.h for IDL dictionaries - Uses hasXxxNonNull() and XxxNonNull() APIs to access a nullable vector properly Bug: 839389 Change-Id: I1c8fbb1e3cadc5568c231315b58c9a20f59951ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439999 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#812605}
-
Miriam Polzer authored
The histogram is called "UpgradeDetector", not "UpgradeDetecter". Bug: None Change-Id: I06f74a35ead4b17d81eb155b38b6f620f2d42bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440038Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#812604}
-
Corentin Wallez authored
And deprecate GPUBindGroupLayoutEntry.multisampled. Bug: dawn:517 Change-Id: I0959d46f603c2c7741dc2288098ca119d38b344e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440655Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#812603}
-
Gyuyoung Kim authored
As the last step to convert ViewMsg_UpdateWebPreferences IPC message to Mojo, this CL moves ViewMsg_UpdateWebPreferences to PageBroacast Mojo interface. - Introduce web_preferences.mojom which has WebPreferences Mojo struct with needed enum types. - Add web_preferences_mojom_traits.h/cc files to map Mojo fields to the proper native types. - Remove IPC legacy stuff regarding the IPC message in //content. Bug: 1097943 Change-Id: I3a4286b106b7f0a0b38cb7482f1f0f8f7fbf590f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426070Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Meilin Wang authored
This CL fixes the settings issue introduced by the CL below: https://chromium-review.googlesource.com/c/chromium/src/+/2363914/comment/81a70101_1ab41885/ We now move the logic of updating weather settings inside the |OnSettingsAndAlbumsFetched|, where the previous user settings stored on the server side have been retrieved. We then check the |show_weather| field and update the weather settings if necessary. Bug: b/158630188 Change-Id: Ifcd66699ca483a88d119afc5182539e508639c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389416Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812601}
-
Ioana Pandele authored
This ensures that the entire view is scrolled when the keyboard starts overlapping with the contents. Bug: 1133221 Change-Id: Id826c7ea25a25d4424aed75f51389b4ae8d9b362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440498Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#812600}
-
Glen Robertson authored
DigitalGoodsFactory was split up to DigitalGoodsFactory{Factory,Impl}. Allows the impl on the other side of the mojo interface to determine whether the DigitalGoods API should be available. Previously the caller could not distinguish a successful vs failed attempt to get a DigitalGoods impl over mojo. Bug: 1131747 Change-Id: Ib21b72d27522a101ceaf2430e7130069a149d576 Fixed: 1131747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426150Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#812599}
-
Piotr Tworek authored
Two minor and pretty generic issues are exposed when building the code with libstdc++ instead of bundled libcxx. 1. Code in thread_cache.h uses std::atomic but fails to include required header file. 2. Code in partition_alloc_constants.h uses std::max_align_t which is defined in cstddef, not its C version stddef.h. In both cases libcxx basically pulls in required headers indirectly. Bug: 957519 Change-Id: Idcee3e7abfab94cb40e1b95c636b97cf9c766b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440436Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c337a36b2e8..4f09dd47da6e 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b042f4e70879 to 5e947adaf26e (4 revisions) 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cc47e0cd to 085332bf (612 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I028599affda72b7b2ac2353a7a1eb6f339e0ffef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442418Reviewed-by:
-
Piotr Tworek authored
Exact-width atomics are C++17 feature while chromium and blink are still supposed to target C++14. The code builds fine when using default bundled libcxx, but fails when using external C++ standard library that does not support C++17. Ref: http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2441 Change-Id: Ia83342a7920e19d5d270e17aa49da39730084713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438458Reviewed-by:
-
Morten Stenshorne authored
This consists of two fixes: 1. The block formatting context root must not be marked as "at block end" if there are broken floats inside. 2. Set exclusion space correctly. We used to add an "infinitely" tall exclusion, which would cause the containing block (the formatting context root) to become "infinitely" tall. Set it to the amount of space left in the fragmentainer instead. Bug: 829028 Change-Id: I316d7a9b50b9a502d203d83021389274713d2429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438494 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812595}
-
phillis authored
Make a separate install source for installing from "Create Shortcut" instead of sharing the same install source with install from menu. Also record the Webapp.Install.InstallEvent for this source. Bug: 1131210 Change-Id: Id0531e6d283603da01c02ba3c94cfa44138daacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439425 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#812594}
-
Anders Hartvoll Ruud authored
When adding features to a simple selector, we are currently calling IsIdClassOrAttributeSelector() to determine if we should add features to the universal sibling set or not. This means selectors like ':is(.a) + .b' will result in a universal sibling set containing '.b', since ':is(.a)' is not an ID/class/attribute. This CL instead detects whether an ID/class/attributes exist inside the nested selector list, thus avoiding the addition to the universal sibling set. Note that this affects -webkit-any() as well. Bug: 568705 Change-Id: I7bba857a3f24e9789f5517617e4201079d7350ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435089 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812593}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I5fa62cfbaf434d19732997b86f00c9a3d37b1efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442590Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812592}
-
Kent Tamura authored
LayoutObject::IsFoo() functions which match to a legacy type and the corresponding NG type are named as: - IsFooIncludingNG() (e.g. IsFieldsetIncludingNG()) or - IsFooOrNGFoo() (e.g. IsButtonOrNGButton()) This CL makes them consistent. This CL has no behavior changes. Change-Id: I7e7b652e44d89168a4efb442cc11bf48696e9ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442209Reviewed-by:
-
Fredrik Söderqvist authored
If the font changes we need to invalidate the text metrics so that the text layout data is updated. Fixed: 1133297 Change-Id: I13579257430e535e139ae57ca53990c053cf8d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439072Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#812590}
-
Fredrik Söderqvist authored
This only needs to answer the query "do we have a paint", so it can be simplified to reflect that. Bug: 109212 Change-Id: If1aa31e81f32c5c3aace708fe5a81edb653cb1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440657Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#812589}
-
arthursonzogni authored
The [coop-reporting-explainer] defined several URLs that might be reported: - initial_popup_url - openee_url - opener_url - other_document_url - referrer This patch adds body.initialPopupURL [coop-reporting-explainer]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md Bug: 1090273 Change-Id: I535e44e66578fc90f449be59586f19b154677caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424092 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#812588}
-
Thanh Nguyen authored
App reinstall recommendations should only be shown if suggested content flag is enabled. Bug: 1028373 Change-Id: Ic0dead9396634715c89cd85f284b41a55a78b08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440200Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812587}
-
Hirokazu Honda authored
libvpx::VP9RateControlRtcConfig::layer_target_bitrate must be set in an accumulative manner, but originally Vp9Encoder sets the bitrate of each layer independently. This CL fixes the wrong settlement. Bug: b:169219904, 1030199 Test: appr.tc/?vrc=vp9&vsc=vp9 Change-Id: I27787d2ce43394ff5b032562a21425da4654e772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434416 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812586}
-
arthursonzogni authored
The [coop-reporting-explainer] defined several URLs that might be reported: - initial_popup_url - openee_url - opener_url - other_document_url - referrer This patch adds body.referrer [coop-reporting-explainer]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md Bug: 1090273 Change-Id: Ia61b9abe7b4bbe361438341d8629e3ec4d1028ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421452Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Alex Rudenko authored
DevTools has been rolled so enabling this test. The test was marked to time out in Release builds before it was disabled. I have run the test multiple times to make sure it is not flaky and does not time out so I am removing the expectation of timeout as well. Bug: 1044424 Change-Id: Ia13dd440b4310a0c4802796619649f9d9ba2e95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440590 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#812584}
-
Makoto Shimazu authored
Bug: 1095896 Change-Id: I5f38333e48d61d42239254cbe58176d1ba5b3829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440001 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#812583}
-
Alice Wang authored
This reverts commit bd3b0ee6. Reason for revert: Likely the cause of of the compile crash on https://ci.chromium.org/p/chrome/builders/ci/arm64-unpublished-builder-rel/14332 Error: ../../clank/android_webview/next/java/src/com/android/webview/chromium/PacProcessorForS.java:34: error: constructor AwPacProcessor in class AwPacProcessor cannot be applied to given types; mProcessor = new AwPacProcessor(network); ^ required: no arguments found: Network reason: actual and formal argument lists differ in length 1 error Original change's description: > [aw] Allow to set Network in AwPacProcessor. > > Bug: 1085115 > Change-Id: I8846261a0f21ecb48692b70ab778f68996843760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414173 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Anna Malova <amalova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812494} TBR=torne@chromium.org,amalova@chromium.org Change-Id: I087cdfa4fd0f4ca71c50a38b3a01fec1f67fa7aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440600Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812582}
-
Daniel Hosseinian authored
1) Use a new method focusAndScroll() on thumbnails that disables the default scrolling behavior of focus() and uses scrollIntoView() instead. That way the scrolling behavior of focused and active thumbnails are unified. 2) Add a top padding to the first thumbnail so the box shadow is shown when the thumbnail is scrolled into view. 3) Remove the opacity transition on thumbnails, which was causing some flashing to occur while scrolling through the active thumbnail quickly using the keyboard. Bug: 652400 Change-Id: Ie8b26c670b03b4829444215d184e54e39f344924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441936Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812581}
-
Alexander Dunaev authored
Blocking the power save mode has platform-specific bits. Ozone didn't have any support for that. This CL introduces the concept of a power save blocker for Ozone, and implements the X11-specific part of it. Bug: 1121926 Change-Id: Ic60210b55808cb30e27b0811e5fade69ac01512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378071 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812580}
-
Ramin Halavati authored
kRequestedFileSystemTemporary is recently removed from UseCounters in crrev.com/c/2414917 along with a number of other highly used metrics. This metric and kRequestedFileSystemPersistent are now replaced with dedicated UKMs. Bug: 990731, 1129061 Change-Id: Iba8be6a1fe4063388843f2a54f95827fefd3a42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421746Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#812579}
-
Miyoung Shin authored
This is a reland of fe6e27d6 Old ExtensionApiTest.OpenOrClosedShadowRootInBackgroundPage navigated to unnecessary empty.html and timeout error occurs as flaky, but TC already runs the background page successfully, so this CL rewrites the test case using ExtensionApiTest::RunExtensionTest simply to fix a flaky issue. Original change's description: > Allow access to closed shadow root from Extension > > This CL introduces chrome.dom.openOrClosedShadowRoot that is a > read-only property to allow access to the closed shadow root in > the Extension's content script. > > Bug: 778816 > Change-Id: I933bc5d3996a74f46ee75181c535150901a5a46a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319951 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809277} TBR=peria@chromium.org,yukishiino@chromium.org,tkent@chromium.org,karandeepb@chromium.org,mkwst@chromium.org,masonfreed@chromium.org Bug: 778816 Change-Id: I3bb7289cbc0c7c8a1c970000d87458f937acd4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428528 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812578}
-
Scott Violet authored
In contrast to other overflow types, 'clip' does not create a PaintLayerScrollableArea (a PaintLayer is created though). The approach taken to apply the clip is to accumulate overflow as is normally done, and then apply the clip (as necessary) at the end. This enables some layout tests exercising this code, but a couple are still disabled: external/wpt/css/css-overflow/clip-003.html : this one (currently) has indeterministic behavior. It triggers a vertical scrollbar, but the presence of the vertical scrollbar necessitates a horizontal scrollbar. Whether the horizontal scrollbar is added varies between ng and classic. external/wpt/css/css-overflow/overflow-body-propagation-008.html: I believe the reference test needs to be updated. The test case has a border-right, where as the reference does not. This seems to be triggering a difference on the mac, which I need to further investigate. BUG=1087667 TEST=various tests in external/wpt/css/css-overflow Change-Id: I7a44505b556da1a26da1eeffd612eeebf20c509c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414911Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812577}
-
Istiaque Ahmed authored
This CL adds the histogram Extensions.Events.DispatchWithServiceWorkerBackground when an extension event is dispatched to the background service worker of an extension. Bug: None Change-Id: I6a119dfb4d39b518201c8cf166e99a2f4595dac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441949 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#812576}
-
Nick Burris authored
This patch fixes a bug in the SPC controller logic that checks for the existence of the PaymentRequestSpec. This bug results in no UI shown when the feature is activated. Bug: 1133822 1127322 Change-Id: I27d1d6f2a53e859a132f2f73237a360979efe6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441937 Commit-Queue: Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812575}
-
Siyu An authored
We found in the metrics the number of (bubble shown) and number of (bubble closed with reason) are not matched. I am suspecting in some cases it will be logged before the close_reason is returned, and in this case the reason will be unknown[1]. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/autofill/payments/save_card_bubble_views.cc;l=123-134;drc=d9daac114a9f5c8a7bc99042d92f40dcd62c3d08 Added a logging to verify Bug: 1070799 Change-Id: I8a0cb2eb4c4158d11fcd6593777ad568947812d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441014 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#812574}
-
Hazem Ashmawy authored
Batch all espresso devui tests in PER_CLASS batches. Bug: 1120847 Test: run_webview_instrumentation_test_apk -A Batch=android_webview_devui Change-Id: I59c117d0f26e75dfe4200954ce2153db81d842e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438536 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812573}
-
Irina Fedorova authored
This CL adds localized strings for compromised credentials sections to be used if a user is not sign in but has compromised credentials that have been found in the past. Bug: 1119752 Change-Id: Idb3a825b248f5a8f273b0ccb81f9c6229821cb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438461 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812572}
-
Eric Willigers authored
WebApplicationInfo now uses apps::ShareTarget, for easy detection of changes. Note that ShareTarget is only implemented for web apps, not bookmark apps. Bug: 1127213 Change-Id: Iadba1cd798cc5f87c58c1af9ec1a12a66d3b60c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437994Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4be5db9..e9a57883 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9aa710465a2366ab9ef9d537c3e71c6357937526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440239Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812570}
-
Esmael El-Moslimany authored
Bug: 1132424 Change-Id: I1b56fdec5c37d81a4939e986b3282af4585772ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440970 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812569}
-
Nate Fischer authored
The kOutOfBlinkCors base::Feature was removed in https://crrev.com/c/2415752. This removes the corresponding Dev UI switch since it's obsolete. Fixed: 1132134 Test: N/A Change-Id: I314358545fd89ccdcf68a340da671242e4be99c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441933 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#812568}
-
