- 30 Jul, 2019 40 commits
-
-
Ahmed Mehfooz authored
We do not currently flip the canvas for focus rings when RTL is enabled. This can cause certain focus rings to be drawn incorrectly for their corresponding buttons. Some views change their canvas flipping on RTL behavior after installing focus rings. This can cause a recently added DCHECK to fail. Bug: 986571, 960284 Change-Id: Ic24db27c1faee1c62bafbb0de1db3426bf5c23e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719673 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#682117}
-
Gayane Petrosyan authored
Bug: 988880 Change-Id: I7107fb8c3399ae1ce561d8971e40e42e112371e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725006 Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682116}
-
Akihiro Ota authored
Implement AutofillPopupViewNativeViews::GetAccessibleNodeData to set the role of the autofill suggestions container to kMenu. This method was previously unimplemented, which was causing issues with PosInSet and SetSize calculations of the enclosed AutofillPopupItemViews. This change also adds robustness to the accessibility posinset and setsize calculation code by continuing over nodes with role of kUnknown. This way, containers do not have to be immediate parents of their items, which is common on the web. Lastly, this change adds a test in accessibility code to verify the new behavior. Bug: 985987 Change-Id: I3078ff4ddfcb31224af07523da8b385267644bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709660 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682115}
-
Fabrice de Gans-Riberi authored
* Add the host chromedriver binary as part of the Fuchsia build. * Add a CIPD package to upload a stripped chromedriver binary. Bug: IN-1321 (Fuchsia internal) Change-Id: Ia414914304ede7a54ff097365bb72cba6674e5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719377 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#682114}
-
Cliff Smolinsky authored
Add wtsapi32 to delayloads list and remove it from the allowed list for chrome_child.dll. This dll is used in the browser process and with the remoting feature, neither of which requires immediate loading in chrome_child.dll. Bug: 987672 Change-Id: Ib3ddbb27578f76d854e1966a12eb1fc6cd30e9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719304Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff3f2082..bd0b0262 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d219f23380b788615a877510beb8a61f80280cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725130Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682112}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c73c7e11dbb..0395e7c66a5f git log 6c73c7e11dbb..0395e7c66a5f --date=short --no-merges --format='%ad %ae %s' 2019-07-29 moragues@google.com Atlas: Remove deprecated firmware-atlas-11827.12.B from build config Created with: gclient setdep -r src/third_party/chromite@0395e7c66a5f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1c8eaefc22db8e05f207e2e64944a736ae91a2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682111}
-
Mohsen Izadi authored
When underlying cc::Layer of a ui::Layer is changed via ui::Layer::SwitchToLayer(), a bunch of properties are transferred from the old cc::Layer to the new one. masks_to_bounds() value should also be transferred. BUG=988819 TEST=LayerWithRealCompositorTest.SwitchCCLayerTrilinearFiltering/* in compositor_unittests Change-Id: I36d245a91975f0e3e6a6cd51119d973b0452ae68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725095Reviewed-by:enne <enne@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682110}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It removes CancelAllRequests and CancelRequestsForAccount from PO2TS since these are only used by PO2TS and it could call these methods through |token_manager_| instead of having helper methods. It moves CancelAllRequests and CancelRequestsForAccount from ProfileOAuth2TokenServiceTest to OAuth2AccessTokenManagerTest since OAuth2AccessTokenManager manages requests. It adds AddAccount to FakeOAuth2AccessTokenManagerDelegate to handle multiple accounts. Bug: 967598 Change-Id: I550a241a632a84f431c8eb348b544b81f1b8eac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715174 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682109}
-
Collin Baker authored
FloodFillInkDropRipple uses different durations for flood-fill and fade-out animations for different target states. This changes InstallableInkDrop to use the same times. Bug: 933384 Change-Id: I84520a7c8b919223a71df979cebcbdb070dfdf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716099 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#682108}
-
Hesen Zhang authored
- In support of loading/adding/deleting a vector of icons with callbacks. - Change Add API, removing key argument. - Will follow-up unit test in next cl. Bug: 963290 Change-Id: Ie0fddeea5a1dc74103fb5765a976bb3ad933e156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722407 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682107}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2386ffedf334..ff7e2ebc5e4d git log 2386ffedf334..ff7e2ebc5e4d --date=short --no-merges --format='%ad %ae %s' 2019-07-29 rnasri@google.com Add screenshots based speed index metric Created with: gclient setdep -r src/third_party/catapult@ff7e2ebc5e4d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:983638 Change-Id: I67e976206f255ea37092e9a7ef9972d7cec223a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725295Reviewed-by:
-
Vlad Tsyrklevich authored
WaitForMultiprocessTestChildExit on Android currently can't handle child process crashes due to threading requirements for the Android-specific implementation. Hack around it for now. Bug: 973167 Change-Id: I7027dba463150802516ea525f4fc4e2cdfd8d18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725335 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#682105}
-
Koji Ishii authored
This patch changes AXNodeObject::AriaAutoComplete() to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII should be sufficient for most web platform usages. From the spec perspective, the ARIA-HTML spec does not specify case-insensitiveness for "aria-autocomplete" attribute: https://www.w3.org/TR/wai-aria-1.1/#aria-autocomplete but HTML uses ASCII case-insensitive for all its attributes: https://infra.spec.whatwg.org/#ascii-case-insensitive Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. Bug: 627682 Change-Id: I9aa1e89365aee4d795daaea53103049ff5bdfd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720820Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682104}
-
Keith Lee authored
Change-Id: I2e895223f327172b59613302454654b943d7fdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722831 Auto-Submit: Keith Lee <keithlee@google.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Keith Lee <keithlee@google.com> Cr-Commit-Position: refs/heads/master@{#682103}
-
Andrew Grieve authored
It's used only for chrome_apk. Also simplifies resource_blacklist_regex in compile_resources.py so that it is able to remove a resource from all densities. Bug: 988047 Change-Id: Ic47140f9f597dcee7abd0762131a5dbffd08780b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721452Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#682102}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5048a6a756bf..e68b5bd4e6e9 git log 5048a6a756bf..e68b5bd4e6e9 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 csmartdalton@google.com don't try to format includes on windows 2019-07-29 csmartdalton@google.com Rename labrynth.cpp -> labyrinth.cpp Created with: gclient setdep -r src/third_party/skia@e68b5bd4e6e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: If241921fa74997277fb312790fdbb1dafc31be64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725294Reviewed-by:
-
Timothy Loh authored
This CL removes the CrostiniAppLaunchObserver abstraction, which does not actually give us any benefit because where it is used we already know about the derived class, and it also isn't used like a regular observer. I also updated includes to make the dependencies clearer. Change-Id: Id75bac0db683a9800ede6b9993c62dfa927231b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722139 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682100}
-
Oliver Dunk authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ucEUTqoi4Nc/wx3q-B7tAQAJ Bug: chromium:966249 Change-Id: I84c95a54724227815e674b3804119666bf6b0291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702364 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#682099}
-
George Burgess IV authored
Our current profile is one from a release branch, and release branch profiles have caused us headaches in the past. We're fixing the autoroller to no longer roll us to these profiles in https://skia-review.googlesource.com/c/buildbot/+/230302 . That CL requires us to be on a profile that isn't a branch profile. TBR=agrieve@chromium.org Bug: 988452 Change-Id: I6a631e16bb0f40d1613bfdbb5b5a2e50bbaa5a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723025Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#682098}
-
Jeremy Chinsen authored
Currently draw_utils::GetBottomFillRect() returns the gap on the bottom side of a page created by insetting the page. However, in two-up view, the bottom gap for a page has height equal to the difference in height between the current page and its adjacent one. draw_utils::GetBottomGapBetweenRects() takes the bottom component of a page and a rectangle, returning the portion of the rectangle that is below the page. This will be used in PDFiumEngine to compute the bottom empty space for a page in two-up view as mentioned above. Bug: 51472 Change-Id: I436600264106340ca6699799359149f29c797844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721318Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#682097}
-
Jonathan Ross authored
The image diff was approved. Re-enable the test TBR=ynovikov@chromium.org TEST=Pixel_CSS3DBlueBox Bug: 976370 Change-Id: I99d457c83e72982525f6ef4b9d2ce16d1b1101e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724890Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#682096}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8404419a9f8..385f490b054e Created with: gclient setdep -r src-internal@385f490b054e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ic02267473efe1de63739ff6c149af1a9ba967c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725188Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682095}
-
John Rummell authored
Now that FileStreamReader and FileStreamWriter work with PluginPrivateFileSystem, enable incognito mode for PluginPrivateFileSystem. Also updates FileStreamReader to work with the PluginPrivateFileSystem in incognito mode, as the ObfuscatedFileUtilMemoryDelegate is different. This adds 2 more browser tests that verify that encrypted media can read and write files successfully in incognito mode (as it uses the PluginPrivateFileSystem). Verified using inotifywait that the test does not write anything to disk. Bug: 958294,902021 Test: new browser_tests pass Change-Id: I01914cdd866ff96867e7bebfeaea6ef827a5a9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718985Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682094}
-
Mustafa Emre Acer authored
When the lookalike URL interstitial stops a redirect, reloading it navigates to the end of the redirect chain which hides the interstitial. In order to prevent this, this CL stores the parameters of the interstitial (URL, redirect chain and referrer) as WebContentsUserData. On page reload, the throttle retrieves the parameters and checks if the currently navigated URL is at the end of the stored redirect chain. If so, it cancels the current navigation (the reload) and navigates back to the original lookalike URL that triggered the interstitial. As a result, a reload will end up with the same interstitial as before. The throttle immediately clears stored interstitial parameters after it retrieves them, so that unrelated navigations (to a different URL, or initiated directly by the user) don't re-trigger the interstitial. Bug: 941886 Change-Id: If37802815f296bf534d7fb3b54fe96813d1659d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715759 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#682093}
-
Jun Mukai authored
Currently state changes are ignored when the app-list is closed, so I think it's better not to clear the search state there. Instead this allows to clear the state on showing (ResetForShow). This works fine with tablet mode so I'm leaving some of the existing conditions as-is. Ideally state change should be accepted after the closing animation finishes -- that wouldn't affect the rendering and animation smoothness. Modifying that requires larger changes, but this CL wants to be small for merging to M77 branch. Bug: 987584 Test: manually Change-Id: Ie577941b662e68768b2ef03490eb6eb7324332d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725190Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#682092}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/10fe83305a04..7dec2d1c5689 git log 10fe83305a04..7dec2d1c5689 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 idanr@google.com Use Vulkan 1.1 if available Created with: gclient setdep -r src/third_party/dawn@7dec2d1c5689 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:976495 Change-Id: I50b2d054dc66ad5417174eabed3c19c1b4b0b4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725187Reviewed-by:
-
Min Qin authored
These code are no longer being used, remove them BUG=934009 Change-Id: If65a6104796a3e9b046cca5113ea19f352941183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641804 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#682090}
-
Nick Harper authored
TBR=rsleevi@chromium.org Binary-Size: Increase due to adding more domains to HSTS preload list Change-Id: I70b8c1444633101e357d73dd1bcfb3c8d1c47672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722984 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682089}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves OAuth2TokenServiceObserver from google_apis to components/signin since O2TS's been folded into PO2TS and renames OAuth2TokenServiceObserver to ProfileOAuth2TokenServiceObserver. Bug: 967598 Change-Id: If85f29dbc29f4186e19bc82fcdaac2fd053295ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716203 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0eb5c83949fa..e6092f3bc901 git log 0eb5c83949fa..e6092f3bc901 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 bclayton@google.com Fix memory corruption SpirvShaderKey::SpecializationInfo 2019-07-29 bclayton@google.com Use raw pointers for the routine const cache. Created with: gclient setdep -r src/third_party/swiftshader@e6092f3bc901 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137524292,chromium:b/137649247 Change-Id: Ia06ec781daf74eca9565dd05b74ae787c018984f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725217Reviewed-by:
-
John Emau authored
Bug: 963183 Change-Id: I16c95430821e329433334a9d6515b9c3fc555f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711061Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: John Emau <johnemau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682086}
-
Hiroki Nakagawa authored
ServiceWorkerNavigationHandle can be destroyed while service worker interception is happining for workers. To avoid crashes, this CL adds guards in ServiceWorkerNavigationLoaderInterceptor and WorkerScriptLoader. For navigation, it's guaranteed that the handle outlives the interceptor, so it's safe. See https://bugs.chromium.org/p/chromium/issues/detail?id=988247#c3 Bug: 988247 Change-Id: Ib72005c4832895eb82f8e28160d5b879ad19794c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722933 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682085}
-
James Cook authored
Specifically, the "OSSettings" test files that were forked as part of the SplitSettings project. Bug: none Test: browser_tests Change-Id: Ice152bb936d541d956dc45a442b08eb177508371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721380Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#682084}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fee18fe49862..d31c667503bc git log fee18fe49862..d31c667503bc --date=short --no-merges --format='%ad %ae %s' 2019-07-29 benjamin.beaudry@microsoft.com Get the rotation angle of a character. 2019-07-29 myoki.crystal@gmail.com Observe CXFA_FFPageView across OnSetFocus() events. 2019-07-29 thestig@chromium.org Roll third_party/freetype/src/ b110acba9..12af46b64 (2 commits) 2019-07-29 thestig@chromium.org Fix some nits in FPDFDOC_InitFormFillEnvironment(). Created with: gclient setdep -r src/third_party/pdfium@d31c667503bc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: chromium:985604,chromium:982397 Change-Id: I0bcdc5298da26dc5baaa1e1556c78d4e42a8b900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725216Reviewed-by:
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/b77e5c76252b..a45c24ac1878 $ git log b77e5c762..a45c24ac1 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 misterg Googletest export 2019-07-29 misterg Manual docs tweaks still in preparation for including docs with code pushes 2019-07-29 misterg Manual docs tweaks still in preparation for including docs with code pushes 2019-07-11 adam.f.badura Correct CMake to cover Cygwin 2019-07-25 absl-team Googletest export 2019-07-25 absl-team Googletest export 2019-07-18 misterg Googletest export Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: Ib2312c3484e9856a4a6703b3eeb8e633e807aa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724812 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682082}
-
Karan Bhatia authored
This CL adds support for a new Redirect dictionary to the "action" field of a Rule. This allows specifying rules which redirect to extension paths or performing various url transformations. Eventually this is meant to replace the "redirectUrl" field. This CL adds support for the schema and indexing of these rules. In a subsequent CL, these rules will be evaluated. This also fixes a bug with the current handling of redirectUrl key when the redirect url is relative. The query and fragment paths within the relative url weren't being handled correctly. DOC=https://docs.google.com/document/d/1foL79VwByaVeUwYPBfZeqyC2SYcAawhjjH05eqHqW_E/edit BUG=983685 No-Presubmit: True Change-Id: Ief61eed0a640f5fcadbc17e58fe611691fa64e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705019 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682081}
-
Nate Chapin authored
Bug: 984932 Test: fast/loader/target-blank-to-local-resource.html Change-Id: Ic257c6ed3d15522663cd96c3a9eb190afeb0e9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721350 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#682080}
-
ziyangch authored
Bug: internal b/138405284 Test: Cast YouTube to the device and check the log. -Build the whole ota package with this change. -Build the whole ota package without this change and update the cast_shell with this change. Change-Id: I1645cabae8752c3a88d44d71c3b2d038fef5af6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725182Reviewed-by:Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#682079}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/gfx/image. *_struct_traits.* => *_mojom_traits.* ui/gfx/image/mojo => ui/gfx/image/mojom Bug: 806965 Change-Id: I0c9eb26fdfdae25716f9754c76a6e5156624a0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723831Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
