GitLab

Issue #1) creating HTML by string is fast in all browsers.
Creating HTML by DOM methods is extremely slow in IE. 100-300x slower.

http://www.quirksmode.org/dom/innerhtml.html

Issue #2) There's a bug in IE related to <select> tags.

http://support.microsoft.com/kb/276228


Review URL: http://codereview.chromium.org/155154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20059 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pinkerton

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20058 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20057 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20056 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: http://codereview.chromium.org/149267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=13907

Review URL: http://codereview.chromium.org/149150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20054 0039d316-1c4b-4281-b951-d872f2087c98

Basics of a new TabStrip.It's very, very rough, but I wanted to check it in so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout!
Review URL: http://codereview.chromium.org/42490

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98

Hook up the prefs for the optional home buttons and page/wrench buttons. Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked. 
BUG=13151
TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar.
Review URL: http://codereview.chromium.org/155151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16096, 10737, 10738
TEST=watch the linux ui buildbots for valgrind warnings; this should make several go away

Review URL: http://codereview.chromium.org/155152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20050 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20049 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20047 0039d316-1c4b-4281-b951-d872f2087c98

CID=2001
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20046 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20045 0039d316-1c4b-4281-b951-d872f2087c98

on Mac.  I'm leaving the window resizable for now, because I dislike
non-resizable windows.  This is easy enough to change later.

BUG=None
TEST=After bringing up the dialog, verify that the only way to dismiss
it is by pressing either the wait button or the kill button.
Review URL: http://codereview.chromium.org/151009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20044 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/13967

Review URL: http://codereview.chromium.org/149259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20043 0039d316-1c4b-4281-b951-d872f2087c98

Change the use of typedef Language in Spell Check files back to std::string. It is unnecessary, and is conflicting with enum Language definition for compact language detection library.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20042 0039d316-1c4b-4281-b951-d872f2087c98

There are still a few issues, but that's a start.
- only windowed plugins
- we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID).
- the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC.
- some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live.

Patch from Antoine Labour <piman@google.com>, with some touchups by me.

Review URL: http://codereview.chromium.org/146078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=13360

Review URL: http://codereview.chromium.org/149164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20040 0039d316-1c4b-4281-b951-d872f2087c98

Calls avcodec_free and avcodec_thread_free appropriately.

Review URL: http://codereview.chromium.org/151192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20039 0039d316-1c4b-4281-b951-d872f2087c98

WebMediaPlayerImpl interacts with multiple threads that it
becomes necessary to make it refcounted so we can post task
on different threads' message loop.

Review URL: http://codereview.chromium.org/147225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20038 0039d316-1c4b-4281-b951-d872f2087c98

Crashers from the field indicate the navigation entry can be NULL. This is not expected and not clear how this happen.
Working-around the crasher.

BUG=http://crbug.com/15605
TEST=None



Review URL: http://codereview.chromium.org/150185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20037 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=12863,16093,16102,16103,16104

Review URL: http://codereview.chromium.org/155144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20036 0039d316-1c4b-4281-b951-d872f2087c98

Fix a typo.  TextDirection is the name of the enum, while GetTextDirection returns the current text direction.  Also fixes a few lint nits.

CID=4539
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20035 0039d316-1c4b-4281-b951-d872f2087c98

Fix the GC of workers. When Worker object is GC'ed in the renderer, we need to terminate the worker process.
BUG=15647, 15759
TEST=new ui_test is part of this CL
Review URL: http://codereview.chromium.org/151125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20034 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20033 0039d316-1c4b-4281-b951-d872f2087c98

This is step 1 of moving ResourceFetcher usage out of WebFrame.  This
CL adds a new method to WebFrame, named DispatchWillSendRequest, which
may be used to associate a WebURLRequest with the WebFrame.  This
triggers the WebViewDelegate's WillSendRequest method among other things.

ResourceFetcher and friends have been modified to use callbacks instead
of delegates.  I just find this approach a bit cleaner and easier to
work with.

BUG=15648
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/149172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WebKit Mac builders go green.
TBR=nsylvain


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20030 0039d316-1c4b-4281-b951-d872f2087c98

BUG:16106

Review URL: http://codereview.chromium.org/155147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20029 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons.  Observe that WCB's are themed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19758
Review URL: http://codereview.chromium.org/150041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise any browser window closed afterwards will overwrite settings with the original ones.

Review URL: http://codereview.chromium.org/155140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12863,16089,16091,16092,16093,16095,16096
TEST=run tools/valgrind/chrome_tests.sh -t ui and see many fewer warnings

Review URL: http://codereview.chromium.org/149250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20025 0039d316-1c4b-4281-b951-d872f2087c98

so fork() doesn't corrupt log files; lets --generate_suppressions 
work even with the hacky valgrind fix that makes anything but --log-file
crash on child of fork().

Also avoid killing user desktop session if zygote dies!

BUG=none, but related to fix for http://crbug.com/15771
TEST=patch valgrind with fork workaround; sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui logs you out on linux without this.

Review URL: http://codereview.chromium.org/155130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20024 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155139


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20023 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155136


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20022 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: Issue 'scripts' command on attach only, work based on after_compile events in the rest of the cases (such as refresh).
BUG=15825

Review URL: http://codereview.chromium.org/155138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20021 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: clear breakpoints when devtools window is closing. This change depends on v8 change: http://codereview.chromium.org/149197

BUG=15993
Review URL: http://codereview.chromium.org/155090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20020 0039d316-1c4b-4281-b951-d872f2087c98

This makes tooltips behave more normally, and fixes some of the bugs. Patch by Jens Alfke (snej@google.com)
BUG=15655
TEST=tooltips should feel more like native tooltips

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20019 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20018 0039d316-1c4b-4281-b951-d872f2087c98