- 09 Dec, 2020 40 commits
-
-
Timothy Loh authored
plugin_vm_installer.h: - Update declaration order to explicitly show installation flow, and match style guide. - Make a couple of internal functions private - Update comments to be clearer/simpler/etc. plugin_vm_installer.cc changes: - Re-order function definitions in .cc to match header file Bug: 1063748 Change-Id: I4618d5a3845d8ac381063cec0ae1adc798364702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576967 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#835116}
-
Jinsuk Kim authored
LocationBarModel has several dependencies on classes in //chrome_java target that provide public static utils methods. This CL injects them as functional interfaces through the constructor. Bug: 1127732 Change-Id: Ia502e2d43bc140c1a6e5efa735e93a30a4b61e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543725Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#835115}
-
Andres Calderon Jaramillo authored
This CL removes the usage of a GpuMemoryBufferFactory from the V4L2VideoEncodeAccelerator. This is because we don't actually need it to allocate buffers and it simplifies things. Note that we must start the |encoder_task_runner_| with base::MayBlock() because the first encoder to make use of this path will open the render node. Bug: b:173167846 Test: video.EncodeAccel.h264_720p_nv12_dmabuf on elm Change-Id: I01d5f63f0b358c0ee9bb448ded7ba24355a72f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568548 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835114}
-
Alexis Hetu authored
This issue is related to the GetInstalledVersionLinuxTest.WithVersion test where, unlike on Windows or MacOS, querying Chrome's version relies on the content of the console output of a child process. This cl makes GetInstalledVersion() slightly more verbose in order to make it easy to identify potential warnings (or any other console outputs) when querying the version. Bug: chromium:1152832 Change-Id: Iea153887d3f1e439c1a6305b88c93dfef17cc4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560609 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#835113}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607471901-85f06a8978ebf1d40d9cf80572b77a4ab0bcfbe1.profdata to chrome-linux-master-1607493425-c73fec691091cf0b277c9f5003730e7d0a079735.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I78161c39acf075030fe4dc27b2df22ab94b179a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835112}
-
Asami Doi authored
This CL enables the kCheckOfflineCapability feature with the warn only mode by default in M89. Bug: 965802 Change-Id: Ife97e09f4cb03cf3c3316f7d59368b7d64e10996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580668Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835111}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2979a9c445f4..ea80f524f61b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: Iba3972c80b8b857044dbd64e6f3bdf1f74bde26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835110}
-
Hiroki Nakagawa authored
This CL disallows activation of prerendered pages for pop-up windows. The previous CL (https://crrev.com/c/2494291) already did the same thing for iframes. In addition, this adds tests for both iframes and pop-up windows. We might also need to disallow both the contexts to trigger navigation for prerendering (trigger <link rel=prerender>), but it is out of the scope of this CL. Change-Id: I741b07983e2e8d9f9f3af88ca618129c5d52674f Bug: 1138711, 1138723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560362Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#835109}
-
Victor Hugo Vianna Silva authored
If the new (DISABLED_BY_DEFAULT) IgnoreEncryptionKeysLongMissing feature is enabled, ModelTypeWorker will ignore both future and pending updates encrypted with keys that remained unknown for 'too long', as measured by UnknownEncryptionKeyInfo::gu_responses_while_should_have_been_known. The threshold for 'too long' is arbitrary for the moment. Two different metrics are added: the first is logged when a key starts being ignored, and records the number of pending updates that were dropped. The second is recorded individually for each incoming update entity that's encrypted with an ignored key. Future CLs will start persisting the notion of unknown keys across browser restarts. Bug: 1109221 Change-Id: I52b841368385ce347fbaa8746501ab07a5b7752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567883Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#835108}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607471901-3e959809a33b2895908083a52c31919f2827c11a.profdata to chrome-mac-master-1607493425-af0aa6c36468b9d0e6f03a33932dae6d4017f80e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic0d92302c8a5d75521835a639fd794a5cf331006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581420Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/27e52ca05dc7..36f74334e16b 2020-12-09 syoussefi@chromium.org Vulkan: Fix query pause on framebuffer binding change 2020-12-09 jiawei.shao@intel.com Enable ComputeShaderTest/DrawDispatchDispatchDraw on Intel/Win/Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ie0bcd4ec30bce6b5af4e8c06d5b805f1f5dafc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580232Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b219431a16..b5c844554e30 2020-12-09 treehugger-gerrit@google.com Merge "Do not use template for profiler guardrails." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icf4559dd8697791a8a9bf312f2a66aba4c14e81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581223Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607450253-68d0fa295c41f196aa098d193a0a21605dcba7f2.profdata to chrome-win64-master-1607460951-8dc40a3fea0b80cf0b8a704b92ca55c4b39739b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0c34057f1ed1d550e0ad6cfac8d79770bf8257ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580771Reviewed-by:
-
Aga Wronska authored
Bug: 1151166 Change-Id: I4fbb7608b8f194d957dd31c731aa9e1cba50675f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580406 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#835103}
-
Heng-Ruey Hsu authored
Refactor delegate to support multiple clients and manipulate buffers from corresponding clients according to the stream type. Bug: b:151047537 Test: Manually test Change-Id: I511be4f20f495a973141a7199f4b4c3c50871f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351932 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#835102}
-
Nicolas Arciniega authored
In Edge, we found that this test would occasionally fail due to simple timing issues. This change enforces the correct ordering of received postMessage calls and makes sure each tested iframe loads before we make make any asserts. Change-Id: I051952088bf3d958a7e55cc4292b6107360dc322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580748Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#835101}
-
Thanh Nguyen authored
This CL allows LSS clients to use GetIndex multiple times. It also allows SearchMetricsReporter being shared between multiple clients. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I23b2433424d1ccae45ed8cbce1d490d5fa07759d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580667Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835100}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7cbfe50ac1b1..406bc3320344 2020-12-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25a38d382f7ed654968a457cae2bf5b059a0b17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579839Reviewed-by:
-
Miyoung Shin authored
This CL uses @JavascriptInterface explicitly instead of passing null for JavaBridge* tests unless the tests are specifically testing the case of no annotations. Bug: 1105935 Change-Id: Ib1a7fb5e69bd1899f3a56278dc9599030f697eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569012 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835098}
-
Darren Shen authored
System PK and the VK extension share the same IME service and backend decoder. This shared state can make it brittle to swap between the two, especially since they use different APIs. Rather than handle all the edge cases carefully, we decided to opt for a more robust solution: - When the extension is enabled, all events are routed to the extension, including PK events. - When the extension is disabled, all events are routed to the system PK code. To ensure that the extension and system PK start with a clean state, we always reactivate the current engine (which would send an activate and focus event) when switching between the two. This guarantees that the extension and system PK are isolated from each other. Tested: on real device, flipping back and forth between clamshell/tablet. Bug: b/172771899 Change-Id: Ibef308a5b8798f5719da038d21320d11c689a3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567013Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#835097}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a737e5f65ca1..c6b219431a16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I544e086c423826528b891474b1ec6ef2e5a949a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581035Reviewed-by:
-
Curtis McMullan authored
Make the assistive multi word suggestions flag available to the IME service. Bug: 1146266 Change-Id: Iba1f3c15ea8386fe3374f2ed45454616c49ca15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580640Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835095}
-
Jan Wilken Dörrie authored
This change moves base::Contains into a new base/containers/contains.h header. This organizes base/stl_util.h a bit, which has become somewhat of a dumping ground. Bug: 970209 Change-Id: I7f0df1a1cbfb323f060f2b7a67bcf9c139aa589e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578941Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835094}
-
Thomas Guilbert authored
This CL updates LocalFileSystemOperation to use OnceClosures instead of closures. Bug: 1152272 Change-Id: I5aef5b841cdc9f0553aa06a53329d1f7be4c0d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576692 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#835093}
-
Makoto Shimazu authored
This is a clean up task after ServiceWorkerOnUI. EmbeddedWorkerInstance::CreateFactoryBundles() now returns the parameters without callbacks. Bug: 1138155 Change-Id: Ifc896fb6c1c3e8d897f7d9ca1abed6fa5ddd9c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576962 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835092}
-
Alan Cutter authored
This CL adds a UI tweak to web app windows where instead of flashing the origin we flash the app name in the title bar on launch. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=480010&signed_aid=kCtHgWsEYOU09MTBmCOz_w==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=480009&signed_aid=MXfRHF_FvvLj76okiIayNg==&inline=1 Bug: 1156934 Change-Id: Ie5a32a5cf7acae69085378eb63ed5183b7c3f0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581162 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#835091}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb1cad334635..2979a9c445f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I165b2d25196d944dca0d4cb6be13a63e0a675d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579946Reviewed-by:
-
Elly Fong-Jones authored
It is very flaky on arm64. Bug: 1154345 Change-Id: I7305f56291c191fcdcec6c6c89408459d53a13ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580165 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#835089}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fde98cbddd43..5e744acfad58 2020-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 251ba5cb119f to 27e52ca05dc7 (24 revisions) 2020-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3668d352bc5f to 30805557e651 (33 revisions) 2020-12-09 reed@google.com Revert "Revert "Use explicit samplingoptions"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Test: Test: Test:Test: Test: Seven Deadly Sins MECTest: Test: angle_perftests --gtest_filter="*whatsapp*" Change-Id: I769234db0e270ce3a241c7d7269c346a6f41afa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581073Reviewed-by:
-
Darren Shen authored
Both the web and ARC++ IME frameworks support moving the caret after InsertText, but this functionality is not exposed to IMEs. Our new IME needs this feature, so this patch adds an option to move the cursor to TextInputClient. Unfortunately, the web and ARC++ APIs are slightly different: - Web allows the the cursor to be moved anywhere. - ARC++ doesn't allow the cursor to be moved inside the inserted text. Therefore, although both web and ARC++ take in an integer cursor position parameter, they have very different meanings. To avoid confusion, we use an enum to indicate whether the cursor should be before or after the inserted text (since that's the minimal feature that the IME needs). To keep this CL small, we will first introduce the enum with only a single value (move cursor after text). A future CL will add the additional parameter. Bug: 1155331 Change-Id: I5eb9e5c23fef290b9962b1dee327c76343f08f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576062Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#835087}
-
Noel Gordon authored
Mojo requests from the SWA WebContents appear on the receiving SWA page handler mojo endpoint for servicing - that servicing will be handled by the SWA UI class or its delegate. Add the SWA UI class to the page handler mojo pipe constructor. Mention it is the owning |this| since the page handler pipe is both created and owned by the SWA UI class. Bug: 1113981 Change-Id: Ic32e748df303cbaf26b82fe15d39c8b02cee92c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580980Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835086}
-
spdonghao authored
Bug: 1155761 Change-Id: I9c98e3c0066c98e9d9fe7fad43442c0615bda4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576112Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#835085}
-
Darren Shen authored
Most IME tests currently use a class called DummyTextInputClient, which is a mix of a mock and a fake. This makes it quite difficult to use. Following testing best practices, we introduce a proper WIP fake for TextInputClient that complies with the TextInputClient interface. Future CLs will migrate more and more tests to FakeTextInputClient. DummyTextInputClient will eventually be removed. Bug: 1148157 Change-Id: Ib6e356d75d8f316ceff95c55fe905eeb505361a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576061 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835084}
-
Josiah K authored
AX-Relnotes: N/A. Bug: 1156494 Change-Id: I99fb4980235a9be55b5c5e8674d43f0c1326899a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577734Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#835083}
-
Thomas Guilbert authored
This CL converts SyncTaskManager::Task and SyncTaskManager::Continuation to OnceCallbacks. Since some of the closures are stored in a priority queue (which doesn't support move-only types), they are wrapped with base::AdaptCallbackForRepeating. There is also an opportunistic deletion of some dead code, and renaming a test callback to something more useful. Bug: 1152272 Change-Id: I39fd928029e215b118f0c09cbaf84780862197cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576443 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I197685bc456fad5e6404c8c6758ca57fdc596c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581066Reviewed-by:
-
Mason Freed authored
Bug: 966758,937746 Change-Id: I7315e4b9a1a818d470c31000c4b605270e22391c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580432 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#835080}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42f37e5c..2523885b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I50919fae43139f43aaf83ad5dcb7329a86a07f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580227Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835079}
-
Hui Yingst authored
CodeHealthRotation: Migrate RunScriptExceptionHandler to base::OnceCallback in extensions/renderer/. Bug: 1152265 Change-Id: I90a519bfb5c979f25a405800a5a1b92e12c89d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574070 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835078}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f691b3b5096a..27e52ca05dc7 2020-12-09 jdarpinian@chromium.org Fix build when angle_has_build == false If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I00b204183f35182d97facf78b379f287c0b40f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580769Reviewed-by:
-
