GitLab

Note new documentation at https://sites.google.com/a/chromium.org/dev/developers/design-documents/service-processes

BUG=None
TEST= 1) Build.
      2) Launch Chromium with cloud print disabled.
      3) Start Terminal
      4) launchctl list
      5) You should not see any org.chromium.Chromium.framework.service_process/* processes listed
      6) Go to Preferences in chromium
      7) launchctl list
      8) You should now see a org.chromium.Chromium.framework.service_process/* process
      9) Quit chromium
      10) launchctl list
      11) There should not be any org.chromium.Chromium.framework.service_process/* processes anymore

Review URL: http://codereview.chromium.org/7736002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=tonyg@chromium.org

Review URL: http://codereview.chromium.org/7715031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94228
TEST=none
TBR=sky

Review URL: http://codereview.chromium.org/7744022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7749005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98218 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98217 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98216 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98209 0039d316-1c4b-4281-b951-d872f2087c98

OnKeyEvent should create IM object if necessary
NULL check in OnActivate

TBR=penghuang@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7748013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98206 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98203 0039d316-1c4b-4281-b951-d872f2087c98

Fix PPAPITest.PostMessage test which relied on the buggy behavior of
postMessage that had null for the ports property (which has been fixed
in this WebKit roll).

BUG=94182
TEST=none
TBR=podivilov

Review URL: http://codereview.chromium.org/7745015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98202 0039d316-1c4b-4281-b951-d872f2087c98

It also ensures that the AudioInputDevice can be destroyed during an active audio session
without crashing.

This CL is a summary of http://codereview.chromium.org/7497025, i.e., it removes potential
race conditions but in a more "lightweight" manner.

BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7661017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98198 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98197 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7715027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crosbug.com/19597
TEST=no crash

Review URL: http://codereview.chromium.org/7747010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98195 0039d316-1c4b-4281-b951-d872f2087c98

Accumulated these while spelunking into the fast-forward issue, but now that's
on hold figured I'd send these out for cleanup.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/7726002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7461059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98193 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91675
TEST=none
TBR=mark

Review URL: http://codereview.chromium.org/7746007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98192 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7750001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7745002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98189 0039d316-1c4b-4281-b951-d872f2087c98

Also add mock_unittest.cc that demonstrates how to mock synchronos and
asynchronos D-Bus method calls.

BUG=90036
TEST=dbus_unittests

Review URL: http://codereview.chromium.org/7714030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98188 0039d316-1c4b-4281-b951-d872f2087c98

Fix its test to enforce that, and add a test for FileSystemOperation::TouchFile.

BUG=none
TEST=test_shell_tests


Review URL: http://codereview.chromium.org/7685039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98187 0039d316-1c4b-4281-b951-d872f2087c98

BrowserKeyEventsTest.ReservedAccelerators started failing, and this looks
like the most likely candidate in the window:
http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/14075
http://build.chromium.org/p/chromium/builders/Mac%2010.5%20Tests%20%28dbg%29%281%29/builds/12226

- Handle keyboard shortcuts in Mac Panels.

Common code from browser_window_cocoa separated into cocoa/browser_window_utils.

Panel.xib changed to make the NSWindow for the PanelWindowControllerCocoa a ChromeEventProcessingWindow.

BUG=None
TEST=Manual testing with Panels and keyboard shortcuts to find/next/previous/close window/quit chrome.

Review URL: http://codereview.chromium.org/7719016

TBR=jennb@chromium.org
Review URL: http://codereview.chromium.org/7747011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98186 0039d316-1c4b-4281-b951-d872f2087c98

Now that we have a unified resource system, we no longer need the duplication
on both sides of the proxy. This resource is now implemented entirely in
shared_impl.

Review URL: http://codereview.chromium.org/7621070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98185 0039d316-1c4b-4281-b951-d872f2087c98

TBR=penghaung@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7746005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98184 0039d316-1c4b-4281-b951-d872f2087c98

MenuItemView.

BUG=57890
TEST=thorougly test all menus in chrome: bookmarks, wrench menu,
context menu on page, extension menus...
TBR=ben@chromium.org
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7746012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98183 0039d316-1c4b-4281-b951-d872f2087c98

The webstore folks were finding it inconvenient to use javascript and a canvas
tag to get the base64 encoded data for the icon, and asked us to just add this
parameter to have the client fetch it.

BUG=93546
TEST=Includes a browser test, but requires webstore server changes to fully
test.

Review URL: http://codereview.chromium.org/7735001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7740016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98181 0039d316-1c4b-4281-b951-d872f2087c98

indicates FindPreference is returning NULL and we're in shutdown
because the last window is being closed. I suspect that for some
reason on some machines this triggers us to get a WM_CLOSE after we've
removed the property used to lookup the profile (removed in
WM_DESTROY) so that we fall back to the local state prefs which don't
have a property for window position and we crash. I'm adding debugging
code to determine whether that is in fact happening.

BUG=91396
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7727001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98180 0039d316-1c4b-4281-b951-d872f2087c98

for showing (running) the menu entirely to MenuRunner. This way I can
guarantee if MenuRunner is deleted, the related menu classes aren't
deleted until the nested message loop completes.

BUG=57890
TEST=thorougly test all menus in chrome: bookmarks, wrench menu,
context menu on page, extension menus...
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7720012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94195
TBR=zmo@chromium.org

Review URL: http://codereview.chromium.org/7747008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98178 0039d316-1c4b-4281-b951-d872f2087c98

This is pretty broad, but the leak is also pretty broad.

BUG=94195
TBR=zmo@chromium.org

Review URL: http://codereview.chromium.org/7748009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98177 0039d316-1c4b-4281-b951-d872f2087c98

Dropping files checked in by mistake.


BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7748007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=thakis@chromium.org
Review URL: http://codereview.chromium.org/7741008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98175 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98174 0039d316-1c4b-4281-b951-d872f2087c98

Update WebKit to r93717.

BUG=none
TEST=none
TBR=podivilov
Review URL: http://codereview.chromium.org/7727006

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7748008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98173 0039d316-1c4b-4281-b951-d872f2087c98

/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/browser_feature_extractor.cc:456:12:error: no member named 'set_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
  request->set_suffix_prefix_hash(
  ~~~~~~~  ^
1 error generated.

/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:281:20:error: no member named 'has_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
  if (full_request.has_suffix_prefix_hash()) {
      ~~~~~~~~~~~~ ^
/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:282:24:error: no member named 'set_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
    sanitized_request->set_suffix_prefix_hash(
    ~~~~~~~~~~~~~~~~~  ^
/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:283:22:error: no member named 'suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
        full_request.suffix_prefix_hash());
        ~~~~~~~~~~~~ ^
3 errors generated.

Add support for client-side phishing detection for non-UMA users.

In this mode, a sanitized pingback is sent that does not include the URL or any
tokens extracted from the URL or page content.  Currently, this feature is
behind a command-line flag.

BUG=none
TEST=ClientSideDetectionServiceTest,BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/7635010

TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/7746011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98170 0039d316-1c4b-4281-b951-d872f2087c98

This change just deletes executable flags from files added by r98158.

TBR=bradnelson@google.com
BUG=none
TEST=fix check_perms errors
Review URL: http://codereview.chromium.org/7747007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98169 0039d316-1c4b-4281-b951-d872f2087c98

In this mode, a sanitized pingback is sent that does not include the URL or any
tokens extracted from the URL or page content.  Currently, this feature is
behind a command-line flag.

BUG=none
TEST=ClientSideDetectionServiceTest,BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/7635010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98168 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98164 since there are missing dependencies on linux views build - Move resource_dispatcher_host_unittest.cc to content_unittests now that all its link time dependencies are in content.

BUG=90443
Review URL: http://codereview.chromium.org/7746008

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/7743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98166 0039d316-1c4b-4281-b951-d872f2087c98