GitLab

Review-Url: https://codereview.chromium.org/2164073002
Cr-Commit-Position: refs/heads/master@{#406635}

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports it via externs, to roll it we need to remove it. It was mostly used for Objects that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2163093003
Cr-Commit-Position: refs/heads/master@{#406634}

Review-Url: https://codereview.chromium.org/2156663002
Cr-Commit-Position: refs/heads/master@{#406633}

BUG=628942

Review-Url: https://codereview.chromium.org/2155393002
Cr-Commit-Position: refs/heads/master@{#406632}

BUG=627648

Review-Url: https://codereview.chromium.org/2145793002
Cr-Commit-Position: refs/heads/master@{#406631}

This involves an IO base observer which passes messages to the UI thread
using a KeyedService. Consumers should be able to consume this similarly
to the way the NQE is already consumed.

BUG=615563

Review-Url: https://codereview.chromium.org/2103323007
Cr-Commit-Position: refs/heads/master@{#406630}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0b4a19ad4354..80f6597f809c

$ git log 0b4a19ad4..80f6597f8 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2164003002
Cr-Commit-Position: refs/heads/master@{#406629}

The Skia CL https://codereview.chromium.org/2168483003/ (Deprecate SkDevice::accessBitmap method) is removing this entry point from Skia

Review-Url: https://codereview.chromium.org/2162423003
Cr-Commit-Position: refs/heads/master@{#406628}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9e8addb4..8efcb0b5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2163293002
Cr-Commit-Position: refs/heads/master@{#406627}

TBR=sky@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2162693002
Cr-Commit-Position: refs/heads/master@{#406626}

Review-Url: https://codereview.chromium.org/2160753002
Cr-Commit-Position: refs/heads/master@{#406625}

This will provide the time (in minutes) between the last time a precache
session was started and each of the URL fetches made by the user ever since.

This would allow us to better correlate byte savings/PLT with how recently a
precache happened.

BUG=619211

Review-Url: https://codereview.chromium.org/2123813002
Cr-Commit-Position: refs/heads/master@{#406624}

https://boringssl.googlesource.com/boringssl/+log/3a28755badf73e7bc88a1edadfa88d60ae75c519..5440fe0cd10aab3c106eadf9873bb6d61344e29f

BUG=none
TBR=svaldez@chromium.org

Review-Url: https://codereview.chromium.org/2165893004
Cr-Commit-Position: refs/heads/master@{#406623}

Improve the source color picker experiment by making the color swatches clickable.
On click, the swatches launch a spectrum to easily edit the stylesheet colors.

BUG=266326
R=lushnikov

Review-Url: https://codereview.chromium.org/2157533003
Cr-Commit-Position: refs/heads/master@{#406622}

Also, re-enables ancestry announcements in menus. This re-introduces a bug in Docs rooted with re-parenting, but it also makes reading parenting menus again within Panel. The root reparenting bug should be fixed and not worked around in ChromeVox.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2144873002
Cr-Commit-Position: refs/heads/master@{#406621}

BUG=627897

Review-Url: https://codereview.chromium.org/2147403003
Cr-Commit-Position: refs/heads/master@{#406620}

Kept the Mac system color for highlighting a row.

BUG=626442
TEST=Visual

Review-Url: https://codereview.chromium.org/2167693002
Cr-Commit-Position: refs/heads/master@{#406619}

When a download progress changes, Chrome posts an async
task to update the notification.
Both the async task and the UI thread reads the same variables.
As a result, these variables are declared volatile or using thread safe types.
This change eliminates such variable sharing by copying the reference first,
and then pass the copied data to the async task.

Review-Url: https://codereview.chromium.org/2151063002
Cr-Commit-Position: refs/heads/master@{#406618}

BUG=629598
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2160423002
Cr-Commit-Position: refs/heads/master@{#406617}

The import/export feature for passwords is currently behind a flag. However,
the settings WebUI hides the controls instead of the containing DIV. As a
result, on loading the settings, the space for the controls is briefly
taken into consideration and a vertical scrollbar shows up.

This CL hides the containing DIV instead of the individual controls.

Test steps:
With chrome://flags/#password-import-export enabled, observe that about:settings/passwords looks the same as without the patch. With chrome://flags/#password-import-export disabled, observe that during reloading of about:settings/passwords, no vertical scroll bar is flashing/seen.

BUG=626634
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2154223002
Cr-Commit-Position: refs/heads/master@{#406616}

1. Enable unified media pepeline on Cast for ATV.
2. Add a commend parameter to force WMPI starting in fullscreen
mode so that it would use SurfaceView instead of SurfaceTexture on
Android.

BUG=internal b/29463340

Review-Url: https://codereview.chromium.org/2141293002
Cr-Commit-Position: refs/heads/master@{#406615}

Revert of Refactor the buildbot module in webkitpy. (patchset #3 id:40001 of https://codereview.chromium.org/2152663003/ )

Reason for revert:
On 2016/07/20 at 17:51:31, vadimsh wrote:
> Probably broke rebaseline-o-matic: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281

Original issue's description:
> Refactor the buildbot module in webkitpy.
>
> This CL refactors BuildBot so that:
>  - There is now a results_url method in the BuildBot class (moved from AbstractRebaseliningCommand)
>  - Redundant functions are removed
>  - The Builder and Build classes are removed
>  - Buildbot-related functions in webkitpy.common.config.urls are moved into BuildBot
>  - Unit test and mock version are updated
>
> The purpose of this is to simplify the code; this is a follow-up to http://crrev.com/2112133002 which removed some unused functionality.
>
> Committed: https://crrev.com/66b942da80d7af5806f50630e55a9800102f43e1
> Cr-Commit-Position: refs/heads/master@{#406599}

TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2165983003
Cr-Commit-Position: refs/heads/master@{#406614}

See Section 5.34 Framebuffer color attachments in WebGL 2.0 spec.

BUG=628861
TEST=gpu_unittests conformance2/rendering/framebuffer-unsupported.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2159183002
Cr-Commit-Position: refs/heads/master@{#406613}

BUG=628414

Review-Url: https://codereview.chromium.org/2162033003
Cr-Commit-Position: refs/heads/master@{#406612}

Linking with a source_set tells the linker to pull in all of the code
and data from the specified object files, and then discard those that
can be proved to be unnecessary. This can cause extraneous global
variables and code to be retained, which has led to a regression in the
size of chrome.dll in gn builds, compared to gyp builds.

This change avoids linking in three arrays from ffmpeg. All of these
arrays have multiple instances, each half the size of the previous, so
the listed sizes below should all be doubled. The necessary changes were
tracked down by using dia2dump to find large global variables and then
running a python script to find the chain of object files that caused
these global to be pulled in. The arrays are:

ff_cos_65536_fixed - 64 KB, fixed by a previous ffmpeg change which enables these fixes.
ff_sin_65536 - 128 KiB is defined in ffmpeg's rdft.c. Pulled in by:
- service_worker_network_provider.obj, through //content/child:child
- render_frame_observer.obj, through //content/public/renderer:renderer_sources
- render_widget_mus_connection.obj, //content/renderer/mus:mus
- resource_converter.obj, through //content/renderer:renderer
ff_cos_65536 - 128 KiB is defined in ffmpeg's fft_template.c which is #included by fft_float.c. Pulled in by:
- audio_video_metadata_extractor.obj and media_file_checker.obj, through //media/base:base

Changing ffmpeg and the five source_set targets to static_library targets (conditionally in some cases) means that these arrays no longer get pulled in.

The expected in-memory savings in the .data section are (64+128+128)*2 KiB = 640 KiB. Actual savings were 718 KiB. This does not affect file size.

In addition this saved 288 KiB of code in the .text section, and shrunk the read-only data section, for a 301 KiB file-size savings.

Before: size of chrome.dll is 38.808576 MB
      name:   mem size  ,  disk size
     .text: 30.999296 MB
    .rdata:  6.007834 MB
     .data:  1.447656 MB,  0.270336 MB

After: size of chrome.dll is 38.499840 MB
      name:   mem size  ,  disk size
     .text: 30.704163 MB
    .rdata:  6.006906 MB
     .data:  0.712680 MB,  0.270336 MB

Measurements were done on 32-bit official builds from hash b8c16c8d. Still some more work to be done.

BUG=624274

Review-Url: https://codereview.chromium.org/2163823002
Cr-Commit-Position: refs/heads/master@{#406611}

https://chromium.googlesource.com/skia.git/+log/35a98c733fb6..ea70c4bb2239

$ git log 35a98c733..ea70c4bb2 --date=short --no-merges --format='%ad %ae %s'
2016-07-20 robertphillips Remove SkDevice::accessRenderTarget virtual GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
2016-07-20 egdaniel Add GrVkRecycledResource subclass

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2170493002
Cr-Commit-Position: refs/heads/master@{#406610}

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Review-Url: https://codereview.chromium.org/2157113002
Cr-Commit-Position: refs/heads/master@{#406609}

Sometimes the underlying results change after the selection was made and
we crash in updateMatchDestination. Instead, try to find if we still
have an underlying result, and update the index if necessary or just
skip the URL update.

BUG=629124,595395

Review-Url: https://codereview.chromium.org/2159363002
Cr-Commit-Position: refs/heads/master@{#406608}

These are the set of accelerators that have dependencies on parts not ported. I suspect some of these won't make sense in a mash world, but for now I'm lumping it all together.

BUG=612331
TEST=covered by tests
R=jamescook@chromium.org, reveman@chromium.org

Review-Url: https://codereview.chromium.org/2162193003
Cr-Commit-Position: refs/heads/master@{#406607}

BUG=621120

Review-Url: https://codereview.chromium.org/2164023002
Cr-Commit-Position: refs/heads/master@{#406606}

Metadata now contains fields including
{os-arch: "x86_64",
 os-name: "Linux",
 os-version: "3.13.0-76-generic",
 product-version: "Chrome/53.0.2771.0",
 v8-version: "5.3.332.1",
 revision: "1641c3f4-refs/heads/master@{#400465}",
 user-agent: "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2771.0 Safari/537.36"}

Design doc:
https://docs.google.com/document/d/12KvpnDUFUuCEgId7H-QL5PoRcsp99CXdqbZc-EOrpH8/edit#

https://github.com/catapult-project/catapult/issues/2405
BUG=catapult:#2405

Review-Url: https://codereview.chromium.org/2072383002
Cr-Commit-Position: refs/heads/master@{#406605}

This CL adds a failure histogram for certificate error reporting,
similar to the histograms we have for Expect CT and HPKP reports.

It also negates the net error codes for Expect CT and HPKP histograms,
to match up with the histogram enums. (See bug 616599.)

BUG=616599,596624

Review-Url: https://codereview.chromium.org/2120683002
Cr-Commit-Position: refs/heads/master@{#406604}

Chrome has been using Jar and resources from support library for years.
In Q1 2016, Android team stops shipping jars/res for support libray.
Instead, AAR is promoted, which is a zip that wraps jars and resources.

This CL introduces a utility python script that processes an AAR file.
In GN gen time, it lists all files in the AAR, yet it does not extract
it. Actual unpacking is postponed until compilation.

Two other things to notice:
1. In the old jar we depended on, support-v13 contains support-v4 and
support-annotations. After converting to AAR, these two libraries are no
longer part of support-v13. Thus this change needs to be reflected.
2. In the new AAR format, support-v4 now contains two jars instead of
one. All public classes are in classes.jar, and all hidden classes are
in libs/internal_impl-$VERSION.jar.

This work is not possible without bajones@'s pioneering work in
https://chromiumcodereview.appspot.com/2069273002/

BUG=611171

Review-Url: https://codereview.chromium.org/2156453002
Cr-Commit-Position: refs/heads/master@{#406603}

R=inferno@chromium.org
TBR=eugenis@chromium.org, glider@chromium.org
BUG=629468

Review-Url: https://codereview.chromium.org/2166003002
Cr-Commit-Position: refs/heads/master@{#406602}

Follow-up to https://codereview.chromium.org/2158373002/

Turns out that new policies are supposed to be positive, so the pref should be too (otherwise we couldn't have the trivial policy->pref mapping).
And anyway, a positive pref is probably nicer in any case.

BUG=595713

Review-Url: https://codereview.chromium.org/2165983002
Cr-Commit-Position: refs/heads/master@{#406601}

Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic and aria-live.

BUG=590341
R=dmazzoni@chromium.org
TESTED=Manually with Voiceover, browser tests

Review-Url: https://codereview.chromium.org/2163673003
Cr-Commit-Position: refs/heads/master@{#406600}

This CL refactors BuildBot so that:
 - There is now a results_url method in the BuildBot class (moved from AbstractRebaseliningCommand)
 - Redundant functions are removed
 - The Builder and Build classes are removed
 - Buildbot-related functions in webkitpy.common.config.urls are moved into BuildBot
 - Unit test and mock version are updated

The purpose of this is to simplify the code; this is a follow-up to http://crrev.com/2112133002 which removed some unused functionality.

Review-Url: https://codereview.chromium.org/2152663003
Cr-Commit-Position: refs/heads/master@{#406599}

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2162283002
Cr-Commit-Position: refs/heads/master@{#406598}

We seem to be getting messages when a binding is paused. The only way
this should be possible is if an associated interface has been
created. The added DCHECKs check for this.

BUG=626869
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2165873003
Cr-Commit-Position: refs/heads/master@{#406597}

This eliminates the distinction between node and dom node movement of a cursor.

A "node" is everything other than a inline textbox. A line, word, or character move are now the only units of movement that can move a cursor or range into an inline textbox.

Once constructed, a range passed to output uses the leafDomNode predicate (which matches against both inline textboxes if starting from an inline textbox or against "nodes").

This fixes the $descendants format token which used to collect inline textbox nodes for output. It now visits only static text nodes and other leaf "nodes".

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2144593003
Cr-Commit-Position: refs/heads/master@{#406596}