- 18 Nov, 2019 40 commits
-
-
François Beaufort authored
Change-Id: I64b768922a16decf60df57006cbd93a6f9a677b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920669 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#716120}
-
Renato Silva authored
This is a reland of 5fd0e6ed Original change's description: > Fix browser test EulaTest.LoadOffline > > This commit improves the reliability of the EULA browser test > EulaTest.LoadOffline. This test was disabled due to its flakiness > in the past and is now enabled again. > > Tested locally. Ran 100 tests under stress without any errors. > > Bug: 1015948 > Change-Id: I59bc8612da9f5be526a2aa28d13ee70400dbb01e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892775 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Renato Silva <rrsilva@google.com> > Cr-Commit-Position: refs/heads/master@{#712516} Bug: 1015948 Change-Id: I47bd386c589344f011b03bd6e24f50f08c3b42a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899862Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#716119}
-
Jinho Bang authored
According to the spec change[1], the attribute byte offset is no longer optional. [1] https://github.com/gpuweb/gpuweb/pull/469 Bug: 852089 Change-Id: I5c29652a56531273a9205151cee0598c6911268f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919532 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716118}
-
Victor-Gabriel Savu authored
Extending DeviceRebootOnUserSignout to virtual machines requires checks for Crostini, PluginVM and vmc in LockToSingleUserManager. Design Document: https://docs.google.com/document/d/1cIZsPD6rwm6ca5r8GCXUqr2gT1axsoGe0S0Hl2-OgCE Bug: 986755 Change-Id: I54c82a293b9db22158b05ded590b9463c3528668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840892 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#716117}
-
Jinho Bang authored
In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] https://github.com/gpuweb/gpuweb/pull/490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531Reviewed-by:
-
Vasilii Sukhanov authored
- rewrite WaitForElementValue for the UI test. The existing implementation uses onchange event. It's problematic for the real keystroke because the event is triggered on focus change only. oninput is the right choice here. - use WaitForElementValue in FillElementWithValue to enforce that the right input handles the keystrokes. Bug: 1024902 Change-Id: Ib7752e39b62d20c73ed06ff85f4fdea641d0955d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919154 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#716115}
-
Emily Stark authored
These overrides are necessary for keyboard focus to work properly when the dialog is shown. Bug: 1025343 Change-Id: I1a63c6a5e9233bd972cf1a07ad89670bf05a8a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919947 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#716114}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/37f7316ecaaf..bbdabb3b9b0a git log 37f7316ecaaf..bbdabb3b9b0a --date=short --no-merges --format='%ad %ae %s' 2019-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 37dcb894574e..f4d4668529f1 (1 commits) Created with: gclient setdep -r src/third_party/angle@bbdabb3b9b0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: Id2f7e63a3372379e1ba4c3bd2103e019fc38812e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921849Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716113}
-
Vadym Doroshenko authored
This reverts commit ae376cbc. Reason for revert: As a result of this CL a few quiche tests are failing on Windows, the first failure https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80140?blamelist=1#blamelist-tab Original change's description: > Roll src/net/third_party/quiche/src/ 94591413f..409b261f3 (3 commits) > > https://quiche.googlesource.com/quiche.git/+log/94591413f1fe..409b261f38af > > $ git log 94591413f..409b261f3 --date=short --no-merges --format='%ad %ae %s' > 2019-11-15 rch Add a new QUIC platform API QUIC_SLOW_TEST which will be used in chrome to disable tests which are too slow. > 2019-11-15 wub gfe-relnote: (n/a) Change QUIC's AckedPacketVector and LostPacketVector from std::vector to QuicInlinedVector with a inline capacity of 2. Not protected. > 2019-11-15 fayang Introduce HandshakeState enum to sent packet manager. Not used yet, not protected. > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > Add missing QUIC files to net/BUILD.gn > > > Change-Id: If98c172bc524cac0e64c8445d54ed9041b3c29d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918285 > Auto-Submit: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Renjie Tang <renjietang@chromium.org> > Reviewed-by: Renjie Tang <renjietang@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715831} TBR=rch@chromium.org,renjietang@chromium.org Bug:1025417 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I361d4e065d652059406d3327ca4dbad00a98f62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917217Reviewed-by:
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: Ic776473539b833f243c8fd36e0a83323192b8cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919144Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#716111}
-
Xianzhu Wang authored
The baseline created in https://chromium-review.googlesource.com/c/chromium/src/+/1915461 was incorrect. Bug: 377696 Change-Id: I43203bc9602b8552fdefca4a8976067af8b1716b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918401 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#716110}
-
Alan Cutter authored
This flag is set to expire in M80, the feature still needs more development time. Bug: 926083 Change-Id: Ib8c84cf59f1a50a3ed13e05ec18130edc26daeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918910 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#716109}
-
Vadym Doroshenko authored
This reverts commit 7f5baf23. Reason for revert: It's likely a culprit for HomeButtonTest.LongPressGesture failure. Here is the first failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36138?blamelist=1#blamelist-tab Original change's description: > Enable Assistant launcher UI feature flag by default > > Bug: b/144383302 > Test: Manual Test > Change-Id: I50a2462e2094d08d52141a626c0dad89d55d27c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915322 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715971} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/144383302 Change-Id: Ib29930d141e1e9ad23c92f5a06fa7ac5ae572a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917215Reviewed-by:
-
Guido Urdaneta authored
Also check that CreateFrame() does not return null before filling it in VideoFrame::CreateColorFrame(). VideoFrame::CreateFrame() can return null in some cases, so it is safer to check if it returns a null frame in order to avoid crashes. Bug: 1021601 Change-Id: I0e68b152d89f599afd433bc2172903633d94e8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917362Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#716107}
-
Alex Clarke authored
This will help us track down where crashing tasks come from. Bug: 1024587 Change-Id: I084e915026d9df963b5f4ddae551e7d070ce4449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917209 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#716106}
-
Shik Chen authored
It's wrongly removed when addressing comment in https://crrev.com/c/1892972/15/chrome/browser/resources/chromeos/camera/utils/cca.py#243 Bug: 1019581 Test: Run cca.py outside of the CCA directory. Change-Id: I2d190385e35d6ac35831db1c4a75f2ca66f4b05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921605 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#716105}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e0eeef4b34ff..d0c07f112eb2 git log e0eeef4b34ff..d0c07f112eb2 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 jiajie.hu@intel.com Vulkan: Fix release of semaphores in the recording context 2019-11-18 yunchao.he@intel.com Add memory synchronization tests - storage to uniform sync Created with: gclient setdep -r src/third_party/dawn@d0c07f112eb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I311fee05eeeb436ada19f550bb16fd2b81b51c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921525Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iebc8ef8987c98d84851923cfadcef7b73ee4b1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921524Reviewed-by:
-
Peter K. Lee authored
http://crrev/c/1551781 moved files, but a comment is referring to the old location of BUILD.gn Change-Id: Id6ddbe50c14915deb4144e5976648ceeec732882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921604 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#716102}
-
Yoav Weiss authored
Currently there are two different flags that control sending Client Hints to cross-origin resources: Feature Policy delegation (off-by-default) and a build flag that sends legacy hints on Android. This CL makes sure that these two flags play nice together, and adds virtual test suites to exercise them. BUG: 1022366 Change-Id: I00ed4e9ed5a64e378def3d90227f238b9b3eb374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893196 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#716101}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51b5a3222b60..37f7316ecaaf git log 51b5a3222b60..37f7316ecaaf --date=short --no-merges --format='%ad %ae %s' 2019-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 102fd19c65f4..aba1020d3914 (7 commits) Created with: gclient setdep -r src/third_party/angle@37f7316ecaaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: If5d5a28b1d929853c76fa3fc3c0cd6a983b700a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921755Reviewed-by:
-
Mirko Bonadei authored
Both "field_trial" and "metrics" are build target that are overwritten by Chromium (except in some cases, see the BUILD.gn file). This CL moves these dependencies from sub-targets to the WebRTC component build target and it is the prelude of a WebRTC cleanup [1]. [1] - https://webrtc-review.googlesource.com/c/src/+/159862 Bug: webrtc:9419 Change-Id: Iba42cc51370c2c10cf967db3ed0c9a47959e9ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917514Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#716099}
-
Alexander Hendrich authored
This CL removes the temporarily granted exception to use chrome.usb for our Imprivata extensions. With https://crrev.com/c/1908544 we will be using WebUSB for M80 and later versions instead. Bug: 995294 Change-Id: Ic8e1469c2ad5b9d07319af7bb995f90dd337fbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916860Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#716098}
-
Cherie Cheung authored
If host root filesystem is writable and guest system image is EXT format, then the guest root filesystem should also be writable and StartArcVmRequest.rootfs_writable is set to true. This CL is a part of the change for b/144154973. Bug: 144154973 TEST=1. On host, 'mount -o remount,rw /' 2. Make sure guest system image is EXT4 3. On host, 'restart ui' 4. On guest, 'mount -o remount,rw /' 5. Guest root filesystem should be writable Change-Id: Id58ab406ca74f240aeadcfef2888c6578a6c5857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916523 Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Reviewed-by:Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#716097}
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: I5d86962e4dcdd3a95058efef86735a11a75ac8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908531 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#716096}
-
Roger Johannesson authored
https://codereview.chromium.org/2700663002 added key event listeners on the media element to improve keyboard accessibility. Element::SupportsSpatialNavigationFocus() checks if elements has key event listeners when deciding if a element should be focusable by spatial navigation. Element::SupportsSpatialNavigationFocus() is called by Element::SupportsFocus(). So, the CL above makes the media element default focusable if --enable-spatial-navigation is used. This CL modifies Element::SupportsSpatialNavigationFocus() to only consider elements with javascript based key and click event listeners as focusable. BUG=1023287 Change-Id: I254a6e2d1968f9bc1042a3ecaabc81ff3d99eb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913411 Commit-Queue: Roger Johannesson <rogerj@vewd.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#716095}
-
Miyoung Shin authored
This change converts DocumentCoordinationUnit mojom interface client in components to use BrowserInterfaceBroker. Since DocumentCoordinationUnit is a WebContentsObserver and a static helper function is used to register its binder. Bug: 936482 Change-Id: I146d28c81a39b4f977f53c92b567f6409e727553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895026Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#716094}
-
Mirko Bonadei authored
Starting from [1], WebRTC supports the Chromium component build and direct dependencies on //third_party/webrtc are disallowed. A dependency on //third_party/webrtc_overrides:webrtc_component is required instead. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 Bug: webrtc:9419 Change-Id: I8a09d9d2c9a54ff45950b03779832e231213d215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917204Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#716093}
-
Ella Ge authored
Change-Id: I4fa313c41fc3ed776b2e2c0f1370c0a006533824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914347 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716092}
-
Hiroki Sato authored
In ARC++ accessibility, some nodes of generic container or heading role can have a selected state, but it was not announced by ChromeVox. This CL adds an output of selected status. Bug: b:130186975 Test: still passes browser_tests --gtest_filter="ChromeVoxOutputE2ETest*" Change-Id: I53d9babacb5696802dc36b2adaf212d1116d0047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905291Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#716091}
-
sandromaggi authored
Before this change the model created the profiles on load and added it into the required field. The APIs being used were triggering JNI calls that are now being used directly. The sorting logic has been moved to keep the current behaviour. This change requires exposing some previously "hidden" functionality to create Java profiles from the c++ data in the personal_data_manager_android. These functions do not need any additional information and can be made static (similar to other already existing functionality). Bug: b/144005336 Change-Id: Ic12465f2270ebd877ac380d724bfaa1b460dc7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900986Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#716090}
-
Noel Gordon authored
CL:1449472 added some invalid rules for removable volumes||partitions see for example @line 474 which begins ... tree .tree-item > .tree-item > .tree-row > [volume-type-icon='removable'] { ... } But .tree-item > .tree-item matches nothing in FilesApp: a .tree-item is never a direct child of its parent .tree-item. So remove this rule and now try to understand @line 466 of CL:1449472 tree .tree-item[selected] > .tree-row > .tree-row[selected] [volume-type-icon='removable'][volume-sub... Which might be a transcription error, and then the rule runs onto the next line .tree-row > .tree-row[selected], but once again .tree-row > .tree-row never matches anything in FilesApp. Remove and replace this rule with an approximation of CL:1449472 intent. Bug: 992819 Change-Id: I552890e021c02d1dd304e51a49b772eaf7f13546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921595Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#716089}
-
Christopher Lam authored
Bug: 1018654 Change-Id: I538746e3650bfb21a12092b8fb550c5d74eb7fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913944Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#716088}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc2fd0f3b97c..e6cccd1fb9ad git log fc2fd0f3b97c..e6cccd1fb9ad --date=short --no-merges --format='%ad %ae %s' 2019-11-18 vapier@chromium.org paygen: utils: drop psutil usage Created with: gclient setdep -r src/third_party/chromite@e6cccd1fb9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I492f8e3a0e5ce5ea04c0e5efe82af5119852fec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921751Reviewed-by:
-
Chih-Yu Huang authored
This CL adds ImageProcessorWithPool class, which is a simple client of ImageProcessor. By injecting a DmabufVideoFramePool for allocating output frames and a callback for receiving processed frames, the caller could process input frames by Process() without managing output buffer. BUG=chromium:1004727 TEST=ninja image_processor_test Change-Id: I472366e4bf9460a304fcc8c4d43277c21e16c2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918917Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716086}
-
Alan Cutter authored
This CL enables PWA manifest updating to detect when sites update the scope field. Bug: 926083 Change-Id: Ib304ef830c215f564c64cf55c0d978308e2524e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921012 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#716085}
-
Shik Chen authored
If we use the prod key, the app id would collide with the built-in component app when using "load unpacked" with the build/camera directory. Bug: 1019581 Test: Check the app id is correct after "load unpacked". Change-Id: I8ff8413c96318979165188c3d633c00d0feaef86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921598 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 931087 Change-Id: I10beb004d9b557ea6db67099eb090ea9898a8130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921592 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#716083}
-
Glen Robertson authored
Web apps installed through external sources (ie. default, policy, or system installed) could fail to install due to redirects, making the install process flaky. This was also unexpected for admins setting policy. Bug: 1015650 Change-Id: I616da7b9f68098591c63818be0467c69428350a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914139 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716082}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I5dbb980bc4bcc99938fb8328aa5a74e6ddd463d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913230Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#716081}
-
