- 14 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f9143725470b..d1a55e393e65 git log f9143725470b..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions. Created with: gclient setdep -r src/third_party/angle@d1a55e393e65 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:822310 TBR=cwallez@chromium.org Change-Id: I707d1a122db30dcf53255adc0ee1a749552ffe02 Reviewed-on: https://chromium-review.googlesource.com/c/1334570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607862}
-
yiyix authored
Skipped Frame tracker used to record every frame produced at all times. With that approach, it's hard to study the correlation between the user actions and the skipped frame rate. In this patch, we only track the skipped frame rate during scrolling events. More user actions will be added in the future cls. Design doc on skipped frame tracker: https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg Videos on how it used to work: https://drive.google.com/open?id=1S5fnq8VrqvUIYFZjvIi4GNA3ekIdggG0 Bug: 894149 Change-Id: I02441cb5c9f551cc80b51ea1dcbafa3c492cb5ce Reviewed-on: https://chromium-review.googlesource.com/c/1334103Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#607861}
-
Hiroshige Hayashizaki authored
Previously, FetchClientSettingsObjectImpl - Is used as WorkerFetchContext's FetchClientSettingsObject, - Implements GetHttpsState(), and - Is used for checking mixed contents on workers. Issue 880027 will introduce outsideSettings WorkerFetchContext which will have FetchClientSettingsObjectSnapshot as its FetchClientSettingsObject [1]. Therefore, this CL switches - WorkerFetchContext's FetchClientSettingsObject and - MixedContentChecker::IsMixedContent() to use FetchClientSettingsObject (not ...Impl), and implements GetHttpsState() in FetchClientSettingsObject and FetchClientSettingsObjectSnapshot. This CL shouldn't change the behavior at this time, because WorkerFetchContext's FetchClientSettingsObject is still a FetchClientSettingsObjectImpl object, and thus mixed content checks is done using already-implemented FetchClientSettingsObjectImpl::GetHttpsState(). The code path added in this CL will be used in [2]. [1] https://chromium-review.googlesource.com/1328043 [2] https://chromium-review.googlesource.com/1328164 Bug: 880027 Change-Id: I399694bd239c21fe9b5a650fcb689fb2c98572f5 Reviewed-on: https://chromium-review.googlesource.com/c/1328162Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#607860}
-
Rakina Zata Amni authored
In WebContents destructor, |find_request_manager_| is not reset but FrameTreeNode destructor is trigerred, eventually causing calls to FindRequestManager::SendFindRequest that will try to send a find request to another frame in the same WebContents, which results in a crash. There are also other cases where the WebContents is navigated away, the window is closed, etc. where we also try sending to another frame within that WebContents, even though we won't need it. This CL fixes the crash, and the root cause will be explored and fixed in another CL. Bug: 884679 Change-Id: I229f38a663d50b6a5e8e167ac0d483f9826a7f0b Reviewed-on: https://chromium-review.googlesource.com/c/1242728 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607859}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e9db70e8858..def2885f901d Created with: gclient setdep -r src-internal@def2885f901d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I09159c00b4e8c4709792f921e2c0d0feebf1c541 Reviewed-on: https://chromium-review.googlesource.com/c/1334571Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607858}
-
Jinsuk Kim authored
Android CFI tests exposed a missing null check in one of the tests. Relanding https://crrev.com/c/1304038 after fixing it. TBR=tedchoc@chromium.org Bug: 877878 This reverts commit 7d0fbfd8. Change-Id: I75c560af86cd0f92b4b5eded5896c884fb7181ce Reviewed-on: https://chromium-review.googlesource.com/c/1334667Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#607857}
-
Nikunj Bhagat authored
Bug: 904953 Change-Id: I763d48881143645102fdaf5d85cb2ab812e8b8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1334327Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607856}
-
Eric Roman authored
Bug: 904889 Change-Id: I52e5b4cc2bff0cff0b1c7d6ec55d26b01924c288 Reviewed-on: https://chromium-review.googlesource.com/c/1333906 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#607855}
-
Sammie Quon authored
They were deleted when fingerprint_progress_arc.js was moved from settings to cr_elements. Test: browser_tests CrElementsFingerprintProgressArcTest.* Bug: 894285 Change-Id: I66419456bb00b30b348dcfad1c663237b41e2412 Reviewed-on: https://chromium-review.googlesource.com/c/1332767 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#607854}
-
Hector Carmona authored
Bug: 901210, 900377 Change-Id: I928f6cdb1a8251131afbe2e95afe1cbca39703ea Reviewed-on: https://chromium-review.googlesource.com/c/1332696 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607853}
-
Theresa authored
Create a new package for top toolbar classes and move relevant classes. BUG=904998 Change-Id: Ia9233913f04ec77f31c592f5a033ea18a5fccbf0 Reviewed-on: https://chromium-review.googlesource.com/c/1334416 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607852}
-
Akihiro Ota authored
Clean up aria-setsize-posinset.html Layout Test to use testharness and be more human-readable. Larger goal is to more thoroughly test the aria-posinset and aria-setSize attributes, especially in ambiguous cases. Change-Id: I950d45ceda2bbeb3fb10423812a13380b0da3ef4 Reviewed-on: https://chromium-review.googlesource.com/c/1332412Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#607851}
-
Stephen Chenney authored
This is in preparation for patches to avoid white flash on navigation, when we will be introducing a DeferCommits that only defers commits, not the document lifecycle. Renaming this DeferMainFrameUpdate makes it clearer that we are deferring everything in this case. This is a pure mechanical rename: DeferCommits -> DeferMainFrameUpdate and defer_commits -> defer_main_frame_update. No functionality changes. Added TODO in various places where we need to reintroduce the idea of a deferred commit without a deferred main frame update. See this design doc: https://docs.google.com/document/d/1Q-fq62PPeoz2EUygi1xzTdJwIgLwK6zP12_klO3wVXQ/edit# R=vmpstr@chromium.org, pdr@chromium.org BUG=805798 Change-Id: I48c3b6c230f99e8a96c023a8c88f97de03f110af Reviewed-on: https://chromium-review.googlesource.com/c/1330799Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#607850}
-
Kent Tamura authored
This CL makes webkitRelativePath IDL attribute behavior same as Edge, Firefox, and Safari. It returns relative path from the parent of the selected directory. * chrome/browser/file_select_helper.cc * chrome/browser/file_select_helper.h Record a FilePath with which we started enumeration, and path it to FileSelectListener. * android_webview/browser/aw_web_contents_delegate.cc * chrome/browser/ssl/security_state_tab_helper_browsertest.cc * content/browser/web_contents/web_contents_impl_browsertest.cc * content/renderer/pepper/pepper_file_chooser_host_unittest.cc * content/test/content_browser_test_utils_internal.cc Pass an empty FilePath to FileSelectListener. * content/browser/frame_host/render_frame_host_impl.cc * content/public/browser/file_select_listener.h * third_party/blink/public/mojom/choosers/file_chooser.mojom * third_party/blink/renderer/core/html/forms/file_chooser.h * third_party/blink/renderer/core/html/forms/file_chooser.cc Pass a FilePath to FileInputType through FileSelectListener and mojo. * third_party/blink/renderer/core/html/forms/file_input_type.cc Compute webkitRelativePath with the passed FilePath, instead of a common ancestor. * third_party/WebKit/LayoutTests/fast/forms/resources/mock-file-chooser.js Support FileChooserResult.base_directory Change-Id: I4c9f03b053b5a9230e954dcd216439d8c5c54d0b Bug: 124187 Reviewed-on: https://chromium-review.googlesource.com/c/1325579 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#607849}
-
Toni Barzic authored
BUG=888738 Change-Id: I4567bf4218621fa607bd86a43420bba8d4e4bcaa Reviewed-on: https://chromium-review.googlesource.com/c/1328045 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607848}
-
Yutaka Hirano authored
Following the corresponding spec change: https://github.com/whatwg/fetch/pull/829 Bug: 902681 Change-Id: If0da598ada489417c34926935acdd3cfff519aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1329815Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#607847}
-
Thoren Paulson authored
Before, the system default would always be picked regardless of the value passed in on Android. Bug: internal b/117627257 Test: repro Change-Id: I5004e11fbc94d3c82ac9c61557735665ced79539 Reviewed-on: https://chromium-review.googlesource.com/c/1332719Reviewed-by:
-
Jia authored
This cl logs the following errors that could possibly occur * Negative ALS values * Brightness percent that's outide the expected range [0,100]. Bug: 881215 Change-Id: I381c887cd95a9d4be99a02f2a34711655f847394 Reviewed-on: https://chromium-review.googlesource.com/c/1333169 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#607845}
-
Eric Roman authored
Change-Id: If3b95de0bdf66c10a435be0b76d4162cd40adbee Reviewed-on: https://chromium-review.googlesource.com/c/1334647Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607844}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/428a160dd6bd..6dbf0e43a5ff git log 428a160dd6bd..6dbf0e43a5ff --date=short --no-merges --format='%ad %ae %s' 2018-11-13 danilchap@webrtc.org Remove all aliases to rtc::Thread Created with: gclient setdep -r src/third_party/webrtc@6dbf0e43a5ff The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic198e0804f6f8a14f0e584ef0d5c2907a75abfca Reviewed-on: https://chromium-review.googlesource.com/c/1334568Reviewed-by:
-
Luciano Pacheco authored
After crrev.com/c/1322340 which changed test functions to be lazy loaded (asynchronously), running tests in step-by-step mode wasn't working if tried to step after Files app background page was put to sleep for inactivity. There were 2 issues: 1. The logic was relying on a global state window.IN_TEST which gets lost when extension goes to sleep. 2 Any queued response was replied with sendResponse(true), which was skipping the execution of the test function that it requested to run. This CL fixes both of these issues by doing: 1. Instead of relying on window.IN_TEST, it checks if test functions are loaded with: "test.util.executeTestMessage !== null", if so runs the requested function, otherwise en-queues the request and async-loads the test functions. 2. Change to en-queue both the request and the sendResponse to be able to run the requested functions once the test functions are fully loaded. This new design, made |enableTesting| and |ensureLoaded_| routines not necessary anymore and they were removed. Test: Manually run tests with the flags: --ui-test-action-timeout=100000 --enable-file-manager-step-by-step-tests --remote-debugging-port=9222 and waited all extensions to disappear before issuing a step. Also triggered MSAN and ASAN bots in addition to normal bots. Bug: 903669 Change-Id: Ia66f7ce7cd920a7a815340119591ff5ff957603c Reviewed-on: https://chromium-review.googlesource.com/c/1333177 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607842}
-
Nigel Tao authored
Bug: 826982 Change-Id: I19e9c4af2f3e53952d8ff8d697a43509d23eb809 Reviewed-on: https://chromium-review.googlesource.com/c/1334668 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#607841}
-
Khushal authored
If an entry is in locked state when the renderer dies, it will remain in this state and will never be evicted from the transfer cache in the GPU process. Avoid this by deleting all entries for a decoder when it dies. This is in general good for memory use by avoiding keeping unlocked entries that will never be reused. R=piman@chromium.org Bug: 904515 Change-Id: I4d97d31c7d9ae9d4d51814a874023264a2b06df4 Reviewed-on: https://chromium-review.googlesource.com/c/1334651 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
sczs authored
- Updates the bottomAnchorConstraint constant on sizeThatFits so its updated by the Fullscreen changes. This will also push the Infobar above the bottom toolbar, causing it not to be covered by the toolbar. - Adds missing super calls to will willMoveToSuperview and didMoveToSuperview. Screenshots: https://drive.google.com/open?id=1F8hUj6Cb5VEcOHuSOa8vv6wc8IXY5CeW https://drive.google.com/open?id=1dlDS3HktGQE8iAwgsJDxcGlEo-MOBvND Bug: 894449 Change-Id: I987f5eb3e8a8580323a0367d45c885406edcd7a0 Reviewed-on: https://chromium-review.googlesource.com/c/1334658Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607839}
-
Sky Malice authored
Bug: 900416 Change-Id: I3fed64b4968a75a7bc2279fca1169dbc2c0b0244 Reviewed-on: https://chromium-review.googlesource.com/c/1330334 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#607838}
-
François Beaufort authored
Change-Id: I6edc955ecd0d7f821d642bab0f66a6f25882c098 Reviewed-on: https://chromium-review.googlesource.com/c/1329141Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#607837}
-
Brandon Wylie authored
CL that removes the old image fetching code here: 1306349. Binary-Size: Increase is temporary and due to the cls to add/remove class being split. Bug: 864634 Change-Id: I2f7ec542a89290e565f3a62c11907bbf185e29e7 Reviewed-on: https://chromium-review.googlesource.com/c/1298431 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#607836}
-
Etienne Pierre-Doray authored
Implements perftests that measure throughput of running and posting tasks. Results on Windows P920: [ RUN ] TaskSchedulerPerfTest.PostThenRunNoOpTasks *RESULT Posting tasks throughput: Post-then-run no-op tasks= 1.86 us/task *RESULT Running tasks throughput: Post-then-run no-op tasks= 3.5304 us/task *RESULT Num tasks posted: Post-then-run no-op tasks= 10000 tasks [ OK ] TaskSchedulerPerfTest.PostThenRunNoOpTasks (57 ms) [ RUN ] TaskSchedulerPerfTest.PostThenRunNoOpTasksManyThreads *RESULT Posting tasks throughput: Post-then-run no-op tasks many threads= 2.693075 us/task *RESULT Running tasks throughput: Post-then-run no-op tasks many threads= 2.58605 us/task *RESULT Num tasks posted: Post-then-run no-op tasks many threads= 40000 tasks [ OK ] TaskSchedulerPerfTest.PostThenRunNoOpTasksManyThreads (136 ms) [ RUN ] TaskSchedulerPerfTest.PostThenRunNoOpTasksMorePostingThanRunningThreads *RESULT Posting tasks throughput: Post-then-run no-op tasks more posting than running threads= 3.253125 us/task *RESULT Running tasks throughput: Post-then-run no-op tasks more posting than running threads= 2.419125 us/task *RESULT Num tasks posted: Post-then-run no-op tasks more posting than running threads= 40000 tasks [ OK ] TaskSchedulerPerfTest.PostThenRunNoOpTasksMorePostingThanRunningThreads (135 ms) [ RUN ] TaskSchedulerPerfTest.PostRunNoOpTasks *RESULT Posting tasks throughput: Post/run no-op tasks= 2.9757 us/task *RESULT Running tasks throughput: Post/run no-op tasks= 3.2136 us/task *RESULT Num tasks posted: Post/run no-op tasks= 10000 tasks [ OK ] TaskSchedulerPerfTest.PostRunNoOpTasks (35 ms) [ RUN ] TaskSchedulerPerfTest.PostRunNoOpTasksManyThreads *RESULT Posting tasks throughput: Post/run no-op tasks many threads= 8.7977 us/task *RESULT Running tasks throughput: Post/run no-op tasks many threads= 2.26535 us/task *RESULT Num tasks posted: Post/run no-op tasks many threads= 40000 tasks [ OK ] TaskSchedulerPerfTest.PostRunNoOpTasksManyThreads (94 ms) [ RUN ] TaskSchedulerPerfTest.PostRunBusyTasksManyThreads *RESULT Posting tasks throughput: Post/run busy tasks many threads= 4.046625 us/task *RESULT Running tasks throughput: Post/run busy tasks many threads= 50.63795 us/task *RESULT Num tasks posted: Post/run busy tasks many threads= 40000 tasks [ OK ] TaskSchedulerPerfTest.PostRunBusyTasksManyThreads (2028 ms) [ RUN ] TaskSchedulerPerfTest.PostWithConstantWorkload *RESULT Posting tasks throughput: Post tasks with constant workload= .0135 us/task *RESULT Running tasks throughput: Post tasks with constant workload= 2.5396 us/task *RESULT Num tasks posted: Post tasks with constant workload= 10000 tasks [ OK ] TaskSchedulerPerfTest.PostWithConstantWorkload (29 ms) [----------] 7 tests from TaskSchedulerPerfTest (2523 ms total) Change-Id: I1e47eaf2db792d96e3e3ba290769e95673bd0b62 Reviewed-on: https://chromium-review.googlesource.com/c/1296624 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#607835}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5549f98ca7e4..9e9db70e8858 Created with: gclient setdep -r src-internal@9e9db70e8858 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2f70d4b14827f7e47c0b36286d4cdc36fa2aed74 Reviewed-on: https://chromium-review.googlesource.com/c/1334569Reviewed-by:
-
Oriol Brufau authored
Currently the NGConstraintSpace's direction for inline children of a block containeris is LTR even if the block container has RTL direction. BUG=904951 Change-Id: I271f2e2f4b30df6513d84ea149dc73b9532a4ce0 Reviewed-on: https://chromium-review.googlesource.com/c/1334508Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#607833}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: If133d6f0be2e39f2da535692790f549269b6be5d Reviewed-on: https://chromium-review.googlesource.com/c/1334836Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#607832}
-
Findit authored
This reverts commit 20b9700c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607824 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIwYjk3MDBjODQ1MGFmNGY4ZmQ5NzE3MDRkMDhhZThhZjdhZmQxMDEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109897 Sample Failed Step: compile Original change's description: > Add Fast Transition as enterprise policy > > Add support for an enterprise policy that lets the admin > turn Fast Transition on or off. > > BUG=791202 > CQ-DEPEND=1291930 > TEST=(1) unit-tests (2) Added network policy to YAPS > server, enabled Fast Transition and checked that the > values propagate to client > > Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d > Reviewed-on: https://chromium-review.googlesource.com/c/1297644 > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607824} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=791202 Change-Id: I250820660b1aaccc0cf30b14e8d9e105d264ccab Reviewed-on: https://chromium-review.googlesource.com/c/1334837 Cr-Commit-Position: refs/heads/master@{#607831}
-
Chris Lu authored
To make a fake of LargeIconService, its methods need to be defined as virtual. This change make it an abstract class and moves implementation to an Impl file. Change-Id: I4a9f92d3b3e14f94a2f8eec72c2924a4ff45da7f Reviewed-on: https://chromium-review.googlesource.com/c/1311538 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#607830}
-
jonross authored
In order to address an surface invariants race condition, BrowserPluginGuest began sending a child allocated LocalSurfaceId. BrowserPlugin would forcibly begin using this ID. This was initially a workaround for a <webview> bug. However <webview> no longer uses BrowserPlugin, so this is no longer necessary. PDFs still do, but do not suffer from this invariants violation. Bug: 655231 Change-Id: I02299fee7990b2a6747be16d32c42e5a0b4743ae Reviewed-on: https://chromium-review.googlesource.com/c/1330218Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#607829}
-
Marcin Wiacek authored
1. replace indexing by DialogOption with switch (easier to maintain) 2. improve comments 3. add one assert to confirm code correctness Change-Id: I6c4aee88e945ebcedfdc2b7864b68feec95e1f4a Reviewed-on: https://chromium-review.googlesource.com/c/1262644Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#607828}
-
Regan Hsu authored
account for every time status changes its value Change location of host status collection during MultiDevice Setup. The metric was logged only on start-up. This change intends for HostStatus to log on start up and every time status changes its value. Bug: 902868 Change-Id: I30de454dee61ff8bf8f5cd8b6ab071fc820abd35 Reviewed-on: https://chromium-review.googlesource.com/c/1327415Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607827}
-
Peng Huang authored
RatserDecoder uses Skia to do rendering, and skia can restore vertex attribs. So we don't need maintain and restore it in RasterDecoder. Bug: 902904 Change-Id: I3e85d3960e0b782e41ae6d45c07ddf3494e63ca9 Reviewed-on: https://chromium-review.googlesource.com/c/1334201 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Douglas Creager authored
If a request fails with a net::Error code that we don't have an explicit NEL standard `type` value for, we still want to generate a NEL report. The standard provides an `unknown` type for these errors. Change-Id: If4c0ab3bf4052cec9224dfd7053e1ca500b1b5dc Reviewed-on: https://chromium-review.googlesource.com/c/1329351Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#607825}
-
Matthew Wang authored
Add support for an enterprise policy that lets the admin turn Fast Transition on or off. BUG=791202 CQ-DEPEND=1291930 TEST=(1) unit-tests (2) Added network policy to YAPS server, enabled Fast Transition and checked that the values propagate to client Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d Reviewed-on: https://chromium-review.googlesource.com/c/1297644 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#607824}
-
Chase Phillips authored
The following structs were redundant with structs that Mojo auto-generates: - WebIDBCursorDirection - WebIDBDataLoss - WebIDBOperationType - WebIDBPutMode - WebIDBTaskType - WebIDBTransactionMode This CL updates those references to refer to the equivalent blink::mojom:: type, instead. References to kWebIDB* values are updated to point to the equivalent value in the associated Mojo enum type. Bug: 717812 Change-Id: Ie4bf482e4437ec9e5fa61c78086256bc84f8c6df Reviewed-on: https://chromium-review.googlesource.com/c/1303634 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#607823}
-
