- 04 Sep, 2019 40 commits
-
-
redatawfik authored
-When TableViewTextCell is tapped the background for the cell turned to gray while the background for the textLabel stays white. -Removing the code which sets TableViewTextCell textLabel background solves the problem. Bug: 984545 Change-Id: I615041f21b29e4c93e7d6b98b87d40be02c636e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778043 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#693185}
-
Robbie Gibson authored
There are two major changes to the design here. First, the arrow icon is now always the same color. It no longer changes color when the circle is visible. Second, the image for the border between the side_swipe view and the webpage has been removed. Now, it's always just a plain UIView with a background color. This UIView looks the same as the shadow between the toolbar and the web content (or an infobar and the web content). Bug: 998441 Change-Id: I0b96def297b7ab7688ea978ddc09d5a38be83c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768593Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#693184}
-
gogerald authored
to suppress 'UnusedResources' lint warning when feed is disabled. Bug: 982018 Change-Id: I841104a65ed7f1f7bf02b2bd4fdc40ed90505ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782718Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#693183}
-
Mitsuru Oshima authored
This was added for WS, but no longer used. Bug: None Change-Id: I02704c8bf7c968a42c79a86191396e998c42662b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783361 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693182}
-
Tibor Goldschwendt authored
Follow up to crrev/c/1769526 after downstream changes landed. Change-Id: Icc37ffc2cbeacaab4fdac810d3df464641da2696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769529Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693181}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e9e9171..d40593f4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f47f58265ab918fe575d137e2e879542625bf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784583Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693180}
-
chrome://flags/enterprisechrome://flags/deprecatedYann Dago authored
Bug: 982371 Change-Id: I6b6aaf1615cad18927df9523f12dac779b2375c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779105Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#693179}
-
Maksim Moskvitin authored
Once sync is disabled, we need to clear all Nigori data and reset model state. Since ModelTypeController for Nigori lives inside SyncEngineBackend we also need to explicitly disconnect and stop Nigori during DoShutdown(). Bug: 922900 Change-Id: Ide16fe4652d8bbdb5972c22110ae73492444e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784717 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#693178}
-
Evan Shrubsole authored
The stat has recently been added to the RTCOutboundRtpStreamStats https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-qualitylimitationresolutionchanges Bug: webrtc:10935 Change-Id: I97ba38b373996f4994a905ca7e9a5bb12ce13b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777681 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#693177}
-
Francois Doray authored
TBR=antrim@chromium.org Bug: 992022 Change-Id: I9917c63be7e2ce20cc6f06c9eb13cf3148253dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784625Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693176}
-
Ricky Liang authored
This CL makes the GpuMemoryBuffer APIs and Mojo interface public to all platforms. Although GMB-based video capture is currently only possible on CrOS, the APIs can be made platform agnostic. Bug: 982201 Change-Id: Ib16e722416c8f7f634b7a4c33630f020e42a0184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739237Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693175}
-
Lan Wei authored
In order to send multiple events in one frame, we want to use "SendCommandAndIgnoreResponse" to dispatch events, but this approach may break some tests which do not wait for the action finish in the tests. We will use a flag which will only be called asynchronously in testdriver Action API, which we use promise to wait for the action finishing. Bug: 999750, 606367 Change-Id: I05c850667c3b9aac95c0d4c7ea210360a48ffa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783243Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#693174}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/630b14f4812c..9cbdc04e23f6 Created with: gclient setdep -r src-internal@9cbdc04e23f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I73b56bedd7895d0b80e2a3aef282ef57907959f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783814Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693173}
-
Kevin Bailey authored
A small UI change to indent pedal submatches along with tab switch suggestions (if enabled as submatches). Bug: 995935 Change-Id: I657ff010e54d2cbf80ccfc029fdc8c4643b56cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783524Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693172}
-
Juanmi Huertas authored
Removing unnecessary ValidateStack that was failing as it was happening in midway during a reset stack process. Bug: 1000044 Change-Id: I8b646f60abea1d21d3d9925771d10c3330bc9c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782501 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693171}
-
Jakob Ivarsson authored
Bug: chromium:993325 Change-Id: I5e6c8cf1da24e1bb77981f9c0073b57ad2a56352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781424Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#693170}
-
Francois Doray authored
The test is flaky on Chrome OS. TBR=dgozman@chromium.org Bug: 1000654 Change-Id: I566552569619751d76284e3ccfdabf1f942c7167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784623Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1f6f69209ec2..26a87516dc1b git log 1f6f69209ec2..26a87516dc1b --date=short --no-merges --format='%ad %ae %s' 2019-09-04 jmadill@chromium.org Remove overlay font hash from codegen. Created with: gclient setdep -r src/third_party/angle@26a87516dc1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I74e02537e98bbd5a41bf036b7ed35d67c55f0bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693168}
-
Jan Wilken Dörrie authored
TBR=ulan@chromium.org Bug: 999004 Change-Id: If8eca8c8b94f91e67765f71d25b24eb53204b599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782854Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693167}
-
Jérôme Lebel authored
This patch removes dead code in MainController, ApplicationSettingsCommands and SettingsNavigationController, related to unified consent flag. This flag is now always true. Bug: 951313 Change-Id: I5a695d0b6c59ba24f1230b8f41b75a491ce6f226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784597 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
arthursonzogni authored
The test: BackForwardCacheBrowserTest.SchedulerTrackedFeaturesUpdatedWhileStoring has been reported to be flaky. It was added with a known potential for flakiness that has been resolved in this CL. Bug: 999738 Change-Id: I1342d3313fc3898067e33b7847631edbddd77058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781150Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693165}
-
Pavel Shmakov authored
When NotificationPermissionUpdater#onClientAppUninstalled is called, native might not have been loaded, so we need a ChromeFeatureList.isInitialized() check. Change-Id: Idc478bfc880264b15f0ad5303f87aba0756ded04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782853 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693164}
-
Francois Doray authored
TBR=asvitkine@chromium.org,yrsun@chromium.org Bug: 996823 Change-Id: I76d2d25e687069e9a731393368df94a80edafa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784621Reviewed-by:
-
Stefano Sanfilippo authored
Bug: 993372, 992424 Change-Id: I23bd70836fd70ef1fa98de797f04b4a7f7d1546e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782851 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#693162}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/86c39c71262d..45812a1faa61 git log 86c39c71262d..45812a1faa61 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 halcanary@google.com gn: try to fix flutter roll Created with: gclient setdep -r src/third_party/skia@45812a1faa61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I140b55faa9b84395ee086f566301e0fa033b5c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783812Reviewed-by:
-
Nico Weber authored
We now know how often these fire. Also use the new, more targeted -Wno-reorder-init-list which unblocks the roll from the cleanup. Bug: 999871,999886 Change-Id: I87c9b2e3fb75053c3ebaed2317192549570fefb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784620 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#693160}
-
Jan Krcal authored
This CL updates the rest of the avatar toolbar button code to use the new API for retrieving the unconsented primary account from IdentityManager. Bug: 983182 Change-Id: Ib1c2be250a49ecfbab7e15e52130d834b5320457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781690 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#693159}
-
Ross McIlroy authored
Change-Id: I850e1fcb8a87c38ea54b91fb49bce304262da6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783154 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693158}
-
Satoshi Niwa authored
Also update ArcPolicyBridge, the sole user of these time values. Context : We have been using SessionManagerImpl::GetArcStartTimeTicks() for perf measurements, etc, but this doesn't work for ARCVM. This CL makes ArcSessionManager.arc_start_time() equivalent to SessionManagerImpl::GetArcStartTimeTicks() by using TimeTicks. Bug: b/140361966 Test: try Change-Id: Ic935ccdf8b2177abb0644551a3b422a5e5c0c25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783687Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#693157}
-
Ren-Pei Zeng authored
Original MjpegDecodeAccelerator (MJDA) Mojo interface only permits shared memory buffers and I420 output format. This CL adds DecodeWithDmaBuf() function that enables DMA buffers and different output pixel formats. Bug: b:120057531 Test: Preview in camera apps with MJPEG stream. Change-Id: Ic5dbf2b0bf2ba13e295388db70b1ade7a117fb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547470 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#693156}
-
Stephen Chenney authored
Switch to triggering input based on the signal to restart main frame updates and commits, rather than waiting for an actual main frame update and commit. Some frames have no content until input is received, so would never get any input with the previous approach. The input system now only suppresses input when either main frame updates or compositor commits are being deferred. There are maybe some narrow windows where input might get through but this seems the only reliable way to track the deferred states because some pages have non-standard sequences of deferral (such as about:blank and DevTools). Bug: 958424, 994288 Change-Id: I94957fbdbd3a6ef0ea309c4d633f1a510458ca6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768834Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693155}
-
Kentaro Hara authored
This reverts commit 623f213f. Reason for revert: It turned out that we haven't yet reached consensus about the change. Original change's description: > Update Blink C++ styleguide > > This CL removes a couple of Blink-specific style rules per the discussion at blink-dev@ (https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/gNRO6_sMWRM/WNR2c6NdAAAJ). > > Bug: None > Change-Id: I125954a547c11d0021ef38fd6a9aff79f3d69fca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771227 > Auto-Submit: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691153} TBR=jbroman@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: Ie13c19e16803f87fc130d1483464ce051912df8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784603Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693154}
-
Ayu Ishii authored
This change follows this CL [1] and does further cleanup to remove the concept of timeouts from the SMS Receiver API mainly from the API interface and renderer process. [1] https://crrev.com/c/1783219 Bug: 1000376 Change-Id: If7b8c17e0f1332df17e374c6f84e772a267c4760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783227Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#693153}
-
Navid Zolghadr authored
This CL adds a runtime flag that sends the click and auxclick events as PointerEvents. There are more cases to fix such as context menu events and click from other paths such as touch and pointerlock. Bug: 989958 Change-Id: I0e440ceef29e6cad202bc7f07150c7f3b6b35da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762792Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693152}
-
Rune Lillesveen authored
We currently compute system colors as their rgba values based on color-scheme. However, color-scheme was not a high priority property, so changing color-scheme on the same element as the system color was set did not always yield the correct result as the color-scheme might have been applied too late. There is an open issue[1] for having system colors computing to themselves and resolve to an rgba value for the used value. That would mean we will have to change the internal storage for colors in ComputedStyle and possibly store a StyleColor with system color keywords in addition to currentcolor which currently computes to the keyword. For now, instead of introducing an even higher priority level, make color-scheme a high priority property, and delay application of the cascaded color property value to the ComputedStyle until we have applied other high priority properties. [1] https://github.com/w3c/csswg-drafts/issues/3847 Bug: 939811 Change-Id: I91ce04a55886507ee20aace9b2470a5ac5b43fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773073 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#693151}
-
Wei Lee authored
This is a reland of d66ef7a9 The original CL was wrongfully reverted in https://crrev.com/c/1783523.\ TBR=wtlee@chromium.org Original change's description: > Cleanup the usage of force-use-chrome-camera-app flag > > This CL removes all the usage of force-use-chrome-camera-app since we > make CCA the default camera app started from R76. > > Bug: b/140463175, 953690 > Test: Chrome can be compiled successfully > > Change-Id: Ib5430fc06c7c7420a3c04f21e3d0b5dbeeb4ec47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784023 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693032} Bug: b/140463175, 953690 Change-Id: I8d023f34f28673aa67737d32f8945a52534bf67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784599Reviewed-by:
-
Maksim Moskvitin authored
We need to remove all stored sync metadata when user disabled sync. Nigori is not user type, so we have to remove everything related in this case. NigoriStorage::ClearData() just removes the corresponding file. Bug: 922900 Change-Id: Icfbb27f4a693122b3d048bdba857764d5dd83a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782848 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Armando Miraglia authored
It was discovered that due the asynchronous nature of starting up a video capture device, it is possible to leave a callback holding a dangling pointer if the device is stopped before it is ready. This change makes sure that when such a stop operation occurse, also the callbacks associated to the sessions for the starting device are removed. BUG=998548 Change-Id: I27d42f266b83a2dbb26f7ecfd117cc5931564375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782813Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#693148}
-
Olya Kalitova authored
Moves files related to Crostini default container management using Ansible into a separate subdirectory. This would add more structure to source code and reduce review cycle time. TEST=unit_tests --gtest_filter="Crostini*" Bug: 1000005 Change-Id: I3924a36f39a1e2ac5ede03bb3e57c69159a361dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781449Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#693147}
-
Jérôme Lebel authored
Adding accessibility identifiers for Google services settings and manage sync settings views. Needed for crrev.com/i/1752430 Bug: 718061 Change-Id: I242a5f5e812260d00c4da2e33b9d8cb77088df8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783149Reviewed-by:
-
