GitLab

This patch implements an "add new rule" functionality to add a style rule in a user stylesheet. It is also possible to
add rule inside media query rules.

BUG=402461

Review URL: https://codereview.chromium.org/441873010

git-svn-id: svn://svn.chromium.org/blink/trunk@180164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method encourages className crafting and runs unexpectedly long.

BUG=316092

Review URL: https://codereview.chromium.org/466703002

git-svn-id: svn://svn.chromium.org/blink/trunk@180163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://fullscreen.spec.whatwg.org/#fullscreen-element-ready-check

This is a change in behavior for what was previously "a descendant
browsing context's document has a non-empty fullscreen element stack,"
now "element has no ancestor element whose local name is iframe and
namespace is the HTML namespace."

It's now never possible to go fullscreen with a descendant of an iframe,
whereas previously it would be possible as long as that iframe's
document had an empty fullscreen element stack.

Since the difference is very unlikely to affect any real content, the
LegacyFullScreenErrorExemption was dropped for this case. There was
apparently no test coverage for that exemption.

BUG=402376

Review URL: https://codereview.chromium.org/462103002

git-svn-id: svn://svn.chromium.org/blink/trunk@180162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a few target objects have a method with the same name as the selection,
we should create context menu items for all of them.

BUG=391593

Review URL: https://codereview.chromium.org/466743002

git-svn-id: svn://svn.chromium.org/blink/trunk@180161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert "Revert of [oilpan]: Change marking to do precise roots first and conservative second. (http… (patchset #2 of https://codereview.chromium.org/413133006/)

Reason for revert:
This breaks strongification of ephemerons when there are pointers on the stack. See:

https://codereview.chromium.org/461413002/

for details.


Original issue's description:
> Revert "Revert of [oilpan]: Change marking to do precise roots first and conservative second. (https://codereview.chromium.org/405403003/)"
> 
> This reverts commit 765af3a45b15c4e5f65810c8ed8e20d44da04034.
> 
> AFAICT the CrossThreadPointerToOrphanedPage test was a bit flaky in the sense that the compiler was free to reuse the slot where the stackPtrValue was located after the RELEASE_ASSERT. However the test assumed the stackPtrValue was on the stack (to mimic a rogue integer value finding a dead object) when doing the conservative GC further down.
> After my change to Heap::CollectGarbage it seemed the android compiler no longer kept the value around and hence the test started failing. I have now moved the RELEASE_ASSERT down to after the point where we do the conservative GC which makes the test pass on android again.
> 
> I uploaded the unfixed diff first and then a second diff (moved RELEASE_ASSERT) with the fix.
> 
> R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com, tkent@chromium.org, zerny@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178845

NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/464253002

git-svn-id: svn://svn.chromium.org/blink/trunk@180160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The presence of Target-related mappings in UISC is a severe
dependency violation.
This patch moves those mappings into DebuggerWorkspaceBinding.

R=pfeldman, sergeyv, vsevik

Review URL: https://codereview.chromium.org/464963002

git-svn-id: svn://svn.chromium.org/blink/trunk@180159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357274
R=lushnikov

Review URL: https://codereview.chromium.org/421123003

git-svn-id: svn://svn.chromium.org/blink/trunk@180158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/463043002

git-svn-id: svn://svn.chromium.org/blink/trunk@180156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Rename WebAnimation to WebCompositorAnimation (patchset #5 of https://codereview.chromium.org/412123002/)

Reason for revert:
BUG=402897

TBR=samli@chromium.org, jochen@chromium.org, vollick@chromium.org

Original issue's description:
> Rename WebAnimation to WebCompositorAnimation
>
> Change WebAnimation to WebCompositorAnimation
> Change WebAnimationCurve to WebCompositorAnimationCurve
> Change WebAnimationDelegate to WebCompositorAnimationDelegate
>
> This is patch 3 of 3. It builds on http://crrev.com/413983002
>
> BUG=396358
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179910

Review URL: https://codereview.chromium.org/467123002

git-svn-id: svn://svn.chromium.org/blink/trunk@180155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The name is probably a copy/paste typo originally; the expression used
for the |expected| parameter's value in code_generator_v8.pm originally
was $leastNumMandatoryParams, and this identifier somehow ended up
concatenated to the |provided| parameter's name on the C++ side.

Since then, the strange name has spread a bit, and had been "fixed" into
|providedLeastNumMandatoryParams| in some places along the way.

BUG=

Review URL: https://codereview.chromium.org/466283002

git-svn-id: svn://svn.chromium.org/blink/trunk@180154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=Tools/GardeningServer/tests.py
BUG=401358
R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/465233002

git-svn-id: svn://svn.chromium.org/blink/trunk@180153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following https://src.chromium.org/viewvc/chrome?view=rev&revision=287310,
the Blink clang plugin insists that part objects are to be traced
via Visitor's fallback method

  template<typename T>void trace(const T& t);

Fix up some uses that were not.

R=haraken
BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/471463002

git-svn-id: svn://svn.chromium.org/blink/trunk@180152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is part 2 of merging the CSS .in files. Having a single .in
file for listing CSS properties makes it both easier to add new properties
and add new property flags.

BUG=396992
TBR=pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180034

Review URL: https://codereview.chromium.org/415613002

git-svn-id: svn://svn.chromium.org/blink/trunk@180151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web Animations uses ms for duration, while legacy keyframe animations uses sec
for duration. Currently, the given perf tests use sec, so animations are weird.

BUG=309981

Review URL: https://codereview.chromium.org/433423003

git-svn-id: svn://svn.chromium.org/blink/trunk@180150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/469713002

git-svn-id: svn://svn.chromium.org/blink/trunk@180149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/457523004

git-svn-id: svn://svn.chromium.org/blink/trunk@180148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The underlying cause described in r180096 wasn't correct; update the
FIXME comment to make it more accurate.

R=haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/461373002

git-svn-id: svn://svn.chromium.org/blink/trunk@180147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8WindowShell is an implementation of "WindowProxy" in the spec
(http://www.w3.org/TR/2009/WD-html5-20090423/browsers.html#windowproxy).
We should rename it accordingly.

Review URL: https://codereview.chromium.org/451013003

git-svn-id: svn://svn.chromium.org/blink/trunk@180146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=316092
NOTRY=true

Review URL: https://codereview.chromium.org/464813002

git-svn-id: svn://svn.chromium.org/blink/trunk@180145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=316092
NOTRY=true

Review URL: https://codereview.chromium.org/461383002

git-svn-id: svn://svn.chromium.org/blink/trunk@180144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SPEC: http://dom.spec.whatwg.org/#dom-range-deletecontents

Unlike extractContents, deleteContents doesn't throw error.
So this CL modified implementation as per specified.

Behavior in other browsers.
*)FF: PASS
*)IE: PASS

In addition 4 failed cases will be passed with this CL in
http://w3c-test.org/dom/ranges/Range-deleteContents.html

TEST=LayoutTests/fast/dom/Range/deleteContents-doctype.html

Review URL: https://codereview.chromium.org/451403002

git-svn-id: svn://svn.chromium.org/blink/trunk@180143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The primary output is lextab.py, but since it is imported, Python also
writes lextab.pyc. Listing it too as an output means it won't be left
around by "ninja -t clean" (and not much else, I think.)

Prior to the patch
  https://codereview.chromium.org/425953002/
the result of not having lextab.pyc listed as an output and running
"ninja -t clean" was a tree that would build correctly, but that would
always rerun all the IDL code generation scripts, and thus never become
"clean".

BUG=397909

Review URL: https://codereview.chromium.org/463063003

git-svn-id: svn://svn.chromium.org/blink/trunk@180142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are tests for the Chromium patch r288994:
https://codereview.chromium.org/413063004

Our current shortcomings are:
- New-scope registration overrides the existing registration. This is an
existing bug: https://code.google.com/p/chromium/issues/detail?id=398355
- register() should wait before resolving if docs are using an unregistered
registration. This is a new spec requirement.
- We don't do "early-rejection" described by
https://github.com/slightlyoff/ServiceWorker/issues/396. Also a new spec
requirement.

BUG=388095

Review URL: https://codereview.chromium.org/416003003

git-svn-id: svn://svn.chromium.org/blink/trunk@180141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402766, 403121
NOTRY=true

Review URL: https://codereview.chromium.org/463413002

git-svn-id: svn://svn.chromium.org/blink/trunk@180140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If WorkerThread::stop is already called, WorkerThread::initialize should return immediately without starting the thread execution.

BUG=403179
TEST=none (it's timing-dependent)

Review URL: https://codereview.chromium.org/462423003

git-svn-id: svn://svn.chromium.org/blink/trunk@180139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function is only implemented by blink_web, but not called by
anyone, anywhere.

There are not callers of it on Blink nor on Chromium.

This fixes the TODO in WebView.h

BUG=None
TEST=None
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/469693003

git-svn-id: svn://svn.chromium.org/blink/trunk@180138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to reduce duplicated functions between V8Binding.h and
ScriptPromise.h, this CL adds arity error creation functions to V8Binding.h
and deletes arity error throwing functions from V8Binding.h and
ScriptPromise.h.

BUG=359411

Review URL: https://codereview.chromium.org/460923002

git-svn-id: svn://svn.chromium.org/blink/trunk@180137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL renames all of the repaint methods in core/rendering/svg to be
paintInvalidation.

BUG=338691

Review URL: https://codereview.chromium.org/463883003

git-svn-id: svn://svn.chromium.org/blink/trunk@180136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The directory was added recently and needs to be here so that
the right thing is uploaded to appengine.

TBR since this breaks pushing to appengine.

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/469633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of driving the blend mode computation from
updateDescendantDependentFlags, this CL drives the blend mode computation from
CompositingInputsUpdater. Using this approach lets us remove a bunch of
bookkeeping because CompositingInputsUpdater does all the bookkeeping for us.

Because CompositingInputsUpdater happens during the compositing update, we need
to add some code to the compositing update to run the CompositingInputsUpdater
even when compositing isn't available (e.g., SVGImage and InspectorOverlay).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/466193002

git-svn-id: svn://svn.chromium.org/blink/trunk@180133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180119

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/465173002

git-svn-id: svn://svn.chromium.org/blink/trunk@180132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems this one is no longer needed, just
the one in HTMLCollection is used.

Review URL: https://codereview.chromium.org/461213002

git-svn-id: svn://svn.chromium.org/blink/trunk@180131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previous implementation had three CoreInitializer methods: initEventNames,
initEventTargetNames, and initBindings, which were never called, and
ModulesInitializer contained identically named methods which were a
superset of the base class implementation. This change removes duplication
and separates core and modules initialization for a cleaner implementation.

This change doesn't fix 393728, but is a necessary refactoring for the
actual fix.

BUG=393728

Review URL: https://codereview.chromium.org/464043002

git-svn-id: svn://svn.chromium.org/blink/trunk@180130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A recent CL to Promises changed when JavaScript is run when a promise
is resolved. In the past the JS ran immediately -- now it is run
using a microtask. For EME code, the "message" event is generated right
after creating the session. It relies on the JS running and binding
an event handler. With the recent CL, it is possible for the event to
be generated before the handler is bound, so the event is lost. This
change delays posting the "message" event if there are no event handlers
registered.

BUG=402766,403121
TEST=Disabled EME browser_test passes

Review URL: https://codereview.chromium.org/465053002

git-svn-id: svn://svn.chromium.org/blink/trunk@180128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems these are not used (anymore).

Review URL: https://codereview.chromium.org/463173003

git-svn-id: svn://svn.chromium.org/blink/trunk@180127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes unnecessary blink:: prefixes.
Also it merges *namespace blink{}* blocks.
Also correcting blink presubmit errors in the changed files.

BUG=

Review URL: https://codereview.chromium.org/467573002

git-svn-id: svn://svn.chromium.org/blink/trunk@180126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This converts the remaining ui test suites, besides the two that are currently failing (ct-failure-card, ct-failure-stream).

BUG=400387
R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/464163002

git-svn-id: svn://svn.chromium.org/blink/trunk@180125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, it was possible to read stale data from
hasSelfPaintingLayerDescendant. After this CL, we clean out the dirty bit
automatically when you read this state. In order to make this work, this CL
separates hasSelfPaintingLayerDescendant from updateDescendantDependentFlags.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/468633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid importing net.html in the top level and instead have the files that
use it importing it themselves.

NOTRY=true

Review URL: https://codereview.chromium.org/467013002

git-svn-id: svn://svn.chromium.org/blink/trunk@180123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A recent CL (Blink revision 179922) changed the way JavaScript is run
after resolving a promise (used to run immediately, now run by a
microtask later). encrypted-media-lifetime-mediakeysession-reference.html
started failing as it expected the PromiseResolver object to be around
and counted. Fixing the test as the PromiseResolver object is gone by the
time the JavaScript executes after resolving a promise.

BUG=374772,378245
TEST=failing test passes

Review URL: https://codereview.chromium.org/465833003

git-svn-id: svn://svn.chromium.org/blink/trunk@180121 bbb929c8-8fbe-4397-9dbb-9b2b20218538