GitLab

This reverts commit f3535b85.

Reason for revert: AccessibilityFullscreenBrowserTest.IgnoreElementsOutsideFullscreenElement is flaky on linux-chromeos-rel

Original change's description:
> Make elements outside of the fullscreen element inert
> 
> There is no spec for this, but an old open spec issue:
> https://github.com/whatwg/fullscreen/issues/15
> 
> Bug: 787867
> Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a
> Reviewed-on: https://chromium-review.googlesource.com/788052
> Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520620}

TBR=dmazzoni@chromium.org,mlamouri@chromium.org,foolip@chromium.org

Change-Id: I5e042244565404b7735f4e5fecc4d1194ed2a402
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787867
Reviewed-on: https://chromium-review.googlesource.com/801517Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520661}

ChromeOS user type is set based on decoded is_child_account information derived
from the ID token, and this type is also used to trigger website supervision on
the browser.

This is part of the migration from the deprecated GetUserInfo call that was used
to detect a child account.

DD: https://docs.google.com/document/d/13VBL5yBr6cXHX70bs7L1jIH68GXZp67f7cBqICcCESk/edit

Bug: 716063
Change-Id: I47177aa8e7a87c4b57ffe1599f8029bc684d7e55
Reviewed-on: https://chromium-review.googlesource.com/792285
Commit-Queue: Luciana Maroun <maroun@google.com>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520660}

If a file is changed on the filesystem and is ignored in devtools it
will now properly not be created in workspaces.

R=lushnikov
BUG=754371

Change-Id: Ic0bc61ede57fb1aa17f1483f614bcca414fe14b6
Reviewed-on: https://chromium-review.googlesource.com/798735
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520659}

The test should pass now after https://chromium-review.googlesource.com/c/chromium/src/+/773483

BUG=715630

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1850aaf490b1920e9e2bc9766a6e291d0ba50b0f
Reviewed-on: https://chromium-review.googlesource.com/795037Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520658}

Control Flow Integrity [1] indirect call (cfi-icall) checking can not
verify that dynamically resolved function pointers call their intended
function. Instead we place the pointer for gdk_set_allowed_backends in
ProtectedMemory, a wrapper for keeping variables in read-only memory
except for when they are initialized.  After setting the pointer in
protected memory we can use the UnsanitizedCfiCall wrapper to disable
cfi-icall checking when calling it since we know it can not be tampered
with.

[1] https://www.chromium.org/developers/testing/control-flow-integrity

Bug: 771365
Change-Id: I5c359697c466921084aea17cda655231fdc33a92
Reviewed-on: https://chromium-review.googlesource.com/775617Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520657}

Jumbo is a unity build system for Chromium, aimed at reducing
compilation times by merging cc files into larger
translation units.

This is 0.1% of the total build time so not very much but also
the final remaining part of blink/platform. And all the CPU
minutes add up.

Bug: 761475
Change-Id: Id0643d869960a660a91a4f3a9a23b4585f9e0073
Reviewed-on: https://chromium-review.googlesource.com/785678Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#520656}

TBR: rbyers, foolip
Bug: 789707
Change-Id: I9ceb10e4ce74680a1d7d422a2d9391fd8b2a25c7
Reviewed-on: https://chromium-review.googlesource.com/801456Reviewed-by: Alex Vallee <avallee@chromium.org>
Commit-Queue: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520655}

Also add an images section.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I46fbc471c8ec047890e3866e522fecd53e9815c9
Reviewed-on: https://chromium-review.googlesource.com/798890
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520654}

The Blink Rename has made most uses of this-> unnecessary. The
relevant variable names no longer clash with the getters.

Bug: 789653
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5386997583eee778e5afc2b9718f62f3e814b5d4
Reviewed-on: https://chromium-review.googlesource.com/798031Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/heads/master@{#520653}

This closes the loop for tab focus change inside overlay in case it is
currently showm.

Bug: 788127
Test: Manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0dc45f0702e0608961718c8fafbd013227de3ee8
Reviewed-on: https://chromium-review.googlesource.com/797670
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520652}

This CL fixes the DOMTimer.cpp changes made in:
https://chromium-review.googlesource.com/737435

Bug: 772432
Change-Id: I1e990d1ac595c99249996372fcdd93530eb43f41
Reviewed-on: https://chromium-review.googlesource.com/800730
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520651}

removes colorspaces unused in chrome.
only supported ones are: RGBA/BGRA/rgbA/bgrA (decoder)
as well as: WebPPictureImportRGB/RGBX/RGBA (encoder).

Bug: 789665
Change-Id: I27fdfc197f806413526242d9b029c506e1a71c3f
Reviewed-on: https://chromium-review.googlesource.com/798472Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#520650}

Bug: 789242
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6c379b49dc444a786a5afa597c306d69f5a43841
Reviewed-on: https://chromium-review.googlesource.com/798799
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520649}

This reverts commit df64b29e.

Reason for revert: Caused http://crbug.com/790557 .

Original change's description:
> Add WebRTC logging to Windows audio input implementation.
> 
> Log failures in Open() and Start().
> 
> Bug: 757737
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Idaad68af9aabc753cb4fca17b2dfff3cdf69d83b
> Reviewed-on: https://chromium-review.googlesource.com/795727
> Commit-Queue: Henrik Grunell <grunell@chromium.org>
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520562}

TBR=grunell@chromium.org,maxmorin@chromium.org,marinaciocea@chromium.org

Change-Id: I54d97e5063d5a63325977ce19753d1e5439dd396
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757737, 790557
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/801263Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520648}

BUG=790549,788390
TBR=beccahughes
NOTRY=true

Change-Id: I4046eb8ca85c48ba0ec851a14700ace62deca5c0
Reviewed-on: https://chromium-review.googlesource.com/801656
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520647}

A header forward declared a WebUIMessageHandler in the global
namespace which seriously confused jumbo builds since the
actual WebUIMessageHandler is in the content namespace.

Change-Id: I623b2f729d03dbea199c27f62790f8119d0e3926
Reviewed-on: https://chromium-review.googlesource.com/800933
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520646}

Bug: 686281
Change-Id: I2909d2f199deec969948177770a6947ca86ddee8
Reviewed-on: https://chromium-review.googlesource.com/721843
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520645}

Makes the post-test WebappRegistry clearing occur on the UI thread.
This fixes the ConcurrentModificationException that was occasionally
being thrown due to the WebappRegistry's mStorages hash map being
simultaneously iterated over and modified on separate threads.

Bug: 
Change-Id: I38331b90d2c84cca59b4012ab4b407c191ad606f
Reviewed-on: https://chromium-review.googlesource.com/798111Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520644}

If the new virtual baseline is the same as the fallback, don't create
new baseline file. This is just the same logic as --reset-results for
normal tests and flag-specific results. Change the condition to remove
the old baseline before creating the new baseline to ensure the logic
for virtual tests.

(An example of the case:
Before rebaseline:
  base test: some/test.html
  generic baseline: some/test-expected.txt containing "BASE"
  virtual test: virtual/spv175/some/test.html
  virtual baseline: virtual/spv175/some/test-expected.txt containing "DIFF"

Suppose a code change causes the test produces the same result for the
base test and the virtual test. Previously we would reset the virtual
baseline leaving it along with the generic baseline file even if they
were the same. Now we will delete the virtual baseline.)

Remove extra spv175 baselines.

Change-Id: I3b586d7d0225b1ffd8b7da14f81914d9dacfbf03
Reviewed-on: https://chromium-review.googlesource.com/801210Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520643}

Drag up the closing launcher on the shelf area and end with FLING_START event
with velocity_y that exceeds |kAppListDragVelocityThreshold| will end with
setting the launcher state to FULLSCREEN_ALL_APPS. But the state was already
set to CLOSED after close animation is started and hence setting state to
FULLSCREEN_ALL_APPS does not have effect. Should dismiss the launcher instead
of setting its state in this case.
Related cl: https://chromium-review.googlesource.com/c/chromium/src/+/667949

Bug: 766324
Change-Id: Ibac26da14cd18c99046b801c96c974484f5d30c6
Reviewed-on: https://chromium-review.googlesource.com/798321
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520642}

Events that would trigger logging TabMetrics are ignored if we already
logged TabMetrics for the same UKM source (navigation) in the past 10
seconds. This is intended to prevent possible flooding of UKMs.

This CL parameterizes that timeout as a fieldtrial param so we
can tweak it as necessary while keeping a safe default.

Bug: 789678
Change-Id: Icd441e78cbef0a57d4b2ee2570bc09e1b1e565ef
Reviewed-on: https://chromium-review.googlesource.com/797772
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520641}

Bug: 780626
Change-Id: If716fdc9c5313ac67eb0d8580b219b3916122377
Reviewed-on: https://chromium-review.googlesource.com/762517Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520640}

To be used in SaveCardBubbleViewsBrowsertest

Bug: 772483
Change-Id: Ia5ffc7fb180465aec335f8e6a37feb200aebdccf
Reviewed-on: https://chromium-review.googlesource.com/792264
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520639}

The sync error infobar was presenting from a dismissed view controller.
This CL plumbs in the BVC as the sync presenter to the sync error
infobar.

Bug: 788377
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I26ee8ec25432d8eb482ff45d6320f4c2877702e4
Reviewed-on: https://chromium-review.googlesource.com/795651Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520638}

A follow-up of adding the info to views-based lock (CL 786635)

Bug: 789755
Change-Id: If869eba2e770667fbee607e6e2ff2093d2cf26a8
Reviewed-on: https://chromium-review.googlesource.com/798852Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520637}

BUG=

Change-Id: If69d11225a5832ff5217c23e3e1dde505f7f4d58
Reviewed-on: https://chromium-review.googlesource.com/797944Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520636}

Update ChromeDriver to support PlzNavigate in Chrome v63. (v64 is
already supported.)

Bug: chromedriver:2025
Change-Id: I9efcda03d24c5475b01e2736992624a3dffd687b
Reviewed-on: https://chromium-review.googlesource.com/798801Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520635}

Occasional flakes on win7_chromium_rel_ng.
Bug: 789948

Change-Id: I8021688e7d67a5d1313cd1189df7920cf1cb9b2d
Reviewed-on: https://chromium-review.googlesource.com/801114
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520634}

BUG=
TBR=vollick@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia51ac38950206dbe28aa2461c2ac2e88cc98c20d
Reviewed-on: https://chromium-review.googlesource.com/800891
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520633}

Initialize base::StatisticsRecorder early in the test suite to ensure
histogram pointers created at any moment during test execution are
available globally.

See https://codereview.chromium.org/2901703002 for a more complete
explanation.

Change-Id: Ib2c81dd8ef960168355c53dbc80f2a7833153483
Reviewed-on: https://chromium-review.googlesource.com/800431Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520632}

When opening a new tab from a keyboard command, the BVC is told to also focus
the omnibox.

Bug: 548179
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I98269d85e8a4d49150d58874f2c15ceea7bd9387
Reviewed-on: https://chromium-review.googlesource.com/789751
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520631}

This is a reland of 1acd2bd8
Revert reason: Break Win x64 Builder (dbg)
Original change's description:
> [scheduler] Add per-thread task duration UMA.
>
> Previously, we have extensive metric coverage and understanding of types of
> work being run on the renderer main thread. Our understanding of work being
> done on other renderer threads, however, is very limited. This patch:
>
> 1. Moved TaskDurationMetricReporter to util/ so that it can be shared by
> child/;
> 2. Added OnTaskCompleted API in WorkerScheduler and implemented it in
> WorkerSchedulerImpl and CompositorScheduler;
> 3. Report per-thread task duration for main thread, worker thread and
> compositor thread.
>
> BUG=788744
>
> Change-Id: Ida597ccb90ff42129fd786f95f0d9810a5d5b745
> Reviewed-on: https://chromium-review.googlesource.com/795014
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520368}

TBR=holte@chromium.org

Bug: 788744
Change-Id: Iecdcd17dd9bc5e934be73f38f6bfc9574e250f3f
Reviewed-on: https://chromium-review.googlesource.com/798851
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520630}

This was also seen in strace of network service.
Moved some code around to put reading command and writing reply
to the socket in the same function.

Bug: 715679
Change-Id: I381607c50e8aa1cf85f59fb7817efdf725f8c768
Reviewed-on: https://chromium-review.googlesource.com/780440
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520629}

This reverts commit 270b4e2b.

Reason for revert: causes msan regression in fuzzer

BUG=789812

TBR=danakj@chromium.org

Original change's description:
> Turn on new image blur for chrome.
>
> BUG=472742
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: Iddaaf37132faf2698c09ae0851c741fb78d97656
> Reviewed-on: https://chromium-review.googlesource.com/791010
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Herb Derby <herb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519831}

TBR=danakj@chromium.org,fmalita@chromium.org,herb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 472742
Change-Id: Ia7a31e8ec46679b69e2bad02896921da45dc279a
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/801150
Commit-Queue: Herb Derby <herb@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520628}

R=skyostil@chromium.org
BUG=699541

Change-Id: I8809b1f1486a6d92be56deaee7e135540cc0c03f
Reviewed-on: https://chromium-review.googlesource.com/800639Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520627}

85023f02 rolled clang past r318199
adding an option to insert instrumentation calls after inlining. This
drastically decreases the instrumented build size:

before:
-rwxr-x--- 1 lizeb eng 257M Nov 29 14:20 libchrome.so*

after:
-rwxr-x--- 1 lizeb eng 67M Nov 29 14:49 libchrome.so*

This should reduce compilation time on the orderfile bot.

Bug: 776702
Change-Id: I37549e5f6611286ff09238d428b05458f8f2397c
Reviewed-on: https://chromium-review.googlesource.com/796478Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520626}

media_devices.mojom is moved from //content to //WebKit/public to allow
MediaDevicesDispatcherHost mojom interface's access from Blink.

This CL is the first step towards migration of MediaDevices.enumerateDevices()
processing from content to Blink.

Bug: 764680
Change-Id: I2abdf63b7601cc24aa74434384cd0b7d28d69656
Reviewed-on: https://chromium-review.googlesource.com/790119Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#520625}

This CL adds a PresentationCallback for gl::GLSurface::SwapBuffers,
gl::GLSurface::PostSubBuffer, etc. This callback is used for getting
presentation information (timestamp for when the buffer is presented
on screen, etc). This CL also plumbs the presentation information from
GLSurface to viz::Display to trigger FrameSink presentation feedbacks.

Bug: 776877
Test: Tested with wayland_rects_client which uses FrameSink presentation feedback.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifefc21fd1e88ebaea083760115a55ab0033573ce
Reviewed-on: https://chromium-review.googlesource.com/741451Reviewed-by: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520624}

Currently, native extension bindings use the same method to execute
script whether or not JS is suspended at the time. The difference
instead is that we expect JS to finish synchronously in the sync case.
This is nice, because it means that we never circumvent script
suspension.

Unfortunately, this is insufficient. We need to execute script
synchronously in order to respond to certain JS calls, and script can
be running at multiple times even though JS is suspended (though it
perhaps shouldn't be).

Instead, change RunJSFunctionSync() to use APIs that guarantee script
execution (WebLocalFrame::CallFunctionEvenIfScriptDisabled and
v8::Function::Call). Since these should only be used in response to
direct JS entry points, this shouldn't introduce any new areas of
running script while suspended.

Bug: 786957, 653596

Change-Id: Ibc2f066bd562ab071dbd7cb2bd7de7b46d9d6892
Reviewed-on: https://chromium-review.googlesource.com/786894
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520623}

Bug: 598854
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If8a541dbd650663d255c04b8bd70bbf0f8d8342e
Reviewed-on: https://chromium-review.googlesource.com/794541Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520622}