- 09 Jul, 2020 40 commits
-
-
Anastasia Helfinstein authored
This reverts commit 2e0cfc50. Reason for revert: crbug/1103769 Original change's description: > [Switch Access] Detect menus and modal dialogs > > If the user navigates to a modal or system menu (other than by focus > automatically jumping there), we should still use the custom behavior > for modals. > > AX-Relnotes: n/a. > Bug: None. > Change-Id: Ie0b963f1540568cdd8f249ee016e787de45c0b3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270468 > Auto-Submit: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Cr-Commit-Position: refs/heads/master@{#785946} TBR=dtseng@chromium.org,anastasi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None. Change-Id: I4d285382d993d5082814da6f43e0122558777010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290350Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#786906}
-
Collin Baker authored
Fixed: 1103167 Change-Id: Ibfd33d4148ad4a776b4112860eaf36f95c9b127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289061Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#786905}
-
Liviu Tinta authored
Fix following lint problems noticed in cc/trees/property_tree.cc: 1138:Use int16/int64/etc, rather than the C type long [runtime/int] [4] 1999:Add #include <string> for string [build/include_what_you_use] [4] 1678:Add #include <utility> for move [build/include_what_you_use] [4] 2081:Add #include <algorithm> for max [build/include_what_you_use] [4] Bug: 1087088 Change-Id: I56179eb0989acae48535dc3665ee89aba948bfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289917Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#786904}
-
Anastasia Helfinstein authored
This change sets up the infrastructure for future development of an alternate form of selection via Switch Access called Point Scanning. (go/cros-switch-point-scanning has more details). Specifically, this change creates a PointScanController to drive the logic and a PointScanLayer to draw the UI, as well as a command-line to develop behind. Currently, if the flag kEnableSwitchAccessPointScanning is enabled, Switch Access draws a vertical line through the center of the screen when the feature is turned on. Bug: 1061537 Change-Id: Ifba390904d5e94ee5edbe494a6799168a95a7272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092731 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#786903}
-
danakj authored
These are flaky because they are ending before composite happens, and then their log messages don't appear in the test results. R=avi@chromium.org, jarhar@chromium.org Bug: 1103759, 866140 Change-Id: I3b651439f7b5b14e7c6f5e53bf8b335d8014f980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289943Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786902}
-
Xiaohan Wang authored
ComPtr<T>::GetAddressOf() is banned. Previously we abuse GetAddressOf() for input array of T*. This CL creates an array explicitly to get rid of this abuse. Bug: 914910 Change-Id: Id4ea06d3d188d9e7d1a5f692549f0914bc41707d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290254 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#786901}
-
Brandon Jones authored
Bug: 1099831 Change-Id: Ifd896b7caf8fedcf3083a8fc4ea6c8b1d85b94c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290073 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786900}
-
Robbie McElrath authored
crrev.com/c/2247154 introduced a regression that caused empty seed files to be considered valid. When requesting a new seed from the service, we create an empty 'new' seed file that will possibly get written to the by the service at a later point. If the service doesn't write an updated seed to the empty file, WebView is supposed to try the old seed file. Because we now consider empty seed files valid, we don't fall back to the old file anymore if there's an empty new file, which will be the case any time a new seed has been requested. Test: out/aw/bin/run_webview_instrumentation_test_apk \ Test: --gtest_filter='*VariationsSeedLoaderTest#testHaveEmptyNewSeed' Bug: 1103003 Change-Id: Ic34a685cb7623bf1d70823edc491346551e7a144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286271 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786899}
-
Chris Hamilton authored
This CL introduces a strongly typed FrameToken mojo struct. Subsequent CLs will migrate all code to use this type. BUG=1096617 Change-Id: I139e5c14ff29c9fe7437f9cc805d38da6999460a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288208Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#786898}
-
Yves Arrouye authored
When requesting device state, if the device state restore mode is set to RESTORE_MODE_NONE in the response and there is a value for the initial_state_response field, process that field immediately. See go/cros-oobe-state-determinations for design. Bug: chromium:1102607 Test: xvfb-run unit_tests --gtest_filter="*AutoEnrollmentClientImplTest*" Change-Id: Ida3976a196f9df516f6886f7bc4e56bb186e3cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283586Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#786897}
-
Yusuf Sengul authored
Bug: 1101123 Change-Id: Ic34c0e3a3e59a4311de4746b36479e0bc839a025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278067 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#786896}
-
Mike Dougherty authored
Bots rolled with the following script: git grep -l '12a6159' | xargs sed -i '' -e 's/12a6159/12a6163b/g' to update: infra/config/lib/builders.star infra/config/subprojects/chromium/master-only/ci.star testing/buildbot/mixins.pyl testing/buildbot/waterfalls.pyl then configs were generated with: ./infra/config/main.star ./testing/buildbot/generate_buildbot_json.py CIPD packages: infra_internal/ios/xcode/mac 12a6163b infra_internal/ios/xcode/ios 12a6163b Bug: 1102933 Change-Id: I647e328ed6e8b0b7160a930eb97fb98f400944b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285387 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#786895}
-
Christopher Cameron authored
Bug: 1076568 Change-Id: I795e2d1a992a3f25cf6255a8ed263c26a12f9794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289545 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786894}
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. ComPtr::ReleaseAndGetAddressOf() is safe but ComPtr::operator& is still preferred. Bug: 914910 Change-Id: Ifc70f64a9d584883b2162fafce6ef12d18647dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289440 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Matt Menke authored
Update DnsProbeBrowserTests so that none of them enable Link Doctor. The feature has been disabled globally for a year, and is now being removed. Link Doctor interacted pretty extensively with DNS error pages, which trigger DNS probes, so there were a bunch of tests for how they interacted with each other. Bug: 1030281 Change-Id: I9a0c7967dec45d8163bf03b7d23bed6155de3f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284406Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#786892}
-
Anastasia Helfinstein authored
This change adds a new class E2ETestBase to contain functions shared between extensions around end to end testing. It then moves two very commonly moved methods into the test base: newCallback and runWithLoadedTree. Because runWithLoadedTree had diverged slightly, we added one additional optional parameter to indicate what node was expected (the page contents or the desktop node). Outside of that, the function is as it was in chromevox_next_e2e_test_base.js. This change also adjusts SwitchAccessPredicateTest to use this new parameter to simplify its tests. AX-Relnotes: n/a. Bug: 1078119 Change-Id: I68c573fff6bdd26be5122363b86f8a136b3cc23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276760Reviewed-by:
-
James Hawkins authored
R=hansberry@chromium.org Bug: 902378 Change-Id: I62b8d80f2e8d41e5f2c63d78cfaccbe16d577da6 Tests: existing Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288756Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#786890}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/265b89c7b025..c71e15242e07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jarhar@google.com,nektar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1071344,chromium:1100812,chromium:1103655 Tbr: jarhar@google.com,nektar@google.com Change-Id: Id275dd14e2883a3cc6548a2c2e70ea8bfe6043ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290173Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786889}
-
Brian Sheedy authored
This reverts commit 0763c88c. Reason for revert: Suspected culprit of crbug.com/1103502 Original change's description: > Reland #2 "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > This reverts commit 0763bc96. > > Reason for reland: No longer removing target_sdk_version from webapk shell > > Original change's description: > > Revert "Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile"" > > > > This reverts commit e0f5a1c0. > > > > Reason for revert: Breaking downstream builder: > > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8875332406729172240/+/steps/compile/0/logs/raw_io.output_failure_summary_/0 > > > > Original change's description: > > > Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > > > > > This reverts commit fb07fcff. > > > > > > Reason for reland: Not changing target_sdk_version for angle tests > > > > > > Original change's description: > > > > Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > > > > > > > This reverts commit b7fb15b1. > > > > > > > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849 > > > > > > > > Original change's description: > > > > > Android: Bump default target_sdk_version 24 -> SDK used to compile > > > > > > > > > > Why do this? > > > > > * It's best practice to target the latest sdk, so this makes for a > > > > > better default. > > > > > * Many targets were neglecting to ever update this value > > > > > > TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org > > > > > > Bug: 1099849 > > > Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981 > > > Reviewed-by: Bo <boliu@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786275} > > > > TBR=boliu@chromium.org,agrieve@chromium.org,behdadb@chromium.org > > > > Change-Id: If60966b54d37bfa2c5326bcad0f36819f1c47023 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1099849 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288092 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786357} > > TBR=boliu@chromium.org,agrieve@chromium.org,behdadb@chromium.org > > Bug: 1103295 > Change-Id: Ia7cdeb9dc309d4bea7e0863b709b29ebc49ee6e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288097 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786425} TBR=boliu@chromium.org,agrieve@chromium.org Change-Id: Iae61d337d8b0ad8bf1730e9fd66e8629015fb780 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289993Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#786888}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e078f1d4..04bf08f4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I511f38d7d85e537646d223370164ab623db8c812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289616Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786887}
-
Xiaoqian Dai authored
Bug: 972162 Change-Id: I64027b7ba3be9842b4e8c4e7a270e9ae96d78cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290290Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#786886}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/58afe4cb7a7b..fac681701f44 2020-07-09 thakis@chromium.org Don't build vulkan_validation_layers on macOS. 2020-07-09 ianelliott@google.com Vulkan: Rotate damage rects for 90/270 rotation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1098741 Tbr: syoussefi@google.com Test: Test: Aztec Ruins with VVL Change-Id: Idb5f82e57ef1150063670675821179cb1783f341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786885}
-
Corentin Wallez authored
Bug: chromium:1101491 Change-Id: I5bca2df0b4ac0eb40cc6c0327f27611add3832a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289413Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#786884}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10872bf1e4d6..bb2dd57bd92c 2020-07-09 petermarshall@chromium.org tests: Request a free port for the chrome debug port 2020-07-09 sigurds@chromium.org [issues] Sort issues alphabetically 2020-07-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-07-09 alexrudenko@chromium.org Reland "Fix snippet saving and search" 2020-07-09 bmeurer@chromium.org Fix stylelint-config-standard issues in ui/tabbedPane.css 2020-07-09 tmathmeyer@chromium.org Remove media from experiments. 2020-07-09 bmeurer@chromium.org Fix stylelint-config-standard issues in ui/textPrompt.css 2020-07-09 sigurds@chromium.org Refactor TreeElement.appendChild to support sorted insertion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1018414,chromium:1066415,chromium:1072335,chromium:1083142,chromium:1093247,chromium:1101784 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia12eb81fe3ef210b71cffc4e01e0cb3010b42d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290183Reviewed-by:
-
Becca Hughes authored
At the moment we require 30 mins of watchtime for a feed to be fetched or displayed. This removes the display requirement so devs can manually fetch feeds and for them to be shown in the UI. For most users the fetching will apply the watchtime requirement. BUG=1103749 Change-Id: I01d27f5a36f526a1c6bc26a991aa5ca3454826e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290310Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#786882}
-
Sonny Sasaka authored
Feature is planned for Q3, updating the expiry. BUG=chromium:785758 TEST=Flag is shown in chrome://flags Change-Id: I6a06040f9de0055b8230c466bec7109a14bf75cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288817Reviewed-by:
-
Joey Arhar authored
This reverts commit 0b48c1a4. Reason for revert: This patch is causing a bunch of mac waterfall bots to consistently fail on the telemetry_perf_unittests step: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/6256 I was able to reproduce the failure locally on my mac and verified that this revert makes the test pass again. Original change's description: > Use the metric we've defined inside trace processor to compute the > scroll_jank table. > > This allows us to change one file in the perfetto repo and get the > improvements in all subsequent metrics we write. > > Change-Id: Ifbdf66d273f005cc99f58b165f9284a1c5c0da20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287889 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Cr-Commit-Position: refs/heads/master@{#786701} TBR=nuskos@chromium.org,khokhlov@google.com Bug: 1103727 Change-Id: I77050123dd730d07aa209a9e5182169171115756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289548Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I803b8964c53987f9a68e799b9fabc708fb072a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289385Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1b4fc33ec93c26c0bdf2214fbc58961392a90b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290175Reviewed-by:
-
Tao Bai authored
There are two issues: It seemed that triggering render process crash isn't reliable, RenderProcessExit sometime wasn't sent on navigation return, as the render process crash isn't critical case we want to test, this patch uses the simulation to avoid the flaky. The specific histogram the test checked wasn't always written after the navigation, this patch picked a random histogram from render process allocator and verifies if it was copied to the global allocator. Bug: 1102807,1102852 Change-Id: If1456b3fc87b0255c549e12350074e318737dcf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285319 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#786877}
-
Peter Wen authored
Allow java libraries to depend on androidx_activity_activity_java and androidx_savedstate_savedstate_java directly. Libraries were depending on them transitively before, but as part of the direct interface classpath effort, we are making these more explicit. Bug: 1082904 Change-Id: I6443f158fe3b5d1a81c0fdc07b5b21e1f6428c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290311 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786876}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/72669fe039c0..0e4aa978b55b 2020-07-09 khokhlov@google.com Revert "[Telemetry] Only use Perfetto sync when all agents produce proto traces" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102378 Tbr: rmhasan@google.com Change-Id: I0ee74653bc4108c472df6a5777b39bda66bfe5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289909Reviewed-by:
-
Brandon Walderman authored
This change updates JavaScriptTests.testAllJS to use a smaller window size of 640x480. get_element_location_test.html has been updated to take the smaller viewport into account. This change also updates ChromeDriverTest.testActionsMouseDrag to run safely on a smaller screen by making the drag actions a little smaller. I've verfied that the tests now run successfully on the impacted test environment. See bug for details including failed test logs. Bug: 1103391 Change-Id: I5d0284c187a7dd41b91857af102f7f6458d266fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288279 Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786874}
-
Yves Arrouye authored
This CL treats a value of 0 for the check_enrollment RW VPD key as a signal to do an initial state determination (a.k.a. initial enrollment in the code right now). If the value is 1, it still does an FRE check. This change allows for multiple initial state determinations that can bring up the proper OOBE for license packaging (LP) as well as for zero-touch enrollment (ZTE). Writing check_enrollment=0 to the RW VPD is effectively made a no-op now. We do not clean all the places in the code that write this value in this CL in order to make it smaller. This can be done easily in a followup CL. See go/cros-oobe-state-determinations for design. --gtest_filter="*Wizard*WithInitialEnrollmentTest*" Bug: chromium:1103006 Test: xvfb-run -s "-screen 0 800x600x24" out/Default/browser_tests \ Change-Id: Ia3f60cee26dbe0fc8c81818c04c483e50ac7aaaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285517 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/08a294d37693..6cd27bab06f4 2020-07-09 capn@google.com Remove unsupported formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic5d345403ac8b8c50bae89733562193356239379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290176Reviewed-by:
-
Panos Astithas authored
Bug: 1101179 Change-Id: I4c4bad5bede356bd34601c3972beefa935c77719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286474Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Panos Astithas <pastithas@google.com> Cr-Commit-Position: refs/heads/master@{#786871}
-
Tim Volodine authored
SyntheticInputTest.SlowSmoothScrollWheel test is flaky on Android bots. Failed recently on Lollipop Phone Tester, see crbug.com/1103731. BUG=1103731 TBR=bokan@chromium.org,sadrul@chromium.org Change-Id: I7bc8a98daf7f192eed6f0f7ef7d3ad4ca9b14900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288706Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#786870}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594295624-67e0cea334ff513a5ec88ee6203327adbc5924fc.profdata to chrome-mac-master-1594317395-ab4c4d7824bf93337da7afe44e0cee387faf7ba7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8ecb5e914432d4403036183b2d7812127f247869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289656Reviewed-by:
-
Ali Juma authored
This CL moves real-time lookup logic from safe_browsing_url_checker_impl_content.cc to safe_browsing_url_checker_impl.cc, so it can be used on iOS. Only WebUI-related logic remains in the content-specific file. This CL also makes SafeBrowsingUrlCheckerTests run on iOS. Bug: 1103218 Change-Id: I9ee4eda4b90d10d75890e213c13e244607e1523c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288205Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#786868}
-
danakj authored
Either the renderer sends it, or the browser generates it. R=avi@chromium.org Bug: 866140 Change-Id: I3691825760ce2e8d260de856a8d3756206df1c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289387 Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
