- 18 Sep, 2019 40 commits
-
-
Pauline Leitao authored
BookmarkSpecifics are currently accepted even if their GUID field holds an invalid value. However, we want to discard updates containing an invalid GUID, unless such GUID is empty, as we handle this situation separately. This CL makes the corresponding changes for this to happen. Bug: 978430 Change-Id: I39c32cef051e07b36f4dc20027c5ab3414f1c1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807332 Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697570}
-
Mohamed Abdelhalim authored
This is the 5th CL of multiple CLs to remove the usages of NavigationHandleImpl completely and replace it with NavigationRequest. This CL aims at replacing navigation_request->navigation_handle()->* pattern with navigation_request->*. Bug: 995268 Change-Id: I40a10f674ee5adecefbfe9183654a3a3b9a3f4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807196Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697569}
-
Hans Wennborg authored
This reverts commit 445e3f42. Reason for revert: This broke the x86 and x86_64 builds (see bug): 797/85913] ACTION //chrome/android:chrome_java__lint(//build/toolchain/android:android_clang_x64) FAILED: gen/chrome/android/chrome_java__lint/result.xml gen/chrome/android/chrome_java__lint/config.xml python ../../build/android/gyp/lint.py --lint-path ../../third_party/android_sdk/public/tools-lint/b...(too long) ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml:679 The resource `R.string.update_from_market` appears to be unused: UnusedResources [warning] <string name="update_from_market">"Update"</string> ~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > Remove unused methods in AccessibilityUtil. > > These methods were added for crbug.com/358708 but the usage was > reverted shortly after and they were not cleaned up. > > Bug: 995916 > Change-Id: I63a4ec3756e34b56e1cccb54cbc7cf1bb9c312ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808082 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697363} TBR=dmazzoni@chromium.org,twellington@chromium.org,hnakashima@chromium.org Change-Id: Idf10d1a28b5c0cf5dfd13edf697451966eea64bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995916, 1005188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810525Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#697568}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d5521094f779..873079f1d3a2 git log d5521094f779..873079f1d3a2 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src be467db7bdaa..e0932f676db6 (3 commits) Created with: gclient setdep -r src/third_party/angle@873079f1d3a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I2f3de5e468660733d538524777ecdcd7559d6741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810461Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697567}
-
Henrique Ferreiro authored
Convert the implementation and all users of the content::mojom::InputInjector interface. Bug: 955171 Change-Id: I2950bd5d4f0770a4714fead2033ba578e5be639b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807498Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697566}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4c8d52b7313..a1178b9bda47 git log a4c8d52b7313..a1178b9bda47 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 treehugger-gerrit@google.com Merge "ui: Reset pan/zoom acceleration when reversing direction" 2019-09-18 tneda@google.com Merge "perfetto-ui: Adding border over the clicked marker and hover state" 2019-09-18 fmayer@google.com Merge "Do not close FD while held by FILE*." 2019-09-18 hjd@google.com Merge "perfetto-ui: Pan down to search result" Created with: gclient setdep -r src/third_party/perfetto@a1178b9bda47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I48ca84b7e7aef43c6ddcd4f754b2f803f54e8f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810460Reviewed-by:
-
Ioana Pandele authored
The backend for the HC link has been updated. Bug: 1002035 Change-Id: Ieaaa3aeb421ce2a0f62d14bd566305a45db799e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791152 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697564}
-
Kent Tamura authored
Include url_loader_factory.mojom-blink-forward.h instead of url_loader_factory.mojom-blink.h in resource_loader_options.h This CL reduces the estimated pre-processed size of resource_loader_options.h from 3.53MB to 0.89MB. Bug: 1001360 Change-Id: If3406a954fbe94f8a0486b0a73a32f5c312aaa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810508Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697563}
-
Pauline Leitao authored
This CL adds UMA metrics to keep track of the reasons BookmarkSpecifics are being deemed invalid upon being processed. Bug: 988451 Change-Id: If3e588a4fad485c16e9a650e60209fce16873944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724669Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Cr-Commit-Position: refs/heads/master@{#697562}
-
Henrique Ferreiro authored
Convert the implementation and all users of the media::mojom::MediaEngagementScoreDetailsProvider interface. Bug: 955171 Change-Id: Ifd5be6d387550e17b5dc9707f6c82ce3c2acc7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803293Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697561}
-
Mohamed Abdelhalim authored
This is the 3rd CL of multiple CLs to remove the usages of NavigationHandleImpl completely and replace it with NavigationRequest. This CL replaces NavigationHandleImpl in MixedContentNavigationThrottle and NavigationHandleImplBrowserTest with NavigationRequest, and renames NavigationHandleImplBrowserTest to NavigationRequestBrowserTest. Bug: 995268 Change-Id: Ia0d76dda052f4cea67586cafdc51635a4a3c8a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803447 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
-
Lowell Manners authored
The following tests now pass with BackForwardCacheEnabled: NavigationControllerTest.Back_NewPending NavigationControllerTest.CopyStateFromAndPruneSourcePending Bug: 1003744 Change-Id: Ib2803487eba3612e2f00918854284e2e5b9ddb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810521Reviewed-by:
-
Miyoung Shin authored
This CL converts SystemInfo{Ptr, Request} in services to the new Mojo types. Bug: 955171 Change-Id: Ie5d39d40751a95a20cafbddcc118d76c2090b01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787636 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:Olga Sharonova <olka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd1414608ba1..f948db6228fd git log fd1414608ba1..f948db6228fd --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Abolish absClear 2019-09-18 csmartdalton@google.com Revert "Reorder msaa and mipmap resolves to happen all at once" Created with: gclient setdep -r src/third_party/skia@f948db6228fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I8bc57abfe8ae46099c141097666bb14049605466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810619Reviewed-by:
-
Nico Weber authored
Reland "win: Pass /libpath: on Windows too, and use /lldignoreenv to make lld ignore the %LIB% env var." This is a reland of 1a693093 The reland completely omits the non-clang toolchains in cross builds. Original change's description: > win: Pass /libpath: on Windows too, and use /lldignoreenv to make lld ignore the %LIB% env var. > > See https://reviews.llvm.org/D67456 > > Makes the build a bit more hermetic, and should have no behavior change. > > Bug: none > Change-Id: I90080aa7f8ec814e6ec9b1a4fbcad464e12a450d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807154 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697369} Bug: none Change-Id: I0de1b71b0f2bff753bcbe69da01ea9694e11edf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810061 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This change adds a presubmit check preventing new usages of the following old Mojo types, which are now considered deprecated in favor of the ones outlined in crbug.com/955171: - mojo::AssociatedBinding<> - mojo::AssociatedBindingSet<> - mojo::AssociatedInterfacePtr<> - mojo::AssociatedInterfacePtrInfo<> - mojo::AssociatedInterfaceRequest<> - mojo::Binding<> - mojo::BindingSet<> - mojo::InterfacePtr<> - mojo::InterfacePtrInfo<> - mojo::InterfaceRequest<> - mojo::MakeStrongAssociatedBinding() - mojo::MakeStrongBinding() - mojo::MakeRequest() - mojo::MakeRequestAssociatedWithDedicatedPipe() - mojo::StrongAssociatedBindingSet<> - mojo::StrongBindingSet<> For now, we will only raise warnings during the presubmit stage whenever any of these types get introduced in //third_party/blink, but the plan is to progressively cover more directories and convert such warnings into errors as soon as more areas get fully migrated to the new types. See the "Mojo Bindings Conversion CheatSheet" for more information: https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E Bug: 955171 Change-Id: I0d40b1507d85cbc11397f9c2fb02fb96a7490911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796371 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#697555}
-
Pauline Leitao authored
In cases where no GUID is found in BookmarkSpecifics, the originator_client_item_id is used to populate the GUID field, as long as it is of valid GUID format. This CL records UMA metrics to determine how often: -A valid GUID was actually found in the specifics. -The originator_client_item_id was a valid GUID and therefore used. -The originator_client_item_id was not a valid GUID and thus the GUID field was left empty. Bug: 989560 Change-Id: Ie1b5dbb965b7313946406d10bc3c944e0b7f3a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729158 Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16144e1a..36658f46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I037be18e911cf99530a68e7ca668bf31b0f0a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810717Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697553}
-
Marc Treib authored
These have evolved to mean something different, so those names weren't appropriate anymore. They're now called delegate_for_full_sync_mode/ delegate_for_transport_mode. Similarly, the StorageOption enum is renamed to SyncMode and its entries from STORAGE_ON_DISK/STORAGE_IN_MEMORY to kFull/kTransportOnly. TBRing trivial changes (renaming some parameters) in autofill_wallet_model_type_controller.h/cc TBR=jsaul@google.com Bug: 999980 Change-Id: I21ecfb6620ac42d323b91fc284e0593d19ff4379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795605 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This CL enables VaapiVideoEncodeAccelerator encode GpuMemoryBuffer based VideoFrame. VaapiideoEncodeAccelerator still can encode DMABUF based VideoFrame. Bug: 1001413 Test: video_encode_accelerator_unittest on eve with crrev.com/c/1808939 Change-Id: I992d076a8c90eb7ad6f157e21d0f982cf2ca49dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809043 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697551}
-
Andrei Chulkov authored
This CL add tests to ensure that the onboarding UI is prompted when the user submits a password form and that the subsequent flow is functioning correctly. Bug: 983445 Change-Id: Ic2489724b74bf90e0120de3fff1266e1aaa071ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809305Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Albert J. Wong authored
ScreenInfo appears to be a page-wide concept. Even in emulation mode, it is unclear why any local roots would have a different ScreenInfo concept. To make this work, PageMsg_UpdateScreenInfo also had to be removed otherwise there would be a race that could cause missed updates. Luckily, PageMsg_UpdateScreenInfo sending was only ever triggered by RenderWidgetHostImpl::SynchronizeVisualProperties() which would have sent another message containing the ScreenInfo update to the targeted renderer earlier in the function. This made PageMsg_UpdateScreenInfo just redundant. Bug: 419087,998273 Change-Id: Id4edf4d7141487feb39fe9e8e41b465191d48bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797141Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
James Forshaw authored
This CL adds new sandbox error codes to replace the many instances of the SBOX_ERROR_GENERIC code. This should aid in identifying the cause of sandbox launch failures. Bug: 1000447 Change-Id: I64ed1891e699dad253b608e68c954b095ef29ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808448Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697548}
-
Henrique Ferreiro authored
Convert the implementation and all users of the explore_sites_internals::mojom::PageHandler interface. Bug: 955171 Change-Id: I10c6afa8c22eb3ccac5bba728cb90b4b023ebe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807319Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL is a preparation for an upcoming CL, in which CoverageModel starts supporting suspendModel/resumeModel. CoverageModel needs to perform actions that still/already require the other models to be suspended/resumed, so this will make use of the new hooks. Drive-by: Don't start shutting down models while still polling data from them. Bug: chromium:1000155, chromium:1002427 Change-Id: I98f318daa909b129d992bdc142d1b3a6ed0adefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795442 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#697546}
-
Raphael Kubo da Costa authored
According to FindIt this is also affecting release builds such as mac-rel. See https://bugs.chromium.org/p/chromium/issues/detail?id=833215#c22 for example. TBR=reillyg, wanming.lin@intel.com Bug: 731018 Change-Id: I2ede287e13d3c9a3e7ff934859e70194c0110ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807304Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#697545}
-
Friedrich [CET] authored
This reverts commit 20a13e9a. Reason for revert: The string is not a good choice. Landing a second CL will make merging really hard. Therefore, Undo this CL and redo it with a proper text. Original change's description: > [Mfill Android] Improve announcement for keyboard accessory > > The keyboard accessory was still using the old announcement. It would > shout "Passwords available" which isn't wrong since passwords fallbacks > are available but it is very unprecise, incomplete and misleading if the > accessory is filled with Address autofill suggestion. > > Bug: 969202 > Change-Id: I5792ff1479b361344d976b3036bec7b46cdf5638 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793082 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695079} TBR=fhorschig@chromium.org,ioanap@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 969202 Change-Id: I70bd861c012d0d67a4f6ca6529079b8597e8c84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807237Reviewed-by:
-
Thomas Tangl authored
Flag: profile-menu-revamp Bug: 995720 Change-Id: I6faf022715aa95342b646833990789864b3b5146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807330 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#697543}
-
Sylvain Defresne authored
When using IdentityTestEnvironmentProfileAdaptor, it is required to register the testing factories when creating the Profile, as the adaptor will expect the IdentityManager to have been created with certain fakes. If the factories are not set, then it is possible to encounter Undefined Behaviour (as IdentityTestEnvironment cast some of the objects to the expected fake subclasses) in the worst case or just non-fonctioning test (calling undefined methods) on certain platforms. Fix ChromeAssistantUtilTest to use the proper factory. Bug: 982751 Change-Id: Ic61a874b300cf36f3575f524a8bf7e57e0dc96b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806741Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#697542}
-
Roman Sorokin authored
Bug: none Change-Id: Ic0f05310a37d5de634e46e7f19d9d6642902732a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807505 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#697541}
-
Arthur Hemery authored
When going through NavigateFromFrameProxy, it is possible to cancel an ongoing browser initiated navigation if we have a navigation that moved from the FrameTreeNode to the RenderFrameHost already. In this case however, under specific timing conditions, and if this new navigation does not commit, we could be left in a state that has a pending navigation entry to the original browser initiated navigation, effectively spoofing the URL. To make sure we do not leave the pending navigation entry hanging, we discard it as soon as we try to do another navigation and cancel the original one. Bug: 966914 Change-Id: Ib9b66bd87f072b89465da0793296142cf8523cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751205 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
-
Jit Yao Yap authored
When starting a managed guest session (with no Terms of Service), a blank Ash dialog is shown for a brief moment before the session starts. This is caused by the Ash dialog for Oobe being shown even when all the Oobe screens are skipped. This CL changes the behavior of the Ash dialog to only show when required by using a OobeUI::Observer. The dialog is not shown by default, and will be shown when a Oobe screen is shown. OobeScreenWaiter now checks that the native window is visible by default. A small number of tests had to be changed to either show the native window or ignore the visibility check. The reasoning for the changes are in the comments for their respective tests. The WebUI behavior is unchanged. Bug: 1000164 Change-Id: I9995f4beba85d7c5af7b13f81f1a654e2d52f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790450 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#697539}
-
arthursonzogni authored
(This is a pure refactor. Changes in behavior aren't expected) - Use early returns, it avoid using too many nested if/then/else. There was up to 4 level of indentation in this function. - Remove unnecessary DCHECK. Checking a pointer to be non-null before dereferencing it is useless, because it would have immediately crash anyway. Bug: 1001982 Change-Id: Id54de8441bb0b19b91a70d22435dff5fcd6c5260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806674Reviewed-by:
-
Thomas Tangl authored
Sync promos are added to the identity box of the profile menu. Screenshots: https://drive.google.com/file/d/16Hrj0jMyRW9V0Lujnht__dq9FwDbDqgZ/view?usp=sharing https://drive.google.com/file/d/11pITu_EY6jwocAbDwpE14dRQEbWXsMev/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: I54848b8688cb9e7417a8b9274f85b6093148e568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807502 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Ken Rockot authored
ResetIPC() is called by both Cleanup() and ProcessDied(), where the latter may be called immediately before the RPHI is reused for a new render process. Some IPC-related cleanup tasks were only being done in Cleanup(). This means it was possible for some tasks scheduled on behalf of the previous process to run after a new process was started by the host. Namely UI-thread interface binding tasks -- limited in lifetime by instance_weak_factory_ WeakPtrs -- could run despite ProcessDied() being invoked after their scheduling. This CL resets instance_weak_factory_ in ResetIPC() rather than only in Cleanup(). It also moves |io_thread_host_| cleanup to ResetIPC() for good measure, since this should prevent some inevitably-cancelled UI thread tasks from being posted on a dead process's behalf. Bug: 1000327 Change-Id: Ib2701e2d99a922c991d57745ad63a6d9b8c294ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810036Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#697536}
-
Anton Bikineev authored
This fixes EventsDispatchingInDeeplyNestedV1ShadowTrees regressions in blink_perf.events. Bug: 1003112 Change-Id: I7e5feed395cf9232d576940594a2432e14d5d55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809304 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This CL enables V4L2VideoEncodeAccelerator to encode GpuMemoryBuffer based VideoFrame. GpuMemoryBuffer is preferred to DMABUF on encoding because GpumemoryBuffer interface support Map() and multiplatform support (e.g. Android and Windows). V4L2VideoEncodeAccelerator still can encode DMABUF based VideoFrame. Bug: 1001413 Test: video_encode_accelerator_unittest on kevin with crrev.com/c/1808939 Change-Id: I1bc19d47bea88077cb778cb2c7c70618d22731a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808946 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#697534}
-
Mikel Astiz authored
Besides Windows, flakes have also been observed on: Mac: http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/46978 Linux: http://build.chromium.org/p/chromium.linux/builders/linux-trusty-rel/builds/2754 ChromeOS: http://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/29284 TBR=dtrainor@chromium.org Bug: 810982 Change-Id: I30a1e0a9394b5fd34406e618fe51abafd7ddf899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810519Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b12fdd2a7ac..a4c8d52b7313 git log 5b12fdd2a7ac..a4c8d52b7313 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 hjd@google.com Merge "perfetto-ui: Checkerboard on no data" Created with: gclient setdep -r src/third_party/perfetto@a4c8d52b7313 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1d468a21de5413fadb722ddd09211f03019d2923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809985Reviewed-by:
-
Maks Orlovich authored
Bug: 911299 Change-Id: Icb13317ebaf558753d828754148009cff9ad9ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784957 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#697531}
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
