- 29 Nov, 2019 40 commits
-
-
Finnur Thorarinsson authored
Bug: 1027019, 860467. Change-Id: I60f74c73bdcd7c071bf21ecdd8eeb5e9909d5ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943144Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#720215}
-
Guido Urdaneta authored
It has been timing out flakily and causing some CQ false rejections. Bug: 1027436 Change-Id: I093ef6e1aeed38d36488825dbea1181e9afafcae No-Try: True TBR: petermarshall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944353Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720214}
-
Thomas Tangl authored
Bug: 1021587, 993752 Change-Id: Id0b9adcfa72c5c9567a315dc7bada293a2bdbe52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899880 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#720213}
-
danakj authored
R=blundell@chromium.org, clamy@chromium.org TBR=reillyg@chromium.org Bug: 1007763 Change-Id: Id5aba2a6a9d0bd01a738704b844cc429c0132650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942939 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720212}
-
Jeremy Roman authored
In response to https://chromium-review.googlesource.com/c/chromium/src/+/1943108. Change-Id: I06e99b465b52aa6710d6f747277c375b86be5b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943334 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720211}
-
chrome://media-internalsSamuel Huang authored
This moves ~19 kB of gzipped resources to the DFM. The resources are split from content_resources.grd, so extra work is needed compare to other DevUI DFM page movement tasks: * Generate media_internals_resources_map.{cc, h}, and have these read by SharedResourcesDataSource. * Repack media_internals_resources.pak into content_shell.pak. Bug: 927131 Change-Id: Ic10fadb3eff4d519b7eacf430d75e1be3dcba122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937850Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#720210}
-
Finnur Thorarinsson authored
After inspecting the AOSP code and talking to a member of the Android Contacts team, it looks like there is no code path that would result in an image being handed to our Contact Picker, without Android Contacts first decoding it in the same way we do. Bug: 860467 Change-Id: Ifb1c75cf0048c843644506e6d0fe4f9b886b6095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943181Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a44c3e3b3615..9544832a076e Created with: gclient setdep -r src-internal@9544832a076e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981,chromium:1029449,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: If8220a471e4634744d92c467c25ae3f6aa3a8ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720208}
-
Denis Kuznetsov authored
Explicitly shut down LoginDisplayHost in OOBEConfigurationTests It should remove flakiness upon shutdown. Also Fix race condition in setting up demo mode (reason for previous revert). Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1934342 Bug: 997685 Change-Id: I0cb8f084484395a13bc3b29e8f1b7150cada8403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942339 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720207}
-
Marc Treib authored
This CL adds a pref that stores which accounts have opted in to use the Google account storage for passwords. While this pref is false, passwords can not be saved to the account, and passwords in the account are not downloaded. It also adds an entry to the password autofill dropdown that lets the user set the opt-in. Bug: 1024332 Change-Id: Iac552c310d0e9f19ee2bb1893e217e60b1114d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645294 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#720206}
-
danakj authored
Use OnceCallback where possible, and use BindRepeating() where it is meant to be a RepeatingCallback. Majority of this change is a few typedefs that are very widely used: - LoadedCallback - ValidateTokenCallback - ValidateRegistrationCallback - GotDataCallback** ** Especially this one. R=blundell@chromium.org, clamy@chromium.org, marq@chromium.org TBR=clamy Bug: 1007760 Change-Id: I3e6b2bfbc1ff5d36a96628da1163f6a37fb2b204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943327 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a58befe..44b794ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic16dd7bb18ca29088fd4221e347f8215aa63932b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944371Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720204}
-
Finnur Thorarinsson authored
Bug: 1029056, 656015 Change-Id: Ib206c718ba4984d67209c708b4baa75e5f77816d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940186Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#720203}
-
Tomasz Dobrowolski authored
Added KerberosCredentialsManagerFactory and promoted KerberosCredentialsManager to KeyedService to provide a way to control initialization order with other keyed services that may depend on it. Bug: 1027087 Change-Id: I157c5aba8e1efc604ee4978d382469650a62a1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928790 Commit-Queue: Tomasz Dobrowolski <tomdobro@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Auto-Submit: Tomasz Dobrowolski <tomdobro@chromium.org> Cr-Commit-Position: refs/heads/master@{#720202}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fb7ca1d5aca5..9d128947de8c git log fb7ca1d5aca5..9d128947de8c --date=short --first-parent --format='%ad %ae %s' 2019-11-29 swiftshader.regress@gmail.com Regres: Update test lists @ fb7ca1d5 Created with: gclient setdep -r src/third_party/swiftshader@9d128947de8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6985b0c54a6582a8dcb80f2509d7f6fc7c43b8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720201}
-
Javier Ernesto Flores Robles authored
This naming is more consistent with the rest of the sibling folders. Bug: 959739 Change-Id: Ief587f052449c9d2bdfbf184ba0f4f996c897406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943136Reviewed-by:
-
Olya Kalitova authored
If during Crostini installation default Crostini container is failed to be configured, removes Crostini at all so that "Retry" button installs Crostini from the very beginning and Terminal app icon is not available in a Chrome OS launcher. Test: unit_tests --gtest_filter="Crostini*" Bug: 1022784 Change-Id: I8d8c45cf6c39593657963786c117d384a6cecf9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917202 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#720199}
-
Gauthier Ambard authored
This CL freezes the Safari version in the Mobile User Agent, aligning with https://blog.chromium.org/2019/05/improving-privacy-and-security-on-web.html. It will also increase compatibility with WebKit, as it is frozen in WebKit mobile User Agent. The iOS 12 version was introduced in http://crrev.com/c/1102485. This CL was made during the beta version of iOS 12, my guess is that the version was frozen in WebKit before the Stable version was released, so we released a wrong version by mistake. Bug: 1026615 Change-Id: I7641bc54327f3d135501dc47c365c4458ca8dace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926488 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#720198}
-
Stephen McGruer authored
After https://crrev.com/e90092dea, the --force-prefers-reduced-motion flag could be accidentally ignored if the system-level setting was changed after the browser had started. This CL restores the behavior so that the flag always wins, and adds a test to ensure that. Bug: None Change-Id: I46927e3821f1118f38f4896d07755b3eaebe48b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921553Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720197}
-
Chris Sharp authored
TBR=xhwang Bug: 1029355 Change-Id: I42665ef9025a00ced5c33c88fc74781b0cec1c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943031Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720196}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/31b0a5681dea..8df9e6a2d570 git log 31b0a5681dea..8df9e6a2d570 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 ilkos@google.com Merge "trace_processor: fix span outer join when one of the tables is empty" Created with: gclient setdep -r src/third_party/perfetto@8df9e6a2d570 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id055921f56529d4f4902b67e951af3fb161372c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943609Reviewed-by:
-
Marc Treib authored
The old (Tango-based) implementation of invalidations has been (mostly) replaced by a new (FCM-based) one. The old one can not quite be deleted yet, so this CL marks all the old classes/files with a TODO for removal. It also removes a few unnecessary includes of the to-be-removed files. Bug: 1029481 Change-Id: Ic10da302ba20731487fc4784971c923bec07a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943177 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720194}
-
David Roger authored
Pre-Dice promos are no longer used. This CL removes the code and the resources. TBR=jsaul Change-Id: Ia38bd805e69aa5d3890fef8d77582d4525189447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944387 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#720193}
-
Balazs Engedy authored
The production code has also been updated in two regards: -- CrowdDenySafeBrowsingRequest::SafeBrowsingClient no longer assumes that CheckApiBlacklistUrl never invokes the callback synchronously if it returns false, as this can actually happen if the full hashes are already available on the client. -- DeleteOnIOThread is replaced with a manual call to DeleteSoon, as the former made testing difficult. Bug: 1028642 Change-Id: Id939dd25e7ddabf6ed3529209eaa4ec2a2d7609e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942429Reviewed-by:Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5a792c5fb9e..a44c3e3b3615 Created with: gclient setdep -r src-internal@a44c3e3b3615 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id87a2bb9131d1d3087e7fb8a09525851d2d4bb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943383Reviewed-by:
-
Kevin Ellis authored
This patch adds ref tests for play controls and enables these tests to run as part of a virtual test suite with the compositor enabled. The tests are designed to catch regression that break animation play controls. Tests were added for syncing the compositor start time as well as updating the playback rate. The test for zero playback rate exposed a bug where it should have been disabled on the compositor but wasn't. This bug is also fixed in the patch. Bug: 1029123 Change-Id: I0304d80b93ef273dd2f1dbcd58e2371bc046941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943367Reviewed-by:
-
Marc Treib authored
invalidation_util.h/cc contained a few functions to convert between InvalidationObjectId and string that were unused, so this CL removes them. Bug: none Change-Id: I4b90fb78eaf4a1b4c43f193715ed9d67da4642f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943134 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Marc Treib authored
The flags (cmdline switches) kInvalidationUseGCMChannel and kSyncNotificationHostPort were obsolete (never set or checked anymore), so this CL removes them. Bug: none Change-Id: Id11dd81bae8fcb49b0b8b2f2eae4013cfd2a06f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944348 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Jan Scheffler authored
This cl prepares for crrev.com/c/1934213 Bug: chromium:1016772 Change-Id: I3ed38174fce88373bb205a2e0fc3a63f8d7901cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936491 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#720187}
-
Marc Treib authored
Bug: none Change-Id: I0bce94804ed7d9877ca2189a56e139e75eb47550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943178 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Navid Zolghadr authored
This CL paves the way to move the ComputedStyle to Oilpan as this is needed to get MakeGarbageCollected to work with this class. Bug: 939691 Change-Id: I3f3455b86e2d53cefe17c0b27c7462a4b54fc8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943493Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720185}
-
Peter Marshall authored
onceAttachedToTarget needs to be run before the thing that causes the target creation otherwise it will race with the creation, which could occur after e.g. the evaluate() call and before the onceAttached() call. Change-Id: I26cd5d9d6fdd993fcb0a38c28923870b0e5c8e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944467 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720184}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e2f45a379a7..13f71fb5e752 git log 5e2f45a379a7..13f71fb5e752 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 tvanderlippe@chromium.org Reland "Migrate elements/ to ESM" Created with: gclient setdep -r src/third_party/devtools-frontend/src@13f71fb5e752 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e809aea83b27afd4f909b80bcfbe76aea8da7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943382Reviewed-by:
-
Gauthier Ambard authored
This CL doesn't introduce any functional change. This CL cleans up the code constructing the user agent as it was based on outdated methods. It also adds the UserAgentType parameter, allowing to get the desktop user agent if necessary. Bug: 1026615 Change-Id: I157baf8b0135e2e16c0a738a3301e00814df45b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921983Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b9646867..0a58befe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I324ad51b4719111d7b558b3d005983befadb2a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943006Reviewed-by:
-
Carlos Caballero authored
Make sure we do not show a UI for pages in the cache. Bug: 1001087 Change-Id: I7f77f144252d36070b710506fa3a82a48e95e6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939983 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#720180}
-
Greg Thompson authored
Unregistering ends up posting tasks to perform cleanup in the Encryption db. Let these tasks run during TearDown so that all files have been closed by the time the test fixture's ScopedTempDir is torn down. BUG=546640 Change-Id: Iddbe8857e96c3042ea9d15223b299acb521a1b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943230 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Reilly Grant authored
Bug: 1007721 Change-Id: I227e7a9eb2d98f7650410443aa4cab3b544d3bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934517 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Sam McNally authored
This is a reland of c54a52fa with the native messaging host registered as user-level in the test, avoiding issues where overriding the local machine registry to register the host as system-level would cause renderer launching to fail on Windows 7. Original change's description: > Allow background mode while an extension is communicating with a native app. > > Add support for enabling background mode while an extension capable of > accepting inbound native messaging launch requests is active. Allow > cooperating native apps to launch Chrome without a browser window when > initiating communications with a cooperating extension. > > Bug: 967262 > Change-Id: I61353c0becb341ad3e08a5a8635e171f9f9bd59b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898894 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Drew Wilson <atwilson@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Reviewed-by: Sergei Datsenko <dats@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716480} Bug: 967262 Tbr: sergeyu@chromium.org, atwilson@chromium.org, tmartino@chromium.org, dats@chromium.org Change-Id: Ice54f4f309c5714d3011647d845d7c2af9a1ed39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923870Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#720177}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae8c170db133..b5a792c5fb9e Created with: gclient setdep -r src-internal@b5a792c5fb9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I207fc90518cb433536be212e3c05e957baa86d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944307Reviewed-by:
-
