GitLab

RotateHidingWindowAnimationObserver is leaking from
wm::AnimateOnChildWindowVisibilityChanged() because it's not observing
animation events. The fix is to make RotateHidingWindowAnimationObserver
observe the animation events.

BUG=389296
TEST=wm_unittests:WindowAnimationsTest.RotateHideNoLeak

Review URL: https://codereview.chromium.org/343753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283970 0039d316-1c4b-4281-b951-d872f2087c98

Add some tests for FontRenderParams's interactions with
Fontconfig, which is used on desktop Linux and Chrome OS.

Also re-add platform_font_pango_unittest.cc for gn.

BUG=125235

Review URL: https://codereview.chromium.org/394963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283969 0039d316-1c4b-4281-b951-d872f2087c98

Fix extension scrollbar regression bug, and add a regression test to catch similar issues in the future.

This changes the extension_install_dialog_view permission strings layout to have a fixed width for the bullet, centered, and subtract that width from the width used to size the permission string label.

This also adds two browser tests: one to test that a scrollbar _does_ show for a very long set of permissions, and one for the specific regression case from the bug.

BUG=385570

Review URL: https://codereview.chromium.org/363523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283968 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Taking the address of a temporary
* Octal escape sequence terminated by decimal number
* Signedness mismatch
* Possibly-uninitialized local variable

This also contains a small number of cleanups to nearby code (e.g. no else after return).

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/382673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390755

Review URL: https://codereview.chromium.org/394903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283966 0039d316-1c4b-4281-b951-d872f2087c98

- Add accessors: web_frame(), routing_id(), render_view().
- Remove accessor: render_frame(). Where we do need to touch the
  RenderFrame, we'll look it up by its routing ID.
- Small change to the CompositingHelper to use the new getters.
- Add a map to allow finding a RenderFrameProxy by its associated
  blink::WebFrame.
- Introduce a second factory function and differentiate the two
  factory functions according to the two ways RenderFrameProxies will
  be created. The first is for when an extant local RenderFrame is
  being swapped out and replaced with a new RenderFrameProxy. The
  second is for when a RenderFrameProxy needs to be created without
  displacing an existing RenderFrame, as shall occur once we mirror
  the frame tree.
- This second factory function, which is uncalled at the moment, will
  create WebRemoteFrames. Also there is stubbed out code in the first
  factory function to create WebRemoteFrames. This code is in
  preparation for eliminating the RenderFrame (and its attendant
  WebLocalFrame) and having instead just a RenderFrameProxy.
- Add some defensive checks to prepare for when the render frame may
  not exist, as will happen once the second factory function
  enters use.
- Add an Init function so that code can be shared between the two
  factory functions.

As an adminstrative note, this patch is a chunk of nasko's 
larger "use RenderFrameProxyHost" effor (issue 241223002)

BUG=357747
TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283572

Review URL: https://codereview.chromium.org/357043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394866

Review URL: https://codereview.chromium.org/400003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283964 0039d316-1c4b-4281-b951-d872f2087c98

ChromeExtensionWebContentsObserver to ChromeExtensionMessageFilter.

BUG=394383
R=jamescook@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/402673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47554

Review URL: https://codereview.chromium.org/394373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393019

Review URL: https://codereview.chromium.org/404573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283961 0039d316-1c4b-4281-b951-d872f2087c98

No intended behavior change.

BUG=none

Review URL: https://codereview.chromium.org/402773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393677
TEST=Ran without the pci id on daisy which bypassed the tests.

Review URL: https://codereview.chromium.org/393223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283958 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Change some !OS_ANDROID #ifdefs to ENABLE_EXTENSIONS in ChromeResourceDispatcherHostDelegate.

Review URL: https://codereview.chromium.org/405493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283954 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/403623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283953 0039d316-1c4b-4281-b951-d872f2087c98

Demonstrate in the NaCl SDK API demo for pp::Graphics3D how to
use full device resolution on HiDPI displays. For Graphics3D it
is simply a matter of sizing the texture in device pixels, by
multiplying the width/height by view.GetDeviceScale().

BUG=196253
TEST=Build NaCl SDK, run with --force-device-scale-factor=2

Review URL: https://codereview.chromium.org/398943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283952 0039d316-1c4b-4281-b951-d872f2087c98

This patch is the first part of ensuring that recycle tree does not
contain any unshared tiles.

This is done by ensuring that we invalidate the soon to become recycled
tiling while activating.

BUG=393802
R=danakj

Review URL: https://codereview.chromium.org/397303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283951 0039d316-1c4b-4281-b951-d872f2087c98

There was still a bug on the hotword extension side, and the
recent version 5023 doesn't contain the fix, which means 5023
is still 'old' in this sense :-(

BUG=393321
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/405483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394474
R=tfarina@chromium.org,gunsch@chromium.org

Review URL: https://codereview.chromium.org/399833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283949 0039d316-1c4b-4281-b951-d872f2087c98

Compilation error visible in try jobs of original review.

> GN fixes for the Windows build.
> 
> R=scottmg@chromium.org
> TBR=scottmg
> 
> Review URL: https://codereview.chromium.org/404603002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/400493006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283948 0039d316-1c4b-4281-b951-d872f2087c98

The trace comes handy when unexpected resize message triggers a main
frame.

BUG=392652
TEST=do a trace for scrolling a page on clank during which the top control
     becomes hidden, and found that at the end of scroll there is a
     RenderViewImpl::OnResize trace event.

Review URL: https://codereview.chromium.org/403593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283947 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/404603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283946 0039d316-1c4b-4281-b951-d872f2087c98

The panel's minimum size depends on whether the panel is minimized. This CL
ensures that when a panel is minimized, the X window's minimum size is first
updated, then the X window's bounds are updated (to be smaller than the
non-minimized panel minimum size allows)

BUG=382301
TEST=PanelViewTest.*
R=erg
TBR=dimich (For reenabling tests in panel_view_browsertest.cc)

Review URL: https://codereview.chromium.org/363483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283945 0039d316-1c4b-4281-b951-d872f2087c98

All SourceBufferStream string based unit tests assume that decode and
presentation timestamps are the same. This change extends the string
syntax so that buffers can be created where the presentation and
decode timestamps are different. This will make it easier to write
tests that verify proper behavior when B-frames are used.

Review URL: https://codereview.chromium.org/395303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394957
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/397373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283943 0039d316-1c4b-4281-b951-d872f2087c98

This change replaces the IdentityAccountTracker with
gaia::AccountTracker, which mostly does the same thing. The one
functional consequence of this change is that the Identity API no
longer keeps track of login token errors on its own. Instead it
relies on the underlying token services to report errors to the
user.

BUG=364203

Review URL: https://codereview.chromium.org/398573007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283942 0039d316-1c4b-4281-b951-d872f2087c98

Now that the QUnit-based unit tests are running on the bots, we can retire gtestjs unit tests.

This CL
1. Modifies remoting_webapp_unittest to include all files that are formerly covered by all_js_load.gtestjs.
2. Removes all the gtestjs files under remoting.
3. Moves run_all_remoting_unittests.cc back into the remoting directory as we no longer depends on chrome_paths.h.

Review URL: https://codereview.chromium.org/394023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283941 0039d316-1c4b-4281-b951-d872f2087c98

On ash, toplevel window (which is a widget) is already aligned so the RWHV should be aligned to the toplevel window intead of RootWindow.

This depends on the following CL:
https://codereview.chromium.org/375693006/
https://codereview.chromium.org/357063002/
BUG=391822

Review URL: https://codereview.chromium.org/379483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283940 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/398163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283935 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/390393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283933 0039d316-1c4b-4281-b951-d872f2087c98

The bounds of the ExtensionToolbarMenuView were different than that of the
contained BrowserActionsContainer, so part of the BrowserActionsContainer was
cut off. Fix this by setting the bounds of the MenuView to match those of the
Container.

Before: http://imgur.com/15oiD3G,04VAifx#0
After: http://imgur.com/15oiD3G,04VAifx#1

Blue is the ExtensionToolbarMenuView, Red is the BrowserActionsContainer.
In the before, note that Browser Action VIII is missing (cut off).

BUG=391280

Review URL: https://codereview.chromium.org/400693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283932 0039d316-1c4b-4281-b951-d872f2087c98

R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/397803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283931 0039d316-1c4b-4281-b951-d872f2087c98

error: narrowing conversion of ‘(keysym & 65535ul)’ from ‘KeySym {aka long unsigned int}’ to
‘uint16 {aka short unsigned int}’ inside { } is ill-formed in C++11

error: narrowing conversion of ‘xkey.XKeyEvent::keycode’ from ‘unsigned int’ to ‘uint8 {aka
unsigned char}’

Fixed by using the underlaying type instead, KeySym and unsigned.

BUG=394636
TEST=Passed try bots.

Review URL: https://codereview.chromium.org/398203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283930 0039d316-1c4b-4281-b951-d872f2087c98

The 'audio/mpeg; codecs="mp3"' mimetype is not RFC 3003 compliant, but a
bunch of sites apparently use it. This change restores the behavior that
was in M35 and earlier and returns "probably" for this mimetype.

The changes are intentionally kept small so they can be easily be merged
to the M36 & M37 branches.

BUG=393720,386073
TEST=MediaCanPlayTypeTest.CodecSupportTest_mp3

Review URL: https://codereview.chromium.org/400023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283929 0039d316-1c4b-4281-b951-d872f2087c98

We're going to remove WebNode::getElementsByTagName.

BUG=394234

Review URL: https://codereview.chromium.org/393873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283928 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283927 0039d316-1c4b-4281-b951-d872f2087c98

This roll updates the arm64 and x86_64 ABIS to include changes in NDK r10b-rc1.
This also removes android_tools/ndk_experimental and moves all 64 bit targets
over to using android_tools/ndk instead.

BUG=393903

Review URL: https://codereview.chromium.org/404553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283926 0039d316-1c4b-4281-b951-d872f2087c98

Normally fake interface implementations use Fake prefix, but there
were some with Fake suffix, namely SignalStrategyFake and
HostStatusMonitorFake. Renamed them to use Fake prefix.

R=rmsousa@chromium.org

Review URL: https://codereview.chromium.org/393703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283925 0039d316-1c4b-4281-b951-d872f2087c98

Messages which track the progress of discovery are VLOG(2) and unusual events are VLOG(1).

We can use this to diagnose failures in test automation with release builds.

BUG=394082

Review URL: https://codereview.chromium.org/394383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394836
NOTRY=true

Review URL: https://codereview.chromium.org/400803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283912 0039d316-1c4b-4281-b951-d872f2087c98