- 05 Mar, 2019 40 commits
-
-
Miyoung Shin authored
- short -> int16_t - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I6b22716e77ad858152a3255eb52204bb35a985ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501237Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637575}
-
Nektarios Paisios authored
Line break elements are not defined as text nodes in Blink. However, traditionally we have been able to set a selection before or after a line break and our accessibility code on the browser side treats objects with the line break role as text objects. These tests ensure that line break elements are not treated as text objects for selection purposes. Also, adds more selection tests for text fields. R=dmazzoni@chromium.org, dtseng@chromium.org, aleventhal@chromium.org Change-Id: I4cf968225322a9bbc4eb2ace4b80c07dffc5a801 Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498611Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#637574}
-
Hector Carmona authored
Bug: 936624 Change-Id: Ifa7b57212f6de0346b5523ed6795f65d21b6e12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493374 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#637573}
-
Malay Keshav authored
This patch adds an API to ui::Layers that lets clients set a rounded corner radius on the layer. The change is propagated to the cc layer and its effect node as well. Adds unit test for the change. Bug: 903486 Change-Id: Ib0d36af9e76b9f6701e0cb674e855e29f5844c7f Component: ui layer, cc layer, effect node Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497851 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637572}
-
Michael Moss authored
This reverts commit ad0f43e7. Reason for revert: breaking youtube, crbug/937702 Original change's description: > Remove Shadow DOM V0, Custom Element V0 and HTML Imports > > This patch removes Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports. > Intent to Deprecate and Remove: http://bit.ly/2RGHe3x > > Bug: 911943 > Change-Id: I1baa906e019e0f59331c1fb590eccbc38a482fec > Reviewed-on: https://chromium-review.googlesource.com/c/1481130 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636728} TBR=kinuko@chromium.org,hayato@chromium.org,tkent@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911943, 937702 Change-Id: I4aa4e34f3846ee8b5c2e19b29905243e0db5319a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501935 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#637571}
-
Dan Beam authored
R=aee@chromium.org BUG=833049 Change-Id: I51412d06bf6ed61ba6afc35d6166d15754cb603d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501575 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637570}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf661acb705f..adbf3bef6872 git log cf661acb705f..adbf3bef6872 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@adbf3bef6872 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2a228a26f05b2078e1c4e5df9026457016527255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637569}
-
chrome-search://ntpiconKristi Park authored
Limit max icon size to 192dp and scale factor to the maximum device scale factor. Bug: 932774 Change-Id: Ia03d50a8530fa32292e6591ab75b6131ba2ed986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497655 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#637568}
-
Alexey Baskakov authored
Create SetCrxInstallerFactory test-only method which enables tests to inject a CrxInstaller mock. This change will allow us to support parallel installs (see next CLs). Bug: 915043 Change-Id: I2872a815e1d6255488e4c0af182f26f776b042aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498259Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#637567}
-
Ashitha Santhosh authored
Added ProduceRGBEmulationGLTexture function that creates a new texture and binds the existing GL image with this texture as per the specified internal format. This will be used for RGB emulation on Mac for WebGL blitFramebuffer. Bug: 924198 Change-Id: I5c3267015c411803dbacc828d3536448f6bba1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484859 Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637566}
-
Shu Chen authored
Bug: 937001 Change-Id: If0026c566270327f5b7d90ffa311d90a6e0bfa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498252Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637565}
-
Pavel Feldman authored
The only reason it was there was for the trace, where it was misinterpreted. Change-Id: If1fe338516ecc1a72984ab7ec16cd3fb58cd779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495870 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#637564}
-
Jamie Walch authored
Currently these messages are suppressed for @google.com addresses, but we'll want to start showing them soon. This CL lets us control that via gstatic, rather than requiring a webapp update. Change-Id: Ifca5fa9058510f54eacb80ca74c461a79192822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501533Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637563}
-
Yoshisato Yanagisawa authored
We seem not add iOS and ChromeOS builders to cr-buildbucket.cfg. I suppose that might be the reason why we did not see any updates for the builders in milo. Let me try to add them. Bug: 874754 Change-Id: I72969147d3199cffad4c543cd88f7693bacd26c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501632 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637562}
-
Yi Gu authored
Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=UserActivityManagerTest.MultiBrowsersAndTabs TBR=pdyson@chromium.org Bug: 938141 Change-Id: Ib127d62d026ce05d7528921f2d4f574cdd571f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502073Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637561}
-
Johannes Henkel authored
In Values_cpp.template, always check for the empty string first. This covers WTF::String::IsNull, for which the other routines may not work so well. Change-Id: I44ede6ca51970fca3f1d1320fb427a64fbd47b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501536 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#637560}
-
kyle Ju authored
Currently all Webdriver test failures are expected failures until the two-way sync with upstream github is created. The bug is caused by the fact that expected != actual in the output Json output while the is_unexpected (by default when this field is not set) field is false. Comparing patch 9 where two fields are equal and the webdrvier test suit didn't retry when green, to patch 10 where two fields are not equal and webdriver test suits retried, I conclude that this is the cause of the bug for 929689 and 936557 Bug: 929689, 936557 Change-Id: Iee0da2344ef1a6feff3ccde4746810f3c5ec8b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490897Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#637559}
-
Aran Gilman authored
Bug: 925949 Change-Id: I82760c97fd583bc509058fec4cd8540e4fe0e19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474514 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637558}
-
Saman Sami authored
This CL introduces SurfaceAllocationGroup, a class that keeps track of LocalSurfaceIds generated from the same ParentLocalSurfaceIdAllocator. In future CLs, more code will move into this class from SurfaceDependencyTracker & SurfaceManager, but for now its sole purpose is to make sure different FrameSinks don't use the same embed token. Bug: 931801 Change-Id: Id9cfb0c77b917d15da4c9663fe752c8a7bc293e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490506Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#637557}
-
Pavel Feldman authored
Only highlight on hover, clear the highlight once editing starts. Bug: 935687 Change-Id: I25fe10be549a5c0c37d08aba62688c3472c66354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501212Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637556}
-
Becky Zhou authored
+ Split toolbar background from native page background + Fix tint and text color on LocationBar, UrlBar, ToolbarPhone, ToolbarTablet, CustomTabToolbar, tab switcher toolbar + Don't restore default toolbar color for tabs + Fix find toolbar for night mode + Rename colors and drawables that don't make sense on night mode Bug: 934525, 934505 Change-Id: I4998303d6356e47d56305f510cb12cbb3ec45e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489416 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#637555}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb305299f4de..232c456db8e9 git log bb305299f4de..232c456db8e9 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 chrisforbes@google.com Fix setup code to deal with inverted area sign 2019-03-04 hliatis@google.com Implement vkGetSwapchainImagesKHR 2019-03-04 chiur@google.com Create CI for gcp_windows 2019-03-04 chrisforbes@google.com Remove some GL/D3D legacy format quirks from vulkan vertex buffers 2019-03-04 hliatis@google.com VkCreateSwapchainKHR and VkDestroySwapchainKHR 2019-03-04 chrisforbes@google.com Add support for conversion instructions 2019-03-04 chrisforbes@google.com Add support for OpDot 2019-03-04 chrisforbes@google.com Add support for OpUMulExtended, OpSMulExtended 2019-03-04 bclayton@google.com SpirvShader: Add debug checks on Intermediate. 2019-03-04 chrisforbes@google.com regres: fix wsi test list Created with: gclient setdep -r src/third_party/swiftshader@232c456db8e9 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/127343247,chromium:b/124265819,chromium:b/124265819,chromium:b/126952020,chromium:b/126873455,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id0233ed66f3c5b119c8c343c7da75926b9c21b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637554}
-
Joel Hockey authored
Rename CrostiniSharedPathsChangedEvent to CrostiniEvent and add 'enable' and 'disable' types for FilesApp to show and hide the 'Linux files' volume item when crostini is installed or uninstalled. Removed fileManagerPrivate.isCrostiniEnabled which is no longer required. Bug: 920024 Change-Id: Ic2b2733880e4f1ac927b7c6f7c709350ea6be678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498791 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#637553}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b736d0c00cd..5610d5a7e96a Created with: gclient setdep -r src-internal@5610d5a7e96a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: Ic937ee496d99b4d3c47ec74c14bbd1db37f32de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501592Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637552}
-
Maggie Chen authored
We still saw flakinees in VideoPathTraceTest_DirectComposition_ComplexOverlays. Increase the wait time to 60 swapped frames before checking the result. We have to make sure the video frame is ready. Bug: 937545 Change-Id: I1a4d2b84a90a359c93b7f4695a4c3610f6528c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500787Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637551}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/5ec7f0c4a113..efecb0bfa687 $ git log 5ec7f0c4a..efecb0bfa --date=short --no-merges --format='%ad %ae %s' 2019-02-25 absl-team Googletest export 2019-02-25 rsinnet Fix grammatical error in primer.md 2019-02-21 yaneurabeya Don't hardcode the filename in `CxxExceptionDeathTest.PrintsMessageForStdException` 2019-02-20 misterg Googletest export 2019-02-19 absl-team Googletest export 2019-02-20 dds Avoid array index out of range 2019-02-18 yaneurabeya Ignore `-Wsign-conversion` issues 2019-02-13 yaneurabeya Fix clang `-Wunused-parameter` warnings 2019-02-13 yaneurabeya Fix clang `-Winconsistent-missing-override` warnings 2019-02-13 yaneurabeya Fix clang `-Winconsistent-missing-override` warnings 2019-02-13 yaneurabeya Add `cxx_strict_flags` for clang to match FreeBSD's WARNS flags 2019-02-12 yaneurabeya Import `patch-bsd-defines` from FreeBSD ports [1] 2019-02-12 yaneurabeya Compile clang with `-Wall -Wshadow -Werror` 2019-02-12 yaneurabeya Fix -Wunused-private-field issues with clang 2019-02-12 misterg Googletest export 2019-02-07 absl-team Googletest export 2019-02-05 absl-team Googletest export 2019-02-04 absl-team Googletest export 2018-02-10 knut.omang Set gtest version correctly for older cmake versions 2018-02-25 knut.omang Generate a libgtest.la to help libtool managing dependencies 2016-12-23 jwakely Stop TestInfo::Run() calling a function through null pointer 2019-02-05 chrisjohnsonmail fix: Correct *-all.cc file paths 2019-02-05 keiichiw Fix an invalid example of JSON report in advanced.md 2019-02-04 gennadiycivil Update .travis.yml 2019-02-04 gennadiycivil Update .travis.yml 2019-01-12 yaneurabeya Test out changes with clang/OSX each PR using Travis CI 2019-02-04 misterg Googletest export 2019-02-04 misterg Googletest export 2019-02-01 absl-team Googletest export 2019-02-04 maetugr cmake: detect Cygwin which needs extensions to build 2019-02-04 maetugr cmake: move global project definition to beginning 2019-01-31 absl-team Googletest export 2019-02-01 chrisjohnsonmail chore: Add PlatformIO supported platforms list 2019-01-31 chrisjohnsonmail fix: Add Arduino to embedded platform list 2019-01-31 chrisjohnsonmail fix: Add *_all.cc files to ignore list 2019-01-31 g4691821 Fix README.md broken link 2019-01-30 gennadiycivil Repeat #2090 2019-01-30 Kelly_G_Walker Update advanced.md casing in example 2019-01-29 gennadiycivil Added -Wgnu-zero-variadic-macro-arguments" clang 2019-01-28 hugo.lindstrom Avoid dynamic/static runtime linking (LNK4098) by properly replacing MD(d)->MT(d) in both C and CXX flags, resolves 2074 2019-01-22 samolisov Enable CI on Windows (appveyor) with Bazel 2019-01-18 mathbunnyru Fix INSTANTIATE_TEST_CASE_P with zero variadic arguments 2019-01-14 samolisov Enable building as a shared library (dll) on Windows with Bazel Created with: roll-dep src/third_party/googletest/src Also temporarily disable Googletest deprecation warnings in //third_party/boringssl and //third_party/libaddressinput until they migrate their usage of deprecated APIs. Also replace _TEST_CASE_ with _TEST_SUITE_. Bug: 925652, 936691 Change-Id: I50fb3811b067453d04dc2b2f739b27141c0951b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497355 Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#637550}
-
Avery Musbach authored
In overview, the split view drag indicator always has an opacity of 18%, whereas the specification calls for 30% when indicating where to drag a window, and 18% when serving as a preview of snapped window bounds: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#indicator-expand Test: manual Bug: 808283 Change-Id: I4cbf1230f34d3b90389c60d8fc909298b8b9d386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500912 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637549}
-
Jarryd authored
I am taking ownership of quota histograms that currently have an owner outside of our team. Change-Id: Idd205db3d8e46d9f9a27fdaf2116abc8842170ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497216Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637548}
-
Roberto Carrillo authored
R=bpastene,jbudorick,liaoyuke,stgao,sajjadm@google.com Change-Id: I3d5da142211c4d8ce33288b6bdaf202710952963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484731Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637547}
-
Xiaocheng Hu authored
This patch changes almost all VisibleSelectionInFlatTree-typed local variables into SelectionInFlatTree as a preparation to remove unnecessary canonicalizations from SelectionController. Bug: 657237 Change-Id: Id6234ddf3a920f31a02a7474975c6b029c49a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500699Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637546}
-
Ahmed Fakhry authored
This CL is a follow-up https://crrev.com/c/1475159 to add the animations for the desk mini views creation and removal. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c7 BUG=866622 Change-Id: If34cb407ac6617e71a66f11f914d94e91148f7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500253 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#637545}
-
Robbie McElrath authored
Bug: 937139 Change-Id: Icbf0141a8561179eb3a26e6112f66764f1db7af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496603 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#637544}
-
Jeffrey Cohen authored
This will avoid each client having to individually interact with a history service, and consolidate the code needed to link SendTabToSelf and the history services under//components/send_tab_to_self. Bug: 910390 Change-Id: I8c53e63d0a28a398385533446170408483db8b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500834 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637543}
-
dstockwell authored
Bug: 902646, 933205 Change-Id: I7ddb3da8ac6131532896f886a03451351b3780aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482356 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#637542}
-
Dan Beam authored
Screenshot: https://imgur.com/a/ieMzOhL R=aee@chromium.org BUG=883049 Change-Id: Ia993dc5c2661c1d033f0c0191b29a352e79b13c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501352 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637541}
-
Jacob DeWitt authored
According to WebXR spec https://immersive-web.github.io/webxr/#dom-xrframe-getpose Bug: 922202 Change-Id: Ia7af7156e4195cb01d1eebda2701520d2ab836b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480272Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#637540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8949933bd5aa..ccc29087522a git log 8949933bd5aa..ccc29087522a --date=short --no-merges --format='%ad %ae %s' 2019-03-04 mattm@chromium.org Fix areValidConstants checking timeTickOffset twice with different expectations. 2019-03-04 benjhayden@chromium.org Add alerts-section to chromeperf-app. Created with: gclient setdep -r src/third_party/catapult@ccc29087522a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917273,chromium:918193 TBR=sullivan@chromium.org Change-Id: Iea7ce1376b0639a993827a5bb9c146e754242f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637539}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I775d749c6fde7f7ebfcbbd5f9a6ef75bccce37b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501273Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#637538}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3be9a522b8a..cf661acb705f git log a3be9a522b8a..cf661acb705f --date=short --no-merges --format='%ad %ae %s' 2019-03-04 iannucci@chromium.org [bot_update] Downstream change for buildbucket proto update. Created with: gclient setdep -r src/third_party/depot_tools@cf661acb705f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:930761,chromium:927716 TBR=agable@chromium.org Change-Id: I7349eca1cd1a542b20469e1de3c736e4de769b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637537}
-
Maggie Cai authored
Currently the sort on All Sites page only sorts the etld+1, not the origins under the etld+1. This CL updates to sort the origins under each etld+1 as well. BUG=922847,835712 Change-Id: Ifcfdb71fa344839e9270d26bc182fa061e3fbca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491056Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637536}
-