- 11 Apr, 2019 40 commits
-
-
Joel Hockey authored
Modified export/import handling from CrostiniManager to take a CrostiniResultMessageCallback which receives both a CrostiniResult and a base::string16 error message which can be displayed in the notification. Strings from https://docs.google.com/spreadsheets/d/1paVaVV2azeuAHnxHT4jQ402VvaZ7Z8btZ5e_y7rPRnE/edit#gid=0 Bug: 933948 Change-Id: I2451492d85cd8263a8914a31b82162d4e93a77de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558559 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649780}
-
Yashar Dabiran authored
This CL is part of the efforts to add |RuntimeEnabled| IDL attribute support for origin trial features. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q This CL writes all runtime features (defined in runtime_enabled_features.json5) to a file to be able to access them during the bindings generation. Bug: 934451 Change-Id: I839d7893af89e0e687feaf5888e699c1efb15c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557868 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#649779}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/4ebef283ecc4..cbd8851734d8 $ git log 4ebef283e..cbd885173 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 luum system_api: Add DBus service constants for CupsProxyDaemon 2019-03-11 joelhockey system_api: validate container architecture when importing Created with: roll-dep src/third_party/cros_system_api Bug: 933948 Change-Id: Id2346c605f6e387cea1b13a977c152336a50c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563231 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL finishes annotating the rest of the classes of //third_party/blink/renderer/bindings with the macros of Allocator. After some analyzes, it was concluded that for the case of NodeBuilder, State, WorklistItemBase classes, they makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. Lastly, the rest of the classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I8590c31702d34ccdadf4d079c8123a192b36aeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#649777}
-
Nicolas Ouellet-payeur authored
linux64 Bug: 949382 Change-Id: Id6e865cc6ae2848a4cbe8d39c5e3020c94f74461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561965 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#649776}
-
David Black authored
This reverts commit 0ee09a04. Reason for revert: Regresses Assistant UI. Original change's description: > views: removal of dead code in NativeViewHost > > NativeViewHost has code to deal with being clipped by an ancestor. This logic > dates back to when we used NativeViewHost more often, and in particular when > NativeViewHost was contained in a ScrollView. AFAIK we no longer have this > scenario, so, this removes the unnecessary logic. > > BUG=none > TEST=covered by tests > > Change-Id: I7b1a9ba047bd7c4abab68f9fe49c651bf50209d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560130 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649355} TBR=sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:130305523 Change-Id: Ib0b5dba24bb4e376f3cdad11d19d59e318fd1b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563031Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#649775}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ec288d4..3304bd02 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c6764d5b222cbd7a2d1ef9e012a8636bfb81629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563150Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649774}
-
Xiaocheng Hu authored
This reverts commit 33b5c673. Reason for revert: Adding production CHECKs to collect LayoutNG failures for the 3rd time. Original change's description: > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"" > > This reverts commit 26ca019a. > > Reason for revert: Crash data already collected > > Original change's description: > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > This reverts commit ec11fe81. > > > > Reason for revert: Try to catch more crashes in the wild after > > a fix (crrev.com/c/1546713) has been landed. > > > > Original change's description: > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > This reverts commit bade42c5. > > > > > > Reason for revert: New crashes already caught. Reverting CHECKs > > > back into DCHECKs to reduce noises. > > > > > > Original change's description: > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG > > > > > > > > Bug: 946004 > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305 > > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#644907} > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 946004 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156 > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#645407} > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 946004 > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#646516} > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946004 > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647418} TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946004 Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649773}
-
Wei Lee authored
similar method This CL fixes the wrong buffer size that is used in CreateGpuMemoryBufferHandle(). And it also removes a similar method in VaapiPictureNativePixmap. Bug: None Test: None Change-Id: I870e540975e13a21a4262bdb7f54b7ee45808eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538268 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649772}
-
Christopher Lam authored
This CL removes the 'Open as tab/window' and 'App Info' options for System PWAs in the App Launcher and Shelf. Bug: 836128 Change-Id: I80dd5046d49e709c766a893d581298eb176e4bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557478Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#649771}
-
Pavel Feldman authored
All these rule definitions operate CSS variables now. Bug: 935286 Change-Id: I9cdd4883e0c07e1040da06af8db3ef36f64ebc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562893Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649770}
-
Pavel Feldman authored
Bug: 947458 Change-Id: I117238860ade9c6fb86c4310c07c501306201196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562575 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Reland "Ensure header modification for a redirect's onBeforeSendHeaders is applied with network service." This is a reland of b5e1969b Original change's description: > Ensure header modification for a redirect's onBeforeSendHeaders is applied with network service. > > This currently worked if 'extraHeaders' was specified, but not without it. > > Bug: 942062 > Change-Id: Ic962ad256d89384082e25a5983181bf563021ffb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548673 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647160} TBR=rockot@chromium.org Bug: 942062, 949478 Change-Id: I11889f6c2973548b28e3ea8029f1516626c950f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559013Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649768}
-
James Darpinian authored
conformance/textures/misc/texture-active-bind.html was fixed on Windows in https://github.com/KhronosGroup/WebGL/pull/2819 LUMINANCE/ALPHA emulation fixes in http://crrev.com/c/1545512 fixed these tests on Android Qualcomm: conformance2/textures/misc/tex-new-formats.html conformance2/textures/misc/copy-texture-image-luma-format.html deqp/functional/gles3/textureformat/unsized_2d_array.html deqp/functional/gles3/textureformat/unsized_3d.html TBR: kbr@chromium.org Bug: 931006, 906740, 947236 Change-Id: I5c3a79c17b6a263b1a52f0a9fa646de591e370b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559756Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#649767}
-
Alex Kalugin authored
Fix possible calls on null pointer. Change-Id: I5899e0debfba13afc330a88d6d2eaec29275fa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533907 Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649766}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie1ab823189bac7a60148e918e4f65a8aa4c57a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649765}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3e80ed4d. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I177bba2baaf566cfa17eae5de9dfaa40dc09e174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562925Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649764}
-
Charles Zhao authored
High discard count also means high reload count, which indicates the user is more likely to come back to this tab. Therefore it should have higher scorer. Changed how discard count is scored. Bug: 948915 Change-Id: Ifea930bfb3aab6bb4eb86a05e4ae949631d55e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560931Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649763}
-
Pavel Feldman authored
When using Target.exposeDevToolsProtocol to grant debugging priviledges to a page, make sure that all the unhandled JS errors are surfaced in that page. Currently, we use Runtime.evaluate which silently drops those errors on the floor. Change-Id: I9ba08ef0d56a11d4c7325cc29deeaf57672cf8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562087Reviewed-by:
-
Pavel Feldman authored
... and migrate front-end to it. Bug: 915945 Change-Id: I91220f7d7681fef3faa4c543b729d3475df5b8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560533 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1701094c07ba..6379cd39a333 git log 1701094c07ba..6379cd39a333 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 nodir@google.com Roll bb Created with: gclient setdep -r src/third_party/depot_tools@6379cd39a333 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I02a3463c3250375026d5746fe10783ca76225eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562994Reviewed-by:
-
John Budorick authored
Follow-up to comments on crrev.com/i/1164251 Bug: 947555 Change-Id: I83417737552c38d47e5ec6a3268179fb1ac07973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562766 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#649759}
-
Timothy Loh authored
ARC windows get an application id of the form org.chromium.arc.%d set on the exo surface. This logic is repeated in a few places so this CL moves it to a single helper function. Bug: 943447 Change-Id: I7381c5b43deb64137ef6b565b26d849caaab489e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532136 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649758}
-
Kenneth Russell authored
Forgotten in the most recent CL. Bug: 948902 Change-Id: Ic72688b98721fe6081c6902849ae2852c2b7fdc1 Tbr: martiniss@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562795Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649757}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/950150cb..0ec288d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47a30767d00253a112d191c4d25957c1f6eca2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562127Reviewed-by:
-
Ahmed Fakhry authored
For virtual desks, and for tracking the windows in each desk in a separate container, the default container should no longer be used directly. Users should instead query the currently active desk container. BUG=866622 Change-Id: Ie121b5e488a629307511c1b79eb0ee5e9d66f422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559348Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#649755}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8ca352dcc024..f21ce663029c git log 8ca352dcc024..f21ce663029c --date=short --no-merges --format='%ad %ae %s' 2019-04-11 dhanyaganesh@chromium.org buildbucket_v2: GetBuildFailures equivalent 2019-04-11 dhanyaganesh@chromium.org net.py: Write to logs only on retries 2019-04-11 jflat@chromium.org commands: Strip -kernelnext label from board names 2019-04-11 dburger@chromium.org Add more artifacts logging for gaining config insight. Created with: gclient setdep -r src/third_party/chromite@f21ce663029c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I4a72eccb687669e43e8dcdec536e1873803c7536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562953Reviewed-by:
-
btolsch authored
TBR=eirage@chromium.org Bug: 951638 Change-Id: Id3503ab83b6ed002bd4037cd1de2e75d9f305325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562767Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#649753}
-
Ahmed Mehfooz authored
Add Empty Border around UserAvatarButton to create space for focus ring Change focus ring shape to same shape as Button Compensate for extra space needed in TopShortcutsView and FeaturePodsContainer Bug: 922423 Test: Manual Test on PixelBook Change-Id: Ib5c069e9cfb4619faaa34f474e1a83ef5b765417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542498 Auto-Submit: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649752}
-
David Staessens authored
This CL adds a parameter to the video_decode_accelerator_tests and the video_decode_accelerator_perf_tests to switch between the current VDA-based video decoders and the new VD-based video decoder implementations. Currently as no VD-based video decoders are present yet, using this parameter will always cause the tests to fail. TEST=ran new VDA tests on nocturne BUG=925712 Change-Id: I0f5e7df0507b6d7c6d6d75aed54a982cec7b4004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559091 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649751}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aa5c0d19ac94..9cf260b9d7f4 git log aa5c0d19ac94..9cf260b9d7f4 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 thestig@chromium.org Clean up CJS_Document::removeField(). Created with: gclient setdep -r src/third_party/pdfium@9cf260b9d7f4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If0e0408e1d403a0e4e724cf48e314ac1aef7d905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562952Reviewed-by:
-
David Bienvenu authored
Bug: 813093 Change-Id: Ia026e01a5699658e681316fc5b464b7c2cfe9880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562895Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649749}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be94a4842692..99d792276740 git log be94a4842692..99d792276740 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@99d792276740 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I38ae23e7e69bd04ab74cd355ef3d19a16b5e12b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562951Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f74c21e2e9f..1701094c07ba git log 4f74c21e2e9f..1701094c07ba --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1701094c07ba The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If2268d269369b4f0c33d5707d92c9e035896d0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561874Reviewed-by:
-
Austin Eng authored
Bug: 877147 Change-Id: I7e6575b419bb1487bbcb5154a2a4ad4a45d199d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554122Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#649746}
-
Aleks Totic authored
I am trying to figure out why laying out a large table takes up twice as much memory in NG. My test case is a 100K cells table (attached to bug). When profiling, I've noticed that NGPhysicalTextFragment had rare data 96340 times. NGPaintFragment NGInkOverflowModel was being created 88360 times This patch is my attempt to improve this. With the patch: NGPhysicalTextFragment rare data is down to 82084 NGInkOverflowModel is down to 74080 The reason RareData was being created was that ink_overflow.ExpandEdgesToPixelBoundaries() local_ink_overflow = ConvertToLocal(ink_overflow) local_rect.Contains(local_ink_overflow) was false whenever ink_overflow was fractional (because it expanded). Expanding edges only if local_rect does not contain local_ink_overflow without expansion reduced the number of RareData created > 15%. There is another problem with ascents/location that causes more cache misses. I'll need @kojii's help with it. Bug: 931663 Change-Id: I586ca26024338a97263f9d324d62a4a50d53895a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535294 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649745}
-
Austin Eng authored
This patch allows WebGPU to allocate command space up to the transfer buffer size instead of being limited to the initial starting transfer buffer size. This patch also creates SharedMemoryLimits::ForWebGPUContext(). Because WebGPU sends the majority of its commands via the transfer buffer, it is preferrable to have a larger minimum transfer buffer size and smaller command buffer. Change-Id: I31bb74dfb1075a2b6f159985b297695d57e71ed3 Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559455 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649744}
-
Nigel Tao authored
One part (in chrome/services/app_service) is the interface. The other part (in chrome/browser/apps/app_service) is the implementation, including profile-specific implementation. For example, App Publisher implementations depend on the profile, and the App Service Proxy is a convenient place to initialize those App Publishers. The latter subclasses (implements) the former. Future commits may add further subclasses of the former, especially fakes or mocks to use within tests. BUG=826982 Change-Id: Ia23c3e2a3836e56749673f2f6792e5ef160da87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552211Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649743}
-
David Staessens authored
This CL adds additional documentation to the video_decode_accelerator_tests command, describing supported parameters such as --vmodule and --metadata. TEST=ran new VDA tests on nocturne BUG=None Change-Id: Ic5a54ca404a41a6f31a47d29640a4683f83ffa8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558735 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
exo::Surface might be unavailable when: - Just after the Activity starts - It's getting recreated when resizing the window. BUG=925769 TEST=manually Change-Id: Ie6dbf9349aeec6f65366fb3d1f077135c0439dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493689Reviewed-by:
-
