- 06 Dec, 2017 40 commits
-
-
Gregory Chatzinoff authored
Reenable the FeatureEngagement testBadgedREadingListFeatureShouldShow test by increasing the timeout. Bug: 789943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iace3e1e7c3beb1930ef7c85cc1184ac27665fcff Reviewed-on: https://chromium-review.googlesource.com/812218Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522222}
-
Matt Reynolds authored
AbstractHapticGamepad encapsulates the logic for translating haptic effect descriptions into a sequence of vibration actuator commands. Users of AbstractHapticGamepad should override SetVibration so that it updates the vibration actuators on the device with the specified intensities. BUG=749295 Change-Id: I3744cd3b06efb7970bd87048996250e52c472919 Reviewed-on: https://chromium-review.googlesource.com/810006Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#522221}
-
Andrew Grieve authored
Makes it easier to add a java_annotation_processor() template This removes main_class from java_prebuilt() in favor of using java_binary() with a jar_path. Bug: 792170 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8b92addae2228398f911d9456b9c55d5ebf48529 Reviewed-on: https://chromium-review.googlesource.com/810032Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#522220}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/307c9f954dc5..a2299532b526 $ git log 307c9f954..a2299532b --date=short --no-merges --format='%ad %ae %s' 2017-12-06 simonhatch Dashboard - Fix /add_histograms from re-adding same diagnostic. 2017-12-06 rnephew [Telemetry/TADA] Make expectation parser only support raw data and not file path. 2017-12-06 perezju [Telemetry] Dump output of "ps" when failing to find PID Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ee30516264ef4ee24e5f45f6f2c5a9e03a7c31f Reviewed-on: https://chromium-review.googlesource.com/812004 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522219}
-
Jared Saul authored
Bug: 778436 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ba2a695880a8594a145ecfa9724907253f5ad7f Reviewed-on: https://chromium-review.googlesource.com/752074 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#522218}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4bd2ad8cf901..fd9e0b8f5f92 $ git log 4bd2ad8cf..fd9e0b8f5 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 thestig Fix nits on some font code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4798f7891d9e82e538880fe193973022703f59cc Reviewed-on: https://chromium-review.googlesource.com/811893 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522217}
-
Yuwei Huang authored
This CL fixes a few warnings reported by the clang static analyzer: * Remove the unnecessary `next_frame += bytes_to_copy` line from AudioPlayerBuffer. * Call dictionaryWithDictionary with empty dictionary if data is nil. * Add [super viewDidLoad] calls to view controllers. Note that none of them causes actual problem in the official app. Bug: 791222 Change-Id: Icaaf8a43481eb68950dbf6c25c9d7789237aed5e Reviewed-on: https://chromium-review.googlesource.com/809928 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#522216}
-
Ted Choc authored
warning: [ImmutableEnumChecker] enums should be immutable, and cannot have non-final fields private int mValue; BUG= Change-Id: Ib5753459af5ea967d052251f306612e747ade786 Reviewed-on: https://chromium-review.googlesource.com/811453Reviewed-by:Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522215}
-
Evan Stade authored
NotificationDisplayService. Test by commenting out most of OnPortalDetectionCompleted() (in addition to unit tests). Bug: 783018 Change-Id: I403967f28883c588d9c2e5fd43effe05e41f7eda Reviewed-on: https://chromium-review.googlesource.com/807445Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522214}
-
Zhenyao Mo authored
BUG=784183 TEST=test case in the bug in ASAN build R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie25ca328af99de7828e28e6a6e3d775f1bebc43f Reviewed-on: https://chromium-review.googlesource.com/811826Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#522213}
-
Peter Collingbourne authored
Previously these tests did not use the conventional TestRenderFrameHost and TestRenderViewHost objects, but instead used RenderFrameHostImpl and RenderViewHostImpl. This caused them to fail with CFI bad cast errors when code in TestWebContents attempted to cast these objects to the test classes. This change eliminates the bad casts by creating a RenderViewHostTestEnabler object in the scope of the test fixture. This ensures that any Render*Host objects created for the duration of the test are in fact of type TestRender*Host. Bug: 469376 Change-Id: I9d4d048e7c8f1162fd4c8bc8e67ffc0932b6d220 Reviewed-on: https://chromium-review.googlesource.com/792450Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522212}
-
Philippe Hamel authored
Bug: 759161 Change-Id: I81acfa8caf45d460ebfc940f8d182300623769e1 Reviewed-on: https://chromium-review.googlesource.com/811751Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522211}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4bd2ad8cf901..fd9e0b8f5f92 $ git log 4bd2ad8cf..fd9e0b8f5 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 thestig Fix nits on some font code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I601a2c853d26536771a922d69c4a3a2ee45475ee Reviewed-on: https://chromium-review.googlesource.com/811965 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522210}
-
Filip Gorski authored
This deals with the case where multiple calls are made to Execute, before the store manages to initialize. This patch adds a test for such case. Bug: 792530 Change-Id: I270b0a035e55b6a66e8ada3b93d70ac0a1f207db Reviewed-on: https://chromium-review.googlesource.com/811746 Commit-Queue: Filip Gorski <fgorski@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#522209}
-
Wez authored
Bug: 775122 Change-Id: I3effce43273adbad46c0e085a01790c75427b489 Reviewed-on: https://chromium-review.googlesource.com/810057Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#522208}
-
Min Qin authored
This blocks the history service shutdown. The issue was originally introduced in https://codereview.chromium.org/1960223002 However, when render process is gone, there is no need to check removed files. We can do that next time when downloads page is loaded BUG=477975 Change-Id: I468cabc7d4c564591dfeaf4b0af66290e1ac8f53 Reviewed-on: https://chromium-review.googlesource.com/810107 Commit-Queue: Min Qin(OOO 12/7-1/10) <qinmin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#522207}
-
Christian Fremerey authored
This is a second instance of the same issue and fix as reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/806442. TBR=emircan@chromium.org,hajimehoshi@chromium.org Bug: 789669 Test: third_party/WebKit/Tools/Scripts/run-webkit-tests --target gn_release --enable-leak-detection fast/mediastream/argument-types.html Change-Id: If16c19395209a19a4548491f8b3e04893915adc2 Reviewed-on: https://chromium-review.googlesource.com/811865Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#522206}
-
Devlin Cronin authored
If a user hits "reload" on an unpacked extension, there's a chance that reload will fail (if the local files were modified in a way that causes a load error). Once this happens, successive calls to reload() will fail, because ExtensionService::ReloadExtension() doesn't play nicely with extensions that failed to reload. Adjust devleoperPrivate.reload() to return a LoadError (similar to loadUnpacked()) if the reload fails. The extensions page now checks for this result, and shows the load error dialog if the reload fails. The load error dialog can then trigger a retry of this load, which goes through loadUnpacked() rather than reload() (thus circumventing weirdness with ExtensionService::ReloadExtension()). This is comparable to how the current extensions page handles this scenario. This is *not* the ideal solution, as a) we shouldn't be going through loadUnpacked() for a loaded extension and b) the user can still get into a broken state (where the extension cannot be enabled, nor can it be reloaded) by dismissing the load error without fixing the error, but it brings us at least to parity with the old page. Bug: 789659 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib0bd6eb4bfe74b1da588a9ea78e3396703fee973 Reviewed-on: https://chromium-review.googlesource.com/798599 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#522205}
-
Reza.Zakerinasab authored
This change reduces createImageBitmap resize test tolerance from 10 to 0 for all image sources except for blob (which is set to 5). It also refactors the tests to include pixelated, low and medium filter qualities. Furthermore, it separates the test path for premul and unpremul image bitmap sources when the filter quality is high, to match the way this is implemented in chromium. Bug: 744647, 792607 Change-Id: I4e0b8af71d88f5885ff56540a17ec8b716cd58d7 Reviewed-on: https://chromium-review.googlesource.com/809808 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522204}
-
Eric Willigers authored
We check that the input has at least 5 characters before reading characters[4]. An rgb(a) color contains at least 3 numbers or percentages, plus separator characters, so the length of a valid rgb(a) color will be well over 5. TBR=nainar@chromium.org BUG=792306 Change-Id: Iceb49992ee7c5da346e2f64cbc7ccb82ad619f81 Reviewed-on: https://chromium-review.googlesource.com/811784Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#522203}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/10a4d43462fa..378c3a51d5f0 $ git log 10a4d4346..378c3a51d --date=short --no-merges --format='%ad %ae %s' 2017-12-04 oetuaho Clean up storing interface blocks in the symbol table Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ief1e722e35262c8e857382e9d1c4f57af919fcd3 Reviewed-on: https://chromium-review.googlesource.com/811894Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522202}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4bd2ad8cf901..fd9e0b8f5f92 $ git log 4bd2ad8cf..fd9e0b8f5 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 thestig Fix nits on some font code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie542801610893c18ffcf81d0df84f40238099403 Reviewed-on: https://chromium-review.googlesource.com/811888 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522201}
-
Elliot Glaysher authored
Add a reference to the returned invisible cursor when we try to create a cursor from an invalid bitmap. X11CursorFactoryOzone is only used in the chromeos-on-linux development environment. I've double checked that this doesn't occur in CursorDataFactoryOzone and BitmapCursorFactoryOzone. Bug: 791243 Change-Id: Ia12edf1638a420b61eb7f72f3696dabf506a44e0 Reviewed-on: https://chromium-review.googlesource.com/809492 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Bill Orr authored
Many experience use the gamepad id to choose a hardcoded mapping. The defacto standard id to use for OpenVR is "OpenVR Gamepad", and we should use that as well. Change-Id: I7717516c76a4fb7f5bccf16bbd8d197470de71e1 Reviewed-on: https://chromium-review.googlesource.com/810038Reviewed-by:
-
Balazs Engedy authored
Every RenderFrameHost exposes an InterfaceProvider to its corresponding RenderFrame, which is used by content/renderer/, Blink and WebUI JS code to access frame-scoped services implemented by the RenderFrameHost. Previously, for each frame, there was just a single InterfaceProvider interface connection that was used throughout the entire lifetime of the RenderFrame. The client end of this connection was passed in to the RenderFrame synchronously at construction time, and was then bound to |RenderFrameImpl::remote_interfaces_|. As of this CL, this primordial InterfaceProvider interface connection will only service interface requests originating from the initial empty document in the frame. For each subsequent cross-document navigation, a new message pipe is created, with its client end being bound to the RenderFrame's |remote_interfaces_| when the navigation commits, and its request end sent to the browser process as part of the DidCommitProvisionalLoad message. The one and only exception to this rule is when a browsing context is navigated from the initial empty document to another same-origin document, in which case the global object (i.e. the Window instance) associated with the initial document is reused for the new Document corresponding to the first real navigation committed. This is to support the following use-case: 1) Parent frame dynamically injects an <iframe>. 2) The parent frame calls `child.contentDocument.write(...)` to inject script that may stash objects on the child frame's global object (LocalDOMWindow). Internally, these objects may be using Mojo services exposed by the RenderFrameHost. The InterfaceRequests for these will be en-route to the RenderFrameHost for some time. 3) The `child` frame commits a first real load that is same-origin. 4) The global object in the child frame's browsing context is re-used. 5) When the InterfaceRequests arrive to the browser process, the RenderFrameHost should not discard these requests, so that JS objects stashed on the global object will continue to work. On the browser process side, when the RenderFrameHost receives an InterfaceProvider request along with DidCommitProvisionalLoad, it immediately breaks the old InterfaceProvider connection. Pending interface requests on the old connection are dropped, if any. Interface requests possibly pending on the new InterfaceProvider connection are only dispatched after WebContentsObserver::DidFinishNavigation fires. This ensures that interface requests racing with navigation commit will be either ignored, or correctly serviced in the security context of the document they originated from. In other words, when an interface request is dispatched, the invariant will hold that calling GetLastCommittedURL on the RenderFrameHost will return a URL that matches that of the document from which the interface request actually originated from. Note that |remote_interfaces_| remains a non-Channel-associated interface. Also note that it remains the responsibility of individual features using |remote_interfaces_| to close interface connections already established through the InterfaceProvider when a cross-document navigation commits, if needed in particular use-case. Bug: 729021 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1eb4aa78be9627f70fdf6e18af570f083b9e306d Reviewed-on: https://chromium-review.googlesource.com/735686Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522198}
-
Benjamin C. Wiley Sittler authored
Tests multipart form POSTs with file inputs where the selected "file" was constructed using the `File` constructor and added to a `DataTransferItemList` (this avoids the user gesture requirement which otherwise would consign this to manual testing.) For the non-ASCII filenames with non-UTF-8 accept-charsets this also verifies fallback encoding/replacement of unrepresentable characters using numeric character references. https://github.com/whatwg/html/issues/2861 Coverage for fallback encoding is still tentative because filename fallback encoding is not yet standardized. https://github.com/whatwg/html/issues/3223 Bug: 661819 Change-Id: Ic646f76b0c8a0792d1214a7848d2238bcc3a76e7 Reviewed-on: https://chromium-review.googlesource.com/811625Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Cr-Commit-Position: refs/heads/master@{#522197}
-
Xi Han authored
In this CL, we use Notification.Builder.recoverBuilder() to create a Builder from the notification sent by Chrome, and reset the notification's channel ID when necessary. Bug: 700228 Change-Id: I34cfa00ee2cb93935053020da487242709fbb36e Reviewed-on: https://chromium-review.googlesource.com/810984 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522196}
-
Xiaochu Liu authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5c4b603461a7..304b21ef6d91 $ git log 5c4b60346..304b21ef6 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 xiaochu add UnmountComponent method constant 2017-12-01 ljusten authpolicy: Add GetUserStatusRequest and OU errors Created with: roll-dep src/third_party/cros_system_api chromiumos/platform/system_api.git Bug=chromium:769970 TEST=None Change-Id: Id85f7273a891b93370d1d4c2e79a73715242dbc8 Reviewed-on: https://chromium-review.googlesource.com/811628Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522195}
-
Takumi Fujimoto authored
Set the provider ID for Cast/Dial sinks discovered in browser, so that it's not UNKNOWN. We will remove UNKNOWN as the default argument for the ctor param in a separate patch to avoid bugs like this. Bug: 792586 Change-Id: Ia43a3e451908f8a8e3c902b7869196f2ff6a7b2a Reviewed-on: https://chromium-review.googlesource.com/811666Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#522194}
-
Yuzhu Shen authored
Bug: 699569, 718047 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e2d9e55cac52b392bd31c96c51cc94a361b618b Reviewed-on: https://chromium-review.googlesource.com/809545Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522193}
-
Bence Béky authored
Stop using SpdySession instances in Http2PushPromiseIndexTests. This makes tests much simpler. Rename SpdySessionKey::Equals() to SpdySessionKey::operator==() so that it can be tested by gMock. This conforms to the style guide "prefer to define == [...] rather than Equals()", see https://google.github.io/styleguide/cppguide.html#Operator_Overloading Define struct UnclaimedPushedStream instead of using std::pair or std::tuple. Named members are much nicer than first, second, or get<>. Define CompareByUrl in conformance with the same section of the style guide "if your type doesn't have a natural ordering [...] use a custom comparator rather than overloading <". The next CL will merge SpdySession::UnclaimedPushedStreamContainer into Http2PushPromiseIndex. For this, two sets of UnclaimedPushedStream entries will need to be maintained with identical contents but different ordering. The other will be done by CompareByDelegate and will allow efficient lookup of entries for a given Delegate. Bug: 776415, 791054 Change-Id: I0c1912e9932b102e17528f9319163232860a8813 Reviewed-on: https://chromium-review.googlesource.com/809187Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522192}
-
Brian Anderson authored
Adds LatencyInfo entries for 5 frame sources: 1) Renderer main. 2) Renderer compositor. 3) UI main. 4) UI compositor. 5) Display compositor. These will be used to calculate metrics in followup patches. This patch also: * Discards LatencyInfos that don't result in damage in the Display, which is consistent with what we do earlier in the pipeline. The exception being snapshot requests to keep them working. * Adds a LatencyInfo::TraceIntermediateFlowEvents helper. * Fixes LayerTreeHostImpl::DrawLayers so it only adds INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT in the Renderer. Bug: 790759 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I478db123d536654acf3633ca5efb4e4d20132e78 Reviewed-on: https://chromium-review.googlesource.com/783849 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:vmpstr <vmpstr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#522191}
-
Morten Stenshorne authored
The Ahem font doesn't behave reliably at any given size. Multiples of 5px is supposed to work better. So use 20px instead of the default (16px). Bug: 788337 Change-Id: Ifd803008c6780a32fbeb5609faf23270ed4e8066 Reviewed-on: https://chromium-review.googlesource.com/811485 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522190}
-
Jinho Bang authored
Change-Id: Ic7eebc07a3fec115130c7de70b8571385bdd04f0 Reviewed-on: https://chromium-review.googlesource.com/812024Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#522189}
-
Katie Dektar authored
BUG=none NOTRY=true Change-Id: I78b082eae5c8033dee3bc2684a8d176034d7857e Reviewed-on: https://chromium-review.googlesource.com/811687Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522188}
-
chrome://interventions-internalsThanh Le authored
Decision log messages are grouped so that they don't flood the logs table. Log messages can be grouped by page_id retrieved from PreviewsIOData. The messages that don't need grouping can use 0 as page_id, since the generated IDs start at 1. Screenshot: https://drive.google.com/a/chromium.org/file/d/17mp8fIHWIJjbZp_t711PGLEaWuZoG1v2 Screenshot: https://drive.google.com/a/chromium.org/file/d/1KI_f1XCYVSk2hLqq2LGaTr0g7LZ6oQcd Bug: 791637 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5eff89d6a8ffc38209819d8787fdac30caaa939a Reviewed-on: https://chromium-review.googlesource.com/806758Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Lily Houghton authored
Per https://bugs.chromium.org/p/chromium/issues/detail?id=755727, as of C++14, std::make_unique provides the same functionality as Base::MakeUnique, and is preferred. Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaac534f4598872f56ddad67afcfaac4318883edf Reviewed-on: https://chromium-review.googlesource.com/806595 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#522186}
-
gogerald authored
TBR=rouslan@chromium.org Bug: 787837 Change-Id: I86e4e239329a93d4e1e2b28ac83d3732c447f47d Reviewed-on: https://chromium-review.googlesource.com/811747Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Sébastien Marchand authored
This reverts commit 88125134. Reason for revert: Breaks the Windows build This breaks the Windows build (in some situation), https://chromium-review.googlesource.com/c/chromium/src/+/810787 fix some issue but it's not sufficient, e.g. https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/60438 failed with the following stack trace: FAILED: gen/chrome/test/data/media/engagement/preload/test.pb C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../tools/media_engagement_preload/make_dafsa.py ../../chrome/test/data/media/engagement/preload/test.json gen/chrome/test/data/media/engagement/preload/test.pb Traceback (most recent call last): File "../../tools/media_engagement_preload/make_dafsa.py", line 17, in <module> import media_engagement_preload_pb2 File "C:\b\c\b\win\src\tools\media_engagement_preload\media_engagement_preload_pb2.py", line 8, in <module> from google.protobuf import descriptor as _descriptor File "C:\b\c\b\win\src\third_party\protobuf\python\google\protobuf\descriptor.py", line 37, in <module> import six ImportError: No module named six Original change's description: > Media Engagement: Add DAFSA generator and reader > > Add a tool to generate preload data in DAFSA format and > add a MediaEngagementPreloadedList class to read it. > > BUG=787464 > > TBR=dpranke@chromium.org > > Change-Id: If0d99a2e1091d0b23699f2173d8146582173ee54 > Reviewed-on: https://chromium-review.googlesource.com/803994 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522068} TBR=dalecurtis@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org Change-Id: I1b5bbaf0dc435a28905bfdaf15142115e8636d2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787464 Reviewed-on: https://chromium-review.googlesource.com/811945Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#522184}
-
Sébastien Marchand authored
This reverts commit 3946a6ad. Reason for revert: This is breaking the Windows build. https://chromium-review.googlesource.com/c/chromium/src/+/803994 broke the Windows build and needs to be reverted, and as this CL is depending on it it need to be reverted too. Original change's description: > Media Engagement: Histograms for preloaded list. > > This adds two histograms to MediaEngagementPreloadedList. The first is > used when the list is loaded and will allow us to see if the loads are > failing and why. The second is used when the list is checked and will > allow us to see if the list has not been loaded or is empty, as well > as how often the list is matching. > > BUG=787464 > > Change-Id: I935405ef56aa197a2f32fbd85df7c9ae4851b12a > Reviewed-on: https://chromium-review.googlesource.com/808305 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522085} TBR=jwd@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org Change-Id: Id6f811e28c70063467a0ce1e97da59a2dc0e6c14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787464 Reviewed-on: https://chromium-review.googlesource.com/812044Reviewed-by:
-
