- 03 Aug, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7917065. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22261 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jsbell@chromium.org: external/wpt/encoding external/wpt/resources msramek@chromium.org, mkwst@chromium.org: external/wpt/clear-site-data TBR=foolip No-Export: true Change-Id: Ic5e40a323daad97a8358872fe0dd1f70438b4d20 Reviewed-on: https://chromium-review.googlesource.com/1161617 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580463}
-
Marc Treib authored
Followup to https://crrev.com/c/1148392, which introduced IsSyncFeatureEnabled and made IsSyncActive depend on it. Bug: 856179 Change-Id: Icfc6e35550285ec7688b0de0cdce9c161d2049cc Reviewed-on: https://chromium-review.googlesource.com/1160850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580462}
-
Darren Shen authored
VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow tests that we don't reduce the viewport size of IME related windows (like the floating candidate window when you gesture type). However, the test uses ShowKeyboard(true), which shows the locked keyboard. When the locked keyboard appears, we don't overscroll. Rather, we reduce the size of the work area, shrinking the actual size of the window. The test still passes because shrinking the work area also shrinks the viewport size. This patch changes the test to use ShowKeyboard(false), which triggers overscrolling. This matches the original intent of the test more closely. TBR=yhanada@chromium.org Bug: 849995 Change-Id: Ifdbea75c5b84081fc67cd29e3af21f1984b4a4eb Reviewed-on: https://chromium-review.googlesource.com/1160064Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#580461}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d146987b6945..ee09b25fcad3 git log d146987b6945..ee09b25fcad3 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vapier@chromium.org toolchain: fix default selection in toolchain.conf processing 2018-08-03 dgarrett@google.com workspace: Use a reference repo if available. 2018-08-03 tikuta@chromium.org cros_chrome_sdk: Invoke gomacc inside compiler wrapper 2018-08-03 dgarrett@google.com run_tests: Move new tests into chroot. Created with: gclient setdep -r src/third_party/chromite@ee09b25fcad3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I33d5604f2d2b82439546ffb89f5bd9b246f68a06 Reviewed-on: https://chromium-review.googlesource.com/1161347Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580460}
-
Mark Cogan authored
This CL fixes the size distortion of the incognito NTP in the new tab animation. The foreground animation view was assuming that the content view it animated had the same bounds as itself; this isn't correct for the incognito NTP, which is shorter to accommodate the toolbar. This CL instead repositions the content view correctly without resizing it. It also makes the animation view shorter (by StatusBarHeight()) to make this calculation cleaner. Bug: 868292 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id49a3de2f3f62c246356da082f74285014a7b37a Reviewed-on: https://chromium-review.googlesource.com/1160843Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580459}
-
Abhishek Bhardwaj authored
Add an |is_tethered| field to the WiFi struct embedded in NetworkConfiguration. This field will tell the instance whether a WiFi configuration is tethered. BUG=b:62926617 TEST=Verify the is_tethered field is true when Chrome OS is connected to a mobile hotspot and false otherwise. Change-Id: I5dfc9f019be585fab435000f39a10661d2d35894 Reviewed-on: https://chromium-review.googlesource.com/569099 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580458}
-
Jennifer Apacible authored
A previous change made controls always appear when the mouse is moving on all OS except Windows. This change gates handling the ET_MOUSE_MOVED event to Windows OS. Bug: 870120 Change-Id: I556c354643a920c34b973066369e26f38130705f Reviewed-on: https://chromium-review.googlesource.com/1161300 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#580457}
-
Kunihiko Sakamoto authored
This reverts commit 381beab3. Reason for revert: Suspected of breaking browser_tests on Mac. crbug.com/870579 Original change's description: > chrome: Call SetUpBundleOverrides from ChromeMain. > > It looks like we always need to call SetUpBundleOverrides no matter > what the process type is, so we can just call it from ChromeMain. This > will save us from needing to call this function from browser-specific > code in a later change. > > While here, also remove a dead declaration. > > Bug: 855193 > Change-Id: I449d92ef9c7d80d066d4cfefb3015014bd407cc1 > Reviewed-on: https://chromium-review.googlesource.com/1159335 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580285} TBR=avi@chromium.org,pcc@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I32f905ff8f82306a85fbc9798652b8c99aa46009 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855193,870579 Reviewed-on: https://chromium-review.googlesource.com/1161722Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580456}
-
Chris Palmer authored
johnme@ suggests a better way to handle it; let's do that. Bug: 786211 Change-Id: I446c70117451d2ef49ce13f5884ebb858d9ee392 Reviewed-on: https://chromium-review.googlesource.com/1161400 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580455}
-
Oystein Eftevaag authored
This adds support for both global metadata, and metadata events. As part of this, the Perfetto support expands in a couple of ways: * Implement Flush(), so a Consumer can make sure the metadata events are written once, before tracing shuts down. * Support multiple data sources; global metadata is a separate data source as it's not actually tied to tracing. Bug: 840499 Change-Id: Ib4a76f692f333ffea89f7cf8200d0da3eeefaa23 Reviewed-on: https://chromium-review.googlesource.com/1129959 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#580454}
-
Max Moroz authored
Bug: 870331 Change-Id: Icbf8bc191e4078bd3ee8fb7fe15e51caae59e372 Reviewed-on: https://chromium-review.googlesource.com/1160861Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580453}
-
Bill Orr authored
Third party code will be blocked in the browser process. We'll need to host VR input outside the browser process. To support that, we need some IPC mechanism to get gamepad data over to the browser process where the device/gamepad service is hosted. For now, we'll host OpenVR gamepad data in the same place we host the OculusRenderLoop. This is not the final shipping location, but adding an IPC mechanism moves us closer to the final architecture. BUG=795510, 860821 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib63489c36e3e08723d9e4f92327fb97aa77597a9 Reviewed-on: https://chromium-review.googlesource.com/1147742 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580452}
-
Kunihiko Sakamoto authored
This reverts commit 94d8037b. Reason for revert: USS/TwoClientBookmarksSyncTestIncludingUssTests.CreateSyncedBookmarks/1 failed on linux-chromeos-rel and Win 7 Tests x64 (1) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11463 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/41473 Original change's description: > [Sync:USS] Enable more two client bookmarks integration tests > > This CL enables more integration tests for bookmarks to run > against USS archiecture. > > > Bug: 516866 > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f > Reviewed-on: https://chromium-review.googlesource.com/1158691 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580434} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I34b63c1bc4202e2605527ff4844116fcc389e883 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/1161721Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580451}
-
Renee Wright authored
Bug: 864897 Change-Id: Iede53b65ec37b5778f9ec52f5a03293b2a0ee604 Reviewed-on: https://chromium-review.googlesource.com/1154738 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#580450}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6db395a..f357c021 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2b55e25d0196c1663ffb5823be8915ad3b3622f Reviewed-on: https://chromium-review.googlesource.com/1161602Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580449}
-
Mitsuru Oshima authored
Use ZERO tween applies the target values at the end of the animation when animation is not necessary. I'll consolidate two SetTransform in a separate CL. BUG=none TEST=covered by unittests. Change-Id: I29291b4d43330552cdc3f92ee91bd9faf23f921b Reviewed-on: https://chromium-review.googlesource.com/1158844 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580448}
-
Mohamed Amir Yosef authored
This CL enables the two client bookmark integration test MC_DeleteBookmark to run against USS archticture. Bug: 516866 Change-Id: I5d60f5b7473ba2b24ebbf501d2e6ae689f7aa0d8 Reviewed-on: https://chromium-review.googlesource.com/1158697 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580447}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/95340100f95f..2958a8faf500 git log 95340100f95f..2958a8faf500 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 tsepez@chromium.org Use more helper macros/methods in JBig2_Image.cpp. 2018-08-02 thestig@chromium.org Fix some nits in SkiaState. 2018-08-02 thestig@chromium.org Skia Path: Fix text/xform size mismatch when calling drawTextRSXform(). Created with: gclient setdep -r src/third_party/pdfium@2958a8faf500 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:751423 TBR=dsinclair@chromium.org Change-Id: I57dc7b1e7ab52e06e0b3ad22952be79cd6d6561b Reviewed-on: https://chromium-review.googlesource.com/1161345Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580446}
-
Han Leon authored
Currently we have a [Native] mojom struct content.mojom.PushEventPayload with a typemapping to the native struct content::PushEventPayload, we use them to pass payload data when calling the Mojo call content.mojom.ServiceWorker.DispatchPushEvent(). However, as content::PushEventPayload contains only 2 members: a string containing real data and a bool indicating data's validity, and it has no expectations to be expanded for now, so, we can just use a base::Optional<string> to replace it, and correspondingly in mojom we just needs a 'string? payload' for our content.mojom.ServiceWorker.DispatchPushEvent(). This CL removes content::PushEventPayload by doing the above replacement. BUG=789854 Change-Id: I8df737165b3004db820e3b758c1bfa8bdb7b5690 Reviewed-on: https://chromium-review.googlesource.com/1149705Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#580445}
-
BUG=762641 TBR=alemate@google.com Change-Id: I7e17a0c0a86fdd5de588a64ffb745435e6e39fd5 Reviewed-on: https://chromium-review.googlesource.com/1161608 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580444}
-
mrefaat authored
The current behavior is that apps can launch without user gestures. This is a source of abusive experience for users. Bug: 850760, 804054 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If47224bf27018a4b9d5a1cdbc39891849de05eb4 Reviewed-on: https://chromium-review.googlesource.com/1152692 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#580443}
-
Kunihiko Sakamoto authored
This reverts commit be2632ac. Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 Original change's description: > Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > This reverts commit 67ca5a07. > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. > > Original change's description: > > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > > > This reverts commit 20f64257. > > > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg) > > > > Original change's description: > > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors > > > > > > This change implements obtainining Remote Gatt Descriptors for WinRT by > > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, > > > appropriate tests are enabled. > > > > > > Bug: 821766 > > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 > > > Reviewed-on: https://chromium-review.googlesource.com/1156392 > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#579830} > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 821766, 870208 > > Reviewed-on: https://chromium-review.googlesource.com/1159943 > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580106} > > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org > > Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766, 870208 > Reviewed-on: https://chromium-review.googlesource.com/1160901 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580200} TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1161682Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580442}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0da902e4fde4..ca942e227a7a Created with: gclient setdep -r src-internal@ca942e227a7a The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865968 TBR=mmoss@chromium.org Change-Id: I8143efdc6693c31454ebde0f0a6ba4760de23581 Reviewed-on: https://chromium-review.googlesource.com/1161023Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580441}
-
Kunihiko Sakamoto authored
This reverts commit ffac89b5. Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 Original change's description: > Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > This reverts commit d01b7c9e. > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. > > Original change's description: > > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > > > This reverts commit f61df6f9. > > > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change. > > > > Sample builds: > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242 > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240 > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236 > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235 > > > > failures: > > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0 > > BluetoothTestWinrt.GetPrimaryServices/1 > > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1 > > BluetoothTestWinrt.GetPrimaryServicesByUUID/1 > > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0 > > BluetoothTestWinrt.GetGattServices_and_GetGattService/1 > > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1 > > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0 > > > > Original change's description: > > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors > > > > > > This change implements reading and writing of Remote Gatt Descriptors > > > for WinRT. Furthermore, it enables corresponding tests. > > > > > > Bug: 821766 > > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe > > > Reviewed-on: https://chromium-review.googlesource.com/1156703 > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#579838} > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 821766 > > Reviewed-on: https://chromium-review.googlesource.com/1159961 > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580062} > > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766 > Reviewed-on: https://chromium-review.googlesource.com/1160902 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580201} TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766,870208 Reviewed-on: https://chromium-review.googlesource.com/1161681 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580440}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/77e8a21d75e2..d4de71b02044 git log 77e8a21d75e2..d4de71b02044 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 hinoka@google.com Add .vpython file with httpplib2 2018-08-02 hinoka@chromium.org Revert "Reland "Whitespace change to kick off luci jobs"" 2018-08-02 hinoka@chromium.org Reland "Whitespace change to kick off luci jobs" Created with: gclient setdep -r src/native_client@d4de71b02044 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204,chromium:868204,chromium:868204 TBR=mseaborn@chromium.org Change-Id: I04c64a4fc1b0ab551bdfe24c637286ccd0ca741a Reviewed-on: https://chromium-review.googlesource.com/1161344Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580439}
-
Ted Choc authored
This introduces the basic view components from the UI rearchitecture, but this relies very heavily on a lot of outside signals to be passed into the controller. This is meant as a stop gap measure while we can piece meal clean up the various dependencies along the way. BUG= Change-Id: Id6a5438c4b1cd485c5c9a60ce48f832e2a4e4650 Reviewed-on: https://chromium-review.googlesource.com/1148680 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#580438}
-
Kunihiko Sakamoto authored
This reverts commit 43db955e. Reason for revert: Broka device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 Original change's description: > [Bluetooth][WinRT] Implement Subscribing to Notifications > > This change implements subscribing to Gatt Notifications for WinRT and > enables corresponding tests. > > Bug: 821766 > Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7 > Reviewed-on: https://chromium-review.googlesource.com/1156686 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580279} TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: I8db3ae54ee129c51522a879bff6cad32431b6cb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766,870208 Reviewed-on: https://chromium-review.googlesource.com/1161661Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580437}
-
Mohamed Amir Yosef authored
This patch addresses the problem of conflict in bookmarks upon receiving a remote update for a node that has local changes. The general polic that is implemented is that server wins except in case of deletion. Bug: 516866 Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 Reviewed-on: https://chromium-review.googlesource.com/1157006 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580436}
-
Keishi Hattori authored
If you pass a placement only object to WTF::Bind, the Trace method will not be called. It can result in the on-heap objects referenced from the object, collected prematurely. In this case the backing for PaymentInstrument::icons_ had this problem. In this CL we wrap the PaymentInstrument in a GarbageCollected class so we can use a Persistent on it. Bug: 869887 Change-Id: I2ae75c3652f52a898dac422c2c867c388d170f88 Reviewed-on: https://chromium-review.googlesource.com/1158668 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580435}
-
Mohamed Amir Yosef authored
This CL enables more integration tests for bookmarks to run against USS archiecture. Bug: 516866 Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f Reviewed-on: https://chromium-review.googlesource.com/1158691 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580434}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eae13a4b34cc..e16a2e80be66 git log eae13a4b34cc..e16a2e80be66 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vovoy@chromium.org Look up wpr archives by story name only 2018-08-02 zmo@chromium.org Hookup finder_options.browser_options.wpr_mode for gpu integration tests. Created with: gclient setdep -r src/third_party/catapult@e16a2e80be66 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:810616,chromium:867155 TBR=sullivan@chromium.org Change-Id: I18bcbd9dffcaadf0d66ca2ccc92ee7be45238e82 Reviewed-on: https://chromium-review.googlesource.com/1161146Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580433}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/578ef2847b72..84dd183a82c3 git log 578ef2847b72..84dd183a82c3 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 aljabri@amazon.com Implement Color Filters for SKIA SVG backend Created with: gclient setdep -r src/third_party/skia@84dd183a82c3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I79395f4e00bcbf1841197f8e9f935886cbd31ed3 Reviewed-on: https://chromium-review.googlesource.com/1161346Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580432}
-
David Black authored
The molecule icon is originally centered horizontally in its parent. On delivery of the first query response, it animates to align left in its container. I did not animate the greeting/progress indicator views in this CL because they are going to have to move to a separate parent. This is because they need to be laid out on top of the UiElementContainerView, not inside of it. Otherwise, they will push down the response UI elements when visible. See bug for spec/demo. Bug: b:112161077 Change-Id: Ib46cebb0172e6ac64bf0b0966e2082f3e17f20f8 Reviewed-on: https://chromium-review.googlesource.com/1161383 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580431}
-
David Black authored
We have a contract with the server that TTS will be after all UI responses. When the server breaks this contract, we currently crash. We should not crash when server breaks contract but we will ignore the unexpected responses. Bug: b:112158958 Change-Id: I560c647584bee2ee3fcbce74c2f77b8124fa3d82 Reviewed-on: https://chromium-review.googlesource.com/1161390 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580430}
-
David Black authored
When the mic time's out, we should NOT clear the answer for the previous query to present an empty response. Instead, we should treat it as if the timed out query did not occur and retain the prior view/model state. Bug: b:112146822 Change-Id: I5a403ae071c5a17def3c77b9ae3503d755a70a60 Reviewed-on: https://chromium-review.googlesource.com/1161007 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580429}
-
kristipark authored
Hide the settings menu if a theme is installed and custom links is not enabled. Bug: 869702 Change-Id: If8fe8d2382ab92f7c8f44795548e1f3e34e2c690 Reviewed-on: https://chromium-review.googlesource.com/1159681 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580428}
-
Robert Sesek authored
GetKeyEquivalentAndModifierMaskFromAccelerator() computes the key equivalent for menu items. If the key equivalent is inherently shifted (e.g. + and }), do not include Shift in the modifier flags, since it is already encoded in the equivalent. Including it in the flags results in Shift being required in addition to the key. Bug: 867788 Test: Cmd+Plus zooms the page, as well as Cmd+Shift+Plus. Change-Id: I3536d7652804f77a14b51197cdf5f49d6defc77d Reviewed-on: https://chromium-review.googlesource.com/1157224Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580427}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I51800268a9406760ff8058719e75bc0f33e3c093 Reviewed-on: https://chromium-review.googlesource.com/1161480Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#580426}
-
Andrew Moylan authored
Also fix 'bug' where service name was being used instead of interface name in MethodCall (though they are the same string ...) Bug: 782499 Change-Id: I81fb4e2bf9e093b4c58984c47b993fbbd9c30c1c Reviewed-on: https://chromium-review.googlesource.com/1160833Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580425}
-
Jinsuk Kim authored
Should have been deleted by https://crrev.com/c/689054. Bug: 704323 Change-Id: I8f09d44fb10a05e4088c8416af3a5d2fa67461c4 Reviewed-on: https://chromium-review.googlesource.com/1159551 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580424}
-