- 11 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/012d15196023..02eeebf19886 git log 012d15196023..02eeebf19886 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 041f0a02493d..3e4abc9ac382 (2 commits) Created with: gclient setdep -r src/third_party/angle@02eeebf19886 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I2ddc881ef1e3b199a109c78b231e21e5f12e5333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714175}
-
Yoshifumi Inoue authored
This patch makes |LayoutText::{First,Last}CharacterAfterWhitespaceCollapsing()| to utilize |NGInlineCursor| for prepration of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: Id567850f2e0cdc56c62552de1bacac65f3a67bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909062 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714174}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/041f0a02493d..3e4abc9ac382 git log 041f0a02493d..3e4abc9ac382 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 dneto@google.com Try to fix go linter: exported constant comment (#3026) 2019-11-08 afdx@google.com spirv-fuzz: Eliminate spurious semicolons (#3025) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3e4abc9ac382 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: Ic55e842b93957631363cd214193229db846f794c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909438Reviewed-by:
-
Yuki Shiino authored
name_style.arg is preferred to snake_case, but there are cases that a bindings generator needs to control case directly. This patch exposes such low-level controls into name_style.raw namespace. Bug: 839389 Change-Id: I3892238ada61625c36e1cff993640146758089b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909048Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#714172}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I047afae7b61e843416fc11785f806679edd8a215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909437Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutBox::ResolvedDirection()| to utilize |NGInlineCursor| for prepration of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: I4560959b10d83a2c9b2b50815921eaa37301a3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909671 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
This is removing the deprecation warning (mentioning an old version) for -internal-media-controls-overlay-cast-button. This is also adding UKM support to better understand how it is used. Bug: 678285 Change-Id: I0d8fdd978e8e465289a73bb6979e0439951f67ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898618Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#714169}
-
Martin Robinson authored
When a static text node content changes, we should automatically update the parent's hypertext. Static text node children are included as text content in their parents (as opposed to via an embedded object character). This fixes an issue where parents could contain stale content. Bug: 1021783 Change-Id: I9c759c14f30cb774277e0e6ea14c1155fd2d795a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904083Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#714168}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::IsInlineLeaf()| to return false for |IsGeneratedTextType()|, e.g. soft hyphen, ellipsis, fragment to avoid computing Bidi level for them. Before this patch, we attempt to find |NGInlineItem| from |LayoutText| for generated text type fragment but it isn't there then we hit |DCEHCK()|. This patch also introduces |NGInlineCursor::CurrentText()| for testing generated text type in |NGInlineCursorTest| and changes |NGFragmentItem| constructor to handle |kGeneratedText|. Bug: 1021993 Change-Id: If1d160fba75d11d8ed9760d175c01708d89f7b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905045 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add a 16px x 16px eject icon. Append it as a child of its <cr-button> container. Update and combine its CSS with other .align-right-icons: z-index: remove the comment: there's no ripple on any align-right icon once <cr-button> was used for the eject button. z-index has re-paint minimization effects in Files app, so retain z-index. --active-bg: none; disable this prefers-dark-mode-only <cr-button> color until we support dark-mode. :hover: cr-button has a square hover and we keep it to match Files app. Never show the hover effect when Files app is re-sizing. :active: use round activation, via border-radius 20px. Remove code doing the same from directory-tree.js. Remove the eject icon PNG files (no longer used). Bug: 992819 Change-Id: I98530884c9fafccde491786f9c99d5d9a925db25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909670Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714166}
-
Hitoshi Yoshida authored
In comparing ASCII-only strings, unittest module displays multiple lines strings in one line using new line characters ("\n") "abc\nxyz" != "abo\nxyz" With this change, it shows the lines which differs and its around. "abc\nxyz" != "abo\nxyz" - abc ? ^ + abo ? ^ xyz Bug: 839389 Change-Id: Icd8fc5001f02d1b6d7c6abb277836d842b1f424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909767Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#714165}
-
Rob Buis authored
Add MathMLElement idl to allow useful DOM operations on MathML elements. See https://mathml-refresh.github.io/mathml-core/#dom-and-javascript The failures are due to attributes missing from GlobalEventHandler.idl. See for example https://crbug.com/1006096 Bug: 6606 Change-Id: I86f65635e30f74eabeaf5ec0097cb9694137c3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904195Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#714164}
-
Kuo Jen Wei authored
The former video fps candidate only include largest fps and system default. This CL add all fps>=30 video candidates. Test: tast run <DUT> 'camera.CCAUI*' Bug: b/141518780 Change-Id: Ice9b1af3af9d8321c1ff93cc7d43ad1c4894666b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905034 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714163}
-
Keishi Hattori authored
Marks tests as timeout on MSAN bots TBR=lethalantidote@chromium.org Bug: 856601 Change-Id: If988ecc3d97ea17428dd20392078b0b80b528dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909673Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714162}
-
Gyuyoung Kim authored
This CL converts remained old Mojo types of WifiDisplayMediaServer interface to new Mojo types. Major changes are as below, - Convert mojom::WifiDisplayMediaServerPtr to mojo::PendingRemote|Remote<mojom::WifiDisplayMediaServer> - Convert mojo::WifiDisplayMediaServerRequest to mojo::PendingReceiver<mojom::WifiDisplayMediaServer> Bug: 955171 Change-Id: Ifd5c9f95eee9bcb505bf308f09ef6828d29bb276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896486 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#714161}
-
Kenichi Ishibashi authored
This is a preparation for moving ServiceWorkerDatabase to components/services/storage. Remove content/{common,browser}/service_worker dependencies. Also remove some third_party/blink dependencies. This CL doesn't have behavioral changes. ServiceWorkerDatabase and the corresponding proto file will be moved to the storage service in a follow-up CL. Bug: 1016064 Change-Id: Iae2b46353b1045239dfa247cc70a3b78698c2cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906861 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714160}
-
Keishi Hattori authored
This reverts commit 2de0ccb8. Reason for revert: Suspecting cause for screenshot test failure. Seems unlikely but this is the only color related CL in regression range. crbug.com/1023255 Original change's description: > Make use of new hex decoding function for extensions color string parser. > > Bug: 1021236 > Change-Id: I1d1b5180048eb36fa78406a02fc3277cba0dcf63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904809 > Commit-Queue: Eric Roman <eroman@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Auto-Submit: Eric Roman <eroman@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713942} TBR=eroman@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1021236 Change-Id: I474f4e07583f571722e4bacf28ae482c071276a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909669Reviewed-by:
-
Abhijeet Kandalkar authored
This CL removes old downcast helpers generated by macro DEFINE_TYPE_CASTS.The primary goal of this CL is to use new downcast helpers implemented using C++11 type traits. Bug: 891908 Change-Id: Ib00118d7419f371124317376076772ef81d41580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906613 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#714158}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::IsLineBreak()| not to crash for non-text type for |NGFragmentItem| as |NGPaintFragment|. This patch makes following test to pass instead of crash: - editing/pasteboard/drag-drop-input-textarea.html - fast/events/remove-target-with-shadow-in-drag.html - http/tests/security/drag-drop-different-origin.html - virtual/mouseevent_fractional/fast/events/remove-target-with-shadow-in-drag.html Bug: 982194 Change-Id: Ib5656688308080e8aede3ca5ffabfa43e32f4019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909060 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Generates basic code for accessors of dictionary members. Bug: 839389 Change-Id: I710f090a0cd66bb9821bbe0274cce3f120a93e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900522 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 5a2bf1a6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 714152 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVhMmJmMWE2MjJlNzVlNDgwNmMyNWFiM2FhOTNmNzQzOGJiZTFjYTcM Sample Failed Build: https://ci.chromium.org/b/8897108652777688192 Sample Failed Step: compile Original change's description: > bind-gen: Implement CodeGenContext.idl_location_and_name > > Implements CodeGenContext.idl_location_and_name in order to pretty- > print a path to an IDL file and IDL definition name being processed. > > Bug: 839389 > Change-Id: I2699f735fd5897206e25364b2b29932bd0177330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909049 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714152} Change-Id: If40954d80e71c5b10e3e7729befa99ea04ae2447 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909715 Cr-Commit-Position: refs/heads/master@{#714155}
-
Hiroki Nakagawa authored
IsContextAlive() just checks ServiceWorkerProviderHost::context_, and is only called in ServiceWorkerProviderHost. It's not necessary to expose it as a public function. Bug: n/a Change-Id: I33f5b23c4f2bdaaffc7b8b45d99ee7cd84a13c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909053 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#714154}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Iaa5986929e5f758cf3f3ebfaae1a3dfdfb56df85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874996Reviewed-by:
-
Yuki Shiino authored
Implements CodeGenContext.idl_location_and_name in order to pretty- print a path to an IDL file and IDL definition name being processed. Bug: 839389 Change-Id: I2699f735fd5897206e25364b2b29932bd0177330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909049 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibb15a1d8d27474d0b46af42525958758cc4ac85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906850 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1012114 Test: Verify shutter for different capture mode. Change-Id: I272de6a89b02f72d087b95759ea32aa9d1d3538e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890518 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56af378833d9..92338b81e5c4 git log 56af378833d9..92338b81e5c4 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 fancl@chromium.org SheriffRedux: Add a sample chromeperf-sheriffs.cfg for testing Created with: gclient setdep -r src/third_party/catapult@92338b81e5c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:953181 Change-Id: I5456e628a67b41d82e2dc79e47027bae58cac877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909271Reviewed-by:
-
Hiroki Nakagawa authored
This CL adds WebFeature::kClassicDedicatedWorker and WebFeature::kModuleDedicatedWorker for WorkerOptions#type. These are recorded in following cases. (1) When a dedicated worker is constructed using classic scripts, kClassicDedicatedWorker is recorded: const worker1 = new Worker('worker.js'); // or const worker2 = new Worker('worker.js', { type: 'classic' }); (2) When a dedicated worker is constructed using module scripts, kModuleDedicatedWorker is recorded: const worker3 = new Worker('worker.js', { type: 'module' }); This CL adds web_tests for these cases. In addition to that, this CL adds tests for existing kWorkerStart and kNestedDedicatedWorker. kWorkerStart is recorded when a dedicated worker is constructed regardless of given options (e.g., 'type') and creator's execution context. kNestedDedicatedWorker is recorded when a dedicated worker is constructed from another dedicated worker: const worker4 = new Worker('nested-worker.js'); // In nested-worker.js const nested_worker = new Worker('worker.js'); Bug: 680046 Change-Id: Ic8aed3f9f43f6ceafeb5eac4a11382c7a21ea9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906855 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: -
Keishi Hattori authored
editing/input/edit-context.html is failing the leak test and needs to be fixed. TBR=yosin@chromium.org Bug: 1023242 Change-Id: I43353324f089f1c1dac80691bde9b295ee40f555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909056Reviewed-by:
-
Yuzu Saijo authored
This CL removes comment for a closed bug. As the bug comments concluded, rfh look up is always safe with render process id and frame id. Thus, we do not need this comment. Bug: 1012238 Change-Id: I3b21ca1faca405a40f3ec7ca5c1b64d410d91592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909054 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit 74a8f73b. Reason for revert: PageLoadMetricsBrowserTest.PaintInMultipleChildFrames failing on many bots crbug.com/1023235 Original change's description: > Measure FCP of third-party iframes > > What: Measures FCP of third-party iframes on pages. Note that this > will be a bit wonky at times, as lazy-loaded frames will have a very > long FCP. > > Why: So that we can measure the impact of triple-keying the cache on > loading subframes. > > How: Added a third_party_metrics_observer metric. The class records > third-party origin iframes FCP and remembers that the RenderFrameHost > has been recorded so that it's not recorded again. > > Change-Id: Ib4b053eee81210a5ea0a2fec167d4f5995e29967 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890996 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714024} TBR=jkarlin@chromium.org,csharrison@chromium.org,johnidel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iad78d3fd005a14486a9e98bfff8935cf599bf0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906860Reviewed-by:
-
Leon Han authored
mediaType does not make any sense for other record types. The spec change: https://github.com/w3c/web-nfc/pull/419 BUG=520391 Change-Id: Icf077c2fea64364f9a799a08d3aa630531590b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900670 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#714144}
-
Noel Gordon authored
SVGO optimize the external link svg, and place it in a 16x16 icon set so it can be used in an <iron-icon icon='files16:external-link'>. Change AndroidAppItem (the only user) to add external link as a child <iron-icon> of the externalLinkIcon container. Update CSS to style the <icon-icon> 16 x 16px, centered in its parent 40 x 40px externalLinkIcon container. Remove external_link.svg file (no longer used). Bug: 992819 Change-Id: I9430848b2f8a3ce9f9d3e4a8f1c9233847ee5921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906853Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit 79e07a5d. Reason for revert: crashing unittest GLRendererTest.DontOverlayWithCopyRequests crbug.com/1022911 Original change's description: > viz: Use Build Flags to Maintain A Single Overlay Candidate Type (Reland) > > For each platform, we only use one overlay candidate type. Use build > flags to manage that. This also helps unify different platforms' > ProcessForOverlay API. > > This CL is a kindred spirit with crrev.com/c/1664476, but is rebased on > top of ToT and crrev.com/c/1739980. This is CL 2/? for the overlay > processor refactor. > > R=rjkroege > > Bug: 963597 > Change-Id: I3a560bf8da3c8e86227cb7c43d15ba4c437b8764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753810 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713453} TBR=rjkroege@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963597 Change-Id: I0a8923bb67d6889b630c967dad6f4a15e4162649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906859Reviewed-by:
-
Christian Biesinger authored
Speculative fix for bug 1023155. Bug: 1023155 Change-Id: Iba77dae882798f2de9dc6c9adfd1346a8f6138c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908059 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#714141}
-
Alan Cutter authored
Bug: 926083 Change-Id: Ibb961ead98be58a3cb9079ca5bf8edf0e86001fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905293 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#714140}
-
Yuki Shiino authored
Accepting None is must-have to support the following use case. seq.extend([ make_maybe_empty_code_node1(...), make_maybe_empty_code_node2(...), ]) Bug: 839389 Change-Id: Ib5b8b5f907d84e7e62b16be2213df8a602b6d0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906689 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: -
Simeon Anfinrud authored
These asserts are no longer actively being used for debugging. When this is compiled on the Android component build, the linker cannot find the extern bool declared by another shared library. This patch disables the InProcessRenderThread checks, which were intended for debugging in production, so that developers can at least attempt to use the component build on Android. Bug: Internal b/64440217 Bug: 514141 Test: chromecast internal Android component build Change-Id: Iac24c87867e218f98c130677e6baff9142a7fe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898812Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714138}
-
Chih-Yu Huang authored
This CL fixes a compilation error in image_processor_test.cc. Bug: none Test: ninja image_processor_test Change-Id: Ic73e3beb7639a585918184219a1141772252bb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906857 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714137}
-
Stephen Chenney authored
Bug: 1021164 Change-Id: Ifc640896eae412c09cddb3bb70b694cca7e078a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899748 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
