- 07 Apr, 2020 18 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2de511efbdc..84323449dfaf git log d2de511efbdc..84323449dfaf --date=short --first-parent --format='%ad %ae %s' 2020-04-06 cnorthrop@google.com Capture/Replay: Track buffer contents by ID Created with: gclient setdep -r src/third_party/angle@84323449dfaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I49fb36ed98c8135994c66d5e3666b9aa192f1b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756893}
-
Rahul Arakeri authored
This CL simplifies the implementation of thumb drag for the Compositor threaded scrollbar scrolling feature. It also aligns the implementation to main thread thumb drag more than before. The aim of doing this is to reduce the possibility of bugs arising from the disparity between main and cc manipulated scrollbars. Bug: 1067518 Change-Id: I501c68e9993afcb4b1e097d0aafce7670d8bec4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136412 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756892}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/430f07b53422..91aecef3b39e git log 430f07b53422..91aecef3b39e --date=short --first-parent --format='%ad %ae %s' 2020-04-06 lalitm@google.com tp: add support for annotations Created with: gclient setdep -r src/third_party/perfetto@91aecef3b39e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib4fcd4420b17cd24a754cd4664108f36abaccd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756891}
-
Peter Kotwicz authored
BUG=None Change-Id: I94099f04a98d4aac77764a78367e5db8b085cad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138251Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756890}
-
Akihiro Ota authored
The new command is [Search + P + L], which prints the current node's detected and author-provided languages to the console. This is strictly a debugging feature and only works when one (or more) of the following flags have been enabled: enable-experimental-accessibility-chromevox-language-switching enable-experimental-accessibility-language-detection enable-experimental-accessibility-language-detection-dynamic Bug: 1067739 Relnotes: N/A Change-Id: Id645fde857dd5d0b7b9aa5cf6242d6aaec903e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109255 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756889}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d3bc2951dd6..afbf2aa737c8 git log 6d3bc2951dd6..afbf2aa737c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 csmartdalton@google.com Revert "Reland "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"""" 2020-04-06 csmartdalton@google.com Revert "Remove GrGLGpu mirror methods of GL draw calls" 2020-04-06 csmartdalton@google.com Revert "Rename instanceAttribSupport -> drawInstancedSupport" 2020-04-06 mtklein@google.com make gUseSkVMBlitter take over sprite draws 2020-04-06 michaelludwig@google.com Use round for morphology radius 2020-04-06 westont@google.com Modify Linux Mesa driver script for Debian 10. Will update VERSION when switching jobs to Debian10. 2020-04-06 mtklein@google.com full clamp in clip_color 2020-04-06 reed@google.com virtual for saveCamera 2020-04-06 brianosman@google.com Add usage field to SkVertices::Attribute 2020-04-06 reed@google.com simplify some HSL blend modes in skvm 2020-04-06 mtklein@google.com basic runtime color filters on skvm 2020-04-06 kjlubick@google.com [canvaskit] Handle 4x4 matrix passing ourselves. 2020-04-06 ethannicholas@google.com Tracking uniform ownership 2020-04-06 csmartdalton@google.com Rename instanceAttribSupport -> drawInstancedSupport 2020-04-06 csmartdalton@google.com Remove GrGLGpu mirror methods of GL draw calls 2020-04-06 csmartdalton@google.com Reland "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding""" 2020-04-06 mtklein@google.com first sksl on skvm 2020-04-06 reed@google.com clean up public m44 and camera api Created with: gclient setdep -r src/third_party/skia@afbf2aa737c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I3126b3f9721406c8e69b777e290d536a367367d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756888}
-
Frank Liberato authored
If we have an HDR video, send along any stream mastering metadata or display metadata to the VideoProcessor. This allows proper tone mapping on some devices, such as the Radeon 5700. Change-Id: I7b625fec44693c1abf85656c09342b1faae44ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107492 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756887}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/504782cdbabf..eda150cb2208 git log 504782cdbabf..eda150cb2208 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 jbudorick@chromium.org pinpoint: use chrome-tester@ SA when launching tests. Created with: gclient setdep -r src/third_party/catapult@eda150cb2208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068133 Tbr: nuskos@google.com Change-Id: I537a2f6803d88b93ca3f29642c3398a98c331990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756886}
-
Caroline Rising authored
This cl fixes a bug where pinned extensions where stored as the popped out extension when a popup was showing. This change also forces extension popups to close when an extension context menu is triggered, doing this makes behavior the same across all platforms and fixes a crash where the user could try to pin a popped out extension twice. Bug: 1056597 Change-Id: I9fb36625168a4196c21099a9238e3ad0f1fcc1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125550 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756885}
-
Kevin Babbitt authored
https://crrev.com/c/2117330 added tests for cross-platform accessibility hit testing code using parameterized combinations of simulated device scale factor and use-zoom-for-dsf on or off. This CL expands the parameterization to other existing hit-testing tests. To fix issues running these tests on cast_shell_linux I also made two changes to the tests themselves: - Reduce the scale factor from 2 to 1.25 - Relocate one test point to be within the screen size Bug: 1007488 Change-Id: I715270064365458ac9ec69f3c3ac81a674d2718c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135017 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756884}
-
Thomas Lukaszewicz authored
Currently CastDialogNoSinksView is implemented using a HoverButton and plays with the button's internal implementation in a way that doesn't make sense from a UX/a11y standpoint. Refactored the view to eliminate the need for HoverButtons, cleaned up the code, updated its tests. Bug: 1060448 Change-Id: Idf86635c5241367c6c9a4d1615a8c01de6ec4121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099104 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756883}
-
Lily Chen authored
ReportingCache is now told what the NIK of each parsed header is. This will eventually be passed to the ReportingHeaderParser by the caller and will correspond to the NIK of the response sending the header. The NIK fields are still empty for now, except in tests. Bug: 993805 Change-Id: I93c30932559338c6ff2173d7ecbedf3541a0d35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135829 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#756882}
-
Alexander Cooper authored
Logs a reason why the XRSession was rejected to the console. This aids developers in diagnosing what went wrong and (hopefully) how to fix it. Note that this is logged *only* to the console, and not part of the promise rejection. Also adds a couple of DVLOGs where there are very similar rejections. Also adds two new exception types where similar values were being re- used but weren't wholly accurate, and removes one that was no longer logged. Finally, renames mojom::ConsoleMessage* to mojom::blink::ConsoleMessage* due to presubmit warnings. Bug: 872316 Change-Id: I73a70ba702b80c5607ce1ce793422675d1d24686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135985 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756881}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for MoveOverlappingImpl. However, secialization is not really necessary here with templates and can be moved into MoveOverlappingImpl method without changing generated code. Bug: 819294 Change-Id: I90b893b9701748302f7b900fbcc2c341685fe0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126290Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#756880}
-
Xida Chen authored
This CL extends fps meter to show the throughput. More specifically, we show the unified throughput of the main && compositor thread for the Universal tracker. At this moment, the number will be updated every 5 seconds as long as there is a new throughput reported during the 5-second period. The result looks like: https://drive.google.com/file/d/1LUxfbK8IINxLFoPi1FoxI_IvnimrXhoR/view?usp=sharing Bug: 1064290 Change-Id: I257333c0b580eddc570eeb971d913b93256db008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135537 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756879}
-
Yue Zhang authored
Based on the error information on bots, this flaky is due to catching multiple views with id new_tab_tile in view hierarchy. This could be because during tab model switching, the check happens when the tab list recyclerView is still updating, and new tab tiles for both models are all in the view hierarchy at that moment. This CL fixes this issue by adding a wait after tab model switch to make sure the recyclerView is stable, and move the TabCountAssertion check earlier to give better error information if the test is still flaky. Bug: 1051961 Change-Id: I18181046f76a6cb60096140d5343cdb913bd6ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135951Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756878}
-
Siyu An authored
It has been approved for full rollout. Bug: 1001308 Change-Id: I61b297839078248ed85ce7b25372f1d98266dcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137993Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#756877}
-
Piotr Pawliczek authored
This is an interface of simple class that can be used as general URI parser and builder. Other CLs: - https://crrev.com/c/2118426 - https://crrev.com/c/2123640 - https://crrev.com/c/2136192 BUG=chromium:821497 TEST=on my workstation Change-Id: I143b8fbfb720dab10c6b654317f9d003e52fecdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103143 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#756876}
-
- 06 Apr, 2020 22 commits
-
-
Johann authored
https://chromium.googlesource.com/webm/libvpx.git/+log/104adb2aa3e6..1717ac939c12 $ git log 104adb2aa..1717ac939 --date=short --no-merges --format='%ad %ae %s' 2020-04-06 johannkoenig x86_abi_support: do not decorate coff functions Created with: roll-dep src/third_party/libvpx/source/libvpx Change-Id: Ib11d25b4313ba803689c9b472a11c9d810f2bd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138471 Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#756875}
-
Hongbo Song authored
The rounding precision is misunderstood, which make the e2e test for TotalInputDelay flaky. To fix this, we need to change the constant factor in the error check function. Bug: 1067320 Change-Id: I0a33af162b531db3591356b6045359054e6a6506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138002 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#756874}
-
Kenichi Ishibashi authored
The method is a wrapper of ServiceWorkerStorage::GetRegistrationsForOrigin(). This CL also adds a wrapper for GetNewRegistrationId() to test the wrapper methods. Bug: 1055677 Change-Id: Ibe04b228ca8334fff1781828720053c1bdc2fcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137102 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756873}
-
Curtis McMullan authored
This commit adds a single new method to the virtual keyboard api, SetWindowBoundsInScreen. It allows the virtual keyboard to set its own keyboard window bounds as required. BUG=1019990 Change-Id: I9b3bfdc6df85eda26a674cd8561b851a14854c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126337Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756872}
-
Johann authored
The PresentationController class does not need ExecutionContextLifecycleObserver since the mojo::Receiver was migrated to HeapMojoReceiver. The replacement wrapper includes management of the presentation_controller_receiver_. Change-Id: I1c96f897a7b604a23d3e7f0bd61a3b0598faa2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137162 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#756871}
-
Dan Harrington authored
- Added continuation token to request - Also set 'request_version' we forgot to set. Bug: 1044139 Change-Id: Ib67e8b5d08a908865aa0778343069b64ca7d6bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135337Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#756870}
-
Bo Liu authored
Commit writes and remove data before deleting the entire profile directory. There are already no WebContents associated with the profile. This is all to avoid racing with code that tries to write the profile during deletion. Bug: 1065585 Change-Id: Ic77fde85bccb7c0f79824bfc491ea6994dffdcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135053Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756869}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b1d2c8a9015..3549e2d6063c Created with: gclient setdep -r src-internal@3549e2d6063c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046880 Tbr: zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com Change-Id: I597419cfd3a20d4a6462cb2d2db65b7dbd2411d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138067Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756868}
-
Gang Wu authored
Omnibox suggestions can have image data, then later can post image data to do image search. Bug: 1055925 Change-Id: Ic7c83b10b404eee56217003f4d9c6cd1bcce1bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103081Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756867}
-
Xiaocheng Hu authored
This reverts commit 033f06d6. Reason for reland: there are new changes: 1. Fix how the loading behavior is observed. Now it's observed whenever a font is preloaded. 2. The loading behavior flag is renamed. Original change's description: > Revert "Reland "Record split UMA histograms when rendering has been delayed for font preloading"" > > This reverts commit 0e19fa7c. > > Reason for revert: should go through the normal review process > > Original change's description: > > Reland "Record split UMA histograms when rendering has been delayed for font preloading" > > > > This reverts commit 950810de. > > > > Reason for revert: Loading behavior fixed > > > > Original change's description: > > > Revert "Record split UMA histograms when rendering has been delayed for font preloading" > > > > > > This reverts commit 4a7fe529. > > > > > > Reason for revert: The loading behavior is designed wrong. > > > > > > The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is. > > > > > > Currently: the behavior is observed when rendering is delayed by font preloading. > > > > > > What's actually needed: the behavior is observed when font preloading occurs > > > > > > Original change's description: > > > > Record split UMA histograms when rendering has been delayed for font preloading > > > > > > > > This patch adds split histograms of the following metrics when > > > > rendering delay for web font preloading has been triggered: > > > > - PaintTiming.NavigationToFirstPaint > > > > - PaintTiming.NavigationToFirstContentfulPaint > > > > - PaintTiming.NavigationToLargestContentfulPaint > > > > - LayoutInstability.CumulativeShiftScore > > > > > > > > This will help us understand the effectiveness of this optimization, and > > > > adjust the length of the delay to the best value. > > > > > > > > Bug: 1040632 > > > > Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251 > > > > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > > > > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > > > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > > > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#754771} > > > > > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > > > > > Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1040632 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010 > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#755081} > > > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > > > Change-Id: Ibae7230089fe9e56e91cf1480d19c7bc70778567 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1040632 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131011 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755108} > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1040632 > Change-Id: I80ae98e1f0ec97a11f35bb2c55ad9d591f1b07b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135047 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756098} Bug: 1040632 Change-Id: I44b9ff37bf7cf75b0d4c9967cc183aa0609e4532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134887 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#756866}
-
Peng Huang authored
The hang is because fence helper is used for destroying vulkan surface asynchronously. However the platform window (X11, android or Win32 window) could be destroyed before destroying the vulkan surface which is created for the native window. It causes hang or crash. Fix the problem by calling vkWaitQueueIdle() and destroying the vulkan surface synchronously. Bug: 1062727,1062703 Change-Id: I73715fe0548221dc33cd5ffb2c266d53795dbb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138253 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756865}
-
Scott Violet authored
BUG=none TEST=doc only change Change-Id: Id3ab4abe817ea56da4a60238285a23557b6e2a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135830 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756864}
-
Tommy Li authored
This CL uses a rudimentary views::Label to display header text for AutocompleteResults that contain matches with headers. Screenshot: https://i.imgur.com/f61GxWR.png Bug: 1052522 Change-Id: I042c21a60a8416e243498793cee5c3dabeaac4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137673 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#756863}
-
Klaus Weidner authored
The render path was transferring the GpuFence for the produced shared image, but was missing the crucial step of converting it to a local GL fence and doing a server wait, apparently this was missed in a refactor. Add that, and re-enable shared image transport which was disabled in https://crrev.com/c/2135957. See example code for details: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/design/gpu_synchronization.md Bug: 1068347 Change-Id: I6fdf3e963de49dc522cb8b0323eeb86ab1a1104e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138159Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#756862}
-
Devlin Cronin authored
Remove unused constants and methods from extension_urls.h/cc. Bug: None Change-Id: Ifddcbcaff4fa9a8b6753bd3efe539dc10acbc7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131363Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756861}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c2fb0f637ece..4e3bbd9c5f1a git log c2fb0f637ece..4e3bbd9c5f1a --date=short --first-parent --format='%ad %ae %s' 2020-04-06 rharrison@google.com Start shaderc v2020.1 2020-04-06 rharrison@google.com Finalize shaderc v2020.0 2020-04-06 rharrison@google.com Update CHANGES Created with: gclient setdep -r src/third_party/shaderc/src@4e3bbd9c5f1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I4fd7b21c7aae6a71ed5928a041c62f8d3e0afcaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138059Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756860}
-
Tom Sepez authored
Change-Id: I2844e801f9dc28fb2673b0b7b2df0f180fd14ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138118 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756859}
-
Thomas Lukaszewicz authored
Fixed a performance regression of ~1.3-1.8% in frame times by deferring updating the BubbleDialogDelegateView's |anchor_widget_| until the bubble needs to be created rather than every time the view is added to a new Widget. Bug: 1064717 Change-Id: I349b4dc6750db107d1d73c561c5cab64d837c403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128976 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756858}
-
Jakob Gruber authored
The histogram will help us evaluate upcoming work. The counter was originally added in https://crrev.com/c/1871601. Bug: v8:9892 Change-Id: I96e11d1ea8bedf8146ba77daaa4d46730af3bb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128108 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756857}
-
Keishi Hattori authored
There is a chance that the HeapMojoReceiver::Wrapper may outlive the Owner in case of a ConservativeGC. The stack scanning may create a root to HeapMojoReceiver::Wrapper, prolonging its life. To make sure they die together in the same GC cycle, we will make the Wrapper retain the Owner. So in case HeapMojoReceiver::Wrapper is kept alive, the Owner is guaranteed to be alive too. Bug: 1067476 Change-Id: I6456c368dc2ad446a627d1b75102bd42a5770c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134093 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756856}
-
David Bertoni authored
The ServiceWorkerBasedBackgroundTest.TabsOnUpdatedSpanning was flaky due to unexpected sync issues between the browser and the renderer. This CL changes the implementation so the renderer pushes the results to the browser, rather than the browser pulling the results from the renderer. This passed 3000 iterations on the try bots with no flakes. Bug: 1003244 Change-Id: I8a1c3c0ed7427535210d9d8cabac5d8b9ddb17cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131362Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756855}
-
David Munro authored
Test: CQ Bug: chromium:1064512 Change-Id: I2cd99ab4db524adb32d5d591ba9174597e089755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137187Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#756854}
-