- 24 Jul, 2019 40 commits
-
-
Natalie Chouinard authored
Migrate the Main, Sign In and Sync Preference settings pages from the deprecated Framework preferences to the Support Library. These are the last PreferenceFragments to migrate, so we recoup some of the binary size and method count regression here. Note: I migrated SyncCustomizationFragment and its tests before realizing they're now unused (https://crbug.com/978908). However, SyncCustomizationFragmentTest now fail on release builds (including try-bots) due to proguard shrinking, so I've @Ignored them all for now, rather than add unnecessary -keep flags until crbug.com/890847 is done. Bug: 968592, 972581 Change-Id: Ie928f54eae84bd3d56428271463ac55f627d9f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708895Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#680490}
-
Jun Cai authored
This CL adds a "Continue" button based on the following UI mocks: https://github.com/samuelgoto/sms-receiver#opt-in-ux This CL also updates SmsService to allow at most one pending SMS request. Bug: 983323, 985438 Change-Id: I34b6f3568cf4332030bed56ad1995e28f5e21376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703928Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#680489}
-
Sylvain Defresne authored
Instead of creating a TestingProfile with custom factories, create fake for the required services and pass them directly to the code that is tested. This makes the tests simpler (as they do not have to create a full TestingProfile but only need to create the necessary services). It required adding an overload of sync_ui_util::GetStatusLabels() that received the services instead of accessing them via their factories. Bug: 984487 Change-Id: Ia596fb46b9915e240bfce2ef2e4ee888c99e16c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715297 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#680488}
-
googlechrome://...`Mike West authored
Bug: 831761 Change-Id: Ibebe1585d06f16a94bc7bdb47c952e3cbefd981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705792Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#680487}
-
Erik Jensen authored
The WebRTC library supports sending messages up to 256KiB, but Chrome currently only seems to support receiving messages up to 64KiB. As a result, any messages larger than 64KiB and smaller than 256KiB cause the connection to terminate. For now, cap the size of clipboard messages to 64KiB to avoid the disconnection issue until Chrome properly supports larger messages or we switch to a stream-based channel with our own message framing. Change-Id: Iecfca67b82104cbda46e45599490a2538b91f1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715099 Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#680486}
-
A Olsen authored
Removed frame from system dialog - title and X are not shown. Added title and X back at the HTML level, inside a cr-dialog for styling. Dialog no longer needs profile to be initialized, since it now happens at the webui level. Internal screenshot is found here: 3_hosted_change.png at http://go/insessionpwchange-screenshots Bug: 930109 Change-Id: I7a93d7e856a9019ad201d072d8a0eacbd255d262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715355 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680485}
-
Jeffrey Cohen authored
Bug: 986536 Change-Id: Idcdd36bfe4db04422c12629a7252aae479819671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715744Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#680484}
-
James Cook authored
This reverts commit fdbb564b. Reason for revert: We're changing the section back to "Search and assistant", so we're going back to the magnifying glass icon. Original change's description: > SplitSettings: Use assistant icon for assistant section > > OS settings doesn't control search engine, so don't use a magnifying > glass icon. Use the assistant icon instead. > > See bug for screenshot. > > Bug: 960937 > Change-Id: Icd2929a76572468df4d6615166c4b9d2782c4c36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674641 > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671859} TBR=jamescook@chromium.org,stevenjb@chromium.org Bug: 960937 Change-Id: Ic99f8b98f2f782bdcb3535e35cd9158c06cc25ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716915Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#680483}
-
chrome://inspectDonna Wu authored
Bug: 987002 Change-Id: I26cac0a7d9db6b47339eae5953ca11c99200c432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716396 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#680482}
-
Leon Han authored
Previously we already have a check in the renderer process that WebNFC API should only be used from top level browsing contexts (main frames). In additional, this CL adds the same check into the browser process as well because only the browser process is the trusted one. BUG=520391 Change-Id: Ia79e3b474974126b272e3af1849afb34dd6c993b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712426 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680481}
-
Hector Carmona authored
Bug: 973686 Change-Id: I7e2b6696785e9009d9a8904ed87105c281d34b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715966Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#680480}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9c500b31ad8..46593a3742be Created with: gclient setdep -r src-internal@46593a3742be The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Id0c2029d9182fb0715de256b2c39d6a8fdd7e9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716243Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680479}
-
chrome://process-internalsAlex Moshchuk authored
We clear stored isolated origins whenever the user clears cookies and history, not cache. Bug: 920911, 850087 Change-Id: I202c4b67999516f263b7f042146d16aed0416d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715239 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#680478}
-
Robbie Gibson authored
Essentially, for each color in question, this creates a new colorset that is only the dark mode variant of the color always. Then, if we're running on iOS 12 and in incognito, we return that new color. Bug: 976643 Change-Id: I14ede8cb4280af7f960d53880712d74f8e4564b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710539Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#680477}
-
Katie D authored
This fixes a bug where users feel like it's hard to hit the close button within the scroll pad. Bug: 984669 Change-Id: I6f241afc011a1e713e74c87f00dba364fe895fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715549 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#680476}
-
Andres Calderon Jaramillo authored
This CL adds support for the case when the result of an accelerated image decode is NV12 (currently, only YV12 is supported). This makes it possible to use VAAPI JPEG decode acceleration in the Intel iHD driver for YUV 4:2:0 JPEGs. It also makes it possible to use VAAPI-accelerated WebP decoding [1,2] since the expected result of a decode there is in NV12. [1] https://tinyurl.com/vaapi-webp-decode-acceleration [2] https://crbug.com/877694 Test: parameterized relevant tests to test both YV12 and NV12 decodes. Bug: 982147 Change-Id: Ia87a0eca18f9b355859b88a8f03a385132e165b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707833 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#680475}
-
Weiliang Chen authored
Share SchedulerSequence implementation between command buffer task executor and skia output surface dependency. Also refactor Android WebView to make sure skia output surface dependency there does not need to be depended on command buffer task executor. Bug: 979788 Change-Id: I0ae966397a93cd82945ffa249328b28fc6da7dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715084 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680474}
-
Lei Zhang authored
If the ENABLE_SERVICE_DISCOVERY build flag is not set, then this code will never work correctly, because DnsSdRegistry will not pass in a valid ServiceDiscoverySharedClient. So just make Discover() a no-op in this case, guarded by ENABLE_SERVICE_DISCOVERY. This in turn, makes some DnsSdDeviceLister member variables only used when ENABLE_SERVICE_DISCOVERY is set, so guard them by the same build flag. Bug: 757530 Change-Id: I2f0864e1342be3d6328fbf449dc2296825fe1fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716102Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#680473}
-
Aaron Colwell authored
This change allows a top-level empty SiteInstance to become the default SiteInstance if the URL for the top-level frame does not require a dedicated process. This allows the top-level frame and any subframes that do not require a dedicated process to share the same default SiteInstance process. Bug: 958060,78757 Change-Id: I920860b822474157897a0f3e3534cca87984599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693778 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680472}
-
Brandon Wylie authored
Queries favicons to show for non-google search engines. This favicon will only be available after the user has navigated to the search engine the first time. Bug: 973150,982430 Change-Id: I16bddb08334aa26f0a1f976abc7df19a2ed79cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705176 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#680471}
-
David Bokan authored
When a FlingCancel event is received, we set a timeout (50ms) during which we may decide to boost the next fling. If an eligable fling begins before this timeout expires, it will be boosted. As gesture events arrive they can extend this timeout. This bug was occuring because we were only cancelling the boost in a GestureScrollUpdate. When a GestureScrollBegin arrives, regardless of how long after the GestureFlingCancel, it would extend the timeout to 50ms past the GSB. The fix in this CL is to first check whether the timeout expired before observing any gesture events and cancelling the boost. This ensures we'll cancel the fling regardless of the event order. This restores the behavior prior to https://crrev.com/c/1630537 which caused this to regress. Bug: 979016 Change-Id: I7a8e01a46d6a77f97c4c76376eb5af433696489d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713278 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680470}
-
Gabriel Charette authored
Per discussion @ https://groups.google.com/a/chromium.org/d/msg/scheduler-dev/X83HjSx32dI/6cH6L0MsEAAJ R=carlscab@chromium.org Bug: None Change-Id: Id6191dffe2b2572576d4f001be800bc3ac74cc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716914 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#680469}
-
Tim Judkins authored
The extensions internals unittest relies on using the automation API permission as an example of a manifest permission. Since this API is restricted to the dev channel, it caused failures on trunk tests. To solve this the feature channel is set manually for that particular test. Bug: 986791 Change-Id: Ib107847f2c5eda6333a705e1f99a6e3e69e1f02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716245Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#680468}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f564f1515bde..fdf4bfe6d389 git log f564f1515bde..fdf4bfe6d389 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 halcanary@google.com SkQP: Refactor Java method SkQP.runTests() Created with: gclient setdep -r src/third_party/skia@fdf4bfe6d389 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: Ie87664bbee3a2689e9aded26a1b9450b7f185168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680467}
-
Yue Zhang authored
https://crrev.com/c/1666270 this CL uses recyclerView.removeViewAt to manually remove dropped view and avoid calling notifyDataSetChanged(). However, removing using index can be problematic if there are scrolling and recycling in recyclerView. This CL fixes this issue. Bug: 985904 Change-Id: I207206bbd4830b1762bfd1a22f998b2617f43fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714215Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680466}
-
Aga Wronska authored
Bug: 939593 Change-Id: Ifb09f92e3188c161038557f6c2384a1f1a6c4d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713866Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#680465}
-
Stephane Zermatten authored
AA Dropout metrics don't make much sense when direct actions are used to trigger scripts. This change turns them off in a way that keeps the guarantee that dropouts are tracked if and only if AA_START was recorded, which is done in the Facade, just before calling Start. In other cases, dropouts are not measured yet. There should be some separate metrics for tracking scripts started by direct actions. Bug: b/138288747 Change-Id: If6792b6173983a289ce08978d52d68bd3c161dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715693 Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#680464}
-
Yue Zhang authored
Bug: 986849 Change-Id: I718c19178ac078414cd773f657c64000ad61cdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715225Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680463}
-
Peng Huang authored
Bug: 985024 Change-Id: Idca21625c38971fc53c58cfa9d644aedf1bbe7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716303 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#680462}
-
Salvador Guerrero authored
LevelDB.ApproximateMemTableMemoryUse helps us track memory usage for leveldb_proto databases, as we'll migrate clients from multiple instances to a single shared instance this histogram will be useful to track possible performance regressions. This CL extends the histogram's expiration by 1 year, and replaces ssid@ with salg@ as an owner. Bug: 986506 Change-Id: I30c472c8ccc3df844de85e6890e17e2ce0dc0234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715543Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#680461}
-
Becca Hughes authored
This is follow up from https://crrev.com/c/1706777 Replaces last updated time with base::TimeTicks. BUG=986542 Change-Id: Icfda207848085a7b7d15c87b3fcf94c87eee3609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715504 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680460}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I6fdac09b795461c2f1de6be177b2ce141fcab529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715006 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680459}
-
Becca Hughes authored
Adds position state to WMPI. This is a combination of playback rate, duration and current time and is used to display the playback position in the UI. The next step is sending this to the browser process. BUG=985394 Change-Id: I76a3671d6357d5fb620e05857e3519de6707fbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706777Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680458}
-
BUG=762641 TBR=malaykeshav@google.com Change-Id: If8925fc68ccf05d43ce1ade9ef631bfc2745622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716177Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#680457}
-
Yi Su authored
ContentSuggestionsService now can possibly return ContentSuggestion objects with empty |salient_image_url| if the image is not allowed to be displayed due to EUCD compliance. If the image URL is not valid, ContentSuggestionsItem.hasImage should be set to NO so that ContentSuggestionCell will use the new layout without image placeholder. The layout of ContentSuggestionCell when feature flag kOptionalArticleThumbnail is enabled is also changed a bit. The subtitle will now attach to the bottom of the main title instead of the bottom of the cell. Notice that under normal font size and when image is missing, the minimum height of the cell is still default-image-height+2*margin, which means there might be some extra space at the bottom of the cell. screenshots: normal-font-top https://drive.google.com/open?id=1uYBuv935wem-Q6UC6dMWSHNa-BHS754j normal-font-bottom https://drive.google.com/open?id=1Yb9vALnGV1w7wmqysL-6_df1cuYeTd7Z a11y-font-top https://drive.google.com/open?id=1totdzFd9DAEAsQL4mKeO-kpVa1yNjChs a11y-font-bottom https://drive.google.com/open?id=1U6lgtNVKMTrowvkgYIuTGlQxY-8UQgKb Bug: 978061 Change-Id: I5ca3f2de7d8304ae48d309180c36b4d466c4a75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715371Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680456}
-
Junbo Ke authored
ResourceDispatcherHostDelegate is deprecated in network service path. Bug: 985873 Test: build cast_shell Change-Id: Ibb34749c6b01c969fb61d91b286593ad7af6edb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716284Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#680455}
-
Aga Wronska authored
The tests used to be flaky. Re-enabling them to check if they are still flaky after code mauve. (Code mauve did changes to login tests building blocks) Bug: 936407 Change-Id: I7dc8102ac6fe7e75c47deb028fb4cf2de0dc631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714024Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#680454}
-
Ren-Pei Zeng authored
When creating VASurface from VideoFrame in VaapiDmaBufVideoFrameMapper, remove the usage of VaapiPicture to avoid pulling Ozone/EGL specific codes. Bug: b:120057531 Test: video_decode_accelerator_tests Change-Id: Iaad5abb53a84901734d330a341ed265bb9cf8e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701661 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680453}
-
Samuel Huang authored
To prepare for handling native resource loading after DFM installation, this CL adds a new hook in ModuleInstallerBackend.onFinished() to call (via JNI) a new native handler for each newly installed module: JNI_ModuleInstallerBackend_OnInstallModule() AsyncTask is used to make the JNI call asynchronous, taking place outside the UI thread. This allows file access (e.g., to open native resources) to take place in the native code, thereby preventing assert failure in Debug builds. After the JNI call, |mListener.onFinished()| is called on UI thread, just like before. Bug: 927131 Change-Id: I36880cc7739a48534052b51d3d655d1ae0beb29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702905 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#680452}
-
Andrew Grieve authored
Change-Id: Ia041cfab55543c476f85ed92e0f82812ce1e011d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716917 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#680451}
-