- 06 Dec, 2018 40 commits
-
-
Anthony Vallee-Dubois authored
The feature is disabled by default, no config currently applies, and it was decided to stop collecting these events. This removes the iOS portion of the code because it allows removing a translate -> sync dependency that was preventing another change from landing. Bug: 896719,911781 Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99 Reviewed-on: https://chromium-review.googlesource.com/c/1361927Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#614385}
-
Clemens Arbesser authored
Before: https://screenshot.googleplex.com/ESkLNquDXJd.png After: https://screenshot.googleplex.com/tEssthOhzV9.png Bug: 806868 Change-Id: I628e6aaa3bf11f453096c80dfc05266393db6ede Reviewed-on: https://chromium-review.googlesource.com/c/1365435Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#614384}
-
Mason Freed authored
Prior to this CL, opacity and filters applied to the backdrop-filtered element did not get applied to the backdrop-filtered backdrop. Now, the opacity and filters get applied directly to the backdrop-filtered image directly, which is an approximation but should be very close. Also fixed up a few of the backdrop-filter tests to account for this, and removed a few lines from TestExpectations that now work. Bug: 497522, 524689 Change-Id: If671bdf65ac0ae04cf175143eb8949ff4be0837b Reviewed-on: https://chromium-review.googlesource.com/c/1357626Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#614383}
-
Takuto Ikuta authored
Change-Id: I801fad16f64b1cce56ea5ecb1aced0e93bf992cd Reviewed-on: https://chromium-review.googlesource.com/c/1364935Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#614382}
-
Elly Fong-Jones authored
This flag is not used anywhere in the code. Bug: 912155 Change-Id: I38343c739a2fc2580aa04f9bf120ab0b74ba6929 Reviewed-on: https://chromium-review.googlesource.com/c/1363436Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#614381}
-
Takuto Ikuta authored
go swarming client have different directory structure of task outputs from python. In go client, directory name of task output become task_id, not shard index like in python. let me support both directory structure during migration. This is cherry-pick of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1360817 This is to prevent infra failure like https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/145571 Bug: 894045 Change-Id: I91da3b0b99ea7a984852ee76f20a09f23e9f490e Reviewed-on: https://chromium-review.googlesource.com/c/1364995Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#614380}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/628f37a6fe24..18f0c3c038fc git log 628f37a6fe24..18f0c3c038fc --date=short --no-merges --format='%ad %ae %s' 2018-12-06 solenberg@webrtc.org Add RegisterAudioSendPayload() method 2018-12-06 nisse@webrtc.org Use opaque int as payload_type in MediaTransportInterface 2018-12-06 artit@webrtc.org Fix iOS version for internal.client.webrtc perf test 2018-12-06 terelius@webrtc.org Fix performance bug in CreateSendSideBweSimulationGraph Created with: gclient setdep -r src/third_party/webrtc@18f0c3c038fc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifbb867efd8a5e86d9623621b8f48610c342a9aa9 Reviewed-on: https://chromium-review.googlesource.com/c/1365425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614379}
-
Anders Hartvoll Ruud authored
Now that we have an object that can represent both native property names and custom property names, let's use it. Sidenote: the reification functions in StyleValueFactory can not take CSSProperty instances. This is because reification needs to happen on worklets, where we don't have the context of a Document (which again is needed to access the property registry). There should be no behavior change in this CL. Change-Id: I0d39a8e83628389699003bb7998548267635dffd Reviewed-on: https://chromium-review.googlesource.com/c/1361041 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614378}
-
jdoerrie authored
This change applies clang-tidy's modernize-loop-convert [1] in /base/i18n. Reproduction steps: - run clang-tidy's modernize-loop-convert - run git cl format - manually remove unused constants due to -Wunused-const-variable [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html This CL was uploaded by git cl split. R=jshin@chromium.org Bug: 895746 Change-Id: I9b9790b60aaca3f6afb2b4bd1109d800aec5b26a Reviewed-on: https://chromium-review.googlesource.com/c/1282404 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#614377}
-
Yi Su authored
This CL changes the _weakDelegate of PasswordDetailsTableViewController from an instance var to a property, and replaces the mock class in PasswordDetailsTableViewControllerUnittest with OCMock. Bug: 894791 Change-Id: I1cbb95e2f8aa3fb6befd3010040b0fe1ff4463d9 Reviewed-on: https://chromium-review.googlesource.com/c/1361245 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#614376}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6a1cb2d8968..06b4f7386a8c git log f6a1cb2d8968..06b4f7386a8c --date=short --no-merges --format='%ad %ae %s' 2018-12-06 primiano@google.com Merge "Implement ftrace flushing" 2018-12-06 eseckler@google.com Merge "tracing service: Verify target buffers specified in commit requests" 2018-12-06 eseckler@google.com Merge "trace writer: Register/unregister on writer creation/destruction" 2018-12-06 eseckler@google.com Merge "trace writer: Set the kChunkNeedsPatching flag when necessary" Created with: gclient setdep -r src/third_party/perfetto@06b4f7386a8c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idda6e5efcff897194b1a51547934631761a92561 Reviewed-on: https://chromium-review.googlesource.com/c/1365427Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Icbd30eb1886bb00105cd8ae5a8b158ffa9a397ea Reviewed-on: https://chromium-review.googlesource.com/c/1352427Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#614374}
-
Vladimir Levin authored
This patch ensures that we do layout in a pending frame rect, which is only put in place for children of the locked element during layout. After the promise is resolved, we put the pending frame rect as the active one and ensure that we relayout the previously locked box itself. This means that if the promise resolution, for example, removed the element as is the case in https://docs.google.com/document/d/1VrcVA5JyBmYn0Yi4wjPt1l9ce5Mhf-zu6o63p_mt98w/edit Then we never commit what was a pending layout and never see a flash of laid out content. R=chrishtr@chromium.org, mstensho@chromium.org Bug: 907613, 882663 Change-Id: I7d03ae73ea4cb96c17ce8bb4162718155c2072be Reviewed-on: https://chromium-review.googlesource.com/c/1358969Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614373}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/bdd887fce76c..5aacd29d5e7e git log bdd887fce76c..5aacd29d5e7e --date=short --no-merges --format='%ad %ae %s' 2018-12-06 cwallez@chromium.org ProcTable: only cast the return value if needed. Created with: gclient setdep -r src/third_party/dawn@5aacd29d5e7e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I629fa6a92ef21293c055a467c0becb4c16cc13bb Reviewed-on: https://chromium-review.googlesource.com/c/1365424Reviewed-by:
-
Jeremy Roman authored
The comment is added because it is clearly tempting to rely on these counters to provide an accurate count of the number of instances that exist across threads, but that is not something that can be computed with atomics (which do not provide mutual exclusion). It doesn't appear that these atomics intend to synchronize any other memory access (and in fact in many cases are used only from a single thread). Bug: 736037 Change-Id: I2372ae73878361024779aadb39a72983f4faa3bb Reviewed-on: https://chromium-review.googlesource.com/c/1355885Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#614371}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44685896babc..3803956c4af7 Created with: gclient setdep -r src-internal@3803956c4af7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62764da8eaf39f1e4804b1100243cd8038fa6046 Reviewed-on: https://chromium-review.googlesource.com/c/1365426Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614370}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I3fcddf556b24d65f93a7d575093d89ab45e5e22e Reviewed-on: https://chromium-review.googlesource.com/c/1352783Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#614369}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I4525159fc6e326db0f77bd38a1a8cca63ae9ab28 Reviewed-on: https://chromium-review.googlesource.com/c/1352764 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#614368}
-
Clemens Arbesser authored
Note that this URL is currently under construction, the corresponding issue is here: b/120547988 Bug: 806868 Change-Id: Ic7ecf90682c392cbe7762ec451570e651e4f5f79 Reviewed-on: https://chromium-review.googlesource.com/c/1365446Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#614367}
-
Yi Gu authored
By spec [1], an animation effect is "in effect" if its active time is not unresolved. However, if the effect is in the "after phase" and its fill mode is neither "forwards" nor "both", its active time should be unresolved which makes the effect not "in effect". Our cc logic doesn't handle this case correctly. This bug was not exposed because for regular animations we cancel the animation on compositor in such scenario. But for worklet animations that's not the case. This patch adds the logic of calculating phases and the corresponding active time based on the spec [2]. [1] https://drafts.csswg.org/web-animations/#in-effect [2] https://drafts.csswg.org/web-animations/#active-time Bug: 906675 Change-Id: I8872719432ede1eeeb1e7bdcf3b5f0312787c0d7 Reviewed-on: https://chromium-review.googlesource.com/c/1342598 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#614366}
-
Peng Huang authored
Bug: 911793 Change-Id: I937e902d7e9ff7e046710558e48e4765b3ec06ee Reviewed-on: https://chromium-review.googlesource.com/c/1363864Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#614365}
-
Xiyuan Xia authored
- Move RestoreFocus from BrowserView::Show to OnWidgetActivationChanged to do it when the browser window is activated; - Remove SetInitialFocus in SessionRestoreImpl::ShowBrowser since BrowserView change should do that as part of RestoreFocus; - Also remove the debugging code for SetInitialFocus crash under SessionRestoreImpl::RestoreTab since ShowBrowser no longer calls SetInitialFocus; Bug: 859257, 850626, 908524 Change-Id: Ia24e4d68e1386de84765f914bb75319c9887dfd1 Reviewed-on: https://chromium-review.googlesource.com/c/1313728 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#614364}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b7ab595d908..b45d5124816e git log 7b7ab595d908..b45d5124816e --date=short --no-merges --format='%ad %ae %s' 2018-12-06 halcanary@google.com bin/sysopen: script moved to bin 2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8f1b7a66a5e3..d300548fcc28 (1 commits) Created with: gclient setdep -r src/third_party/skia@b45d5124816e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I3d2ffa675f1a4bc1a9509ab85ecb6c7b974dc5f9 Reviewed-on: https://chromium-review.googlesource.com/c/1365423Reviewed-by:
-
Noel Gordon authored
- remove list_thumbnail_loader_unittest.html - add BUILD rules to auto-generate and compile this unittest - add @types to the unittest vars - inline the canvas dataURL image creation step in Setup() - fix all Closure compiler errors No change in test behavior, no new tests. Bug: 912557 Change-Id: I157b0c1ef56704901e760e6f5125e4e05ea76377 Reviewed-on: https://chromium-review.googlesource.com/c/1364999 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#614362}
-
Raphael Kubo da Costa authored
This test requires MP4 support in content_shell; that's not enabled by default and breaks WPT imports. TBR=chcunningham@chromium.org, wolenetz@chromium.org No-Try: true Change-Id: I3f176312cec46c8ef03dad5d40106c721b0f9723 Reviewed-on: https://chromium-review.googlesource.com/c/1365613Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#614361}
-
Nicolas Pena authored
This CL makes PerformanceEventTiming IDL consistent with the spec, after https://github.com/WICG/event-timing/pull/16. Note that EventCount is not yet implemented. Bug: 823744 Change-Id: I01779ed82cba0cfea0542ab74cc95b4e7adc8aac Reviewed-on: https://chromium-review.googlesource.com/c/1363961Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#614360}
-
Takuto Ikuta authored
Bug: 851596 Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547 Reviewed-on: https://chromium-review.googlesource.com/c/1364976 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
This fixes the GCC build after commit b6ef3ba2 ("Pass GpuPreferences to in-process GPU in Mash"): In file included from ../../content/utility/utility_service_factory.h:12, from ../../content/utility/utility_service_factory.cc:5: ../../base/memory/scoped_refptr.h: In instantiation of ‘static void scoped_refptr<T>::Release(T*) [with T = gl::GLSurface]’: ../../base/memory/scoped_refptr.h:208:14: required from ‘scoped_refptr<T>::~scoped_refptr() [with T = gl::GLSurface]’ ../../gpu/ipc/service/gpu_init.h:70:48: required from here ../../base/memory/scoped_refptr.h:284:8: error: invalid use of incomplete type ‘class gl::GLSurface’ ptr->Release(); ~~~~~^~~~~~~ In file included from ../../services/viz/service.h:8, from ../../content/utility/utility_service_factory.cc:35: ../../gpu/ipc/service/gpu_init.h:22:7: note: forward declaration of ‘class gl::GLSurface’ class GLSurface; ^~~~~~~~~ gpu_init.h forward-declares gl::GLSurface but using std::move() with GCC seems to require a full declaration for things to work. Bug: 819294 Change-Id: Ib22ca2f8af6977869571292acf780042507a8afd Reviewed-on: https://chromium-review.googlesource.com/c/1365249Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#614358}
-
Sergey Kuznetsov authored
Otherwise dangling pointers are leave - this can affect other tests. For example, if some test uses content::TestBrowserThreadBundle and runs after AndroidWebViewStateSerializerTest, this test will fail. Change-Id: Ic39f5e10a68a232ca2b3d58dcd21dc61bab29e43 Reviewed-on: https://chromium-review.googlesource.com/c/1354445 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614357}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/03afee3b9081..2e4563d94f9d git log 03afee3b9081..2e4563d94f9d --date=short --no-merges --format='%ad %ae %s' 2018-12-06 stevenperron@google.com Document in the context what happens with id overflow. (#2159) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2e4563d94f9d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3d9b965d9a72ca7f3180c5a14e4ed28a7ce905db Reviewed-on: https://chromium-review.googlesource.com/c/1365422Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/659c1b009ec3..f6a1cb2d8968 git log 659c1b009ec3..f6a1cb2d8968 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 lalitm@google.com Merge "trace_processor: speed up args table even more" Created with: gclient setdep -r src/third_party/perfetto@f6a1cb2d8968 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iefd01cf34bed9c2c688570386aa10a75fdaa45f4 Reviewed-on: https://chromium-review.googlesource.com/c/1365421Reviewed-by:
-
Andreea Costinas authored
BUG=498579 Change-Id: I0ef207bbcf210de686902b2248f4e0c96453b707 Reviewed-on: https://chromium-review.googlesource.com/c/1365236 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#614354}
-
Yi Su authored
In current implementation of find_in_page.js, when user navigates to a match result out of the screen, the orange highlight will be added to it with a 250ms delay. In previous version, the callback invoked after 250ms will always add orange highlight to the current selected match result, and the CL(http://crrev/c/1347363) accidently changed the logic and created a bug. If user clicks "goNext" fast enough, selected match result may get highlighted permanently. However, after deeper investigation, the delayed highlight seems to be buggy from the begining. Navigating backward to a match result that is inside the screen will also meets the condition and trigger the delay, but the 250ms is just too short to be noticed. Besides, why we need the delay is also mysterious, and here is my guess: In ancient time the find_in_page.js do two things, first scroll to the match result and then do the highlight, and somehow UIWebView requires us to add a delay(see the comments in old version code). Then the scrolling work moved from Js into OC, so there are two lines about scrolling that are commented out. Since UX has also confirmed that delay on highlight is not necessary, it should be removed now. Bug: 911611 Change-Id: If0fef219b33954e243e527f3b50dbe836f753ede Reviewed-on: https://chromium-review.googlesource.com/c/1365610Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614353}
-
Andrew Grieve authored
Bug: 908479 Change-Id: I6b6d50319143a5b4135c446d7723d6a70fc3fecc Reviewed-on: https://chromium-review.googlesource.com/c/1364610Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#614352}
-
Alex Clarke authored
This test currently relies upon the exact ordering of RenderFrame, InjectFrame and CheckForFrameChanges, which is a mix of delayed and immediate tasks. The scheduler doesn't guarantee the exact ordering of these which causes this test to flake. We add some extra RunLoop().RunUntilIdle() calls to ensure CheckForFrameChanges has a chance to run. TBR=miu@chromium.org Bug: 863341, 891670 Change-Id: I526d6b77f6ce46f04d84584f5daba096ef1a98e5 Reviewed-on: https://chromium-review.googlesource.com/c/1365248Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#614351}
-
Dominick Ng authored
BUG=None Change-Id: Ie6bcdd0b88fd32f8416871f58381cd88f2b6e234 Reviewed-on: https://chromium-review.googlesource.com/c/1364650 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614350}
-
Takuto Ikuta authored
This is to simplify DEPS and enforce to use the same revision for each luci-go client. Change-Id: Ibb642840e09fe83f8736dbf86ab73f00154b0843 Reviewed-on: https://chromium-review.googlesource.com/c/1364998Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d138913917ce..71928dd258ca git log d138913917ce..71928dd258ca --date=short --no-merges --format='%ad %ae %s' 2018-12-06 dhanyaganesh@chromium.org lib/cidb.py: Delete functions used in bad_cl_detector Created with: gclient setdep -r src/third_party/chromite@71928dd258ca The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ice83d4eef69c02fcd84486fabe2d28c58eed7cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1365419Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 911415 Change-Id: Ifab02f8eccba1f2501400150d9aa563e88f44ac8 Reviewed-on: https://chromium-review.googlesource.com/c/1365105 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#614347}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8807e6de3a17..44685896babc Created with: gclient setdep -r src-internal@44685896babc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If1245f560fc46b4b68ad7243540bdeaaf2b309ad Reviewed-on: https://chromium-review.googlesource.com/c/1365420Reviewed-by:
-
