- 30 Jan, 2014 40 commits
-
-
yukishiino@chromium.org authored
As part of effort to support multiple fonts, this CL changes methods which are now taking gfx::Font so they will take gfx::FontList instead. See https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/view BUG=265485 TEST=Run unit_tests, ui_unittests, views_unittests. Review URL: https://codereview.chromium.org/149383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247920 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=166036:166074&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/149213007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247919 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=337998 Review URL: https://codereview.chromium.org/148273010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247918 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
WebContentsImpl's dtor calls End() but it may not cause set_listener(NULL) in some case, which may cause a use-after-free. This CL always reset them at End(). This would mean DidEndColorChooser() may be called twice, so web_contents_ has to be reset to NULL once DidEndColorChooser() is called. BUG=338464 R=keishi@chromium.org Review URL: https://codereview.chromium.org/148223009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247917 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
Review URL: https://codereview.chromium.org/144633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247915 0039d316-1c4b-4281-b951-d872f2087c98
-
bustamante@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/148283009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247913 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=330567 TEST=TBD Review URL: https://codereview.chromium.org/144423006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247912 0039d316-1c4b-4281-b951-d872f2087c98
-
miletus@chromium.org authored
When parsing tracing data into timeline model, also find the browser process and save it into timeline model. This is to support querying async slices starting in browser process. BUG=246034 TEST=Run telemetry smoothness test and make sure input latency trace can be retrieved from querying async slices on browser process. Review URL: https://codereview.chromium.org/144423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247911 0039d316-1c4b-4281-b951-d872f2087c98 -
noms@chromium.org authored
- the bottom options buttons get a blue background when hovered over - corrected the spacing between a button's image and its title. - s/makeAccountButtonWithRect/accountButtonWithRect/g to be consistent with the other control-making methods. Screenshot: https://drive.google.com/file/d/0B1B1Up4p2NRMeERscUNleHNMWWc/edit?usp=sharing BUG=324036 Review URL: https://codereview.chromium.org/132903016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247910 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@chromium.org authored
This cl is pure style-targeted refactoring. No functional changes were made. BUG=339176 Review URL: https://codereview.chromium.org/149093008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247909 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@chromium.org authored
This cl is pure style-targeted refactoring. No functional changes were made. BUG=339176 Review URL: https://codereview.chromium.org/149703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247908 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@chromium.org authored
This cl is pure style-targeted refactoring. No functional changes were made. BUG=339176 Review URL: https://codereview.chromium.org/149253008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247907 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
When relaunching from Metro there is a lengthier time-window where BrowserProcess::IsShuttingDown() is false, but browser_shutdown::IsTryingToQuit() is true. If the app launcher delayed warmup (and the non-delayed asynchronous profile load it triggers) is unlucky enough to get scheduled here, then it can create a window after Widget::CloseAllSecondaryWidgets() has been called on the shutdown path, which otherwise would have mopped up the app launcher resources. Checking browser_shutdown::IsTryingToQuit ensures the app launcher window won't be created after Widget::CloseAllSecondaryWidgets() would have been called during shutdown. BUG=333350 Review URL: https://codereview.chromium.org/149323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247906 0039d316-1c4b-4281-b951-d872f2087c98
-
tsepez@chromium.org authored
This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Review URL: https://codereview.chromium.org/149073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247905 0039d316-1c4b-4281-b951-d872f2087c98
-
pilgrim@chromium.org authored
BUG=338338 Review URL: https://codereview.chromium.org/148333009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247904 0039d316-1c4b-4281-b951-d872f2087c98
-
bshe@chromium.org authored
BUG=NONE Review URL: https://codereview.chromium.org/147033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247903 0039d316-1c4b-4281-b951-d872f2087c98
-
nya@google.com authored
Android Chrome needs to learn whether or not WebContentsObserver::DidFinishLoad() has been called on the prerendered WebContents during the call to CoreTabHelperDelegate::SwapTabContents() here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/prerender/prerender_manager.cc&l=634&q=prerendermanager&type=cs&sq=package:chromium BUG=335479 Review URL: https://codereview.chromium.org/143463012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247902 0039d316-1c4b-4281-b951-d872f2087c98
-
craigdh@chromium.org authored
[chromedriver] Write command line file to both /data/local and /data/local/tmp for Chrome on Android. This supports the new feature where setting chrome as the debug app causes Chrome to look for the command line file in tmp. BUG=chromedriver:665 TEST=None Review URL: https://codereview.chromium.org/138873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247901 0039d316-1c4b-4281-b951-d872f2087c98
-
pearlchen@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/149543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247900 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=324859 Review URL: https://codereview.chromium.org/139903006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247899 0039d316-1c4b-4281-b951-d872f2087c98
-
plundblad@chromium.org authored
Follow-up to r246358. BUG=338341 R=avi@chromium.org TBR=pkasting@chromium.org Review URL: https://codereview.chromium.org/137833009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247898 0039d316-1c4b-4281-b951-d872f2087c98
-
tengs@chromium.org authored
BUG=307300 Review URL: https://codereview.chromium.org/145703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247897 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
This patch fixes the build failure of the 'check_licenses' test in 'Android Builder (dbg)'. Major changes: - Modify the year in the copyright string in audio_player_scripts.js - Put audio_player_scripts.js into the whitelist BUG=none TEST=manually run android_webview/tools/webview_licenses.py scan TBR=boliu@chromium.org, yoshiki@chromium.org Review URL: https://codereview.chromium.org/150143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247896 0039d316-1c4b-4281-b951-d872f2087c98
-
tommycli@chromium.org authored
BUG=161119 Review URL: https://codereview.chromium.org/133463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247894 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
This call is on the startup path; we believe all regressions have been addressed, but would like data from the wild to see how this truly behaves in various user configurations. BUG=330908 Review URL: https://codereview.chromium.org/149073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247893 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
BUG=310328 Review URL: https://codereview.chromium.org/30593007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247892 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=331406 TEST=With the --new-profile-management flag, start Chrome. Sign in a profile, and choose "View all people" from the avatar menu once that is complete. Close the profile browser, then close the user manager window (you should have no windows open) 1. Clicking on the docked Chrome icon should open the user manager and 2. Command-N (or Open New Window) form the docked Chrome icon should do the same. Review URL: https://codereview.chromium.org/129333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247891 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
This type isn't used anywhere and doesn't need to be forward declared. TBR=sky Review URL: https://codereview.chromium.org/142713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247890 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
If the MDnsListener is listening for a record we care about, actively refresh it. BUG=336883 R=vitalybuka@chromium.org,szym@chromium.org Review URL: https://codereview.chromium.org/132693025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247889 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/100173010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247888 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247887 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
This: - makes use of a funky downcast - moves TestableAutofillDialogViews code out of the production binary - makes it impossible to accidentally call testing code from production code mac implementation by groby@chromium.org BUG=306200 Review URL: https://codereview.chromium.org/135933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247886 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
Add the class to temporarily enable SyncFSV2 for testing. BUG=331988 R=kinuko@chromium.org Review URL: https://codereview.chromium.org/130913013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247885 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@chromium.org authored
Enable media android tests and make --disable-gesture-requirement-for-media-playback default for media measurement. Android cases exclude 4k and 50fps content. BUG=329691 Review URL: https://codereview.chromium.org/149793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247884 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
Previously FILE_ERROR_ABORT that is happened by user's cancel operations raises the general error message. BUG=339028 TEST=manually Review URL: https://codereview.chromium.org/149243005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247883 0039d316-1c4b-4281-b951-d872f2087c98
-
fdegans@chromium.org authored
mtune was set to cortex-a8, which is a Nexus S-generation CPU. Removing it allows for small speed improvements (~1%) for warm page load times on top10 mobile sites on more recent devices. Data: https://docs.google.com/spreadsheet/ccc?key=0Ao-xIDuezqMNdDc5OWpxbkk4NFJ0SF9Iemt0Tlg3RFE&usp=sharing And it has virtually no effect on binary size. BUG=334271 Review URL: https://codereview.chromium.org/145663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247882 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=335900 R=ben@chromium.org Review URL: https://codereview.chromium.org/150073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247881 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
R=mpcomplete@chromium.org Review URL: https://codereview.chromium.org/149703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247880 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
BUG=n/a R=nhiroki@chromium.org Review URL: https://codereview.chromium.org/147143005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247879 0039d316-1c4b-4281-b951-d872f2087c98
-
powei@chromium.org authored
https://codereview.chromium.org/26753005/ might have introduced crashes that trace to SetContentViewCore. That previous patch assumed that ContentViewCore (CVC) always outlives its associated RenderWidgetHostView. In this patch, we are trying to ensure that the RWHVA pointer to CVC is nulled when CVC is destroyed. Note the following: - WebContents owns ContentViewCore and WebContentsView. - CVC and WebContentsView are implicitly destroyed (no direct call to clean-up code). So ContentViewCore cannot refer to WebContents or WebContentsView in its destructor. Therefore, we use the observer of when WebContents is destroyed to start the clean up on CVC. BUG=335165, 324341 Review URL: https://codereview.chromium.org/133073012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247878 0039d316-1c4b-4281-b951-d872f2087c98
-